From: Martin Pool <mbp@samba.org>
Date: Thu, 8 Feb 2001 03:28:19 +0000 (+0000)
Subject: Document shortcoming of "unrecognised option" message.
X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/commitdiff_plain/e4114634426cf9f8d43623f0fd028fa7722859aa

Document shortcoming of "unrecognised option" message.
---

diff --git a/options.c b/options.c
index 9b2a68eb..a58df938 100644
--- a/options.c
+++ b/options.c
@@ -621,6 +621,17 @@ int parse_arguments(int argc, char *argv[], int frommain)
 			break;
 
 		default:
+                        /* FIXME: This can be confusing when the error message
+                         * is coming from a remote server which has an older
+                         * rsync version than the local version.  The user
+                         * sees the option documented in the local --help, but
+                         * then the program seems to refuse to execute it.  So
+                         * perhaps the message should give the hostname or
+                         * something.
+                         * 
+                         * In rsync 3.x, it might be nice if options which
+                         * only affect one end didn't have to bother the
+                         * remote end. */
 			slprintf(err_buf,sizeof(err_buf),"unrecognised option\n");
 			return 0;
 		}