From: Martin Pool <mbp@samba.org>
Date: Wed, 29 Aug 2001 08:48:00 +0000 (+0000)
Subject: Count overall failure if some expected scripts were missing.
X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/commitdiff_plain/d286ee98b915721150ba20e4a954f83fbc6df30f

Count overall failure if some expected scripts were missing.
---

diff --git a/runtests.sh b/runtests.sh
index 39ca364b..1026d053 100755
--- a/runtests.sh
+++ b/runtests.sh
@@ -83,7 +83,10 @@
 # Also, we can't count on 'cp -a' or 'mkdir -p', although they're
 # pretty handy.
 
-# Eventually we would like to not count on shell functions.
+# I think some of the GNU documentation suggests that we shouldn't
+# rely on shell functions.  However, the Bash manual seems to say that
+# they're in POSIX 1003.2, and since the build farm relies on them
+# they're probably working on most machines we really care about.
 
 
 set -e
@@ -170,7 +173,7 @@ echo "      $skipped skipped"
 echo "      $missing missing"
 echo '------------------------------------------------------------'
 
-if test $failed -gt 0
+if test "$failed" -gt 0 || test "$missing" -gt 0
 then
     exit 1
 else