From: Martin Pool <mbp@samba.org>
Date: Tue, 9 Apr 2002 06:32:07 +0000 (+0000)
Subject: Correction from Nelson Beebe: argument to functions such as isspace()
X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/commitdiff_plain/3e8369b6dc77c2b14e9d744b4ed9cb6109bbe3c0

Correction from Nelson Beebe: argument to functions such as isspace()
must be an int, not a char.  This could cause sign-extension problems.
---

diff --git a/loadparm.c b/loadparm.c
index e383f7b3..7bd4483c 100644
--- a/loadparm.c
+++ b/loadparm.c
@@ -479,11 +479,12 @@ static int strwicmp(char *psz1, char *psz2)
    /* sync the strings on first non-whitespace */
    while (1)
    {
-      while (isspace(*psz1))
+      while (isspace((int) *psz1))
          psz1++;
-      while (isspace(*psz2))
+      while (isspace((int) *psz2))
          psz2++;
-      if (toupper(*psz1) != toupper(*psz2) || *psz1 == '\0' || *psz2 == '\0')
+      if (toupper((int) *psz1) != toupper((int) *psz2)
+	  || *psz1 == '\0' || *psz2 == '\0')
          break;
       psz1++;
       psz2++;