Matt McCutchen's Web Site
/
rsync
/
rsync.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8e7f310
)
Free a strdup() in do_cmd() that checker was complaining about.
author
Wayne Davison
<wayned@samba.org>
Mon, 14 Dec 2009 03:28:01 +0000
(19:28 -0800)
committer
Wayne Davison
<wayned@samba.org>
Mon, 14 Dec 2009 03:28:01 +0000
(19:28 -0800)
main.c
patch
|
blob
|
blame
|
history
diff --git
a/main.c
b/main.c
index
ebfadd2
..
dec59f4
100644
(file)
--- a/
main.c
+++ b/
main.c
@@
-395,7
+395,7
@@
static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in
int *f_in_p, int *f_out_p)
{
int i, argc = 0;
- char *args[MAX_ARGS];
+ char *args[MAX_ARGS]
, *need_to_free = NULL
;
pid_t pid;
int dash_l_set = 0;
@@
-406,7
+406,7
@@
static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in
cmd = rsh_env;
if (!cmd)
cmd = RSYNC_RSH;
- cmd =
strdup(cmd); /*MEMORY LEAK*/
+ cmd =
need_to_free = strdup(cmd);
if (!cmd)
goto oom;
@@
-538,6
+538,9
@@
static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in
send_protected_args(*f_out_p, args);
}
+ if (need_to_free)
+ free(need_to_free);
+
return pid;
oom: