Include the array-size in array externs so that IBM's code-checker

can do more checking for us.

diff --git a/clientserver.c b/clientserver.c
index 2ba7dbd..57b0e27 100644 (file)
--- a/clientserver.c
+++ b/clientserver.c
@@ -56,7 +56,7 @@ extern char *files_from;
 extern char *tmpdir;
 extern struct chmod_mode_struct *chmod_modes;
 extern struct filter_list_struct daemon_filter_list;
 extern char *tmpdir;
 extern struct chmod_mode_struct *chmod_modes;
 extern struct filter_list_struct daemon_filter_list;

-extern char curr_dir[];
+extern char curr_dir[MAXPATHLEN];

 #ifdef ICONV_OPTION
 extern char *iconv_opt;
 extern iconv_t ic_send, ic_recv;
 #ifdef ICONV_OPTION
 extern char *iconv_opt;
 extern iconv_t ic_send, ic_recv;

diff --git a/exclude.c b/exclude.c
index 080aa49..9672bf9 100644 (file)
--- a/exclude.c
+++ b/exclude.c
@@ -36,7 +36,7 @@ extern int sanitize_paths;
 extern int protocol_version;
 extern int module_id;
 
 extern int protocol_version;
 extern int module_id;
 

-extern char curr_dir[];
+extern char curr_dir[MAXPATHLEN];

 extern unsigned int curr_dir_len;
 extern unsigned int module_dirlen;
 
 extern unsigned int curr_dir_len;
 extern unsigned int module_dirlen;
 

diff --git a/generator.c b/generator.c
index 7735e1e..58ae82f 100644 (file)
--- a/generator.c
+++ b/generator.c
@@ -74,7 +74,6 @@ extern int fuzzy_basis;
 extern int always_checksum;
 extern int checksum_len;
 extern char *partial_dir;
 extern int always_checksum;
 extern int checksum_len;
 extern char *partial_dir;

-extern char *basis_dir[];

 extern int compare_dest;
 extern int copy_dest;
 extern int link_dest;
 extern int compare_dest;
 extern int copy_dest;
 extern int link_dest;


@@ -94,6 +93,7 @@ extern uid_t our_uid;
 extern char *backup_dir;
 extern char *backup_suffix;
 extern int backup_suffix_len;
 extern char *backup_dir;
 extern char *backup_suffix;
 extern int backup_suffix_len;

+extern char *basis_dir[MAX_BASIS_DIRS+1];

 extern struct file_list *cur_flist, *first_flist, *dir_flist;
 extern struct filter_list_struct daemon_filter_list;
 
 extern struct file_list *cur_flist, *first_flist, *dir_flist;
 extern struct filter_list_struct daemon_filter_list;
 

diff --git a/hlink.c b/hlink.c
index ec49709..5c61170 100644 (file)
--- a/hlink.c
+++ b/hlink.c
@@ -35,7 +35,7 @@ extern int remove_source_files;
 extern int stdout_format_has_i;
 extern int maybe_ATTRS_REPORT;
 extern int unsort_ndx;
 extern int stdout_format_has_i;
 extern int maybe_ATTRS_REPORT;
 extern int unsort_ndx;

-extern char *basis_dir[];
+extern char *basis_dir[MAX_BASIS_DIRS+1];

 extern struct file_list *cur_flist, *first_flist;
 
 #ifdef SUPPORT_HARD_LINKS
 extern struct file_list *cur_flist, *first_flist;
 
 #ifdef SUPPORT_HARD_LINKS

diff --git a/log.c b/log.c
index 58c6bb1..6f9a47e 100644 (file)
--- a/log.c
+++ b/log.c
@@ -55,10 +55,10 @@ extern iconv_t ic_chck;
 #ifdef ICONV_OPTION
 extern iconv_t ic_send, ic_recv;
 #endif
 #ifdef ICONV_OPTION
 extern iconv_t ic_send, ic_recv;
 #endif

-extern char curr_dir[];
+extern char curr_dir[MAXPATHLEN];

 extern char *module_dir;
 extern unsigned int module_dirlen;
 extern char *module_dir;
 extern unsigned int module_dirlen;

-extern char sender_file_sum[];
+extern char sender_file_sum[MAX_DIGEST_LEN];

 
 static int log_initialised;
 static int logfile_was_closed;
 
 static int log_initialised;
 static int logfile_was_closed;

diff --git a/main.c b/main.c
index 39eab69..af14f36 100644 (file)
--- a/main.c
+++ b/main.c
@@ -75,12 +75,12 @@ extern char *logfile_format;
 extern char *filesfrom_host;
 extern char *partial_dir;
 extern char *dest_option;
 extern char *filesfrom_host;
 extern char *partial_dir;
 extern char *dest_option;

-extern char *basis_dir[];

 extern char *rsync_path;
 extern char *shell_cmd;
 extern char *batch_name;
 extern char *password_file;
 extern char curr_dir[MAXPATHLEN];
 extern char *rsync_path;
 extern char *shell_cmd;
 extern char *batch_name;
 extern char *password_file;
 extern char curr_dir[MAXPATHLEN];

+extern char *basis_dir[MAX_BASIS_DIRS+1];

 extern struct file_list *first_flist;
 extern struct filter_list_struct daemon_filter_list;
 
 extern struct file_list *first_flist;
 extern struct filter_list_struct daemon_filter_list;
 

diff --git a/receiver.c b/receiver.c
index 5beddd6..434957b 100644 (file)
--- a/receiver.c
+++ b/receiver.c
@@ -52,8 +52,8 @@ extern mode_t orig_umask;
 extern struct stats stats;
 extern char *tmpdir;
 extern char *partial_dir;
 extern struct stats stats;
 extern char *tmpdir;
 extern char *partial_dir;

-extern char *basis_dir[];
-extern char sender_file_sum[];
+extern char *basis_dir[MAX_BASIS_DIRS+1];
+extern char sender_file_sum[MAX_DIGEST_LEN];

 extern struct file_list *cur_flist, *first_flist, *dir_flist;
 extern struct filter_list_struct daemon_filter_list;
 
 extern struct file_list *cur_flist, *first_flist, *dir_flist;
 extern struct filter_list_struct daemon_filter_list;