damn, I had implicitly assumed signed characters when writing the
authorAndrew Tridgell <tridge@samba.org>
Mon, 15 Dec 1997 12:37:40 +0000 (12:37 +0000)
committerAndrew Tridgell <tridge@samba.org>
Mon, 15 Dec 1997 12:37:40 +0000 (12:37 +0000)
commit0aeee8c1c8e8c3fbb2ee2db1000ee7e1aa925cf8
tree64ad0c108cec4fc3e30b25bea225b59dd7cdc056
parent05c629f778acaf7b83583426c0138ef463fb41af
damn, I had implicitly assumed signed characters when writing the
rolling checksum code. The result is that rsync worked much more
slowly when going between two machines where one of the machines uses
signed and the other unsigned chars. The rolling checksum rarely
matched so effectively a copy was done in many cases. The data always
came through correctly so no file corruption occurred but it's pretty
pointless using rsync if it doesn't speed things up!
I've now made the sign of the chars explicit
checksum.c
match.c