X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/fa45cda1aa675aab6d9f9fb88fbfc69d41ea32ab..7b1a0c19b867b2ea7766c4d742a15bca3a1fb3ed:/flist.c

diff --git a/flist.c b/flist.c
index a14ce5f0..41605340 100644
--- a/flist.c
+++ b/flist.c
@@ -70,6 +70,7 @@ extern struct exclude_struct **local_exclude_list;
 int io_error;
 
 static struct file_struct null_file;
+static char empty_sum[MD4_SUM_LENGTH];
 
 static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
 
@@ -350,17 +351,32 @@ static void flist_expand(struct file_list *flist)
 	}
 }
 
+/* These vars are used by both send_file_entry() and receive_file_entry()
+ * (but just one at a time).  They have been placed outside these functions
+ * so that we can reset the values when the batch-processing wants to make
+ * extra use of these functions (which needs to start from a known state). */
+static time_t modtime;
+static mode_t mode;
+static DEV64_T rdev;	/* just high bytes in p28 onward */
+static uid_t uid;
+static gid_t gid;
+static DEV64_T dev;
+static char lastname[MAXPATHLEN];
+
+void reset_file_entry_vars(void)
+{
+	modtime = 0;
+	mode = 0;
+	rdev = 0;
+	uid = 0;
+	gid = 0;
+	dev = 0;
+	*lastname = '\0';
+}
 
-static void send_file_entry(struct file_struct *file, int f,
-			    unsigned base_flags)
+void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
 {
-	unsigned char flags;
-	static time_t last_time;
-	static mode_t last_mode;
-	static DEV64_T last_rdev;
-	static uid_t last_uid;
-	static gid_t last_gid;
-	static char lastname[MAXPATHLEN];
+	unsigned short flags;
 	char *fname, fbuf[MAXPATHLEN];
 	int l1, l2;
 
@@ -378,16 +394,48 @@ static void send_file_entry(struct file_struct *file, int f,
 
 	flags = base_flags;
 
-	if (file->mode == last_mode)
+	if (file->mode == mode)
 		flags |= SAME_MODE;
-	if (file->rdev == last_rdev)
-		flags |= SAME_RDEV;
-	if (file->uid == last_uid)
+	else
+		mode = file->mode;
+	if (preserve_devices) {
+		if (protocol_version < 28) {
+			if (IS_DEVICE(mode) && file->rdev == rdev) {
+				/* Set both flags so that the test when
+				 * writing the data is simpler. */
+				flags |= SAME_RDEV_pre28|SAME_HIGH_RDEV;
+			}
+			else
+				rdev = file->rdev;
+		}
+		else if (IS_DEVICE(mode)) {
+			if ((file->rdev & ~0xFF) == rdev)
+				flags |= SAME_HIGH_RDEV;
+			else
+				rdev = file->rdev & ~0xFF;
+		}
+	}
+	if (file->uid == uid)
 		flags |= SAME_UID;
-	if (file->gid == last_gid)
+	else
+		uid = file->uid;
+	if (file->gid == gid)
 		flags |= SAME_GID;
-	if (file->modtime == last_time)
+	else
+		gid = file->gid;
+	if (file->modtime == modtime)
 		flags |= SAME_TIME;
+	else
+		modtime = file->modtime;
+	if (file->flags & HAS_INODE_DATA) {
+		if (file->dev == dev) {
+			if (protocol_version >= 28)
+				flags |= SAME_DEV;
+		}
+		else
+			dev = file->dev;
+		flags |= HAS_INODE_DATA;
+	}
 
 	for (l1 = 0;
 	     lastname[l1] && (fname[l1] == lastname[l1]) && (l1 < 255);
@@ -399,14 +447,22 @@ static void send_file_entry(struct file_struct *file, int f,
 	if (l2 > 255)
 		flags |= LONG_NAME;
 
-	/* we must make sure we don't send a zero flags byte or the other
-	   end will terminate the flist transfer */
-	if (flags == 0 && !S_ISDIR(file->mode))
-		flags |= FLAG_DELETE;
-	if (flags == 0)
-		flags |= LONG_NAME;
-
-	write_byte(f, flags);
+	/* We must make sure we don't send a zero flags byte or
+	 * the other end will terminate the flist transfer. */
+	if (flags == 0 && !S_ISDIR(mode))
+		flags |= FLAG_DELETE; /* NOTE: no meaning for non-dir */
+	if (protocol_version >= 28) {
+		if ((flags & 0xFF00) || flags == 0) {
+			flags |= EXTENDED_FLAGS;
+			write_byte(f, flags);
+			write_byte(f, flags >> 8);
+		} else
+			write_byte(f, flags);
+	} else {
+		if (flags == 0)
+			flags |= LONG_NAME;
+		write_byte(f, flags);
+	}
 	if (flags & SAME_NAME)
 		write_byte(f, l1);
 	if (flags & LONG_NAME)
@@ -417,55 +473,54 @@ static void send_file_entry(struct file_struct *file, int f,
 
 	write_longint(f, file->length);
 	if (!(flags & SAME_TIME))
-		write_int(f, (int) file->modtime);
+		write_int(f, modtime);
 	if (!(flags & SAME_MODE))
-		write_int(f, to_wire_mode(file->mode));
+		write_int(f, to_wire_mode(mode));
 	if (preserve_uid && !(flags & SAME_UID)) {
-		add_uid(file->uid);
-		write_int(f, (int) file->uid);
+		add_uid(uid);
+		write_int(f, uid);
 	}
 	if (preserve_gid && !(flags & SAME_GID)) {
-		add_gid(file->gid);
-		write_int(f, (int) file->gid);
+		add_gid(gid);
+		write_int(f, gid);
+	}
+	if (preserve_devices && IS_DEVICE(mode)) {
+		/* If SAME_HIGH_RDEV is off, SAME_RDEV_pre28 is also off.
+		 * Also, avoid using "rdev" because it may be incomplete. */
+		if (!(flags & SAME_HIGH_RDEV))
+			write_int(f, file->rdev);
+		else if (protocol_version >= 28)
+			write_byte(f, file->rdev);
 	}
-	if (preserve_devices && IS_DEVICE(file->mode)
-	    && !(flags & SAME_RDEV))
-		write_int(f, (int) file->rdev);
 
 #if SUPPORT_LINKS
-	if (preserve_links && S_ISLNK(file->mode)) {
+	if (preserve_links && S_ISLNK(mode)) {
 		write_int(f, strlen(file->link));
 		write_buf(f, file->link, strlen(file->link));
 	}
 #endif
 
 #if SUPPORT_HARD_LINKS
-	if (preserve_hard_links && S_ISREG(file->mode)) {
+	if (flags & HAS_INODE_DATA) {
 		if (protocol_version < 26) {
 			/* 32-bit dev_t and ino_t */
-			write_int(f, (int) file->dev);
-			write_int(f, (int) file->inode);
+			write_int(f, dev);
+			write_int(f, file->inode);
 		} else {
 			/* 64-bit dev_t and ino_t */
-			write_longint(f, file->dev);
+			if (!(flags & SAME_DEV))
+				write_longint(f, dev);
 			write_longint(f, file->inode);
 		}
 	}
 #endif
 
-	if (always_checksum) {
-		if (protocol_version < 21)
-			write_buf(f, file->sum, 2);
-		else
-			write_buf(f, file->sum, MD4_SUM_LENGTH);
+	if (always_checksum && (protocol_version < 28 || S_ISREG(mode))) {
+		char *sum = file->sum? file->sum : empty_sum;
+		write_buf(f, sum, protocol_version < 21? 2
+						: MD4_SUM_LENGTH);
 	}
 
-	last_mode = file->mode;
-	last_rdev = file->rdev;
-	last_uid = file->uid;
-	last_gid = file->gid;
-	last_time = file->modtime;
-
 	strlcpy(lastname, fname, MAXPATHLEN);
 	lastname[MAXPATHLEN - 1] = 0;
 
@@ -474,15 +529,8 @@ static void send_file_entry(struct file_struct *file, int f,
 
 
 
-static void receive_file_entry(struct file_struct **fptr,
-			       unsigned flags, int f)
+void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
 {
-	static time_t last_time;
-	static mode_t last_mode;
-	static DEV64_T last_rdev;
-	static uid_t last_uid;
-	static gid_t last_gid;
-	static char lastname[MAXPATHLEN];
 	char thisname[MAXPATHLEN];
 	unsigned int l1 = 0, l2 = 0;
 	char *p;
@@ -542,19 +590,41 @@ static void receive_file_entry(struct file_struct **fptr,
 
 	file->flags = flags;
 	file->length = read_longint(f);
-	file->modtime = (flags & SAME_TIME) ? last_time : (time_t)read_int(f);
-	file->mode = (flags & SAME_MODE) ? last_mode
-					 : from_wire_mode(read_int(f));
-	if (preserve_uid)
-		file->uid = (flags & SAME_UID) ? last_uid : (uid_t)read_int(f);
-	if (preserve_gid)
-		file->gid = (flags & SAME_GID) ? last_gid : (gid_t)read_int(f);
-	if (preserve_devices && IS_DEVICE(file->mode)) {
-		file->rdev = (flags & SAME_RDEV) ? last_rdev
-						 : (DEV64_T)read_int(f);
+	if (!(flags & SAME_TIME))
+		modtime = (time_t)read_int(f);
+	file->modtime = modtime;
+	if (!(flags & SAME_MODE))
+		mode = from_wire_mode(read_int(f));
+	file->mode = mode;
+
+	if (preserve_uid) {
+		if (!(flags & SAME_UID))
+			uid = (uid_t)read_int(f);
+		file->uid = uid;
+	}
+	if (preserve_gid) {
+		if (!(flags & SAME_GID))
+			gid = (gid_t)read_int(f);
+		file->gid = gid;
+	}
+	if (preserve_devices) {
+		if (protocol_version < 28) {
+			if (IS_DEVICE(mode)) {
+				if (!(flags & SAME_RDEV_pre28))
+					rdev = (DEV64_T)read_int(f);
+				file->rdev = rdev;
+			} else
+				rdev = 0;
+		} else if (IS_DEVICE(mode)) {
+			if (!(flags & SAME_HIGH_RDEV)) {
+				file->rdev = (DEV64_T)read_int(f);
+				rdev = file->rdev & ~0xFF;
+			} else
+				file->rdev = rdev | (DEV64_T)read_byte(f);
+		}
 	}
 
-	if (preserve_links && S_ISLNK(file->mode)) {
+	if (preserve_links && S_ISLNK(mode)) {
 		int l = read_int(f);
 		if (l < 0) {
 			rprintf(FERROR, "overflow: l=%d\n", l);
@@ -568,37 +638,43 @@ static void receive_file_entry(struct file_struct **fptr,
 			sanitize_path(file->link, file->dirname);
 	}
 #if SUPPORT_HARD_LINKS
-	if (preserve_hard_links && S_ISREG(file->mode)) {
+	if (preserve_hard_links && protocol_version < 28
+	    && S_ISREG(mode))
+		file->flags |= HAS_INODE_DATA;
+	if (file->flags & HAS_INODE_DATA) {
 		if (protocol_version < 26) {
-			file->dev = read_int(f);
+			dev = read_int(f);
 			file->inode = read_int(f);
 		} else {
-			file->dev = read_longint(f);
+			if (!(flags & SAME_DEV))
+				dev = read_longint(f);
 			file->inode = read_longint(f);
 		}
+		file->dev = dev;
 	}
 #endif
 
 	if (always_checksum) {
-		file->sum = new_array(char, MD4_SUM_LENGTH);
-		if (!file->sum)
-			out_of_memory("md4 sum");
-		if (protocol_version < 21)
-			read_buf(f, file->sum, 2);
-		else
-			read_buf(f, file->sum, MD4_SUM_LENGTH);
+		char *sum;
+		if (S_ISREG(mode)) {
+			sum = file->sum = new_array(char, MD4_SUM_LENGTH);
+			if (!sum)
+				out_of_memory("md4 sum");
+		} else if (protocol_version < 28) {
+			/* Prior to 28, we get a useless set of nulls. */
+			sum = empty_sum;
+		} else
+			sum = NULL;
+		if (sum) {
+			read_buf(f, sum, protocol_version < 21? 2
+						: MD4_SUM_LENGTH);
+		}
 	}
 
-	last_mode = file->mode;
-	last_rdev = file->rdev;
-	last_uid = file->uid;
-	last_gid = file->gid;
-	last_time = file->modtime;
-
 	if (!preserve_perms) {
 		extern int orig_umask;
 		/* set an appropriate set of permissions based on original
-		   permissions and umask. This emulates what GNU cp does */
+		 * permissions and umask. This emulates what GNU cp does */
 		file->mode &= ~orig_umask;
 	}
 }
@@ -737,8 +813,14 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
 	file->mode = st.st_mode;
 	file->uid = st.st_uid;
 	file->gid = st.st_gid;
-	file->dev = st.st_dev;
-	file->inode = st.st_ino;
+	if (preserve_hard_links) {
+		if (protocol_version < 28? S_ISREG(st.st_mode)
+		    : !S_ISDIR(st.st_mode) && st.st_nlink > 1) {
+			file->dev = st.st_dev;
+			file->inode = st.st_ino;
+			file->flags |= HAS_INODE_DATA;
+		}
+	}
 #ifdef HAVE_STRUCT_STAT_ST_RDEV
 	file->rdev = st.st_rdev;
 #endif
@@ -748,18 +830,11 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
 		file->link = STRDUP(ap, linkbuf);
 #endif
 
-	if (always_checksum) {
-		file->sum = (char *) MALLOC(ap, MD4_SUM_LENGTH);
+	if (always_checksum && S_ISREG(st.st_mode)) {
+		file->sum = (char*)MALLOC(ap, MD4_SUM_LENGTH);
 		if (!file->sum)
 			out_of_memory("md4 sum");
-		/* drat. we have to provide a null checksum for non-regular
-		   files in order to be compatible with earlier versions
-		   of rsync */
-		if (S_ISREG(st.st_mode)) {
-			file_checksum(fname, file->sum, st.st_size);
-		} else {
-			memset(file->sum, 0, MD4_SUM_LENGTH);
-		}
+		file_checksum(fname, file->sum, st.st_size);
 	}
 
 	if (flist_dir) {
@@ -781,7 +856,7 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
 
 
 void send_file_name(int f, struct file_list *flist, char *fname,
-		    int recursive, unsigned base_flags)
+		    int recursive, unsigned short base_flags)
 {
 	struct file_struct *file;
 	char fbuf[MAXPATHLEN];
@@ -800,7 +875,7 @@ void send_file_name(int f, struct file_list *flist, char *fname,
 	flist_expand(flist);
 
 	if (write_batch)
-		file->flags = FLAG_DELETE;
+		file->flags |= FLAG_DELETE;
 
 	if (file->basename[0]) {
 		flist->files[flist->count++] = file;
@@ -1074,7 +1149,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 struct file_list *recv_file_list(int f)
 {
 	struct file_list *flist;
-	unsigned char flags;
+	unsigned short flags;
 	int64 start_read;
 	extern int list_only;
 
@@ -1094,11 +1169,13 @@ struct file_list *recv_file_list(int f)
 		goto oom;
 
 
-	for (flags = read_byte(f); flags; flags = read_byte(f)) {
+	while ((flags = read_byte(f)) != 0) {
 		int i = flist->count;
 
 		flist_expand(flist);
 
+		if (protocol_version >= 28 && (flags & EXTENDED_FLAGS))
+			flags |= read_byte(f) << 8;
 		receive_file_entry(&flist->files[i], flags, f);
 
 		if (S_ISREG(flist->files[i]->mode))
@@ -1336,8 +1413,8 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
 		return;
 
 	for (i = 0; i < flist->count; i++) {
-		rprintf(FINFO, "[%d] i=%d %s %s mode=0%o len=%.0f\n",
-			(int) getpid(), i,
+		rprintf(FINFO, "[%ld] i=%d %s %s mode=0%o len=%.0f\n",
+			(long) getpid(), i,
 			NS(flist->files[i]->dirname),
 			NS(flist->files[i]->basename),
 			(int) flist->files[i]->mode,
@@ -1356,7 +1433,7 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
 {
 	int dif;
 	const uchar *c1, *c2;
-	enum fnc_state state1 = fnc_DIR, state2 = fnc_DIR;
+	enum fnc_state state1, state2;
 
 	if (!f1 || !f1->basename) {
 		if (!f2 || !f2->basename)
@@ -1370,10 +1447,14 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
 		state1 = fnc_BASE;
 		c1 = (uchar*)f1->basename;
 	}
+	else
+		state1 = fnc_DIR;
 	if (!(c2 = (uchar*)f2->dirname)) {
 		state2 = fnc_BASE;
 		c2 = (uchar*)f2->basename;
 	}
+	else
+		state2 = fnc_DIR;
 
 	while (1) {
 		if ((dif = (int)*c1 - (int)*c2) != 0)