X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/f9c516202005d93005811c77eede7ee1f8267f61..3b3a2fbcf058b90d9116f48ba26ad9528d450134:/flist.c diff --git a/flist.c b/flist.c index 1ae8c341..40158fae 100644 --- a/flist.c +++ b/flist.c @@ -42,12 +42,26 @@ extern int preserve_uid; extern int preserve_gid; extern int preserve_times; extern int relative_paths; +extern int copy_links; static char **local_exclude_list = NULL; static void clean_fname(char *name); +int link_stat(const char *Path, struct stat *Buffer) +{ +#if SUPPORT_LINKS + if (copy_links) { + return stat(Path, Buffer); + } else { + return lstat(Path, Buffer); + } +#else + return stat(Path, Buffer); +#endif +} + /* This function is used to check if a file should be included/excluded from the list of files based on its name and type etc @@ -68,7 +82,7 @@ static dev_t filesystem_dev; static void set_filesystem(char *fname) { struct stat st; - if (lstat(fname,&st) != 0) return; + if (link_stat(fname,&st) != 0) return; filesystem_dev = st.st_dev; } @@ -159,8 +173,8 @@ void send_file_entry_v11(struct file_struct *file,int f) last_gid = file->gid; last_time = file->modtime; - strcpy(lastname,file->name); - lastname[255] = 0; + strncpy(lastname,file->name,MAXPATHLEN-1); + lastname[MAXPATHLEN-1] = 0; } @@ -187,7 +201,7 @@ void receive_file_entry_v11(struct file_struct *file, bzero((char *)file,sizeof(*file)); file->name = (char *)malloc(l1+l2+1); - if (!file->name) out_of_memory("receive_file_entry"); + if (!file->name) out_of_memory("receive_file_entry 1"); strncpy(file->name,lastname,l1); read_buf(f,file->name+l1,l2); @@ -203,15 +217,13 @@ void receive_file_entry_v11(struct file_struct *file, if (preserve_devices && IS_DEVICE(file->mode)) file->rdev = (flags & SAME_RDEV) ? last_rdev : (dev_t)read_int(f); -#if SUPPORT_LINKS if (preserve_links && S_ISLNK(file->mode)) { int l = read_int(f); file->link = (char *)malloc(l+1); - if (!file->link) out_of_memory("receive_file_entry"); + if (!file->link) out_of_memory("receive_file_entry 2"); read_buf(f,file->link,l); file->link[l] = 0; } -#endif #if SUPPORT_HARD_LINKS if (preserve_hard_links && S_ISREG(file->mode)) { @@ -229,8 +241,8 @@ void receive_file_entry_v11(struct file_struct *file, last_gid = file->gid; last_time = file->modtime; - strcpy(lastname,file->name); - lastname[255] = 0; + strncpy(lastname,file->name,MAXPATHLEN-1); + lastname[MAXPATHLEN-1] = 0; } @@ -243,7 +255,7 @@ static struct file_struct *make_file(char *fname) bzero(sum,SUM_LENGTH); - if (lstat(fname,&st) != 0) { + if (link_stat(fname,&st) != 0) { fprintf(FERROR,"%s: %s\n", fname,strerror(errno)); return NULL; @@ -357,22 +369,34 @@ static void send_directory(int f,struct file_list *flist,char *dir) return; } - strcpy(fname,dir); + strncpy(fname,dir,MAXPATHLEN-1); + fname[MAXPATHLEN-1]=0; l = strlen(fname); - if (fname[l-1] != '/') - strcat(fname,"/"); + if (fname[l-1] != '/') { + if (l == MAXPATHLEN-1) { + fprintf(FERROR,"skipping long-named directory %s\n",fname); + closedir(d); + return; + } + strcat(fname,"/"); + l++; + } p = fname + strlen(fname); if (cvs_exclude) { - strcpy(p,".cvsignore"); - local_exclude_list = make_exclude_list(fname,NULL,0); + if (strlen(fname) + strlen(".cvsignore") <= MAXPATHLEN-1) { + strcpy(p,".cvsignore"); + local_exclude_list = make_exclude_list(fname,NULL,0); + } else { + fprintf(FERROR,"cannot cvs-exclude in long-named directory %s\n",fname); + } } for (di=readdir(d); di; di=readdir(d)) { if (strcmp(di->d_name,".")==0 || strcmp(di->d_name,"..")==0) continue; - strcpy(p,di->d_name); + strncpy(p,di->d_name,MAXPATHLEN-(l+1)); send_file_name(f,flist,fname); } @@ -389,7 +413,7 @@ struct file_list *send_file_list(int f,int argc,char *argv[]) char dbuf[MAXPATHLEN]; struct file_list *flist; - if (verbose && recurse && !am_server) { + if (verbose && recurse && !am_server && f != -1) { fprintf(FINFO,"building file list ... "); fflush(FINFO); } @@ -407,14 +431,15 @@ struct file_list *send_file_list(int f,int argc,char *argv[]) char fname2[MAXPATHLEN]; char *fname = fname2; - strcpy(fname,argv[i]); + strncpy(fname,argv[i],MAXPATHLEN-1); + fname[MAXPATHLEN-1] = 0; l = strlen(fname); if (l != 1 && fname[l-1] == '/') { strcat(fname,"."); } - if (lstat(fname,&st) != 0) { + if (link_stat(fname,&st) != 0) { fprintf(FERROR,"%s : %s\n",fname,strerror(errno)); continue; } @@ -472,7 +497,7 @@ struct file_list *send_file_list(int f,int argc,char *argv[]) write_flush(f); } - if (verbose && recurse && !am_server) + if (verbose && recurse && !am_server && f != -1) fprintf(FINFO,"done\n"); clean_flist(flist); @@ -558,20 +583,24 @@ int file_compare(struct file_struct *f1,struct file_struct *f2) int flist_find(struct file_list *flist,struct file_struct *f) { - int low=0,high=flist->count; - - while (low != high) { - int mid = (low+high)/2; - int ret = file_compare(&flist->files[mid],f); - if (ret == 0) return mid; - if (ret > 0) - high=mid; - else - low=mid+1; - } - if (file_compare(&flist->files[low],f) == 0) - return low; - return -1; + int low=0,high=flist->count-1; + + if (flist->count <= 0) return -1; + + while (low != high) { + int mid = (low+high)/2; + int ret = file_compare(&flist->files[flist_up(flist, mid)],f); + if (ret == 0) return flist_up(flist, mid); + if (ret > 0) { + high=mid; + } else { + low=mid+1; + } + } + + if (file_compare(&flist->files[flist_up(flist,low)],f) == 0) + return flist_up(flist,low); + return -1; } @@ -604,10 +633,9 @@ static void clean_fname(char *name) if (strncmp(p=name,"./",2) == 0) { modified = 1; - while (*p) { + do { p[0] = p[2]; - p++; - } + } while (*p++); } l = strlen(p=name);