X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/f227ffe4b9d7decb5e59e7c1b0c7168ec9c671a6..c786a7aec545259f857212a2376ee4c274d2e3b6:/rsync.c

diff --git a/rsync.c b/rsync.c
index e23f1ab4..4c34deb4 100644
--- a/rsync.c
+++ b/rsync.c
@@ -24,18 +24,23 @@
 
 extern int verbose;
 extern int dry_run;
+extern int itemize_changes;
 extern int preserve_times;
+extern int omit_dir_times;
 extern int am_root;
+extern int am_server;
 extern int am_sender;
 extern int am_generator;
 extern int preserve_uid;
 extern int preserve_gid;
 extern int force_delete;
+extern int inplace;
 extern int recurse;
 extern int keep_dirlinks;
 extern int make_backups;
+extern struct stats stats;
 extern char *backup_dir;
-extern int inplace;
+extern char *log_format;
 
 
 /*
@@ -52,19 +57,18 @@ void free_sums(struct sum_struct *s)
  * delete a file or directory. If force_delete is set then delete
  * recursively
  */
-int delete_file(char *fname, int flags)
+int delete_file(char *fname, int mode, int flags)
 {
 	DIR *d;
 	struct dirent *di;
 	char buf[MAXPATHLEN];
 	STRUCT_STAT st;
+	int zap_dir;
 
-	if (!(flags & DEL_DIR)) {
+	if (!S_ISDIR(mode)) {
 		if (robust_unlink(fname) == 0) {
-			if (verbose && !(flags & DEL_TERSE)) {
-				rprintf(FINFO, "deleting %s\n",
-					safe_fname(fname));
-			}
+			if ((verbose || log_format) && !(flags & DEL_TERSE))
+				log_delete(fname, mode);
 			return 0;
 		}
 		if (errno == ENOENT)
@@ -74,17 +78,18 @@ int delete_file(char *fname, int flags)
 		return -1;
 	}
 
-	if (do_rmdir(fname) == 0) {
-		if (verbose && !(flags & DEL_TERSE)) {
-			rprintf(FINFO, "deleting %s/\n",
-				safe_fname(fname));
-		}
+	zap_dir = (flags & DEL_FORCE_RECURSE || (force_delete && recurse))
+		&& !(flags & DEL_NO_RECURSE);
+	if (dry_run && zap_dir)
+		errno = ENOTEMPTY;
+	else if (do_rmdir(fname) == 0) {
+		if ((verbose || log_format) && !(flags & DEL_TERSE))
+			log_delete(fname, mode);
 		return 0;
 	}
 	if (errno == ENOENT)
 		return 0;
-	if ((flags & DEL_NO_RECURSE) || !force_delete || !recurse
-	    || (errno != ENOTEMPTY && errno != EEXIST)) {
+	if (!zap_dir || (errno != ENOTEMPTY && errno != EEXIST)) {
 		rsyserr(FERROR, errno, "delete_file: rmdir %s failed",
 			full_fname(fname));
 		return -1;
@@ -98,8 +103,8 @@ int delete_file(char *fname, int flags)
 	}
 
 	if (!(flags & DEL_TERSE)) {
-		if (verbose)
-			rprintf(FINFO, "deleting %s/\n", safe_fname(fname));
+		if (verbose || log_format)
+			log_delete(fname, mode);
 		flags |= DEL_TERSE;
 	}
 
@@ -112,15 +117,9 @@ int delete_file(char *fname, int flags)
 
 		if (do_lstat(buf, &st) < 0)
 			continue;
-		if (S_ISDIR(st.st_mode))
-			flags |= DEL_DIR;
-		else
-			flags &= ~DEL_DIR;
-
-		if (verbose)
-			rprintf(FINFO, "deleting %s%s\n", safe_fname(buf),
-				flags & DEL_DIR ? "/" : "");
-		if (delete_file(buf, flags) != 0) {
+		if (verbose || log_format)
+			log_delete(buf, st.st_mode);
+		if (delete_file(buf, st.st_mode, flags) != 0) {
 			closedir(d);
 			return -1;
 		}
@@ -162,14 +161,12 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 	}
 
 	if (!preserve_times || S_ISLNK(st->st_mode)
-	    || (make_backups && !backup_dir && S_ISDIR(st->st_mode)))
+	 || (S_ISDIR(st->st_mode)
+	  && (omit_dir_times || (make_backups && !backup_dir))))
 		flags |= PERMS_SKIP_MTIME;
 	if (!(flags & PERMS_SKIP_MTIME)
 	    && cmp_modtime(st->st_mtime, file->modtime) != 0) {
-		/* don't complain about not setting times on directories
-		 * because some filesystems can't do it */
-		if (set_modtime(fname,file->modtime) != 0 &&
-		    !S_ISDIR(st->st_mode)) {
+		if (set_modtime(fname,file->modtime) != 0) {
 			rsyserr(FERROR, errno, "failed to set times on %s",
 				full_fname(fname));
 			return 0;
@@ -180,7 +177,7 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 	change_uid = am_root && preserve_uid && st->st_uid != file->uid;
 	change_gid = preserve_gid && file->gid != GID_NONE
 		&& st->st_gid != file->gid;
-#if !HAVE_LCHOWN && !CHOWN_MODIFIES_SYMLINK
+#if !defined HAVE_LCHOWN && !defined CHOWN_MODIFIES_SYMLINK
 	if (S_ISLNK(st->st_mode))
 		;
 	else
@@ -189,13 +186,15 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 		if (verbose > 2) {
 			if (change_uid) {
 				rprintf(FINFO,
-				    "set uid of %s from %ld to %ld\n",
-				    fname, (long)st->st_uid, (long)file->uid);
+					"set uid of %s from %ld to %ld\n",
+					safe_fname(fname),
+					(long)st->st_uid, (long)file->uid);
 			}
 			if (change_gid) {
 				rprintf(FINFO,
-				    "set gid of %s from %ld to %ld\n",
-				    fname, (long)st->st_gid, (long)file->gid);
+					"set gid of %s from %ld to %ld\n",
+					safe_fname(fname),
+					(long)st->st_gid, (long)file->gid);
 			}
 		}
 		if (do_lchown(fname,
@@ -233,9 +232,9 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 
 	if (verbose > 1 && flags & PERMS_REPORT) {
 		if (updated)
-			rprintf(FINFO,"%s\n",fname);
+			rprintf(FINFO, "%s\n", safe_fname(fname));
 		else
-			rprintf(FINFO,"%s is uptodate\n",fname);
+			rprintf(FINFO, "%s is uptodate\n", safe_fname(fname));
 	}
 	return updated;
 }
@@ -265,7 +264,7 @@ void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
 
 	if (inplace) {
 		if (verbose > 2)
-			rprintf(FINFO, "finishing %s\n", fname);
+			rprintf(FINFO, "finishing %s\n", safe_fname(fname));
 		goto do_set_perms;
 	}
 
@@ -276,13 +275,15 @@ void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
 	set_perms(fnametmp, file, NULL, ok_to_set_time ? 0 : PERMS_SKIP_MTIME);
 
 	/* move tmp file over real file */
-	if (verbose > 2)
-		rprintf(FINFO, "renaming %s to %s\n", fnametmp, fname);
+	if (verbose > 2) {
+		rprintf(FINFO, "renaming %s to %s\n",
+			safe_fname(fnametmp), safe_fname(fname));
+	}
 	ret = robust_rename(fnametmp, fname, file->mode & INITACCESSPERMS);
 	if (ret < 0) {
 		rsyserr(FERROR, errno, "%s %s -> \"%s\"",
 		    ret == -2 ? "copy" : "rename",
-		    full_fname(fnametmp), fname);
+		    full_fname(fnametmp), safe_fname(fname));
 		do_unlink(fnametmp);
 		return;
 	}
@@ -296,5 +297,7 @@ void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
 
 const char *who_am_i(void)
 {
+	if (am_sender < 0)
+		return am_server ? "server" : "client";
 	return am_sender ? "sender" : am_generator ? "generator" : "receiver";
 }