X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/ef1aa9103912b14b67d5b5893038ccb51a8f3371..8642efd0d6bb172c5fed17d545afa615148cfe6b:/generator.c diff --git a/generator.c b/generator.c index 78d867c6..767e86c7 100644 --- a/generator.c +++ b/generator.c @@ -56,7 +56,7 @@ static int skip_file(char *fname, if (compare_dest != NULL) { if (access(fname, 0) != 0) { - slprintf(fnamecmpdest,MAXPATHLEN,"%s/%s", + snprintf(fnamecmpdest,MAXPATHLEN,"%s/%s", compare_dest,fname); fname = fnamecmpdest; } @@ -224,10 +224,17 @@ void recv_generator(char *fname,struct file_list *flist,int i,int f_out) } if (S_ISDIR(file->mode)) { + /* The file to be received is a directory, so we need + * to prepare appropriately. If there is already a + * file of that name and it is *not* a directory, then + * we need to delete it. If it doesn't exist, then + * recursively create it. */ + if (dry_run) return; if (statret == 0 && !S_ISDIR(st.st_mode)) { if (robust_unlink(fname) != 0) { - rprintf(FERROR,"recv_generator: unlink %s: %s\n",fname,strerror(errno)); + rprintf(FERROR,"recv_generator: unlink %s: %s\n", + fname,strerror(errno)); return; } statret = -1; @@ -322,7 +329,7 @@ void recv_generator(char *fname,struct file_list *flist,int i,int f_out) if ((statret == -1) && (compare_dest != NULL)) { /* try the file at compare_dest instead */ int saveerrno = errno; - slprintf(fnamecmpbuf,MAXPATHLEN,"%s/%s",compare_dest,fname); + snprintf(fnamecmpbuf,MAXPATHLEN,"%s/%s",compare_dest,fname); statret = link_stat(fnamecmpbuf,&st); if (!S_ISREG(st.st_mode)) statret = -1; @@ -432,6 +439,8 @@ void generate_files(int f,struct file_list *flist,char *local_name,int f_recv) them. This is then fixed after the files are transferred */ if (!am_root && S_ISDIR(file->mode)) { file->mode |= S_IWUSR; /* user write */ + /* XXX: Could this be causing a problem on SCO? Perhaps their + * handling of permissions is strange? */ } recv_generator(local_name?local_name:f_name(file),