X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/e64ae6d766a984829b1ab115d08a8c9056d8867f..38e3910b6f37eab2156496d1c4837c306235e9c7:/util.c

diff --git a/util.c b/util.c
index 3e783e4d..fc670afc 100644
--- a/util.c
+++ b/util.c
@@ -876,11 +876,11 @@ int pop_dir(char *dir)
 	return 1;
 }
 
-/**
- * Return the filename, turning any newlines into '?'s.  This ensures that
- * outputting it on a line of its own cannot generate an empty line.  This
- * function can handle only 2 names at a time!
- **/
+/* Return the filename, turning any non-printable characters into '?'s.
+ * This ensures that outputting it on a line of its own cannot generate an
+ * empty line.  This function can return only MAX_SAFE_NAMES values at a
+ * time!  The returned value can be longer than MAXPATHLEN (because we
+ * may be trying to output an error about a too-long filename)! */
 const char *safe_fname(const char *fname)
 {
 #define MAX_SAFE_NAMES 4
@@ -891,7 +891,7 @@ const char *safe_fname(const char *fname)
 
 	ndx = (ndx + 1) % MAX_SAFE_NAMES;
 	for (t = fbuf[ndx]; *fname; fname++) {
-		if (!isprint(*fname))
+		if (!isprint(*(uchar*)fname))
 			*t++ = '?';
 		else
 			*t++ = *fname;
@@ -1262,7 +1262,7 @@ const char *find_filename_suffix(const char *fn, int fn_len, int *len_ptr)
 			if (strcmp(s+1, "orig") == 0)
 				continue;
 		} else if (s_len > 2 && had_tilde
-		    && s[1] == '~' && isdigit(s[2]))
+		    && s[1] == '~' && isdigit(*(uchar*)(s+2)))
 			continue;
 		*len_ptr = s_len;
 		suf = s;
@@ -1270,7 +1270,7 @@ const char *find_filename_suffix(const char *fn, int fn_len, int *len_ptr)
 			break;
 		/* Determine if the suffix is all digits. */
 		for (s++, s_len--; s_len > 0; s++, s_len--) {
-			if (!isdigit(*s))
+			if (!isdigit(*(uchar*)s))
 				return suf;
 		}
 		/* An all-digit suffix may not be that signficant. */