X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/dde5b7722603b9818bdea65b4ef00bdbc6fbf9a2..486f8cd1abb053fbe2dc4cbabe3db6f326019ea3:/io.c diff --git a/io.c b/io.c index e23c69a8..a7603ff8 100644 --- a/io.c +++ b/io.c @@ -4,12 +4,11 @@ * Copyright (C) 1996-2001 Andrew Tridgell * Copyright (C) 1996 Paul Mackerras * Copyright (C) 2001, 2002 Martin Pool - * Copyright (C) 2003, 2004, 2005, 2006 Wayne Davison + * Copyright (C) 2003-2007 Wayne Davison * * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of @@ -41,7 +40,7 @@ extern int am_server; extern int am_daemon; extern int am_sender; extern int am_generator; -extern int incremental; +extern int inc_recurse; extern int io_error; extern int eol_nulls; extern int flist_eof; @@ -58,7 +57,7 @@ extern struct file_list *cur_flist, *first_flist; const char phase_unknown[] = "unknown"; int ignore_timeout = 0; int batch_fd = -1; -int done_cnt = 0; +int msgdone_cnt = 0; /* Ignore an EOF error if non-zero. See whine_about_eof(). */ int kluge_around_eof = 0; @@ -100,11 +99,11 @@ static int select_timeout = SELECT_TIMEOUT; static int active_filecnt = 0; static OFF_T active_bytecnt = 0; -static char int_byte_cnt[64] = { - 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, /* (00 - 3F)/4 */ - 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, /* (40 - 7F)/4 */ - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, /* (80 - BF)/4 */ - 5, 5, 5, 5, 5, 5, 5, 5, 6, 6, 6, 6, 7, 7, 8, 9, /* (C0 - FF)/4 */ +static char int_byte_extra[64] = { + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* (00 - 3F)/4 */ + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* (40 - 7F)/4 */ + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, /* (80 - BF)/4 */ + 2, 2, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 5, 6, /* (C0 - FF)/4 */ }; static void readfd(int fd, char *buffer, size_t N); @@ -134,7 +133,7 @@ struct msg_list { struct msg_list_item *head, *tail; }; -static struct msg_list msg2genr, msg2sndr; +static struct msg_list msg_queue; static void flist_ndx_push(struct flist_ndx_list *lp, int ndx) { @@ -248,6 +247,32 @@ static void msg_list_add(struct msg_list *lst, int code, const char *buf, int le lst->tail = m; } +static void msg_flush(void) +{ + if (am_generator) { + while (msg_queue.head && io_multiplexing_out) { + struct msg_list_item *m = msg_queue.head; + if (!(msg_queue.head = m->next)) + msg_queue.tail = NULL; + stats.total_written += m->len; + defer_forwarding_messages++; + writefd_unbuffered(sock_f_out, m->buf, m->len); + defer_forwarding_messages--; + free(m); + } + } else { + while (msg_queue.head) { + struct msg_list_item *m = msg_queue.head; + if (!(msg_queue.head = m->next)) + msg_queue.tail = NULL; + defer_forwarding_messages++; + writefd_unbuffered(msg_fd_out, m->buf, m->len); + defer_forwarding_messages--; + free(m); + } + } +} + /* Read a message from the MSG_* fd and handle it. This is called either * during the early stages of being a local sender (up through the sending * of the file list) or when we're the generator (to fetch the messages @@ -262,7 +287,9 @@ static void read_msg_fd(void) /* Temporarily disable msg_fd_in. This is needed to avoid looping back * to this routine from writefd_unbuffered(). */ + no_flush++; msg_fd_in = -1; + defer_forwarding_messages++; readfd(fd, buf, 4); tag = IVAL(buf, 0); @@ -272,14 +299,18 @@ static void read_msg_fd(void) switch (tag) { case MSG_DONE: - if (len != 0 || !am_generator) { + if (len < 0 || len > 1 || !am_generator) { invalid_msg: rprintf(FERROR, "invalid message %d:%d [%s%s]\n", tag, len, who_am_i(), - incremental ? "/incremental" : ""); + inc_recurse ? "/inc" : ""); exit_cleanup(RERR_STREAMIO); } - done_cnt++; + if (len) { + readfd(fd, buf, len); + stats.total_read = read_varlong(fd, 3); + } + msgdone_cnt++; break; case MSG_REDO: if (len != 4 || !am_generator) @@ -288,11 +319,11 @@ static void read_msg_fd(void) if (remove_source_files) decrement_active_files(IVAL(buf,0)); flist_ndx_push(&redo_list, IVAL(buf,0)); - if (incremental) + if (inc_recurse) decrement_flist_in_progress(IVAL(buf,0), 1); break; case MSG_FLIST: - if (len != 4 || !am_generator || !incremental) + if (len != 4 || !am_generator || !inc_recurse) goto invalid_msg; readfd(fd, buf, 4); /* Read extra file list from receiver. */ @@ -302,7 +333,7 @@ static void read_msg_fd(void) flist->parent_ndx = IVAL(buf,0); break; case MSG_FLIST_EOF: - if (len != 0 || !am_generator || !incremental) + if (len != 0 || !am_generator || !inc_recurse) goto invalid_msg; flist_eof = 1; break; @@ -322,14 +353,14 @@ static void read_msg_fd(void) } if (preserve_hard_links) flist_ndx_push(&hlink_list, IVAL(buf,0)); - if (incremental) + if (inc_recurse) decrement_flist_in_progress(IVAL(buf,0), 0); break; case MSG_NO_SEND: if (len != 4 || !am_generator) goto invalid_msg; readfd(fd, buf, len); - if (incremental) + if (inc_recurse) decrement_flist_in_progress(IVAL(buf,0), 0); break; case MSG_SOCKERR: @@ -357,7 +388,10 @@ static void read_msg_fd(void) exit_cleanup(RERR_STREAMIO); } + no_flush--; msg_fd_in = fd; + if (!--defer_forwarding_messages) + msg_flush(); } /* This is used by the generator to limit how many file transfers can @@ -367,15 +401,15 @@ void increment_active_files(int ndx, int itemizing, enum logcode code) { /* TODO: tune these limits? */ while (active_filecnt >= (active_bytecnt >= 128*1024 ? 10 : 50)) { -#ifdef SUPPORT_HARD_LINKS - if (hlink_list.head) - check_for_finished_hlinks(itemizing, code); -#endif - read_msg_fd(); + check_for_finished_files(itemizing, code, 0); + if (iobuf_out_cnt) + io_flush(NORMAL_FLUSH); + else + read_msg_fd(); } active_filecnt++; - active_bytecnt += F_LENGTH(cur_flist->files[ndx]); + active_bytecnt += F_LENGTH(cur_flist->files[ndx - cur_flist->ndx_start]); } static void decrement_active_files(int ndx) @@ -412,29 +446,30 @@ static void decrement_flist_in_progress(int ndx, int redo) flist->to_redo++; } -/* Try to push messages off the list onto the wire. If we leave with more - * to do, return 0. On error, return -1. If everything flushed, return 1. - * This is only active in the receiver. */ -static int msg2genr_flush(void) +/* Write an message to a multiplexed stream. If this fails, rsync exits. */ +static void mplex_write(int fd, enum msgcode code, const char *buf, size_t len) { - if (msg_fd_out < 0 || no_flush || flist_forward_from >= 0) - return -1; + char buffer[1024]; + size_t n = len; - no_flush++; - while (msg2genr.head) { - struct msg_list_item *m = msg2genr.head; - writefd(msg_fd_out, m->buf, m->len); - msg2genr.head = m->next; - if (!msg2genr.head) - msg2genr.tail = NULL; - free(m); - } - if (iobuf_out_cnt) { - writefd_unbuffered(iobuf_f_out, iobuf_out, iobuf_out_cnt); - iobuf_out_cnt = 0; + SIVAL(buffer, 0, ((MPLEX_BASE + (int)code)<<24) + len); + + if (n > sizeof buffer - 4) + n = 0; + else + memcpy(buffer + 4, buf, n); + + writefd_unbuffered(fd, buffer, n+4); + + len -= n; + buf += n; + + if (len) { + defer_forwarding_messages++; + writefd_unbuffered(fd, buf, len); + if (!--defer_forwarding_messages) + msg_flush(); } - no_flush--; - return 1; } int send_msg(enum msgcode code, const char *buf, int len) @@ -444,11 +479,13 @@ int send_msg(enum msgcode code, const char *buf, int len) return io_multiplex_write(code, buf, len); if (!io_multiplexing_out) return 0; - msg_list_add(&msg2sndr, code, buf, len); + msg_list_add(&msg_queue, code, buf, len); return 1; } - msg_list_add(&msg2genr, code, buf, len); - msg2genr_flush(); + if (flist_forward_from >= 0) + msg_list_add(&msg_queue, code, buf, len); + else + mplex_write(msg_fd_out, code, buf, len); return 1; } @@ -461,7 +498,10 @@ void send_msg_int(enum msgcode code, int num) void wait_for_receiver(void) { - read_msg_fd(); + if (iobuf_out_cnt) + io_flush(NORMAL_FLUSH); + else + read_msg_fd(); } int get_redo_num(void) @@ -550,11 +590,6 @@ static int read_timeout(int fd, char *buf, size_t len) FD_ZERO(&r_fds); FD_ZERO(&w_fds); FD_SET(fd, &r_fds); - if (msg2genr.head) { - FD_SET(msg_fd_out, &w_fds); - if (msg_fd_out > maxfd) - maxfd = msg_fd_out; - } if (io_filesfrom_f_out >= 0) { int new_fd; if (io_filesfrom_buflen == 0) { @@ -581,15 +616,14 @@ static int read_timeout(int fd, char *buf, size_t len) count = select(maxfd + 1, &r_fds, &w_fds, NULL, &tv); if (count <= 0) { - if (errno == EBADF) + if (errno == EBADF) { + defer_forwarding_messages = 0; exit_cleanup(RERR_SOCKETIO); + } check_timeout(); continue; } - if (msg2genr.head && FD_ISSET(msg_fd_out, &w_fds)) - msg2genr_flush(); - if (io_filesfrom_f_out >= 0) { if (io_filesfrom_buflen) { if (FD_ISSET(io_filesfrom_f_out, &w_fds)) { @@ -785,9 +819,10 @@ void io_end_buffering_out(void) iobuf_f_out = -1; } -void maybe_flush_socket(void) +void maybe_flush_socket(int important) { - if (iobuf_out && iobuf_out_cnt && time(NULL) - last_io_out >= 5) + if (iobuf_out && iobuf_out_cnt + && (important || time(NULL) - last_io_out >= 5)) io_flush(NORMAL_FLUSH); } @@ -992,66 +1027,96 @@ int32 read_int(int f) return num; } -int64 read_longint(int f) +int32 read_varint(int f) { - int64 num; - char b[9]; + union { + char b[5]; + int32 x; + } u; + uchar ch; + int extra; - if (protocol_version < 30) { - num = read_int(f); + u.x = 0; + readfd(f, (char*)&ch, 1); + extra = int_byte_extra[ch / 4]; + if (extra) { + uchar bit = ((uchar)1<<(8-extra)); + if (extra >= (int)sizeof u.b) { + rprintf(FERROR, "Overflow in read_varint()\n"); + exit_cleanup(RERR_STREAMIO); + } + readfd(f, u.b, extra); + u.b[extra] = ch & (bit-1); + } else + u.b[0] = ch; +#if CAREFUL_ALIGNMENT + u.x = IVAL(u.b,0); +#endif +#if SIZEOF_INT32 > 4 + if (u.x & (int32)0x80000000) + u.x |= ~(int32)0xffffffff; +#endif + return u.x; +} - if ((int32)num != (int32)0xffffffff) - return num; +int64 read_varlong(int f, uchar min_bytes) +{ + union { + char b[9]; + int64 x; + } u; + char b2[8]; + int extra; #if SIZEOF_INT64 < 8 - rprintf(FERROR, "Integer overflow: attempted 64-bit offset\n"); - exit_cleanup(RERR_UNSUPPORTED); + memset(u.b, 0, 8); #else - readfd(f, b, 8); - num = IVAL(b,0) | (((int64)IVAL(b,4))<<32); + u.x = 0; #endif - } else { - int cnt; - readfd(f, b, 3); - cnt = int_byte_cnt[CVAL(b, 0) / 4]; + readfd(f, b2, min_bytes); + memcpy(u.b, b2+1, min_bytes-1); + extra = int_byte_extra[CVAL(b2, 0) / 4]; + if (extra) { + uchar bit = ((uchar)1<<(8-extra)); + if (min_bytes + extra > (int)sizeof u.b) { + rprintf(FERROR, "Overflow in read_varlong()\n"); + exit_cleanup(RERR_STREAMIO); + } + readfd(f, u.b + min_bytes - 1, extra); + u.b[min_bytes + extra - 1] = CVAL(b2, 0) & (bit-1); #if SIZEOF_INT64 < 8 - if (cnt > 5 || (cnt == 5 && (CVAL(b,0)&0x3F || CVAL(b,1)&0x80))) { + if (min_bytes + extra > 5 || u.b[4] || CVAL(u.b,3) & 0x80) { rprintf(FERROR, "Integer overflow: attempted 64-bit offset\n"); exit_cleanup(RERR_UNSUPPORTED); } #endif - if (cnt > 3) - readfd(f, b + 3, cnt - 3); - switch (cnt) { - case 3: - num = NVAL3(b, 0); - break; - case 4: - num = NVAL4(b, 0x80); - break; - case 5: - num = NVAL5(b, 0xC0); - break; + } else + u.b[min_bytes + extra - 1] = CVAL(b2, 0); +#if SIZEOF_INT64 < 8 + u.x = IVAL(u.b,0); +#elif CAREFUL_ALIGNMENT + u.x = IVAL(u.b,0) | (((int64)IVAL(u.b,4))<<32); +#endif + return u.x; +} + +int64 read_longint(int f) +{ #if SIZEOF_INT64 >= 8 - case 6: - num = NVAL6(b, 0xE0); - break; - case 7: - num = NVAL7(b, 0xF0); - break; - case 8: - num = NVAL8(b, 0xF8); - break; - case 9: - num = NVAL8(b+1, 0); - break; + char b[9]; #endif - default: - exit_cleanup(RERR_PROTOCOL); /* impossible... */ - } - } + int32 num = read_int(f); - return num; + if (num != (int32)0xffffffff) + return num; + +#if SIZEOF_INT64 < 8 + rprintf(FERROR, "Integer overflow: attempted 64-bit offset\n"); + exit_cleanup(RERR_UNSUPPORTED); +#else + readfd(f, b, 8); + return IVAL(b,0) | (((int64)IVAL(b,4))<<32); +#endif } void read_buf(int f, char *buf, size_t len) @@ -1108,7 +1173,7 @@ void read_sum_head(int f, struct sum_struct *sum) exit_cleanup(RERR_PROTOCOL); } sum->s2length = protocol_version < 27 ? csum_length : (int)read_int(f); - if (sum->s2length < 0 || sum->s2length > MD4_SUM_LENGTH) { + if (sum->s2length < 0 || sum->s2length > MAX_DIGEST_LEN) { rprintf(FERROR, "Invalid checksum length %d [%s]\n", sum->s2length, who_am_i()); exit_cleanup(RERR_PROTOCOL); @@ -1204,10 +1269,11 @@ static void writefd_unbuffered(int fd, const char *buf, size_t len) size_t n, total = 0; fd_set w_fds, r_fds, e_fds; int maxfd, count, cnt, using_r_fds; - int defer_save = defer_forwarding_messages; + int defer_inc = 0; struct timeval tv; - no_flush++; + if (no_flush++) + defer_forwarding_messages++, defer_inc++; while (total < len) { FD_ZERO(&w_fds); @@ -1268,6 +1334,9 @@ static void writefd_unbuffered(int fd, const char *buf, size_t len) /* Don't try to write errors back across the stream. */ if (fd == sock_f_out) io_end_multiplex_out(); + /* Don't try to write errors down a failing msg pipe. */ + if (am_server && fd == msg_fd_out) + exit_cleanup(RERR_STREAMIO); rsyserr(FERROR, errno, "writefd_unbuffered failed to write %ld bytes [%s]", (long)len, who_am_i()); @@ -1283,7 +1352,7 @@ static void writefd_unbuffered(int fd, const char *buf, size_t len) } total += cnt; - defer_forwarding_messages = 1; + defer_forwarding_messages++, defer_inc++; if (fd == sock_f_out) { if (io_timeout || am_generator) @@ -1292,71 +1361,24 @@ static void writefd_unbuffered(int fd, const char *buf, size_t len) } } - defer_forwarding_messages = defer_save; no_flush--; -} - -static void msg2sndr_flush(void) -{ - if (defer_forwarding_messages) - return; - - while (msg2sndr.head && io_multiplexing_out) { - struct msg_list_item *m = msg2sndr.head; - if (!(msg2sndr.head = m->next)) - msg2sndr.tail = NULL; - stats.total_written += m->len; - defer_forwarding_messages = 1; - writefd_unbuffered(sock_f_out, m->buf, m->len); - defer_forwarding_messages = 0; - free(m); - } -} - -/** - * Write an message to a multiplexed stream. If this fails then rsync - * exits. - **/ -static void mplex_write(enum msgcode code, const char *buf, size_t len) -{ - char buffer[1024]; - size_t n = len; - - SIVAL(buffer, 0, ((MPLEX_BASE + (int)code)<<24) + len); - - if (n > sizeof buffer - 4) - n = 0; - else - memcpy(buffer + 4, buf, n); - - writefd_unbuffered(sock_f_out, buffer, n+4); - - len -= n; - buf += n; - - if (len) { - defer_forwarding_messages = 1; - writefd_unbuffered(sock_f_out, buf, len); - defer_forwarding_messages = 0; - msg2sndr_flush(); - } + if (!(defer_forwarding_messages -= defer_inc)) + msg_flush(); } void io_flush(int flush_it_all) { - if (flush_it_all) { - msg2genr_flush(); - msg2sndr_flush(); - } - if (!iobuf_out_cnt || no_flush) return; if (io_multiplexing_out) - mplex_write(MSG_DATA, iobuf_out, iobuf_out_cnt); + mplex_write(sock_f_out, MSG_DATA, iobuf_out, iobuf_out_cnt); else writefd_unbuffered(iobuf_f_out, iobuf_out, iobuf_out_cnt); iobuf_out_cnt = 0; + + if (flush_it_all && !defer_forwarding_messages) + msg_flush(); } static void writefd(int fd, const char *buf, size_t len) @@ -1403,106 +1425,81 @@ void write_int(int f, int32 x) writefd(f, b, 4); } -/* - * Note: int64 may actually be a 32-bit type if ./configure couldn't find any - * 64-bit types on this platform. - */ -void write_longint(int f, int64 x) +void write_varint(int f, int32 x) { - char b[12]; + char b[5]; + uchar bit; + int cnt = 4; -#if SIZEOF_INT64 < 8 - if (x < 0 || x > 0x7FFFFFFF) { + SIVAL(b, 1, x); + + while (cnt > 1 && b[cnt] == 0) + cnt--; + bit = ((uchar)1<<(7-cnt+1)); + if (CVAL(b, cnt) >= bit) { + cnt++; + *b = ~(bit-1); + } else if (cnt > 1) + *b = b[cnt] | ~(bit*2-1); + else + *b = b[cnt]; + + writefd(f, b, cnt); +} + +void write_varlong(int f, int64 x, uchar min_bytes) +{ + char b[9]; + uchar bit; + int cnt = 8; + + SIVAL(b, 1, x); +#if SIZEOF_INT64 >= 8 + SIVAL(b, 5, x >> 32); +#else + if (x <= 0x7FFFFFFF && x >= 0) + memset(b + 5, 0, 4); + else { rprintf(FERROR, "Integer overflow: attempted 64-bit offset\n"); exit_cleanup(RERR_UNSUPPORTED); } #endif - if (protocol_version < 30) { - char * const s = b+4; - SIVAL(s, 0, x); -#if SIZEOF_INT64 < 8 + while (cnt > min_bytes && b[cnt] == 0) + cnt--; + bit = ((uchar)1<<(7-cnt+min_bytes)); + if (CVAL(b, cnt) >= bit) { + cnt++; + *b = ~(bit-1); + } else if (cnt > min_bytes) + *b = b[cnt] | ~(bit*2-1); + else + *b = b[cnt]; + + writefd(f, b, cnt); +} + +/* + * Note: int64 may actually be a 32-bit type if ./configure couldn't find any + * 64-bit types on this platform. + */ +void write_longint(int f, int64 x) +{ + char b[12], * const s = b+4; + + SIVAL(s, 0, x); + if (x <= 0x7FFFFFFF && x >= 0) { writefd(f, s, 4); -#else - if (x <= 0x7FFFFFFF && x >= 0) { - writefd(f, s, 4); - return; - } + return; + } - memset(b, 0xFF, 4); - SIVAL(s, 4, x >> 32); - writefd(f, b, 12); - } else if (x < 0) { - goto all_bits; -#endif - } else if (x < ((int32)1<<(3*8-1))) { - b[0] = (char)(x >> 16); - b[1] = (char)(x >> 8); - b[2] = (char)x; - writefd(f, b, 3); - } else if (x < ((int64)1<<(4*8-2))) { - b[0] = (char)((x >> 24) | 0x80); - b[1] = (char)(x >> 16); - b[2] = (char)(x >> 8); - b[3] = (char)x; - writefd(f, b, 4); #if SIZEOF_INT64 < 8 - } else { - b[0] = 0xC0; - b[1] = (char)(x >> 24); - b[2] = (char)(x >> 16); - b[3] = (char)(x >> 8); - b[4] = (char)x; - writefd(f, b, 5); - } + rprintf(FERROR, "Integer overflow: attempted 64-bit offset\n"); + exit_cleanup(RERR_UNSUPPORTED); #else - } else if (x < ((int64)1<<(5*8-3))) { - b[0] = (char)((x >> 32) | 0xC0); - b[1] = (char)(x >> 24); - b[2] = (char)(x >> 16); - b[3] = (char)(x >> 8); - b[4] = (char)x; - writefd(f, b, 5); - } else if (x < ((int64)1<<(6*8-4))) { - b[0] = (char)((x >> 40) | 0xE0); - b[1] = (char)(x >> 32); - b[2] = (char)(x >> 24); - b[3] = (char)(x >> 16); - b[4] = (char)(x >> 8); - b[5] = (char)x; - writefd(f, b, 6); - } else if (x < ((int64)1<<(7*8-5))) { - b[0] = (char)((x >> 48) | 0xF0); - b[1] = (char)(x >> 40); - b[2] = (char)(x >> 32); - b[3] = (char)(x >> 24); - b[4] = (char)(x >> 16); - b[5] = (char)(x >> 8); - b[6] = (char)x; - writefd(f, b, 7); - } else if (x < ((int64)1<<(8*8-6))) { - b[0] = (char)((x >> 56) | 0xF8); - b[1] = (char)(x >> 48); - b[2] = (char)(x >> 40); - b[3] = (char)(x >> 32); - b[4] = (char)(x >> 24); - b[5] = (char)(x >> 16); - b[6] = (char)(x >> 8); - b[7] = (char)x; - writefd(f, b, 8); - } else { - all_bits: - b[0] = (char)0xFC; - b[1] = (char)(x >> 56); - b[2] = (char)(x >> 48); - b[3] = (char)(x >> 40); - b[4] = (char)(x >> 32); - b[5] = (char)(x >> 24); - b[6] = (char)(x >> 16); - b[7] = (char)(x >> 8); - b[8] = (char)x; - writefd(f, b, 9); - } + memset(b, 0xFF, 4); + SIVAL(s, 4, x >> 32); + writefd(f, b, 12); #endif } @@ -1578,9 +1575,9 @@ void write_ndx(int f, int32 ndx) else if (diff < 0 || diff > 0x7FFF) { b[cnt++] = (char)0xFE; b[cnt++] = (char)((ndx >> 24) | 0x80); - b[cnt++] = (char)(ndx >> 16); - b[cnt++] = (char)(ndx >> 8); b[cnt++] = (char)ndx; + b[cnt++] = (char)(ndx >> 8); + b[cnt++] = (char)(ndx >> 16); } else { b[cnt++] = (char)0xFE; b[cnt++] = (char)(diff >> 8); @@ -1610,12 +1607,14 @@ int32 read_ndx(int f) if (CVAL(b, 0) == 0xFE) { readfd(f, b, 2); if (CVAL(b, 0) & 0x80) { - readfd(f, b+2, 2); - num = NVAL4(b, 0x80); + b[3] = CVAL(b, 0) & ~0x80; + b[0] = b[1]; + readfd(f, b+1, 2); + num = IVAL(b, 0); } else - num = NVAL2(b, 0) + *prev_ptr; + num = (UVAL(b,0)<<8) + UVAL(b,1) + *prev_ptr; } else - num = CVAL(b, 0) + *prev_ptr; + num = UVAL(b, 0) + *prev_ptr; *prev_ptr = num; if (prev_ptr == &prev_negative) num = -num; @@ -1691,7 +1690,7 @@ int io_multiplex_write(enum msgcode code, const char *buf, size_t len) return 0; io_flush(NORMAL_FLUSH); stats.total_written += (len+4); - mplex_write(code, buf, len); + mplex_write(sock_f_out, code, buf, len); return 1; }