X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/dd7fb70f6eb6e46dbc9a76049fef568959713135..882e68931246958a37c63c557d6f758356bd92d9:/flist.c

diff --git a/flist.c b/flist.c
index 46079d96..1ef1617a 100644
--- a/flist.c
+++ b/flist.c
@@ -37,10 +37,13 @@ extern int verbose;
 extern int do_progress;
 extern int am_server;
 extern int always_checksum;
+extern int module_id;
+extern int ignore_errors;
 
 extern int cvs_exclude;
 
 extern int recurse;
+extern char curr_dir[MAXPATHLEN];
 extern char *files_from;
 extern int filesfrom_fd;
 
@@ -70,6 +73,7 @@ extern struct exclude_struct **local_exclude_list;
 int io_error;
 
 static struct file_struct null_file;
+static char empty_sum[MD4_SUM_LENGTH];
 
 static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
 
@@ -185,7 +189,7 @@ static void list_file_entry(struct file_struct *f)
 		rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
 			perms,
 			(double) f->length, timestring(f->modtime),
-			f_name(f), f->link);
+			f_name(f), f->u.link);
 	} else {
 		rprintf(FINFO, "%s %11.0f %s %s\n",
 			perms,
@@ -311,6 +315,7 @@ static mode_t from_wire_mode(int mode)
 static void send_directory(int f, struct file_list *flist, char *dir);
 
 static char *flist_dir;
+static int flist_dir_len;
 
 
 /**
@@ -350,17 +355,15 @@ static void flist_expand(struct file_list *flist)
 	}
 }
 
-
-static void send_file_entry(struct file_struct *file, int f,
-			    unsigned short base_flags)
+void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
 {
 	unsigned short flags;
 	static time_t modtime;
 	static mode_t mode;
-	static DEV64_T rdev;	/* just high bytes after p28 */
+	static DEV64_T rdev;	/* just high bytes in p28 onward */
+	static DEV64_T dev;
 	static uid_t uid;
 	static gid_t gid;
-	static DEV64_T dev;
 	static char lastname[MAXPATHLEN];
 	char *fname, fbuf[MAXPATHLEN];
 	int l1, l2;
@@ -370,12 +373,16 @@ static void send_file_entry(struct file_struct *file, int f,
 
 	if (!file) {
 		write_byte(f, 0);
+		modtime = 0, mode = 0;
+		rdev = 0, dev = 0;
+		uid = 0, gid = 0;
+		*lastname = '\0';
 		return;
 	}
 
 	io_write_phase = "send_file_entry";
 
-	fname = f_name_to(file, fbuf, sizeof fbuf);
+	fname = f_name_to(file, fbuf);
 
 	flags = base_flags;
 
@@ -385,19 +392,20 @@ static void send_file_entry(struct file_struct *file, int f,
 		mode = file->mode;
 	if (preserve_devices) {
 		if (protocol_version < 28) {
-			if (IS_DEVICE(mode) && file->rdev == rdev) {
-				/* Set both flags so that the test when
-				 * writing the data is simpler. */
-				flags |= SAME_RDEV_pre28|SAME_HIGH_RDEV;
-			}
-			else
-				rdev = file->rdev;
-		}
-		else if (IS_DEVICE(mode)) {
-			if ((file->rdev & ~0xFF) == rdev)
+			if (IS_DEVICE(mode)) {
+				if (file->u.rdev == rdev) {
+					/* Set both flags so that the test when
+					 * writing the data is simpler. */
+					flags |= SAME_RDEV_pre28|SAME_HIGH_RDEV;
+				} else
+					rdev = file->u.rdev;
+			} else
+				rdev = 0;
+		} else if (IS_DEVICE(mode)) {
+			if ((file->u.rdev & ~0xFF) == rdev)
 				flags |= SAME_HIGH_RDEV;
 			else
-				rdev = file->rdev & ~0xFF;
+				rdev = file->u.rdev & ~0xFF;
 		}
 	}
 	if (file->uid == uid)
@@ -412,20 +420,19 @@ static void send_file_entry(struct file_struct *file, int f,
 		flags |= SAME_TIME;
 	else
 		modtime = file->modtime;
-	if (file->flags & HAS_INODE_DATA) {
-		if (file->dev == dev) {
+	if (file->link_u.idev) {
+		if (file->F_DEV == dev) {
 			if (protocol_version >= 28)
 				flags |= SAME_DEV;
-		}
-		else
-			dev = file->dev;
+		} else
+			dev = file->F_DEV;
 		flags |= HAS_INODE_DATA;
 	}
 
 	for (l1 = 0;
 	     lastname[l1] && (fname[l1] == lastname[l1]) && (l1 < 255);
 	     l1++) {}
-	l2 = strlen(fname) - l1;
+	l2 = strlen(fname+l1);
 
 	if (l1 > 0)
 		flags |= SAME_NAME;
@@ -470,17 +477,18 @@ static void send_file_entry(struct file_struct *file, int f,
 		write_int(f, gid);
 	}
 	if (preserve_devices && IS_DEVICE(mode)) {
-		/* If SAME_HIGH_RDEV is off, SAME_RDEV_pre28 is also off. */
+		/* If SAME_HIGH_RDEV is off, SAME_RDEV_pre28 is also off.
+		 * Also, avoid using "rdev" because it may be incomplete. */
 		if (!(flags & SAME_HIGH_RDEV))
-			write_int(f, file->rdev);
+			write_int(f, file->u.rdev);
 		else if (protocol_version >= 28)
-			write_byte(f, file->rdev);
+			write_byte(f, file->u.rdev);
 	}
 
 #if SUPPORT_LINKS
 	if (preserve_links && S_ISLNK(mode)) {
-		write_int(f, strlen(file->link));
-		write_buf(f, file->link, strlen(file->link));
+		write_int(f, strlen(file->u.link));
+		write_buf(f, file->u.link, strlen(file->u.link));
 	}
 #endif
 
@@ -489,46 +497,60 @@ static void send_file_entry(struct file_struct *file, int f,
 		if (protocol_version < 26) {
 			/* 32-bit dev_t and ino_t */
 			write_int(f, dev);
-			write_int(f, file->inode);
+			write_int(f, file->F_INODE);
 		} else {
 			/* 64-bit dev_t and ino_t */
 			if (!(flags & SAME_DEV))
 				write_longint(f, dev);
-			write_longint(f, file->inode);
+			write_longint(f, file->F_INODE);
 		}
 	}
 #endif
 
 	if (always_checksum) {
-		if (protocol_version < 21)
-			write_buf(f, file->sum, 2);
-		else
-			write_buf(f, file->sum, MD4_SUM_LENGTH);
+		char *sum;
+		if (S_ISREG(mode))
+			sum = file->u.sum;
+		else if (protocol_version < 28) {
+			/* Prior to 28, we sent a useless set of nulls. */
+			sum = empty_sum;
+		} else
+			sum = NULL;
+		if (sum) {
+			write_buf(f, sum, protocol_version < 21? 2
+							: MD4_SUM_LENGTH);
+		}
 	}
 
 	strlcpy(lastname, fname, MAXPATHLEN);
-	lastname[MAXPATHLEN - 1] = 0;
 
 	io_write_phase = "unknown";
 }
 
 
 
-static void receive_file_entry(struct file_struct **fptr,
-			       unsigned short flags, int f)
+void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
 {
 	static time_t modtime;
 	static mode_t mode;
-	static DEV64_T rdev;	/* just high bytes after p28 */
+	static DEV64_T rdev;	/* just high bytes in p28 onward */
+	static DEV64_T dev;
 	static uid_t uid;
 	static gid_t gid;
-	static DEV64_T dev;
 	static char lastname[MAXPATHLEN];
 	char thisname[MAXPATHLEN];
 	unsigned int l1 = 0, l2 = 0;
 	char *p;
 	struct file_struct *file;
 
+	if (!fptr) {
+		modtime = 0, mode = 0;
+		rdev = 0, dev = 0;
+		uid = 0, gid = 0;
+		*lastname = '\0';
+		return;
+	}
+
 	if (flags & SAME_NAME)
 		l1 = read_byte(f);
 
@@ -605,15 +627,15 @@ static void receive_file_entry(struct file_struct **fptr,
 			if (IS_DEVICE(mode)) {
 				if (!(flags & SAME_RDEV_pre28))
 					rdev = (DEV64_T)read_int(f);
-				file->rdev = rdev;
+				file->u.rdev = rdev;
 			} else
 				rdev = 0;
 		} else if (IS_DEVICE(mode)) {
 			if (!(flags & SAME_HIGH_RDEV)) {
-				file->rdev = (DEV64_T)read_int(f);
-				rdev = file->rdev & ~0xFF;
+				file->u.rdev = (DEV64_T)read_int(f);
+				rdev = file->u.rdev & ~0xFF;
 			} else
-				file->rdev = rdev | (DEV64_T)read_byte(f);
+				file->u.rdev = rdev | (DEV64_T)read_byte(f);
 		}
 	}
 
@@ -623,44 +645,51 @@ static void receive_file_entry(struct file_struct **fptr,
 			rprintf(FERROR, "overflow: l=%d\n", l);
 			overflow("receive_file_entry");
 		}
-		file->link = new_array(char, l + 1);
-		if (!file->link)
+		if (!(file->u.link = new_array(char, l + 1)))
 			out_of_memory("receive_file_entry 2");
-		read_sbuf(f, file->link, l);
+		read_sbuf(f, file->u.link, l);
 		if (sanitize_paths)
-			sanitize_path(file->link, file->dirname);
+			sanitize_path(file->u.link, file->dirname);
 	}
 #if SUPPORT_HARD_LINKS
-	if (preserve_hard_links && protocol_version < 28
-	    && S_ISREG(mode))
-		file->flags |= HAS_INODE_DATA;
-	if (file->flags & HAS_INODE_DATA) {
+	if (preserve_hard_links && protocol_version < 28 && S_ISREG(mode))
+		flags |= HAS_INODE_DATA;
+	if (flags & HAS_INODE_DATA) {
+		if (!(file->link_u.idev = new(struct idev)))
+			out_of_memory("file inode data");
 		if (protocol_version < 26) {
 			dev = read_int(f);
-			file->inode = read_int(f);
+			file->F_INODE = read_int(f);
 		} else {
 			if (!(flags & SAME_DEV))
 				dev = read_longint(f);
-			file->inode = read_longint(f);
+			file->F_INODE = read_longint(f);
 		}
-		file->dev = dev;
+		file->F_DEV = dev;
 	}
 #endif
 
 	if (always_checksum) {
-		file->sum = new_array(char, MD4_SUM_LENGTH);
-		if (!file->sum)
-			out_of_memory("md4 sum");
-		if (protocol_version < 21)
-			read_buf(f, file->sum, 2);
-		else
-			read_buf(f, file->sum, MD4_SUM_LENGTH);
+		char *sum;
+		if (S_ISREG(mode)) {
+			sum = file->u.sum = new_array(char, MD4_SUM_LENGTH);
+			if (!sum)
+				out_of_memory("md4 sum");
+		} else if (protocol_version < 28) {
+			/* Prior to 28, we get a useless set of nulls. */
+			sum = empty_sum;
+		} else
+			sum = NULL;
+		if (sum) {
+			read_buf(f, sum, protocol_version < 21? 2
+						: MD4_SUM_LENGTH);
+		}
 	}
 
 	if (!preserve_perms) {
 		extern int orig_umask;
 		/* set an appropriate set of permissions based on original
-		   permissions and umask. This emulates what GNU cp does */
+		 * permissions and umask. This emulates what GNU cp does */
 		file->mode &= ~orig_umask;
 	}
 }
@@ -720,10 +749,12 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
 	char *p;
 	char cleaned_name[MAXPATHLEN];
 	char linkbuf[MAXPATHLEN];
-	extern int module_id;
 
-	strlcpy(cleaned_name, fname, MAXPATHLEN);
-	cleaned_name[MAXPATHLEN - 1] = 0;
+	if (strlcpy(cleaned_name, fname, sizeof cleaned_name)
+	    >= sizeof cleaned_name - flist_dir_len) {
+		rprintf(FINFO, "skipping overly long name: %s\n", fname);
+		return NULL;
+	}
 	clean_fname(cleaned_name);
 	if (sanitize_paths)
 		sanitize_path(cleaned_name, NULL);
@@ -800,46 +831,31 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
 	file->uid = st.st_uid;
 	file->gid = st.st_gid;
 	if (preserve_hard_links) {
-		if (protocol_version < 28? S_ISREG(st.st_mode)
+		if (protocol_version < 28 ? S_ISREG(st.st_mode)
 		    : !S_ISDIR(st.st_mode) && st.st_nlink > 1) {
-			file->dev = st.st_dev;
-			file->inode = st.st_ino;
-			file->flags |= HAS_INODE_DATA;
+			if (!(file->link_u.idev = new(struct idev)))
+				out_of_memory("file inode data");
+			file->F_DEV = st.st_dev;
+			file->F_INODE = st.st_ino;
 		}
 	}
 #ifdef HAVE_STRUCT_STAT_ST_RDEV
-	file->rdev = st.st_rdev;
+	if (IS_DEVICE(st.st_mode))
+		file->u.rdev = st.st_rdev;
 #endif
 
 #if SUPPORT_LINKS
 	if (S_ISLNK(st.st_mode))
-		file->link = STRDUP(ap, linkbuf);
+		file->u.link = STRDUP(ap, linkbuf);
 #endif
 
-	if (always_checksum) {
-		file->sum = (char *) MALLOC(ap, MD4_SUM_LENGTH);
-		if (!file->sum)
+	if (always_checksum && S_ISREG(st.st_mode)) {
+		if (!(file->u.sum = (char*)MALLOC(ap, MD4_SUM_LENGTH)))
 			out_of_memory("md4 sum");
-		/* drat. we have to provide a null checksum for non-regular
-		   files in order to be compatible with earlier versions
-		   of rsync */
-		if (S_ISREG(st.st_mode)) {
-			file_checksum(fname, file->sum, st.st_size);
-		} else {
-			memset(file->sum, 0, MD4_SUM_LENGTH);
-		}
+		file_checksum(fname, file->u.sum, st.st_size);
 	}
 
-	if (flist_dir) {
-		static char *lastdir;
-		if (lastdir && strcmp(lastdir, flist_dir) == 0)
-			file->basedir = lastdir;
-		else {
-			file->basedir = strdup(flist_dir);
-			lastdir = file->basedir;
-		}
-	} else
-		file->basedir = NULL;
+	file->basedir = flist_dir;
 
 	if (!S_ISDIR(st.st_mode))
 		stats.total_size += st.st_size;
@@ -878,7 +894,7 @@ void send_file_name(int f, struct file_list *flist, char *fname,
 	if (S_ISDIR(file->mode) && recursive) {
 		struct exclude_struct **last_exclude_list =
 		    local_exclude_list;
-		send_directory(f, flist, f_name_to(file, fbuf, sizeof fbuf));
+		send_directory(f, flist, f_name_to(file, fbuf));
 		local_exclude_list = last_exclude_list;
 		return;
 	}
@@ -890,7 +906,7 @@ static void send_directory(int f, struct file_list *flist, char *dir)
 	DIR *d;
 	struct dirent *di;
 	char fname[MAXPATHLEN];
-	int l;
+	unsigned int offset;
 	char *p;
 
 	d = opendir(dir);
@@ -901,28 +917,27 @@ static void send_directory(int f, struct file_list *flist, char *dir)
 		return;
 	}
 
-	strlcpy(fname, dir, MAXPATHLEN);
-	l = strlen(fname);
-	if (fname[l - 1] != '/') {
-		if (l == MAXPATHLEN - 1) {
+	offset = strlcpy(fname, dir, MAXPATHLEN);
+	p = fname + offset;
+	if (offset >= MAXPATHLEN || p[-1] != '/') {
+		if (offset >= MAXPATHLEN - 1) {
 			io_error |= IOERR_GENERAL;
 			rprintf(FERROR, "skipping long-named directory: %s\n",
 				full_fname(fname));
 			closedir(d);
 			return;
 		}
-		strlcat(fname, "/", MAXPATHLEN);
-		l++;
+		*p++ = '/';
+		offset++;
 	}
-	p = fname + strlen(fname);
 
 	local_exclude_list = NULL;
 
 	if (cvs_exclude) {
-		if (strlen(fname) + strlen(".cvsignore") <= MAXPATHLEN - 1) {
-			strcpy(p, ".cvsignore");
-			add_exclude_file(&exclude_list,fname,MISSING_OK,ADD_EXCLUDE);
-		} else {
+		if (strlcpy(p, ".cvsignore", MAXPATHLEN - offset)
+		    < MAXPATHLEN - offset)
+			add_exclude_file(&local_exclude_list,fname,MISSING_OK,ADD_EXCLUDE);
+		else {
 			io_error |= IOERR_GENERAL;
 			rprintf(FINFO,
 				"cannot cvs-exclude in long-named directory %s\n",
@@ -935,13 +950,19 @@ static void send_directory(int f, struct file_list *flist, char *dir)
 		if (dname[0] == '.' && (dname[1] == '\0'
 		    || (dname[1] == '.' && dname[2] == '\0')))
 			continue;
-		strlcpy(p, dname, MAXPATHLEN - l);
-		send_file_name(f, flist, fname, recurse, 0);
+		if (strlcpy(p, dname, MAXPATHLEN - offset) < MAXPATHLEN - offset)
+			send_file_name(f, flist, fname, recurse, 0);
+		else {
+			io_error |= IOERR_GENERAL;
+			rprintf(FINFO,
+				"cannot send long-named file %s\n",
+				full_fname(fname));
+		}
 	}
 	if (errno) {
 		io_error |= IOERR_GENERAL;
 		rprintf(FERROR, "readdir(%s): (%d) %s\n",
-		    dir, errno, strerror(errno));
+			dir, errno, strerror(errno));
 	}
 
 	if (local_exclude_list)
@@ -961,7 +982,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 {
 	int l;
 	STRUCT_STAT st;
-	char *p, *dir, *olddir;
+	char *p, *dir, olddir[sizeof curr_dir];
 	char lastpath[MAXPATHLEN] = "";
 	struct file_list *flist;
 	int64 start_write;
@@ -977,7 +998,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 	if (f != -1) {
 		io_start_buffering_out(f);
 		if (filesfrom_fd >= 0) {
-			if (argv[0] && !push_dir(argv[0], 0)) {
+			if (argv[0] && !push_dir(argv[0])) {
 				rprintf(FERROR, "push_dir %s failed: %s\n",
 					full_fname(argv[0]), strerror(errno));
 				exit_cleanup(RERR_FILESELECT);
@@ -1007,8 +1028,9 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 			if (l == 2 && fname[0] == '.') {
 				/* Turn "./" into just "." rather than "./." */
 				fname[1] = '\0';
-			} else {
-				strlcat(fname, ".", MAXPATHLEN);
+			} else if (l < MAXPATHLEN) {
+				fname[l++] = '.';
+				fname[l] = '\0';
 			}
 		}
 
@@ -1027,7 +1049,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 		}
 
 		dir = NULL;
-		olddir = NULL;
+		olddir[0] = '\0';
 
 		if (!relative_paths) {
 			p = strrchr(fname, '/');
@@ -1078,16 +1100,27 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 			fname = ".";
 
 		if (dir && *dir) {
-			olddir = push_dir(dir, 1);
+			static char *lastdir;
+			static int lastdir_len;
 
-			if (!olddir) {
+			strcpy(olddir, curr_dir); /* can't overflow */
+
+			if (!push_dir(dir)) {
 				io_error |= IOERR_GENERAL;
 				rprintf(FERROR, "push_dir %s failed: %s\n",
 					full_fname(dir), strerror(errno));
 				continue;
 			}
 
-			flist_dir = dir;
+			if (lastdir && strcmp(lastdir, dir) == 0) {
+				flist_dir = lastdir;
+				flist_dir_len = lastdir_len;
+			} else {
+				if (lastdir)
+					free(lastdir);
+				flist_dir = lastdir = strdup(dir);
+				flist_dir_len = lastdir_len = strlen(dir);
+			}
 		}
 
 		if (one_file_system)
@@ -1095,9 +1128,10 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 
 		send_file_name(f, flist, fname, recurse, FLAG_DELETE);
 
-		if (olddir != NULL) {
+		if (olddir[0]) {
 			flist_dir = NULL;
-			if (pop_dir(olddir) != 0) {
+			flist_dir_len = 0;
+			if (!pop_dir(olddir)) {
 				rprintf(FERROR, "pop_dir %s failed: %s\n",
 					full_fname(dir), strerror(errno));
 				exit_cleanup(RERR_FILESELECT);
@@ -1105,26 +1139,23 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 		}
 	}
 
-	if (f != -1)
+	if (f != -1) {
 		send_file_entry(NULL, f, 0);
 
-	if (show_filelist_p() && f != -1)
-		finish_filelist_progress(flist);
+		if (show_filelist_p())
+			finish_filelist_progress(flist);
+	}
 
 	clean_flist(flist, 0, 0);
 
-	/* now send the uid/gid list. This was introduced in protocol
-	   version 15 */
-	if (f != -1)
+	if (f != -1) {
+		/* Now send the uid/gid list. This was introduced in
+		 * protocol version 15 */
 		send_uid_list(f);
 
-	/* send the io_error flag */
-	if (f != -1) {
-		extern int module_id;
+		/* send the io_error flag */
 		write_int(f, lp_ignore_errors(module_id) ? 0 : io_error);
-	}
 
-	if (f != -1) {
 		io_end_buffering();
 		stats.flist_size = stats.total_written - start_write;
 		stats.num_files = flist->count;
@@ -1183,28 +1214,28 @@ struct file_list *recv_file_list(int f)
 				f_name(flist->files[i]));
 		}
 	}
-
+	receive_file_entry(NULL, 0, 0); /* Signal that we're done. */
 
 	if (verbose > 2)
 		rprintf(FINFO, "received %d names\n", flist->count);
 
-	clean_flist(flist, relative_paths, 1);
-
 	if (show_filelist_p())
 		finish_filelist_progress(flist);
 
-	/* now recv the uid/gid list. This was introduced in protocol version 15 */
-	if (f != -1)
+	clean_flist(flist, relative_paths, 1);
+
+	if (f != -1) {
+		/* Now send the uid/gid list. This was introduced in
+		 * protocol version 15 */
 		recv_uid_list(f, flist);
 
-	/* recv the io_error flag */
-	if (f != -1 && !read_batch) {	/* dw-added readbatch */
-		extern int module_id;
-		extern int ignore_errors;
-		if (lp_ignore_errors(module_id) || ignore_errors)
-			read_int(f);
-		else
-			io_error |= read_int(f);
+		if (!read_batch) {
+			/* Recv the io_error flag */
+			if (lp_ignore_errors(module_id) || ignore_errors)
+				read_int(f);
+			else
+				io_error |= read_int(f);
+		}
 	}
 
 	if (list_only) {
@@ -1213,7 +1244,6 @@ struct file_list *recv_file_list(int f)
 			list_file_entry(flist->files[i]);
 	}
 
-
 	if (verbose > 2)
 		rprintf(FINFO, "recv_file_list done\n");
 
@@ -1280,10 +1310,10 @@ void free_file(struct file_struct *file)
 		return;
 	if (file->basename)
 		free(file->basename);
-	if (file->link)
-		free(file->link);
-	if (file->sum)
-		free(file->sum);
+	if (!IS_DEVICE(file->mode) && file->u.link)
+		free(file->u.link); /* Handles u.sum too. */
+	if (file->link_u.idev)
+		free((char*)file->link_u.idev); /* Handles link_u.links too. */
 	*file = null_file;
 }
 
@@ -1378,8 +1408,7 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
 				flist->files[i][0] = null_file;
 			else
 				free_file(flist->files[i]);
-		}
-		else
+		} else
 			prev_i = i;
 	}
 
@@ -1439,14 +1468,12 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
 	if (!(c1 = (uchar*)f1->dirname)) {
 		state1 = fnc_BASE;
 		c1 = (uchar*)f1->basename;
-	}
-	else
+	} else
 		state1 = fnc_DIR;
 	if (!(c2 = (uchar*)f2->dirname)) {
 		state2 = fnc_BASE;
 		c2 = (uchar*)f2->basename;
-	}
-	else
+	} else
 		state2 = fnc_DIR;
 
 	while (1) {
@@ -1489,19 +1516,21 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
 
 
 /* Return a copy of the full filename of a flist entry, using the indicated
- * buffer.
+ * buffer.  No size-checking is done because we checked the size when creating
+ * the file_struct entry.
  */
-char *f_name_to(struct file_struct *f, char *fbuf, int bsize)
+char *f_name_to(struct file_struct *f, char *fbuf)
 {
 	if (!f || !f->basename)
 		return NULL;
 
 	if (f->dirname) {
-		int off = strlcpy(fbuf, f->dirname, bsize);
-		off += strlcpy(fbuf + off, "/", bsize - off);
-		strlcpy(fbuf + off, f->basename, bsize - off);
+		int len = strlen(f->dirname);
+		memcpy(fbuf, f->dirname, len);
+		fbuf[len] = '/';
+		strcpy(fbuf + len + 1, f->basename);
 	} else
-		strlcpy(fbuf, f->basename, bsize);
+		strcpy(fbuf, f->basename);
 	return fbuf;
 }
 
@@ -1515,5 +1544,5 @@ char *f_name(struct file_struct *f)
 
 	n = (n + 1) % (sizeof names / sizeof names[0]);
 
-	return f_name_to(f, names[n], sizeof names[0]);
+	return f_name_to(f, names[n]);
 }