X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/d3d07a5e860f1cde0e234ec7a1aff7111a2c514f..refs/heads/hacks/missing-args-b3.0.x:/hlink.c diff --git a/hlink.c b/hlink.c index 2a8b77eb..6d03733e 100644 --- a/hlink.c +++ b/hlink.c @@ -4,7 +4,7 @@ * Copyright (C) 1996 Andrew Tridgell * Copyright (C) 1996 Paul Mackerras * Copyright (C) 2002 Martin Pool - * Copyright (C) 2004-2008 Wayne Davison + * Copyright (C) 2004-2009 Wayne Davison * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -30,6 +30,7 @@ extern int inc_recurse; extern int do_xfers; extern int link_dest; extern int preserve_acls; +extern int preserve_xattrs; extern int make_backups; extern int protocol_version; extern int remove_source_files; @@ -119,18 +120,23 @@ static void match_gnums(int32 *ndx_list, int ndx_count) if (inc_recurse) { node = hashtable_find(prior_hlinks, gnum, 1); if (!node->data) { - node->data = new_array0(char, 5); + if (!(node->data = new_array0(char, 5))) + out_of_memory("match_gnums"); assert(gnum >= hlink_flist->ndx_start); file->flags |= FLAG_HLINK_FIRST; prev = -1; } else if (CVAL(node->data, 0) == 0) { struct file_list *flist; - struct file_struct *fp; prev = IVAL(node->data, 1); - flist = flist_for_ndx(prev); - assert(flist != NULL); - fp = flist->files[prev - flist->ndx_start]; - fp->flags &= ~FLAG_HLINK_LAST; + flist = flist_for_ndx(prev, NULL); + if (flist) + flist->files[prev - flist->ndx_start]->flags &= ~FLAG_HLINK_LAST; + else { + /* We skipped all prior files in this + * group, so mark this as a "first". */ + file->flags |= FLAG_HLINK_FIRST; + prev = -1; + } } else prev = -1; } else { @@ -175,7 +181,7 @@ static void match_gnums(int32 *ndx_list, int ndx_count) * to first when we're done. */ void match_hard_links(struct file_list *flist) { - if (!list_only) { + if (!list_only && flist->used) { int i, ndx_count = 0; int32 *ndx_list; @@ -240,21 +246,43 @@ static int maybe_hard_link(struct file_struct *file, int ndx, } /* Figure out if a prior entry is still there or if we just have a - * cached name for it. Never called with a FLAG_HLINK_FIRST entry. */ -static char *check_prior(int prev_ndx, int gnum, struct file_list **flist_p) + * cached name for it. */ +static char *check_prior(struct file_struct *file, int gnum, + int *prev_ndx_p, struct file_list **flist_p) { - struct file_list *flist = flist_for_ndx(prev_ndx); + struct file_struct *fp; struct ht_int32_node *node; + int prev_ndx = F_HL_PREV(file); - if (flist) { - *flist_p = flist; - return NULL; + while (1) { + struct file_list *flist; + if (prev_ndx < 0 + || (flist = flist_for_ndx(prev_ndx, NULL)) == NULL) + break; + fp = flist->files[prev_ndx - flist->ndx_start]; + if (!(fp->flags & FLAG_SKIP_HLINK)) { + *prev_ndx_p = prev_ndx; + *flist_p = flist; + return NULL; + } + F_HL_PREV(file) = prev_ndx = F_HL_PREV(fp); } - node = hashtable_find(prior_hlinks, gnum, 0); - assert(node != NULL && node->data); - assert(CVAL(node->data, 0) != 0); - return node->data; + if (inc_recurse + && (node = hashtable_find(prior_hlinks, gnum, 0)) != NULL) { + assert(node->data != NULL); + if (CVAL(node->data, 0) != 0) { + *prev_ndx_p = -1; + *flist_p = NULL; + return node->data; + } + /* The prior file must have been skipped. */ + F_HL_PREV(file) = -1; + } + + *prev_ndx_p = -1; + *flist_p = NULL; + return NULL; } /* Only called if FLAG_HLINKED is set and FLAG_HLINK_FIRST is not. Returns: @@ -268,12 +296,20 @@ int hard_link_check(struct file_struct *file, int ndx, const char *fname, char *realname, *prev_name; struct file_list *flist; int gnum = inc_recurse ? F_HL_GNUM(file) : -1; - int prev_ndx = F_HL_PREV(file); + int prev_ndx; - prev_name = realname = check_prior(prev_ndx, gnum, &flist); + prev_name = realname = check_prior(file, gnum, &prev_ndx, &flist); if (!prev_name) { - struct file_struct *prev_file = flist->files[prev_ndx - flist->ndx_start]; + struct file_struct *prev_file; + + if (!flist) { + /* The previous file was skipped, so this one is + * treated as if it were the first in its group. */ + return 0; + } + + prev_file = flist->files[prev_ndx - flist->ndx_start]; /* Is the previous link not complete yet? */ if (!(prev_file->flags & FLAG_HLINK_DONE)) { @@ -294,8 +330,8 @@ int hard_link_check(struct file_struct *file, int ndx, const char *fname, /* There is a finished file to link with! */ if (!(prev_file->flags & FLAG_HLINK_FIRST)) { /* The previous previous is FIRST when prev is not. */ - prev_ndx = F_HL_PREV(prev_file); - prev_name = realname = check_prior(prev_ndx, gnum, &flist); + prev_name = realname = check_prior(prev_file, gnum, &prev_ndx, &flist); + assert(prev_name != NULL || flist != NULL); /* Update our previous pointer to point to the FIRST. */ F_HL_PREV(file) = prev_ndx; } @@ -332,6 +368,9 @@ int hard_link_check(struct file_struct *file, int ndx, const char *fname, int j = 0; #ifdef SUPPORT_ACLS alt_sx.acc_acl = alt_sx.def_acl = NULL; +#endif +#ifdef SUPPORT_XATTRS + alt_sx.xattr = NULL; #endif do { pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname); @@ -361,19 +400,37 @@ int hard_link_check(struct file_struct *file, int ndx, const char *fname, sxp->st = alt_sx.st; #ifdef SUPPORT_ACLS if (preserve_acls && !S_ISLNK(file->mode)) { - if (!ACL_READY(*sxp)) + free_acl(sxp); + if (!ACL_READY(alt_sx)) get_acl(cmpbuf, sxp); else { sxp->acc_acl = alt_sx.acc_acl; sxp->def_acl = alt_sx.def_acl; + alt_sx.acc_acl = alt_sx.def_acl = NULL; } } #endif - } +#ifdef SUPPORT_XATTRS + if (preserve_xattrs) { + free_xattr(sxp); + if (!XATTR_READY(alt_sx)) + get_xattr(cmpbuf, sxp); + else { + sxp->xattr = alt_sx.xattr; + alt_sx.xattr = NULL; + } + } +#endif + } else { #ifdef SUPPORT_ACLS - else if (preserve_acls) - free_acl(&alt_sx); + if (preserve_acls) + free_acl(&alt_sx); +#endif +#ifdef SUPPORT_XATTRS + if (preserve_xattrs) + free_xattr(&alt_sx); #endif + } } if (maybe_hard_link(file, ndx, fname, statret, sxp, prev_name, &prev_st, @@ -413,7 +470,7 @@ void finish_hard_link(struct file_struct *file, const char *fname, int fin_ndx, { stat_x prev_sx; STRUCT_STAT st; - char alt_name[MAXPATHLEN], *prev_name; + char prev_name[MAXPATHLEN], alt_name[MAXPATHLEN]; const char *our_name; struct file_list *flist; int prev_statret, ndx, prev_ndx = F_HL_PREV(file); @@ -440,23 +497,28 @@ void finish_hard_link(struct file_struct *file, const char *fname, int fin_ndx, #ifdef SUPPORT_ACLS prev_sx.acc_acl = prev_sx.def_acl = NULL; #endif +#ifdef SUPPORT_XATTRS + prev_sx.xattr = NULL; +#endif while ((ndx = prev_ndx) >= 0) { int val; - flist = flist_for_ndx(ndx); - assert(flist != NULL); + flist = flist_for_ndx(ndx, "finish_hard_link"); file = flist->files[ndx - flist->ndx_start]; file->flags = (file->flags & ~FLAG_HLINK_FIRST) | FLAG_HLINK_DONE; prev_ndx = F_HL_PREV(file); F_HL_PREV(file) = fin_ndx; - prev_name = f_name(file, NULL); - prev_statret = link_stat(prev_name, &prev_sx.st, 0); + prev_statret = link_stat(f_name(file, prev_name), &prev_sx.st, 0); val = maybe_hard_link(file, ndx, prev_name, prev_statret, &prev_sx, our_name, stp, fname, itemizing, code); flist->in_progress--; #ifdef SUPPORT_ACLS if (preserve_acls) free_acl(&prev_sx); +#endif +#ifdef SUPPORT_XATTRS + if (preserve_xattrs) + free_xattr(&prev_sx); #endif if (val < 0) continue; @@ -474,4 +536,25 @@ void finish_hard_link(struct file_struct *file, const char *fname, int fin_ndx, out_of_memory("finish_hard_link"); } } + +int skip_hard_link(struct file_struct *file, struct file_list **flist_p) +{ + struct file_list *flist; + int prev_ndx; + + file->flags |= FLAG_SKIP_HLINK; + if (!(file->flags & FLAG_HLINK_LAST)) + return -1; + + check_prior(file, F_HL_GNUM(file), &prev_ndx, &flist); + if (prev_ndx >= 0) { + file = flist->files[prev_ndx - flist->ndx_start]; + if (file->flags & (FLAG_HLINK_DONE|FLAG_FILE_SENT)) + return -1; + file->flags |= FLAG_HLINK_LAST; + *flist_p = flist; + } + + return prev_ndx; +} #endif