X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/bceec82f357618356fd209578dfccbbd6b52efba..0f9c48b1d23fbe958544094e97ba8ad2a7d8b8f4:/generator.c diff --git a/generator.c b/generator.c index da2feac1..888835f8 100644 --- a/generator.c +++ b/generator.c @@ -144,9 +144,7 @@ static BOOL disable_deltas_p(void) assert(whole_file == 0 || whole_file == 1); - /* OK, we don't explicitly handle both whole_file and - * no_whole_file; perhaps somebody will care to add an - * error. */ + /* whole_file and no_whole_file are never both on at the same time */ if (whole_file) return True; @@ -219,15 +217,15 @@ static struct sum_struct *generate_sums(struct map_struct *buf,OFF_T len,int n) -/* - * Acts on file number I from FLIST, whose name is fname. +/** + * Acts on file number @p i from @p flist, whose name is @p fname. * * First fixes up permissions, then generates checksums for the file. * - * (This comment was added later by mbp who was trying to work it out; - * it might be wrong.) - */ -void recv_generator(char *fname,struct file_list *flist,int i,int f_out) + * @note This comment was added later by mbp who was trying to work it + * out. It might be wrong. + **/ +void recv_generator(char *fname, struct file_list *flist, int i, int f_out) { int fd; STRUCT_STAT st; @@ -241,6 +239,7 @@ void recv_generator(char *fname,struct file_list *flist,int i,int f_out) extern int list_only; extern int preserve_perms; extern int only_existing; + extern int orig_umask; if (list_only) return; @@ -283,7 +282,7 @@ void recv_generator(char *fname,struct file_list *flist,int i,int f_out) } if (statret != 0 && do_mkdir(fname,file->mode) != 0 && errno != EEXIST) { if (!(relative_paths && errno==ENOENT && - create_directory_path(fname)==0 && + create_directory_path(fname, orig_umask)==0 && do_mkdir(fname,file->mode)==0)) { rprintf(FERROR, RSYNC_NAME ": recv_generator: mkdir \"%s\": %s (2)\n", fname,strerror(errno)); @@ -364,7 +363,7 @@ void recv_generator(char *fname,struct file_list *flist,int i,int f_out) if (preserve_hard_links && check_hard_link(file)) { if (verbose > 1) - rprintf(FINFO, "\"%s\" is a hard link\n",f_name(file)); + rprintf(FINFO, "recv_generator: \"%s\" is a hard link\n",f_name(file)); return; } @@ -486,6 +485,13 @@ void generate_files(int f,struct file_list *flist,char *local_name,int f_recv) rprintf(FINFO,"generator starting pid=%d count=%d\n", (int)getpid(),flist->count); + if (verbose >= 2) { + rprintf(FINFO, + disable_deltas_p() + ? "delta-transmission disabled for local transfer or --whole-file\n" + : "delta transmission enabled\n"); + } + /* we expect to just sit around now, so don't exit on a timeout. If we really get a timeout then the other process should exit */