X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/b31c92edcc11995daa5c90ec280010a1e2c5b64d..0417c34e2d641cbac292ba5cf8a619249c87d4e3:/socket.c diff --git a/socket.c b/socket.c index c6341ced..279b24e2 100644 --- a/socket.c +++ b/socket.c @@ -127,7 +127,7 @@ static int establish_proxy_connection(int fd, char *host, int port, * if this fails. **/ int try_bind_local(int s, int ai_family, int ai_socktype, - const char *bind_address) + const char *bind_addr) { int error; struct addrinfo bhints, *bres_all, *r; @@ -136,9 +136,9 @@ int try_bind_local(int s, int ai_family, int ai_socktype, bhints.ai_family = ai_family; bhints.ai_socktype = ai_socktype; bhints.ai_flags = AI_PASSIVE; - if ((error = getaddrinfo(bind_address, NULL, &bhints, &bres_all))) { + if ((error = getaddrinfo(bind_addr, NULL, &bhints, &bres_all))) { rprintf(FERROR, RSYNC_NAME ": getaddrinfo %s: %s\n", - bind_address, gai_strerror(error)); + bind_addr, gai_strerror(error)); return -1; } @@ -172,12 +172,12 @@ int try_bind_local(int s, int ai_family, int ai_socktype, * reachable, perhaps because we can't e.g. route ipv6 to that network * but we can get ip4 packets through. * - * @param bind_address Local address to use. Normally NULL to bind + * @param bind_addr Local address to use. Normally NULL to bind * the wildcard address. * * @param af_hint Address family, e.g. AF_INET or AF_INET6. **/ -int open_socket_out(char *host, int port, const char *bind_address, +int open_socket_out(char *host, int port, const char *bind_addr, int af_hint) { int type = SOCK_STREAM; @@ -253,9 +253,9 @@ int open_socket_out(char *host, int port, const char *bind_address, if (s < 0) continue; - if (bind_address + if (bind_addr && try_bind_local(s, res->ai_family, type, - bind_address) == -1) { + bind_addr) == -1) { close(s); s = -1; continue; @@ -293,9 +293,9 @@ int open_socket_out(char *host, int port, const char *bind_address, * * This is based on the Samba LIBSMB_PROG feature. * - * @param bind_address Local address to use. Normally NULL to get the stack default. + * @param bind_addr Local address to use. Normally NULL to get the stack default. **/ -int open_socket_out_wrapped(char *host, int port, const char *bind_address, +int open_socket_out_wrapped(char *host, int port, const char *bind_addr, int af_hint) { char *prog = getenv("RSYNC_CONNECT_PROG"); @@ -307,7 +307,7 @@ int open_socket_out_wrapped(char *host, int port, const char *bind_address, } if (prog) return sock_exec(prog); - return open_socket_out(host, port, bind_address, af_hint); + return open_socket_out(host, port, bind_addr, af_hint); } @@ -322,10 +322,10 @@ int open_socket_out_wrapped(char *host, int port, const char *bind_address, * We return an array of file-descriptors to the sockets, with a trailing * -1 value to indicate the end of the list. * - * @param bind_address Local address to bind, or NULL to allow it to + * @param bind_addr Local address to bind, or NULL to allow it to * default. **/ -static int *open_socket_in(int type, int port, const char *bind_address, +static int *open_socket_in(int type, int port, const char *bind_addr, int af_hint) { int one = 1; @@ -339,10 +339,10 @@ static int *open_socket_in(int type, int port, const char *bind_address, hints.ai_socktype = type; hints.ai_flags = AI_PASSIVE; snprintf(portbuf, sizeof portbuf, "%d", port); - error = getaddrinfo(bind_address, portbuf, &hints, &all_ai); + error = getaddrinfo(bind_addr, portbuf, &hints, &all_ai); if (error) { rprintf(FERROR, RSYNC_NAME ": getaddrinfo: bind address %s: %s\n", - bind_address, gai_strerror(error)); + bind_addr, gai_strerror(error)); return NULL; } @@ -478,7 +478,7 @@ void start_accept_loop(int port, int (*fn)(int, int)) /* close log file before the potentially very long select so * file can be trimmed by another process instead of growing * forever */ - log_close(); + logfile_close(); #ifdef FD_COPY FD_COPY(&deffds, &fds); @@ -507,8 +507,8 @@ void start_accept_loop(int port, int (*fn)(int, int)) for (i = 0; sp[i] >= 0; i++) close(sp[i]); /* Re-open log file in child before possibly giving - * up privileges (see log_close() above). */ - log_open(); + * up privileges (see logfile_close() above). */ + logfile_reopen(); ret = fn(fd, fd); close_all(); _exit(ret);