X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/b24498ec2c76807e7cdc201216991d4def5b293a..01d124d9e251317cdd9f12fb170a94e65f3c5e18:/main.c

diff --git a/main.c b/main.c
index 1c71d157..e94dd3f8 100644
--- a/main.c
+++ b/main.c
@@ -50,6 +50,7 @@ extern int protocol_version;
 extern int recurse;
 extern int relative_paths;
 extern int sanitize_paths;
+extern int curr_dir_depth;
 extern int module_id;
 extern int rsync_port;
 extern int whole_file;
@@ -61,13 +62,14 @@ extern int filesfrom_fd;
 extern pid_t cleanup_child_pid;
 extern struct stats stats;
 extern char *filesfrom_host;
+extern char *partial_dir;
 extern char *basis_dir[];
 extern char *rsync_path;
 extern char *shell_cmd;
 extern char *batch_name;
+extern struct filter_list_struct server_filter_list;
 
 int local_server = 0;
-int startdir_depth = 0;
 mode_t orig_umask = 0;
 struct file_list *the_file_list;
 
@@ -471,17 +473,19 @@ static char *get_local_name(struct file_list *flist, char *dest_path)
 	 * it and use mode 1.  If there is something other than a directory
 	 * at the destination path, we must be transferring one file
 	 * (anything at the destination will be overwritten). */
-	if (do_stat(dest_path, &st) == 0) {
+	if (safe_stat(dest_path, &st) == 0) {
 		if (S_ISDIR(st.st_mode)) {
+			if (sanitize_paths)
+				die_on_unsafe_path(dest_path, 0);
 			if (!push_dir(dest_path)) {
 				rsyserr(FERROR, errno, "push_dir#1 %s failed",
 					full_fname(dest_path));
 				exit_cleanup(RERR_FILESELECT);
 			}
-			if (sanitize_paths)
-				startdir_depth = count_dir_elements(dest_path);
 			return NULL;
 		}
+		if (sanitize_paths && S_ISLNK(st.st_mode))
+			die_on_unsafe_path(dest_path, 0);
 		if (flist->count > 1) {
 			rprintf(FERROR,
 				"ERROR: destination must be a directory when"
@@ -527,13 +531,13 @@ static char *get_local_name(struct file_list *flist, char *dest_path)
 			return NULL;
 		}
 
+		if (sanitize_paths)
+			die_on_unsafe_path(dest_path, 0);
 		if (!push_dir(dest_path)) {
 			rsyserr(FERROR, errno, "push_dir#2 %s failed",
 				full_fname(dest_path));
 			exit_cleanup(RERR_FILESELECT);
 		}
-		if (sanitize_paths)
-			startdir_depth = count_dir_elements(dest_path);
 
 		return NULL;
 	}
@@ -549,13 +553,13 @@ static char *get_local_name(struct file_list *flist, char *dest_path)
 		dest_path = "/";
 
 	*cp = '\0';
+	if (sanitize_paths)
+		die_on_unsafe_path(dest_path, 0);
 	if (!push_dir(dest_path)) {
 		rsyserr(FERROR, errno, "push_dir#3 %s failed",
 			full_fname(dest_path));
 		exit_cleanup(RERR_FILESELECT);
 	}
-	if (sanitize_paths)
-		startdir_depth = count_dir_elements(dest_path);
 	*cp = '/';
 
 	return cp + 1;
@@ -608,10 +612,14 @@ static void do_server_sender(int f_in, int f_out, int argc, char *argv[])
 		return;
 	}
 
-	if (!relative_paths && !push_dir(dir)) {
-		rsyserr(FERROR, errno, "push_dir#3 %s failed",
-			full_fname(dir));
-		exit_cleanup(RERR_FILESELECT);
+	if (!relative_paths) {
+		if (sanitize_paths)
+			die_on_unsafe_path(dir, 0);
+		if (!push_dir(dir)) {
+			rsyserr(FERROR, errno, "push_dir#3 %s failed",
+				full_fname(dir));
+			exit_cleanup(RERR_FILESELECT);
+		}
 	}
 	argc--;
 	argv++;
@@ -799,8 +807,32 @@ static void do_server_recv(int f_in, int f_out, int argc,char *argv[])
 	 * we can sanitize the --link-/copy-/compare-dest args correctly. */
 	if (sanitize_paths) {
 		char **dir;
-		for (dir = basis_dir; *dir; dir++)
-			*dir = sanitize_path(NULL, *dir, NULL, startdir_depth);
+		for (dir = basis_dir; *dir; dir++) {
+			*dir = sanitize_path(NULL, *dir, NULL, curr_dir_depth, NULL);
+			die_on_unsafe_path(*dir, 0);
+		}
+		if (partial_dir) {
+			partial_dir = sanitize_path(NULL, partial_dir, NULL, curr_dir_depth, NULL);
+			/* A relative path gets this checked at every dir change. */
+			if (*partial_dir == '/')
+				die_on_unsafe_path(partial_dir, 0);
+		}
+	}
+	if (server_filter_list.head) {
+		char **dir;
+		struct filter_list_struct *elp = &server_filter_list;
+
+		for (dir = basis_dir; *dir; dir++) {
+			if (check_filter(elp, *dir, 1) < 0)
+				goto options_rejected;
+		}
+		if (partial_dir && *partial_dir == '/'
+		 && check_filter(elp, partial_dir, 1) < 0) {
+		    options_rejected:
+			rprintf(FERROR,
+				"Your options have been rejected by the server.\n");
+			exit_cleanup(RERR_SYNTAX);
+		}
 	}
 
 	exit_code = do_recv(f_in,f_out,flist,local_name);