X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/a41a1e87182410ec6c2eeaddb0cd961ec554c404..82471e68a8bb3da8ca95f2b6564c330c52ce891e:/rsync.c

diff --git a/rsync.c b/rsync.c
index 8ee09c7c..576ce63f 100644
--- a/rsync.c
+++ b/rsync.c
@@ -25,6 +25,7 @@
 extern int verbose;
 extern int dry_run;
 extern int preserve_times;
+extern int omit_dir_times;
 extern int am_root;
 extern int am_sender;
 extern int am_generator;
@@ -52,34 +53,42 @@ void free_sums(struct sum_struct *s)
  * delete a file or directory. If force_delete is set then delete
  * recursively
  */
-int delete_file(char *fname)
+int delete_file(char *fname, int flags)
 {
 	DIR *d;
 	struct dirent *di;
 	char buf[MAXPATHLEN];
 	STRUCT_STAT st;
-	int ret;
+	int zap_dir;
 
-#if SUPPORT_LINKS
-	ret = do_lstat(fname, &st);
-#else
-	ret = do_stat(fname, &st);
-#endif
-	if (ret)
-		return -1;
-
-	if (!S_ISDIR(st.st_mode)) {
-		if (robust_unlink(fname) == 0 || errno == ENOENT)
+	if (!(flags & DEL_DIR)) {
+		if (robust_unlink(fname) == 0) {
+			if (verbose && !(flags & DEL_TERSE)) {
+				rprintf(FINFO, "deleting %s\n",
+					safe_fname(fname));
+			}
+			return 0;
+		}
+		if (errno == ENOENT)
 			return 0;
 		rsyserr(FERROR, errno, "delete_file: unlink %s failed",
 			full_fname(fname));
 		return -1;
 	}
 
-	if (do_rmdir(fname) == 0 || errno == ENOENT)
+	zap_dir = flags & DEL_RECURSE || (force_delete && recurse);
+	if (dry_run && zap_dir)
+		errno = ENOTEMPTY;
+	else if (do_rmdir(fname) == 0) {
+		if (verbose && !(flags & DEL_TERSE)) {
+			rprintf(FINFO, "deleting %s/\n",
+				safe_fname(fname));
+		}
+		return 0;
+	}
+	if (errno == ENOENT)
 		return 0;
-	if (!force_delete || !recurse
-	    || (errno != ENOTEMPTY && errno != EEXIST)) {
+	if (!zap_dir || (errno != ENOTEMPTY && errno != EEXIST)) {
 		rsyserr(FERROR, errno, "delete_file: rmdir %s failed",
 			full_fname(fname));
 		return -1;
@@ -92,15 +101,30 @@ int delete_file(char *fname)
 		return -1;
 	}
 
+	if (!(flags & DEL_TERSE)) {
+		if (verbose)
+			rprintf(FINFO, "deleting %s/\n", safe_fname(fname));
+		flags |= DEL_TERSE;
+	}
+
 	for (errno = 0, di = readdir(d); di; errno = 0, di = readdir(d)) {
 		char *dname = d_name(di);
 		if (dname[0] == '.' && (dname[1] == '\0'
 		    || (dname[1] == '.' && dname[2] == '\0')))
 			continue;
 		pathjoin(buf, sizeof buf, fname, dname);
-		if (verbose > 0)
-			rprintf(FINFO, "deleting %s\n", safe_fname(buf));
-		if (delete_file(buf) != 0) {
+
+		if (do_lstat(buf, &st) < 0)
+			continue;
+		if (S_ISDIR(st.st_mode))
+			flags |= DEL_DIR;
+		else
+			flags &= ~DEL_DIR;
+
+		if (verbose)
+			rprintf(FINFO, "deleting %s%s\n", safe_fname(buf),
+				flags & DEL_DIR ? "/" : "");
+		if (delete_file(buf, flags) != 0) {
 			closedir(d);
 			return -1;
 		}
@@ -114,7 +138,7 @@ int delete_file(char *fname)
 
 	closedir(d);
 
-	if (do_rmdir(fname) != 0) {
+	if (do_rmdir(fname) != 0 && errno != ENOENT) {
 		rsyserr(FERROR, errno, "delete_file: rmdir %s failed",
 			full_fname(fname));
 		return -1;
@@ -130,10 +154,9 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 	STRUCT_STAT st2;
 	int change_uid, change_gid;
 
-	if (dry_run)
-		return 0;
-
 	if (!st) {
+		if (dry_run)
+			return 1;
 		if (link_stat(fname, &st2, 0) < 0) {
 			rsyserr(FERROR, errno, "stat %s failed",
 				full_fname(fname));
@@ -143,14 +166,12 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 	}
 
 	if (!preserve_times || S_ISLNK(st->st_mode)
-	    || (make_backups && !backup_dir && S_ISDIR(st->st_mode)))
+	 || (S_ISDIR(st->st_mode)
+	  && (omit_dir_times || (make_backups && !backup_dir))))
 		flags |= PERMS_SKIP_MTIME;
 	if (!(flags & PERMS_SKIP_MTIME)
 	    && cmp_modtime(st->st_mtime, file->modtime) != 0) {
-		/* don't complain about not setting times on directories
-		 * because some filesystems can't do it */
-		if (set_modtime(fname,file->modtime) != 0 &&
-		    !S_ISDIR(st->st_mode)) {
+		if (set_modtime(fname,file->modtime) != 0) {
 			rsyserr(FERROR, errno, "failed to set times on %s",
 				full_fname(fname));
 			return 0;
@@ -161,7 +182,7 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 	change_uid = am_root && preserve_uid && st->st_uid != file->uid;
 	change_gid = preserve_gid && file->gid != GID_NONE
 		&& st->st_gid != file->gid;
-#if !HAVE_LCHOWN
+#if !HAVE_LCHOWN && !CHOWN_MODIFIES_SYMLINK
 	if (S_ISLNK(st->st_mode))
 		;
 	else
@@ -190,8 +211,8 @@ int set_perms(char *fname,struct file_struct *file,STRUCT_STAT *st,
 			return 0;
 		}
 		/* a lchown had been done - we have to re-stat if the
-                 * destination had the setuid or setgid bits set due
-                 * to the side effect of the chown call */
+		 * destination had the setuid or setgid bits set due
+		 * to the side effect of the chown call */
 		if (st->st_mode & (S_ISUID | S_ISGID)) {
 			link_stat(fname, st,
 				  keep_dirlinks && S_ISDIR(st->st_mode));
@@ -240,7 +261,7 @@ void sig_int(void)
 /* finish off a file transfer, renaming the file and setting the permissions
    and ownership */
 void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
-		     int ok_to_set_time)
+		     int ok_to_set_time, int overwriting_basis)
 {
 	int ret;
 
@@ -250,7 +271,7 @@ void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
 		goto do_set_perms;
 	}
 
-	if (make_backups && !make_backup(fname))
+	if (make_backups && overwriting_basis && !make_backup(fname))
 		return;
 
 	/* Change permissions before putting the file into place. */