X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/7a6421fa764dd0f609e2a5024ec8b3bc577575a1..ff8b29b8c62f377ede40fbf0cbbaa428bd8df60a:/clientserver.c

diff --git a/clientserver.c b/clientserver.c
index 38bb171d..71188e97 100644
--- a/clientserver.c
+++ b/clientserver.c
@@ -96,13 +96,35 @@ static int rsync_module(int fd, int i)
 	char *argv[MAX_ARGS];
 	char **argp;
 	char line[1024];
+	uid_t uid;
+	gid_t gid;
+	char *p;
+
+	rprintf(FINFO,"rsync on module %s from %s (%s)\n",
+		lp_name(i), client_name(fd), client_addr(fd));
 
 	module_id = i;
 
 	if (lp_read_only(i))
 		read_only = 1;
 
-	rprintf(FERROR,"rsyncd starting\n");
+	p = lp_uid(i);
+	if (!name_to_uid(p, &uid)) {
+		if (!isdigit(*p)) {
+			rprintf(FERROR,"Invalid uid %s\n", p);
+			return -1;
+		} 
+		uid = atoi(p);
+	}
+
+	p = lp_gid(i);
+	if (!name_to_gid(p, &gid)) {
+		if (!isdigit(*p)) {
+			rprintf(FERROR,"Invalid gid %s\n", p);
+			return -1;
+		} 
+		gid = atoi(p);
+	}
 
 	if (chroot(lp_path(i))) {
 		io_printf(fd,"@ERROR: chroot failed\n");
@@ -114,12 +136,12 @@ static int rsync_module(int fd, int i)
 		return -1;
 	}
 
-	if (setgid(lp_gid(i))) {
+	if (setgid(gid)) {
 		io_printf(fd,"@ERROR: setgid failed\n");
 		return -1;
 	}
 
-	if (setuid(lp_uid(i))) {
+	if (setuid(uid)) {
 		io_printf(fd,"@ERROR: setuid failed\n");
 		return -1;
 	}
@@ -180,6 +202,7 @@ static int start_daemon(int fd)
 	char line[200];
 	char *motd;
 	int version;
+	int i = -1;
 
 	set_socket_options(fd,"SO_KEEPALIVE");
 
@@ -207,8 +230,7 @@ static int start_daemon(int fd)
 		io_printf(fd,"\n");
 	}
 
-	while (1) {
-		int i;
+	while (i == -1) {
 
 		line[0] = 0;
 		if (!read_line(fd, line, sizeof(line)-1)) {
@@ -231,11 +253,9 @@ static int start_daemon(int fd)
 			io_printf(fd,"ERROR: Unknown module '%s'\n", line);
 			return -1;
 		}
-
-		return rsync_module(fd, i);
 	}
 
-	return 0;
+	return rsync_module(fd, i);
 }
 
 
@@ -254,6 +274,7 @@ int daemon_main(void)
 
 	become_daemon();
 
-	return start_accept_loop(rsync_port, start_daemon);
+	start_accept_loop(rsync_port, start_daemon);
+	return -1;
 }