X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/782d1091213df611767787a88365c32427afe9ec..f7d6dce6c8be8f1afd15815c6b59896624eb965d:/support/cull_options

diff --git a/support/cull_options b/support/cull_options
index 3215e89d..07a57021 100755
--- a/support/cull_options
+++ b/support/cull_options
@@ -3,10 +3,8 @@
 # that the code in options.c might send to the server.  This perl code
 # is included in the rrsync script.
 use strict;
-no strict 'refs';
 
-our(%short_no_arg, %short_with_num);
-our(%long_no_arg, %long_before_arg, %long_with_arg);
+our(%short_no_arg, %short_with_num, %long_opt);
 our $last_long_opt;
 
 open(IN, '../options.c') or die "Unable to open ../options.c: $!\n";
@@ -20,39 +18,47 @@ while (<IN>) {
 	undef $last_long_opt;
     } elsif (/\Qargs[ac++]\E = "--([^"=]+)"/) {
 	$last_long_opt = $1;
-	$long_no_arg{$1} = 1;
+	$long_opt{$1} = 0;
     } elsif (defined($last_long_opt)
 	&& /\Qargs[ac++]\E = ([^["\s]+);/ && $1 ne 'dest_option') {
-	delete $long_no_arg{$last_long_opt};
-	$long_before_arg{$last_long_opt} = 1;
+	$long_opt{$last_long_opt} = 2;
 	undef $last_long_opt;
-    } elsif (/dest_option = "--([^"])"/) {
-	$long_before_arg{$1} = 1;
+    } elsif (/dest_option = "--([^"]+)"/) {
+	$long_opt{$1} = 2;
 	undef $last_long_opt;
     } elsif (/\Qasprintf(\E[^,]+, "--([^"=]+)=/ || /\Qargs[ac++]\E = "--([^"=]+)=/) {
-	$long_with_arg{$1} = 1;
+	$long_opt{$1} = 1;
 	undef $last_long_opt;
     }
 }
 close IN;
 
-print "our \$short_no_arg = '", sort(keys %short_no_arg), "';\n",
-    "our \$short_with_num = '", sort(keys %short_with_num), "';\n",
-    "# To disable a short-named option, add its letter to this string:\n",
-    "our \$short_disabled = '';\n",
-    "# To disable a long-named option, change its value to a 0.  A value of -1\n",
-    "# means the arg doesn't need checking, a 2 means only check when receiving.\n";
-
-foreach my $name (qw( long_no_arg long_with_arg long_before_arg )) {
-    $_ = "our \%$name = (\n  '" . join("' => 1,\n  '", sort keys %$name) . "' => 1,\n);\n";
-    if ($name eq 'long_before_arg') {
-	s/ 1,/ 2,/g;
-	s/('files-from' =>) 2,/$1 1,/;
-	s/('max-.* =>) 2,/$1 -1,/g;
-    } else {
-	s/ 1,/ -1,/g;
-	s/('files-from' =>) -1,/$1 1,/;
-    }
-    s/('remove-.* =>) (-?\d),/$1 \$ro ? 0 : $2,/g;
-    print;
+my $short_no_arg = join('', sort keys %short_no_arg);
+my $short_with_num = join('', sort keys %short_with_num);
+
+print <<EOT;
+
+# These options are the only options that rsync might send to the server,
+# and only in the option format that the stock rsync produces.
+
+# To disable a short-named option, add its letter to this string:
+our \$short_disabled = '';
+
+our \$short_no_arg = '$short_no_arg'; # DO NOT REMOVE ANY
+our \$short_with_num = '$short_with_num'; # DO NOT REMOVE ANY
+
+# To disable a long-named option, change its value to a -1.  The values mean:
+# 0 = the option has no arg; 1 = the arg doesn't need any checking; 2 = only
+# check the arg when receiving; and 3 = always check the arg.
+our \%long_opt = (
+EOT
+
+foreach my $opt (sort keys %long_opt) {
+    my $val = $long_opt{$opt};
+    $val = 1 if $opt =~ /^(max-|min-)/;
+    $val = 3 if $opt eq 'files-from';
+    $val = '$ro ? -1 : ' . $val if $opt =~ /^remove-/;
+    print "  '$opt' => $val,\n";
 }
+
+print ");\n\n";