X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/75ea8459043e6df7a6c652baa9216f946c4087b8..5692657757a6c0e3ba60320719ef51af6f78c909:/io.c

diff --git a/io.c b/io.c
index 7cc4d62a..413557a8 100644
--- a/io.c
+++ b/io.c
@@ -541,8 +541,8 @@ static char *perform_io(size_t needed, int flags)
 		if (DEBUG_GTE(IO, 3)) {
 			rprintf(FINFO, "[%s] perform_io(%ld, outroom) needs to flush %ld\n",
 				who_am_i(), (long)needed,
-				iobuf.out.len > iobuf.out.size - needed
-				? (long)iobuf.out.len - (iobuf.out.size - needed) : 0L);
+				iobuf.out.len + needed > iobuf.out.size
+				? (long)(iobuf.out.len + needed - iobuf.out.size) : 0L);
 		}
 		break;
 
@@ -557,8 +557,8 @@ static char *perform_io(size_t needed, int flags)
 		if (DEBUG_GTE(IO, 3)) {
 			rprintf(FINFO, "[%s] perform_io(%ld, msgroom) needs to flush %ld\n",
 				who_am_i(), (long)needed,
-				iobuf.out.len > iobuf.msg.size - needed
-				? (long)iobuf.out.len - (iobuf.msg.size - needed) : 0L);
+				iobuf.msg.len + needed > iobuf.msg.size
+				? (long)(iobuf.msg.len + needed - iobuf.msg.size) : 0L);
 		}
 		break;
 
@@ -578,11 +578,13 @@ static char *perform_io(size_t needed, int flags)
 				goto double_break;
 			break;
 		case PIO_NEED_OUTROOM:
-			if (iobuf.out.len <= iobuf.out.size - needed)
+			/* Note that iobuf.out_empty_len doesn't factor into this check
+			 * because iobuf.out.len already holds any needed header len. */
+			if (iobuf.out.len + needed <= iobuf.out.size)
 				goto double_break;
 			break;
 		case PIO_NEED_MSGROOM:
-			if (iobuf.msg.len <= iobuf.msg.size - needed)
+			if (iobuf.msg.len + needed <= iobuf.msg.size)
 				goto double_break;
 			break;
 		}
@@ -612,21 +614,20 @@ static char *perform_io(size_t needed, int flags)
 			if (iobuf.raw_flushing_ends_before
 			 || (!iobuf.msg.len && iobuf.out.len > iobuf.out_empty_len && !(flags & PIO_NEED_MSGROOM))) {
 				if (OUT_MULTIPLEXED && !iobuf.raw_flushing_ends_before) {
-					size_t val;
-
 					/* The iobuf.raw_flushing_ends_before value can point off the end
 					 * of the iobuf.out buffer for a while, for easier subtracting. */
 					iobuf.raw_flushing_ends_before = iobuf.out.pos + iobuf.out.len;
 
 					SIVAL(iobuf.out.buf + iobuf.raw_data_header_pos, 0,
 					      ((MPLEX_BASE + (int)MSG_DATA)<<24) + iobuf.out.len - 4);
-					if ((val = iobuf.out.size - iobuf.raw_data_header_pos) < 4) {
+					if (iobuf.raw_data_header_pos + 4 > iobuf.out.size) {
+						int siz = (int)(iobuf.raw_data_header_pos + 4 - iobuf.out.size);
 						/* We used some of the overflow bytes, so move them. */
 						if (DEBUG_GTE(IO, 4)) {
 							rprintf(FINFO, "[%s] wrap-bytes moved: %d (perform_io)\n",
-								who_am_i(), (int)val);
+								who_am_i(), siz);
 						}
-						memcpy(iobuf.out.buf, iobuf.out.buf + iobuf.out.size, 4 - val);
+						memcpy(iobuf.out.buf, iobuf.out.buf + iobuf.out.size, siz);
 					}
 
 					if (DEBUG_GTE(IO, 1)) {
@@ -675,8 +676,7 @@ static char *perform_io(size_t needed, int flags)
 		}
 
 		if (extra_flist_sending_enabled) {
-			if (file_total - file_old_total < MAX_FILECNT_LOOKAHEAD
-			 && file_total - file_old_total >= MIN_FILECNT_LOOKAHEAD)
+			if (file_total - file_old_total < MAX_FILECNT_LOOKAHEAD)
 				tv.tv_sec = 0;
 			else {
 				extra_flist_sending_enabled = False;
@@ -881,10 +881,10 @@ int send_msg(enum msgcode code, const char *buf, size_t len, int convert)
 	SIVAL(hdr, 0, ((MPLEX_BASE + (int)code)<<24) + len);
 	/* If the header used any overflow bytes, move them to the start. */
 	if ((pos = hdr+4 - iobuf.msg.buf) > iobuf.msg.size) {
-		size_t siz = pos - iobuf.msg.size;
+		int siz = (int)(pos - iobuf.msg.size);
 		if (DEBUG_GTE(IO, 4))
-			rprintf(FINFO, "[%s] wrap-bytes moved: %d (send_msg)\n", who_am_i(), (int)siz);
-		memcpy(iobuf.msg.buf, hdr+4 - siz, siz);
+			rprintf(FINFO, "[%s] wrap-bytes moved: %d (send_msg)\n", who_am_i(), siz);
+		memcpy(iobuf.msg.buf, iobuf.msg.buf + iobuf.msg.size, siz);
 	}
 
 	if (want_debug && convert > 0)
@@ -1314,9 +1314,10 @@ static void read_a_msg(void)
 		if (msg_bytes != 4 || am_sender)
 			goto invalid_msg;
 		data = perform_io(4, PIO_INPUT_AND_CONSUME);
-		io_error |= IVAL(data, 0);
+		val = IVAL(data, 0);
+		io_error |= val;
 		if (!am_generator)
-			send_msg(MSG_IO_ERROR, data, 4, 0);
+			send_msg_int(MSG_IO_ERROR, val);
 		break;
 	case MSG_IO_TIMEOUT:
 		if (msg_bytes != 4 || am_server || am_generator)
@@ -1393,19 +1394,21 @@ static void read_a_msg(void)
 			exit_cleanup(RERR_STREAMIO);
 		}
 		data = perform_io(4, PIO_INPUT_AND_CONSUME);
+		val = IVAL(data, 0);
 		if (am_generator)
-			got_flist_entry_status(FES_SUCCESS, IVAL(data, 0));
+			got_flist_entry_status(FES_SUCCESS, val);
 		else
-			successful_send(IVAL(data, 0));
+			successful_send(val);
 		break;
 	case MSG_NO_SEND:
 		if (msg_bytes != 4)
 			goto invalid_msg;
 		data = perform_io(4, PIO_INPUT_AND_CONSUME);
+		val = IVAL(data, 0);
 		if (am_generator)
-			got_flist_entry_status(FES_NO_SEND, IVAL(data, 0));
+			got_flist_entry_status(FES_NO_SEND, val);
 		else
-			send_msg(MSG_NO_SEND, data, 4, 0);
+			send_msg_int(MSG_NO_SEND, val);
 		break;
 	case MSG_ERROR_SOCKET:
 	case MSG_ERROR_UTF8: