X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/71903f601a37392eb8ecb737c10fac78d18f5777..9aacb4df0e29b11e298d7353467d821e4a17cc12:/flist.c diff --git a/flist.c b/flist.c index de27934a..11473dc0 100644 --- a/flist.c +++ b/flist.c @@ -27,28 +27,21 @@ #include "rsync.h" -extern struct stats stats; - extern int verbose; -extern int do_progress; +extern int dry_run; +extern int list_only; extern int am_root; extern int am_server; extern int am_daemon; extern int am_sender; -extern int delete_during; +extern int do_progress; extern int always_checksum; extern int module_id; extern int ignore_errors; extern int numeric_ids; - extern int recurse; extern int xfer_dirs; -extern char curr_dir[MAXPATHLEN]; -extern unsigned int curr_dir_len; -extern char *backup_dir; -extern char *backup_suffix; extern int filesfrom_fd; - extern int one_file_system; extern int keep_dirlinks; extern int preserve_links; @@ -59,31 +52,29 @@ extern int preserve_uid; extern int preserve_gid; extern int relative_paths; extern int implied_dirs; -extern int make_backups; -extern int backup_suffix_len; extern int copy_links; extern int copy_unsafe_links; extern int protocol_version; extern int sanitize_paths; -extern int delete_excluded; -extern int max_delete; extern int orig_umask; -extern int list_only; +extern struct stats stats; +extern struct file_list *the_file_list; + +extern char curr_dir[MAXPATHLEN]; extern struct filter_list_struct filter_list; extern struct filter_list_struct server_filter_list; int io_error; +dev_t filesystem_dev; /* used to implement -x */ static char empty_sum[MD4_SUM_LENGTH]; +static int flist_count_offset; static unsigned int file_struct_len; -static struct file_list *received_flist; -static dev_t filesystem_dev; /* used to implement -x */ -static int deletion_count = 0; /* used to implement --max-delete */ +static struct file_list *sorting_flist; -static int flist_find(struct file_list *flist, struct file_struct *f); static void clean_flist(struct file_list *flist, int strip_root, int no_dups); -static void output_flist(struct file_list *flist, const char *whose_list); +static void output_flist(struct file_list *flist); void init_flist(void) { @@ -93,7 +84,6 @@ void init_flist(void) file_struct_len = offsetof(struct file_struct, flags) + sizeof f.flags; } - static int show_filelist_p(void) { return verbose && xfer_dirs && !am_server; @@ -107,20 +97,17 @@ static void start_filelist_progress(char *kind) rflush(FINFO); } - -static void emit_filelist_progress(const struct file_list *flist) +static void emit_filelist_progress(int count) { - rprintf(FINFO, " %d files...\r", flist->count); + rprintf(FINFO, " %d files...\r", count); } - -static void maybe_emit_filelist_progress(const struct file_list *flist) +static void maybe_emit_filelist_progress(int count) { - if (do_progress && show_filelist_p() && (flist->count % 100) == 0) - emit_filelist_progress(flist); + if (do_progress && show_filelist_p() && (count % 100) == 0) + emit_filelist_progress(count); } - static void finish_filelist_progress(const struct file_list *flist) { if (do_progress) { @@ -136,7 +123,6 @@ void show_flist_stats(void) /* Nothing yet */ } - static void list_file_entry(struct file_struct *f) { char perms[11]; @@ -148,7 +134,7 @@ static void list_file_entry(struct file_struct *f) permstring(perms, f->mode); -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (preserve_links && S_ISLNK(f->mode)) { rprintf(FINFO, "%s %11.0f %s %s -> %s\n", perms, @@ -164,7 +150,6 @@ static void list_file_entry(struct file_struct *f) } } - /** * Stat either a symlink or its referent, depending on the settings of * copy_links, copy_unsafe_links, etc. @@ -181,7 +166,7 @@ static void list_file_entry(struct file_struct *f) **/ static int readlink_stat(const char *path, STRUCT_STAT *buffer, char *linkbuf) { -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (copy_links) return do_stat(path, buffer); if (link_stat(path, buffer, 0) < 0) @@ -207,7 +192,7 @@ static int readlink_stat(const char *path, STRUCT_STAT *buffer, char *linkbuf) int link_stat(const char *path, STRUCT_STAT *buffer, int follow_dirlinks) { -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (copy_links) return do_stat(path, buffer); if (do_lstat(path, buffer) < 0) @@ -256,7 +241,7 @@ static int is_excluded(char *fname, int is_dir, int filter_level) static int to_wire_mode(mode_t mode) { -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (S_ISLNK(mode) && (_S_IFLNK != 0120000)) return (mode & ~(_S_IFMT)) | 0120000; #endif @@ -270,9 +255,8 @@ static mode_t from_wire_mode(int mode) return (mode_t)mode; } - static void send_directory(int f, struct file_list *flist, - char *fbuf, unsigned int offset); + char *fbuf, int len); static char *flist_dir; static int flist_dir_len; @@ -333,7 +317,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) char fname[MAXPATHLEN]; int l1, l2; - if (f == -1) + if (f < 0) return; if (!file) { @@ -388,7 +372,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) else modtime = file->modtime; -#if SUPPORT_HARD_LINKS +#ifdef SUPPORT_HARD_LINKS if (file->link_u.idev) { if (file->F_DEV == dev) { if (protocol_version >= 28) @@ -423,10 +407,8 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) } else write_byte(f, flags); } else { - if (!(flags & 0xFF) && !S_ISDIR(mode)) - flags |= XMIT_TOP_DIR; if (!(flags & 0xFF)) - flags |= XMIT_LONG_NAME; + flags |= S_ISDIR(mode) ? XMIT_LONG_NAME : XMIT_TOP_DIR; write_byte(f, flags); } if (flags & XMIT_SAME_NAME) @@ -466,7 +448,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) } } -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (preserve_links && S_ISLNK(mode)) { int len = strlen(file->u.link); write_int(f, len); @@ -474,7 +456,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) } #endif -#if SUPPORT_HARD_LINKS +#ifdef SUPPORT_HARD_LINKS if (flags & XMIT_HAS_IDEV_DATA) { if (protocol_version < 26) { /* 32-bit dev_t and ino_t */ @@ -489,19 +471,16 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) } #endif - if (always_checksum) { + if (always_checksum && (S_ISREG(mode) || protocol_version < 28)) { char *sum; + int slen = protocol_version < 21 ? 2 : MD4_SUM_LENGTH; if (S_ISREG(mode)) sum = file->u.sum; - else if (protocol_version < 28) { + else { /* Prior to 28, we sent a useless set of nulls. */ sum = empty_sum; - } else - sum = NULL; - if (sum) { - write_buf(f, sum, - protocol_version < 21 ? 2 : MD4_SUM_LENGTH); } + write_buf(f, sum, slen); } strlcpy(lastname, fname, MAXPATHLEN); @@ -509,10 +488,8 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags) io_write_phase = "unknown"; } - - -static void receive_file_entry(struct file_list *flist, int ndx, - unsigned short flags, int f) +static struct file_struct *receive_file_entry(struct file_list *flist, + unsigned short flags, int f) { static time_t modtime; static mode_t mode; @@ -540,7 +517,7 @@ static void receive_file_entry(struct file_list *flist, int ndx, *lastname = '\0'; lastdir_len = -1; in_del_hier = 0; - return; + return NULL; } if (flags & XMIT_SAME_NAME) @@ -555,7 +532,7 @@ static void receive_file_entry(struct file_list *flist, int ndx, rprintf(FERROR, "overflow: flags=0x%x l1=%d l2=%d lastname=%s\n", flags, l1, l2, safe_fname(lastname)); - overflow("receive_file_entry"); + overflow_exit("receive_file_entry"); } strlcpy(thisname, lastname, l1 + 1); @@ -614,13 +591,13 @@ static void receive_file_entry(struct file_list *flist, int ndx, } } -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (preserve_links && S_ISLNK(mode)) { linkname_len = read_int(f) + 1; /* count the '\0' */ if (linkname_len <= 0 || linkname_len > MAXPATHLEN) { rprintf(FERROR, "overflow: linkname_len=%d\n", linkname_len - 1); - overflow("receive_file_entry"); + overflow_exit("receive_file_entry"); } } else @@ -633,7 +610,7 @@ static void receive_file_entry(struct file_list *flist, int ndx, + linkname_len + sum_len; bp = pool_alloc(flist->file_pool, alloc_len, "receive_file_entry"); - file = flist->files[ndx] = (struct file_struct *)bp; + file = (struct file_struct *)bp; memset(bp, 0, file_struct_len); bp += file_struct_len; @@ -662,8 +639,11 @@ static void receive_file_entry(struct file_list *flist, int ndx, if (basename_len == 1+1 && *basename == '.') /* +1 for '\0' */ file->dir.depth--; if (flags & XMIT_TOP_DIR) { - in_del_hier = 1; + in_del_hier = recurse; del_hier_name_len = file->dir.depth == 0 ? 0 : l1 + l2; + if (relative_paths && del_hier_name_len > 2 + && basename_len == 1+1 && *basename == '.') + del_hier_name_len -= 2; file->flags |= FLAG_TOP_DIR | FLAG_DEL_HERE; } else if (in_del_hier) { if (!relative_paths || !del_hier_name_len @@ -682,7 +662,7 @@ static void receive_file_entry(struct file_list *flist, int ndx, if (preserve_devices && IS_DEVICE(mode)) file->u.rdev = rdev; -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (linkname_len) { file->u.link = bp; read_sbuf(f, bp, linkname_len - 1); @@ -692,7 +672,7 @@ static void receive_file_entry(struct file_list *flist, int ndx, } #endif -#if SUPPORT_HARD_LINKS +#ifdef SUPPORT_HARD_LINKS if (preserve_hard_links && protocol_version < 28 && S_ISREG(mode)) flags |= XMIT_HAS_IDEV_DATA; if (flags & XMIT_HAS_IDEV_DATA) { @@ -714,20 +694,17 @@ static void receive_file_entry(struct file_list *flist, int ndx, } #endif - if (always_checksum) { + if (always_checksum && (sum_len || protocol_version < 28)) { char *sum; + int slen = protocol_version < 21 ? 2 : MD4_SUM_LENGTH; if (sum_len) { file->u.sum = sum = bp; /*bp += sum_len;*/ - } else if (protocol_version < 28) { + } else { /* Prior to 28, we get a useless set of nulls. */ sum = empty_sum; - } else - sum = NULL; - if (sum) { - read_buf(f, sum, - protocol_version < 21 ? 2 : MD4_SUM_LENGTH); } + read_buf(f, sum, slen); } if (!preserve_perms) { @@ -735,8 +712,9 @@ static void receive_file_entry(struct file_list *flist, int ndx, * permissions and umask. This emulates what GNU cp does */ file->mode &= ~orig_umask; } -} + return file; +} /** * Create a file_struct for a named file by reading its stat() @@ -789,7 +767,7 @@ struct file_struct *make_file(char *fname, struct file_list *flist, && is_excluded(thisname, 0, filter_level)) return NULL; if (save_errno == ENOENT) { -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS /* Avoid "vanished" error if symlink points nowhere. */ if (copy_links && do_lstat(thisname, &st) == 0 && S_ISLNK(st.st_mode)) { @@ -833,7 +811,7 @@ struct file_struct *make_file(char *fname, struct file_list *flist, return NULL; if (lp_ignore_nonreadable(module_id)) { -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (!S_ISLNK(st.st_mode)) #endif if (access(thisname, R_OK) != 0) @@ -862,7 +840,7 @@ skip_filters: } basename_len = strlen(basename) + 1; /* count the '\0' */ -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS linkname_len = S_ISLNK(st.st_mode) ? strlen(linkname) + 1 : 0; #else linkname_len = 0; @@ -891,7 +869,7 @@ skip_filters: file->uid = st.st_uid; file->gid = st.st_gid; -#if SUPPORT_HARD_LINKS +#ifdef SUPPORT_HARD_LINKS if (flist && flist->hlink_pool) { if (protocol_version < 28) { if (S_ISREG(st.st_mode)) @@ -924,12 +902,12 @@ skip_filters: memcpy(bp, basename, basename_len); bp += basename_len; -#if HAVE_STRUCT_STAT_ST_RDEV +#ifdef HAVE_STRUCT_STAT_ST_RDEV if (preserve_devices && IS_DEVICE(st.st_mode)) file->u.rdev = st.st_rdev; #endif -#if SUPPORT_LINKS +#ifdef SUPPORT_LINKS if (linkname_len) { file->u.link = bp; memcpy(bp, linkname, linkname_len); @@ -949,8 +927,9 @@ skip_filters: * a list of files for a delete pass. */ if (keep_dirlinks && linkname_len && flist) { STRUCT_STAT st2; - int i = flist_find(received_flist, file); - if (i >= 0 && S_ISDIR(received_flist->files[i]->mode) + int save_mode = file->mode; + file->mode = S_IFDIR; /* find a directory w/our name */ + if (flist_find(the_file_list, file) >= 0 && do_stat(thisname, &st2) == 0 && S_ISDIR(st2.st_mode)) { file->modtime = st2.st_mtime; file->length = st2.st_size; @@ -958,34 +937,26 @@ skip_filters: file->uid = st2.st_uid; file->gid = st2.st_gid; file->u.link = NULL; - if (file->link_u.idev) { - pool_free(flist->hlink_pool, 0, file->link_u.idev); - file->link_u.idev = NULL; - } - } + } else + file->mode = save_mode; } - if (!S_ISDIR(st.st_mode)) + if (S_ISREG(st.st_mode) || S_ISLNK(st.st_mode)) stats.total_size += st.st_size; return file; } - -void send_file_name(int f, struct file_list *flist, char *fname, - int recursive, unsigned short base_flags) +static struct file_struct *send_file_name(int f, struct file_list *flist, + char *fname, unsigned short base_flags) { struct file_struct *file; - char fbuf[MAXPATHLEN]; - - /* f is set to -1 when calculating deletion file list */ - file = make_file(fname, flist, - f == -1 && delete_excluded? SERVER_FILTERS : ALL_FILTERS); + file = make_file(fname, flist, f == -2 ? SERVER_FILTERS : ALL_FILTERS); if (!file) - return; + return NULL; - maybe_emit_filelist_progress(flist); + maybe_emit_filelist_progress(flist->count + flist_count_offset); flist_expand(flist); @@ -993,8 +964,15 @@ void send_file_name(int f, struct file_list *flist, char *fname, flist->files[flist->count++] = file; send_file_entry(file, f, base_flags); } + return file; +} - if (recursive && S_ISDIR(file->mode) +static void send_if_directory(int f, struct file_list *flist, + struct file_struct *file) +{ + char fbuf[MAXPATHLEN]; + + if (S_ISDIR(file->mode) && !(file->flags & FLAG_MOUNT_POINT) && f_name_to(file, fbuf)) { void *save_filters; unsigned int len = strlen(fbuf); @@ -1012,15 +990,19 @@ void send_file_name(int f, struct file_list *flist, char *fname, } } - -/* Note that the "recurse" value either contains -1, for infinite recursion, - * or a number >= 0 indicating how many levels of recursion we will allow. */ +/* This function is normally called by the sender, but the receiving side also + * calls it from get_dirlist() with f set to -1 so that we just construct the + * file list in memory without sending it over the wire. Also, get_dirlist() + * might call this with f set to -2, which also indicates that local filter + * rules should be ignored. */ static void send_directory(int f, struct file_list *flist, - char *fbuf, unsigned int len) + char *fbuf, int len) { struct dirent *di; + unsigned remainder; char *p; DIR *d; + int start = flist->count; if (!(d = opendir(fbuf))) { io_error |= IOERR_GENERAL; @@ -1032,39 +1014,39 @@ static void send_directory(int f, struct file_list *flist, if (len != 1 || *fbuf != '/') *p++ = '/'; *p = '\0'; + remainder = MAXPATHLEN - (p - fbuf); for (errno = 0, di = readdir(d); di; errno = 0, di = readdir(d)) { char *dname = d_name(di); if (dname[0] == '.' && (dname[1] == '\0' || (dname[1] == '.' && dname[2] == '\0'))) continue; - if (strlcpy(p, dname, MAXPATHLEN - len) < MAXPATHLEN - len) { - int do_subdirs = recurse >= 1 ? recurse-- : recurse; - send_file_name(f, flist, fbuf, do_subdirs, 0); - } else { + if (strlcpy(p, dname, remainder) < remainder) + send_file_name(f, flist, fbuf, 0); + else { io_error |= IOERR_GENERAL; rprintf(FINFO, "cannot send long-named file %s\n", full_fname(fbuf)); } } + + fbuf[len] = '\0'; + if (errno) { io_error |= IOERR_GENERAL; - *p = '\0'; rsyserr(FERROR, errno, "readdir(%s)", full_fname(fbuf)); } closedir(d); -} + if (recurse) { + int i, end = flist->count - 1; + for (i = start; i <= end; i++) + send_if_directory(f, flist, flist->files[i]); + } +} -/* This function is normally called by the sender, but the receiving side - * also uses it to construct one or more file lists if one of the --delete - * options have been specified. The delete_files() function sets f to -1 - * so that we just construct the file list in memory without sending it - * over the wire. It also has the side-effect of ignoring user-excludes if - * delete_excluded is set (so that the delete list includes user-excluded - * files). */ struct file_list *send_file_list(int f, int argc, char *argv[]) { int l; @@ -1076,31 +1058,28 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) int64 start_write; int use_ff_fd = 0; - if (show_filelist_p() && f != -1) + if (show_filelist_p()) start_filelist_progress("building file list"); start_write = stats.total_written; gettimeofday(&start_tv, NULL); - flist = flist_new(f == -1 ? WITHOUT_HLINK : WITH_HLINK, - "send_file_list"); + flist = flist_new(WITH_HLINK, "send_file_list"); - if (f != -1) { - io_start_buffering_out(); - if (filesfrom_fd >= 0) { - if (argv[0] && !push_dir(argv[0])) { - rsyserr(FERROR, errno, "push_dir %s failed", - full_fname(argv[0])); - exit_cleanup(RERR_FILESELECT); - } - use_ff_fd = 1; + io_start_buffering_out(); + if (filesfrom_fd >= 0) { + if (argv[0] && !push_dir(argv[0])) { + rsyserr(FERROR, errno, "push_dir %s failed", + full_fname(argv[0])); + exit_cleanup(RERR_FILESELECT); } + use_ff_fd = 1; } while (1) { char fname2[MAXPATHLEN]; char *fname = fname2; - int do_subdirs; + int is_dot_dir; if (use_ff_fd) { if (read_filesfrom_line(filesfrom_fd, fname) == 0) @@ -1119,23 +1098,30 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) if (l == 2 && fname[0] == '.') { /* Turn "./" into just "." rather than "./." */ fname[1] = '\0'; - } else if (l < MAXPATHLEN) { + } else { + if (l + 1 >= MAXPATHLEN) + overflow_exit("send_file_list"); fname[l++] = '.'; fname[l] = '\0'; } + is_dot_dir = 1; + } else if (l > 1 && fname[l-1] == '.' && fname[l-2] == '.' + && (l == 2 || fname[l-3] == '/')) { + if (l + 2 >= MAXPATHLEN) + overflow_exit("send_file_list"); + fname[l++] = '/'; + fname[l++] = '.'; + fname[l] = '\0'; + is_dot_dir = 1; + } else { + is_dot_dir = fname[l-1] == '.' + && (l == 1 || fname[l-2] == '/'); } - if (fname[l-1] == '.' && (l == 1 || fname[l-2] == '/')) { - if (!recurse && xfer_dirs) - recurse = 1; /* allow one level */ - } else if (recurse > 0) - recurse = 0; if (link_stat(fname, &st, keep_dirlinks) != 0) { - if (f != -1) { - io_error |= IOERR_GENERAL; - rsyserr(FERROR, errno, "link_stat %s failed", - full_fname(fname)); - } + io_error |= IOERR_GENERAL; + rsyserr(FERROR, errno, "link_stat %s failed", + full_fname(fname)); continue; } @@ -1151,42 +1137,20 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) if (!relative_paths) { p = strrchr(fname, '/'); if (p) { - *p = 0; + *p = '\0'; if (p == fname) dir = "/"; else dir = fname; fname = p + 1; } - } else if (f != -1 && implied_dirs && (p=strrchr(fname,'/')) && p != fname) { - /* this ensures we send the intermediate directories, - thus getting their permissions right */ - char *lp = lastpath, *fn = fname, *slash = fname; - *p = 0; - /* Skip any initial directories in our path that we - * have in common with lastpath. */ - while (*fn && *lp == *fn) { - if (*fn == '/') - slash = fn; - lp++, fn++; - } - *p = '/'; - if (fn != p || (*lp && *lp != '/')) { - int save_copy_links = copy_links; - int save_xfer_dirs = xfer_dirs; - copy_links = copy_unsafe_links; - xfer_dirs = 1; - while ((slash = strchr(slash+1, '/')) != 0) { - *slash = 0; - send_file_name(f, flist, fname, 0, 0); - *slash = '/'; - } - copy_links = save_copy_links; - xfer_dirs = save_xfer_dirs; - *p = 0; - strlcpy(lastpath, fname, sizeof lastpath); - *p = '/'; - } + } else if ((p = strstr(fname, "/./")) != NULL) { + *p = '\0'; + if (p == fname) + dir = "/"; + else + dir = fname; + fname = p + 3; } if (!*fname) @@ -1196,7 +1160,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) static char *lastdir; static int lastdir_len; - strcpy(olddir, curr_dir); /* can't overflow */ + strlcpy(olddir, curr_dir, sizeof olddir); if (!push_dir(dir)) { io_error |= IOERR_GENERAL; @@ -1214,65 +1178,98 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) } } + if (implied_dirs && (p=strrchr(fname,'/')) && p != fname) { + /* Send the implied directories at the start of the + * source spec, so we get their permissions right. */ + char *lp = lastpath, *fn = fname, *slash = fname; + *p = '\0'; + /* Skip any initial directories in our path that we + * have in common with lastpath. */ + while (*fn && *lp == *fn) { + if (*fn == '/') + slash = fn; + lp++, fn++; + } + *p = '/'; + if (fn != p || (*lp && *lp != '/')) { + int save_copy_links = copy_links; + int save_xfer_dirs = xfer_dirs; + copy_links = copy_unsafe_links; + xfer_dirs = 1; + while ((slash = strchr(slash+1, '/')) != 0) { + *slash = '\0'; + send_file_name(f, flist, fname, 0); + *slash = '/'; + } + copy_links = save_copy_links; + xfer_dirs = save_xfer_dirs; + *p = '\0'; + strlcpy(lastpath, fname, sizeof lastpath); + *p = '/'; + } + } + if (one_file_system) filesystem_dev = st.st_dev; - do_subdirs = recurse >= 1 ? recurse-- : recurse; - send_file_name(f, flist, fname, do_subdirs, XMIT_TOP_DIR); + if (recurse || (xfer_dirs && is_dot_dir)) { + struct file_struct *file; + if ((file = send_file_name(f, flist, fname, XMIT_TOP_DIR))) + send_if_directory(f, flist, file); + } else + send_file_name(f, flist, fname, 0); if (olddir[0]) { flist_dir = NULL; flist_dir_len = 0; if (!pop_dir(olddir)) { rsyserr(FERROR, errno, "pop_dir %s failed", - full_fname(dir)); + full_fname(olddir)); exit_cleanup(RERR_FILESELECT); } } } - if (f != -1) { - gettimeofday(&end_tv, NULL); - stats.flist_buildtime = - (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000 - + (end_tv.tv_usec - start_tv.tv_usec) / 1000; - if (stats.flist_buildtime == 0) - stats.flist_buildtime = 1; - start_tv = end_tv; + gettimeofday(&end_tv, NULL); + stats.flist_buildtime = (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000 + + (end_tv.tv_usec - start_tv.tv_usec) / 1000; + if (stats.flist_buildtime == 0) + stats.flist_buildtime = 1; + start_tv = end_tv; - send_file_entry(NULL, f, 0); + send_file_entry(NULL, f, 0); - if (show_filelist_p()) - finish_filelist_progress(flist); + if (show_filelist_p()) + finish_filelist_progress(flist); - gettimeofday(&end_tv, NULL); - stats.flist_xfertime = - (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000 - + (end_tv.tv_usec - start_tv.tv_usec) / 1000; - } + gettimeofday(&end_tv, NULL); + stats.flist_xfertime = (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000 + + (end_tv.tv_usec - start_tv.tv_usec) / 1000; if (flist->hlink_pool) { pool_destroy(flist->hlink_pool); flist->hlink_pool = NULL; } + /* Sort the list without removing any duplicates. This allows the + * receiving side to ask for any name they like, which gives us the + * flexibility to change the way we unduplicate names in the future + * without causing a compatibility problem with older versions. */ clean_flist(flist, 0, 0); - if (f != -1) { - /* Now send the uid/gid list. This was introduced in - * protocol version 15 */ - send_uid_list(f); + /* Now send the uid/gid list. This was introduced in + * protocol version 15 */ + send_uid_list(f); - /* send the io_error flag */ - write_int(f, lp_ignore_errors(module_id) ? 0 : io_error); + /* send the io_error flag */ + write_int(f, lp_ignore_errors(module_id) ? 0 : io_error); - io_end_buffering(); - stats.flist_size = stats.total_written - start_write; - stats.num_files = flist->count; - } + io_end_buffering(); + stats.flist_size = stats.total_written - start_write; + stats.num_files = flist->count; if (verbose > 3) - output_flist(flist, f < 0 ? "delete" : who_am_i()); + output_flist(flist); if (verbose > 2) rprintf(FINFO, "send_file_list done\n"); @@ -1280,7 +1277,6 @@ struct file_list *send_file_list(int f, int argc, char *argv[]) return flist; } - struct file_list *recv_file_list(int f) { struct file_list *flist; @@ -1293,7 +1289,6 @@ struct file_list *recv_file_list(int f) start_read = stats.total_read; flist = flist_new(WITH_HLINK, "recv_file_list"); - received_flist = flist; flist->count = 0; flist->malloced = 1000; @@ -1303,27 +1298,27 @@ struct file_list *recv_file_list(int f) while ((flags = read_byte(f)) != 0) { - int i = flist->count; + struct file_struct *file; flist_expand(flist); if (protocol_version >= 28 && (flags & XMIT_EXTENDED_FLAGS)) flags |= read_byte(f) << 8; - receive_file_entry(flist, i, flags, f); + file = receive_file_entry(flist, flags, f); - if (S_ISREG(flist->files[i]->mode)) - stats.total_size += flist->files[i]->length; + if (S_ISREG(file->mode)) + stats.total_size += file->length; - flist->count++; + flist->files[flist->count++] = file; - maybe_emit_filelist_progress(flist); + maybe_emit_filelist_progress(flist->count); if (verbose > 2) { rprintf(FINFO, "recv_file_name(%s)\n", - safe_fname(f_name(flist->files[i]))); + safe_fname(f_name(file))); } } - receive_file_entry(NULL, 0, 0, 0); /* Signal that we're done. */ + receive_file_entry(NULL, 0, 0); /* Signal that we're done. */ if (verbose > 2) rprintf(FINFO, "received %d names\n", flist->count); @@ -1333,7 +1328,7 @@ struct file_list *recv_file_list(int f) clean_flist(flist, relative_paths, 1); - if (f != -1) { + if (f >= 0) { /* Now send the uid/gid list. This was introduced in * protocol version 15 */ recv_uid_list(f, flist); @@ -1346,7 +1341,7 @@ struct file_list *recv_file_list(int f) } if (verbose > 3) - output_flist(flist, who_am_i()); + output_flist(flist); if (list_only) { int i; @@ -1367,14 +1362,14 @@ oom: return NULL; /* not reached */ } - static int file_compare(struct file_struct **file1, struct file_struct **file2) { return f_name_cmp(*file1, *file2); } - -static int flist_find(struct file_list *flist, struct file_struct *f) +/* Search for an identically-named item in the file list. Note that the + * items must agree in their directory-ness, or no match is returned. */ +int flist_find(struct file_list *flist, struct file_struct *f) { int low = flist->low, high = flist->high; int ret, mid, mid_up; @@ -1386,8 +1381,13 @@ static int flist_find(struct file_list *flist, struct file_struct *f) ret = f_name_cmp(flist->files[mid_up], f); else ret = 1; - if (ret == 0) + if (ret == 0) { + if (protocol_version < 29 + && S_ISDIR(flist->files[mid_up]->mode) + != S_ISDIR(f->mode)) + return -1; return mid_up; + } if (ret > 0) high = mid - 1; else @@ -1407,7 +1407,6 @@ void clear_file(int i, struct file_list *flist) memset(flist->files[i], 0, file_struct_len); } - /* * allocate a new file list */ @@ -1425,7 +1424,7 @@ struct file_list *flist_new(int with_hlink, char *msg) out_of_memory, POOL_INTERN))) out_of_memory(msg); -#if SUPPORT_HARD_LINKS +#ifdef SUPPORT_HARD_LINKS if (with_hlink && preserve_hard_links) { if (!(flist->hlink_pool = pool_create(HLINK_EXTENT, sizeof (struct idev), out_of_memory, POOL_INTERN))) @@ -1447,7 +1446,6 @@ void flist_free(struct file_list *flist) free(flist); } - /* * This routine ensures we don't have any duplicate names in our file list. * duplicate names can cause corruption because of the pipelining @@ -1456,11 +1454,17 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups) { int i, prev_i = 0; - if (!flist || flist->count == 0) + if (!flist) return; + if (flist->count == 0) { + flist->high = -1; + return; + } + sorting_flist = flist; qsort(flist->files, flist->count, sizeof flist->files[0], (int (*)())file_compare); + sorting_flist = NULL; for (i = no_dups? 0 : flist->count; i < flist->count; i++) { if (flist->files[i]->basename) { @@ -1470,49 +1474,87 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups) } flist->low = prev_i; while (++i < flist->count) { - if (!flist->files[i]->basename) + int j; + struct file_struct *file = flist->files[i]; + + if (!file->basename) continue; - if (f_name_cmp(flist->files[i], flist->files[prev_i]) == 0) { + if (f_name_cmp(file, flist->files[prev_i]) == 0) + j = prev_i; + else if (protocol_version >= 29 && S_ISDIR(file->mode)) { + int save_mode = file->mode; + /* Make sure that this directory doesn't duplicate a + * non-directory earlier in the list. */ + flist->high = prev_i; + file->mode = S_IFREG; + j = flist_find(flist, file); + file->mode = save_mode; + } else + j = -1; + if (j >= 0) { + struct file_struct *fp = flist->files[j]; + int keep, drop; + /* If one is a dir and the other is not, we want to + * keep the dir because it might have contents in the + * list. */ + if (S_ISDIR(file->mode) != S_ISDIR(fp->mode)) { + if (S_ISDIR(file->mode)) + keep = i, drop = j; + else + keep = j, drop = i; + } else + keep = j, drop = i; if (verbose > 1 && !am_server) { rprintf(FINFO, - "removing duplicate name %s from file list %d\n", - safe_fname(f_name(flist->files[i])), i); + "removing duplicate name %s from file list (%d)\n", + safe_fname(f_name(file)), drop); } /* Make sure that if we unduplicate '.', that we don't * lose track of a user-specified top directory. */ - if (flist->files[i]->flags & FLAG_TOP_DIR) - flist->files[prev_i]->flags |= FLAG_TOP_DIR; + flist->files[keep]->flags |= flist->files[drop]->flags + & (FLAG_TOP_DIR|FLAG_DEL_HERE); - clear_file(i, flist); + clear_file(drop, flist); + + if (keep == i) { + if (flist->low == drop) { + for (j = drop + 1; + j < i && !flist->files[j]->basename; + j++) {} + flist->low = j; + } + prev_i = i; + } } else prev_i = i; } - flist->high = prev_i; + flist->high = no_dups ? prev_i : flist->count - 1; if (strip_root) { - /* we need to strip off the root directory in the case - of relative paths, but this must be done _after_ - the sorting phase */ - for (i = 0; i < flist->count; i++) { - if (flist->files[i]->dirname && - flist->files[i]->dirname[0] == '/') { - memmove(&flist->files[i]->dirname[0], - &flist->files[i]->dirname[1], - strlen(flist->files[i]->dirname)); - } + /* We need to strip off the leading slashes for relative + * paths, but this must be done _after_ the sorting phase. */ + for (i = flist->low; i <= flist->high; i++) { + struct file_struct *file = flist->files[i]; - if (flist->files[i]->dirname && - !flist->files[i]->dirname[0]) { - flist->files[i]->dirname = NULL; + if (!file->dirname) + continue; + if (*file->dirname == '/') { + char *s = file->dirname + 1; + while (*s == '/') s++; + memmove(file->dirname, s, strlen(s) + 1); } + + if (!*file->dirname) + file->dirname = NULL; } } } -static void output_flist(struct file_list *flist, const char *whose_list) +static void output_flist(struct file_list *flist) { char uidbuf[16], gidbuf[16], depthbuf[16]; struct file_struct *file; + const char *who = who_am_i(); int i; for (i = 0; i < flist->count; i++) { @@ -1528,7 +1570,7 @@ static void output_flist(struct file_list *flist, const char *whose_list) if (!am_sender) sprintf(depthbuf, "%d", file->dir.depth); rprintf(FINFO, "[%s] i=%d %s %s%s%s%s mode=0%o len=%.0f%s%s flags=%x\n", - whose_list, i, am_sender ? NS(file->dir.root) : depthbuf, + who, i, am_sender ? NS(file->dir.root) : depthbuf, file->dirname ? safe_fname(file->dirname) : "", file->dirname ? "/" : "", NS(file->basename), S_ISDIR(file->mode) ? "/" : "", (int)file->mode, @@ -1536,18 +1578,31 @@ static void output_flist(struct file_list *flist, const char *whose_list) } } +enum fnc_state { s_DIR, s_SLASH, s_BASE, s_TRAILING }; +enum fnc_type { t_PATH, t_ITEM }; -enum fnc_state { fnc_DIR, fnc_SLASH, fnc_BASE }; - -/* Compare the names of two file_struct entities, just like strcmp() - * would do if it were operating on the joined strings. We assume - * that there are no 0-length strings. - */ +/* Compare the names of two file_struct entities, similar to how strcmp() + * would do if it were operating on the joined strings. + * + * Some differences beginning with protocol_version 29: (1) directory names + * are compared with an assumed trailing slash so that they compare in a + * way that would cause them to sort immediately prior to any content they + * may have; (2) a directory of any name compares after a non-directory of + * any name at the same depth; (3) a directory with name "." compares prior + * to anything else. These changes mean that a directory and a non-dir + * with the same name will not compare as equal (protocol_version >= 29). + * + * The dirname component can be an empty string, but the basename component + * cannot (and never is in the current codebase). The basename component + * may be NULL (for a removed item), in which case it is considered to be + * after any existing item. */ int f_name_cmp(struct file_struct *f1, struct file_struct *f2) { int dif; const uchar *c1, *c2; enum fnc_state state1, state2; + enum fnc_type type1, type2; + enum fnc_type t_path = protocol_version >= 29 ? t_PATH : t_ITEM; if (!f1 || !f1->basename) { if (!f2 || !f2->basename) @@ -1562,61 +1617,113 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2) if (c1 == c2) c1 = c2 = NULL; if (!c1) { - state1 = fnc_BASE; + type1 = S_ISDIR(f1->mode) ? t_path : t_ITEM; c1 = (uchar*)f1->basename; + if (type1 == t_PATH && *c1 == '.' && !c1[1]) { + type1 = t_ITEM; + state1 = s_TRAILING; + c1 = (uchar*)""; + } else + state1 = s_BASE; } else if (!*c1) { - state1 = fnc_SLASH; + type1 = t_path; + state1 = s_SLASH; c1 = (uchar*)"/"; - } else - state1 = fnc_DIR; + } else { + type1 = t_path; + state1 = s_DIR; + } if (!c2) { - state2 = fnc_BASE; + type2 = S_ISDIR(f2->mode) ? t_path : t_ITEM; c2 = (uchar*)f2->basename; + if (type2 == t_PATH && *c2 == '.' && !c2[1]) { + type2 = t_ITEM; + state2 = s_TRAILING; + c2 = (uchar*)""; + } else + state2 = s_BASE; } else if (!*c2) { - state2 = fnc_SLASH; + type2 = t_path; + state2 = s_SLASH; c2 = (uchar*)"/"; - } else - state2 = fnc_DIR; + } else { + type2 = t_path; + state2 = s_DIR; + } + + if (type1 != type2) + return type1 == t_PATH ? 1 : -1; while (1) { - if ((dif = (int)*c1 - (int)*c2) != 0) + if ((dif = (int)*c1++ - (int)*c2++) != 0) break; - if (!*++c1) { + if (!*c1) { switch (state1) { - case fnc_DIR: - state1 = fnc_SLASH; + case s_DIR: + state1 = s_SLASH; c1 = (uchar*)"/"; break; - case fnc_SLASH: - state1 = fnc_BASE; + case s_SLASH: + type1 = S_ISDIR(f1->mode) ? t_path : t_ITEM; c1 = (uchar*)f1->basename; + if (type1 == t_PATH && *c1 == '.' && !c1[1]) { + type1 = t_ITEM; + state1 = s_TRAILING; + c1 = (uchar*)""; + } else + state1 = s_BASE; break; - case fnc_BASE: + case s_BASE: + state1 = s_TRAILING; + if (type1 == t_PATH) { + c1 = (uchar*)"/"; + break; + } + /* FALL THROUGH */ + case s_TRAILING: + type1 = t_ITEM; break; } + if (*c2 && type1 != type2) + return type1 == t_PATH ? 1 : -1; } - if (!*++c2) { + if (!*c2) { switch (state2) { - case fnc_DIR: - state2 = fnc_SLASH; + case s_DIR: + state2 = s_SLASH; c2 = (uchar*)"/"; break; - case fnc_SLASH: - state2 = fnc_BASE; + case s_SLASH: + type2 = S_ISDIR(f2->mode) ? t_path : t_ITEM; c2 = (uchar*)f2->basename; + if (type2 == t_PATH && *c2 == '.' && !c2[1]) { + type2 = t_ITEM; + state2 = s_TRAILING; + c2 = (uchar*)""; + } else + state2 = s_BASE; break; - case fnc_BASE: + case s_BASE: + state2 = s_TRAILING; + if (type2 == t_PATH) { + c2 = (uchar*)"/"; + break; + } + /* FALL THROUGH */ + case s_TRAILING: if (!*c1) return 0; + type2 = t_ITEM; break; } + if (type1 != type2) + return type1 == t_PATH ? 1 : -1; } } return dif; } - /* Return a copy of the full filename of a flist entry, using the indicated * buffer. No size-checking is done because we checked the size when creating * the file_struct entry. @@ -1636,7 +1743,6 @@ char *f_name_to(struct file_struct *f, char *fbuf) return fbuf; } - /* Like f_name_to(), but we rotate through 5 static buffers of our own. */ char *f_name(struct file_struct *f) { @@ -1648,113 +1754,37 @@ char *f_name(struct file_struct *f) return f_name_to(f, names[n]); } - -static int is_backup_file(char *fn) -{ - int k = strlen(fn) - backup_suffix_len; - return k > 0 && strcmp(fn+k, backup_suffix) == 0; -} - - -/* This function is used to implement per-directory deletion, and - * is used by all the --delete-WHEN options. Note that the fbuf - * pointer must point to a MAXPATHLEN buffer with the name of the - * directory in it (the functions we call will append names onto - * the end, but the old dir value will be restored on exit). */ -void delete_in_dir(struct file_list *flist, char *fbuf, - struct file_struct *file) +/* Do a non-recursive scan of the named directory, possibly ignoring all + * exclude rules except for the daemon's. If "dlen" is >=0, it is the length + * of the dirname string, and also indicates that "dirname" is a MAXPATHLEN + * buffer (the functions we call will append names onto the end, but the old + * dir value will be restored on exit). */ +struct file_list *get_dirlist(char *dirname, int dlen, + int ignore_filter_rules) { - static int min_depth = MAXPATHLEN, cur_depth = -1; - static void *filt_array[MAXPATHLEN/2+1]; - struct file_list *dir_list; - STRUCT_STAT st; - int dlen; - - if (!flist) { - while (cur_depth >= min_depth) - pop_local_filters(filt_array[cur_depth--]); - min_depth = MAXPATHLEN; - cur_depth = -1; - return; - } - if (file->dir.depth >= MAXPATHLEN/2+1) - return; /* Impossible... */ - - if (max_delete && deletion_count >= max_delete) - return; + struct file_list *dirlist; + char dirbuf[MAXPATHLEN]; + int save_recurse = recurse; - if (io_error && !(lp_ignore_errors(module_id) || ignore_errors)) { - rprintf(FINFO, - "IO error encountered -- skipping file deletion\n"); - max_delete = -1; /* avoid duplicating the above warning */ - return; + if (dlen < 0) { + dlen = strlcpy(dirbuf, dirname, MAXPATHLEN); + if (dlen >= MAXPATHLEN) + return NULL; + dirname = dirbuf; } - while (cur_depth >= file->dir.depth && cur_depth >= min_depth) - pop_local_filters(filt_array[cur_depth--]); - cur_depth = file->dir.depth; - if (min_depth > cur_depth) - min_depth = cur_depth; - dlen = strlen(fbuf); - filt_array[cur_depth] = push_local_filters(fbuf, dlen); - - if (link_stat(fbuf, &st, keep_dirlinks) < 0) - return; - - if (one_file_system && file->flags & FLAG_TOP_DIR) - filesystem_dev = st.st_dev; - - dir_list = flist_new(WITHOUT_HLINK, "delete_in_dir"); + dirlist = flist_new(WITHOUT_HLINK, "get_dirlist"); recurse = 0; - send_directory(-1, dir_list, fbuf, dlen); - recurse = -1; - fbuf[dlen] = '\0'; - - if (verbose > 3) - output_flist(dir_list, "delete"); - - delete_missing(flist, dir_list, fbuf); - - flist_free(dir_list); -} + send_directory(ignore_filter_rules ? -2 : -1, dirlist, dirname, dlen); + recurse = save_recurse; + if (do_progress) + flist_count_offset += dirlist->count; + clean_flist(dirlist, 0, 0); -/* If an item in dir_list is not found in full_list, delete it from the - * filesystem. */ -void delete_missing(struct file_list *full_list, struct file_list *dir_list, - const char *dirname) -{ - int i, j, mode; - - if (max_delete && deletion_count >= max_delete) - return; - - if (verbose > 2) - rprintf(FINFO, "delete_missing(%s)\n", safe_fname(dirname)); + if (verbose > 3) + output_flist(dirlist); - for (i = dir_list->count; i--; ) { - if (!dir_list->files[i]->basename) - continue; - mode = dir_list->files[i]->mode; - if ((j = flist_find(full_list, dir_list->files[i])) < 0 - || (delete_during && S_ISDIR(mode) - && !S_ISDIR(full_list->files[j]->mode))) { - char *f = f_name(dir_list->files[i]); - if (make_backups && (backup_dir || !is_backup_file(f)) - && !S_ISDIR(mode)) { - make_backup(f); - if (verbose) { - rprintf(FINFO, "deleting %s\n", - safe_fname(f)); - } - } else if (S_ISDIR(mode)) - delete_file(f, DEL_DIR | DEL_FORCE_RECURSE); - else - delete_file(f, 0); - deletion_count++; - if (max_delete && deletion_count >= max_delete) - break; - } - } + return dirlist; }