X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/571a4b265410cdc6b8301580f2b04ee29cff214a..a24e12e6dd814f7da77d121fcedf862f05f061f5:/runtests.sh

diff --git a/runtests.sh b/runtests.sh
index 9e4ee16d..d6a9a482 100755
--- a/runtests.sh
+++ b/runtests.sh
@@ -97,6 +97,9 @@
 
 # BSD machines tend not to have "head" or "seq".
 
+# You cannot do "export VAR=VALUE" all on one line; the export must be
+# separate from the assignment.  (SCO SysV)
+
 
 
 # STILL TO DO:
@@ -108,6 +111,13 @@
 # Perhaps we need a common way to cleanup tests.  At the moment just
 # clobbering the directory when we're done should be enough.
 
+# If any of the targets fail, then (GNU?) Make returns 2, instead of
+# the return code from the failing command.  This is fine, but it
+# means that the build farm just shows "2" for failed tests, not the
+# number of tests that actually failed.  For more details we might
+# need to grovel through the log files to find a line saying how many
+# failed.
+
 
 set -e
 
@@ -200,4 +210,11 @@ echo "      $passed passed"
 [ "$missing" -gt 0 ] && echo "      $missing missing"
 echo '------------------------------------------------------------'
 
-exit `expr $failed + $missing`
+# OK, so expr exits with 0 if the result is neither null nor zero; and
+# 1 if the expression is null or zero.  This is the opposite of what
+# we want, and if we just call expr then this script will always fail,
+# because -e is set.
+
+result=`expr $failed + $missing || true`
+echo "overall result is $result"
+exit $result