X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/4a19c3b254b01c298fe25d72f450a760278e9386..11832604264e49a6399352020fefa240a881b144:/generator.c

diff --git a/generator.c b/generator.c
index 453cff56..abdbaaf8 100644
--- a/generator.c
+++ b/generator.c
@@ -97,6 +97,8 @@ int ignore_perishable = 0;
 int non_perishable_cnt = 0;
 
 static int deletion_count = 0; /* used to implement --max-delete */
+static FILE *delete_delay_fp = NULL;
+static BOOL solo_file = 0;
 
 /* For calling delete_item() and delete_dir_contents(). */
 #define DEL_RECURSE		(1<<1) /* recurse */
@@ -123,10 +125,10 @@ static int is_backup_file(char *fn)
 /* Delete a file or directory.  If DEL_RECURSE is set in the flags, this will
  * delete recursively.
  *
- * Note that fname must point to a MAXPATHLEN buffer if the mode indicates it's
+ * Note that fbuf must point to a MAXPATHLEN buffer if the mode indicates it's
  * a directory! (The buffer is used for recursion, but returned unchanged.)
  */
-static enum delret delete_item(char *fname, int mode, char *replace, int flags)
+static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
 {
 	enum delret ret;
 	char *what;
@@ -134,13 +136,13 @@ static enum delret delete_item(char *fname, int mode, char *replace, int flags)
 
 	if (verbose > 2) {
 		rprintf(FINFO, "delete_item(%s) mode=%o flags=%d\n",
-			fname, mode, flags);
+			fbuf, mode, flags);
 	}
 
 	if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) {
 		ignore_perishable = 1;
 		/* If DEL_RECURSE is not set, this just reports emptiness. */
-		ret = delete_dir_contents(fname, flags);
+		ret = delete_dir_contents(fbuf, flags);
 		ignore_perishable = 0;
 		if (ret == DR_NOT_EMPTY || ret == DR_AT_LIMIT)
 			goto check_ret;
@@ -152,27 +154,27 @@ static enum delret delete_item(char *fname, int mode, char *replace, int flags)
 
 	if (S_ISDIR(mode)) {
 		what = "rmdir";
-		ok = do_rmdir(fname) == 0;
-	} else if (make_backups && (backup_dir || !is_backup_file(fname))) {
+		ok = do_rmdir(fbuf) == 0;
+	} else if (make_backups && (backup_dir || !is_backup_file(fbuf))) {
 		what = "make_backup";
-		ok = make_backup(fname);
+		ok = make_backup(fbuf);
 	} else {
 		what = "unlink";
-		ok = robust_unlink(fname) == 0;
+		ok = robust_unlink(fbuf) == 0;
 	}
 
 	if (ok) {
 		if (!replace)
-			log_delete(fname, mode);
+			log_delete(fbuf, mode);
 		ret = DR_SUCCESS;
 	} else {
 		if (S_ISDIR(mode) && errno == ENOTEMPTY) {
 			rprintf(FINFO, "cannot delete non-empty directory: %s\n",
-				fname);
+				fbuf);
 			ret = DR_NOT_EMPTY;
 		} else if (errno != ENOENT) {
 			rsyserr(FERROR, errno, "delete_file: %s(%s) failed",
-				what, full_fname(fname));
+				what, fbuf);
 			ret = DR_FAILURE;
 		} else {
 			deletion_count--;
@@ -183,7 +185,7 @@ static enum delret delete_item(char *fname, int mode, char *replace, int flags)
   check_ret:
 	if (replace && ret != DR_SUCCESS) {
 		rprintf(FERROR, "could not make way for new %s: %s\n",
-			replace, fname);
+			replace, fbuf);
 	}
 	return ret;
 }
@@ -233,7 +235,7 @@ static enum delret delete_dir_contents(char *fname, int flags)
 	for (j = dirlist->count; j--; ) {
 		struct file_struct *fp = dirlist->files[j];
 
-		if (fp->flags & FLAG_MOUNT_POINT) {
+		if (fp->flags & FLAG_MOUNT_DIR) {
 			if (verbose > 1) {
 				rprintf(FINFO,
 				    "mount point, %s, pins parent directory\n",
@@ -243,7 +245,7 @@ static enum delret delete_dir_contents(char *fname, int flags)
 			continue;
 		}
 
-		strlcpy(p, fp->basename, remainder);
+		strlcpy(p, F_BASENAME(fp), remainder);
 		/* Save stack by recursing to ourself directly. */
 		if (S_ISDIR(fp->mode)
 		 && delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
@@ -265,6 +267,68 @@ static enum delret delete_dir_contents(char *fname, int flags)
 	return ret;
 }
 
+static void start_delete_temp(void)
+{
+	char fnametmp[MAXPATHLEN];
+	int fd, save_dry_run = dry_run;
+
+	dry_run = 0;
+	if (!get_tmpname(fnametmp, "deldelay")
+	 || (fd = do_mkstemp(fnametmp, 0600)) < 0
+	 || !(delete_delay_fp = fdopen(fd, "w+"))) {
+		rprintf(FERROR, "Unable to create delete-delay temp file.\n");
+		exit_cleanup(RERR_FILEIO);
+	}
+	dry_run = save_dry_run;
+	unlink(fnametmp);
+}
+
+static int read_delay_line(FILE *fp, char *buf, int bsize)
+{
+	int ch, mode = 0;
+
+	if ((ch = fgetc(fp)) == EOF)
+		return -1;
+
+	while (1) {
+		if (ch == ' ')
+			break;
+		if (ch > '7' || ch < '0') {
+			rprintf(FERROR, "invalid data in delete-delay file.\n");
+			exit_cleanup(RERR_FILEIO);
+		}
+		mode = mode*8 + ch - '0';
+		if ((ch = fgetc(fp)) == EOF) {
+		  unexpected_eof:
+			rprintf(FERROR, "unexpected EOF in delete-delay file.\n");
+			exit_cleanup(RERR_FILEIO);
+		}
+	}
+
+	while (1) {
+		if ((ch = fgetc(fp)) == EOF)
+			goto unexpected_eof;
+		if (bsize-- <= 0) {
+			rprintf(FERROR, "filename too long in delete-delay file.\n");
+			exit_cleanup(RERR_FILEIO);
+		}
+		*buf++ = (char)ch;
+		if (ch == '\0')
+			break;
+	}
+
+	return mode;
+}
+
+static void delayed_deletions(char *delbuf)
+{
+	int mode;
+
+	fseek(delete_delay_fp, 0, 0);
+	while ((mode = read_delay_line(delete_delay_fp, delbuf, MAXPATHLEN)) >= 0)
+		delete_item(delbuf, mode, NULL, DEL_RECURSE);
+	fclose(delete_delay_fp);
+}
 
 /* This function is used to implement per-directory deletion, and is used by
  * all the --delete-WHEN options.  Note that the fbuf pointer must point to a
@@ -328,9 +392,9 @@ static void delete_in_dir(struct file_list *flist, char *fbuf,
 	 * from the filesystem. */
 	for (i = dirlist->count; i--; ) {
 		struct file_struct *fp = dirlist->files[i];
-		if (!fp->basename)
+		if (!F_IS_ACTIVE(fp))
 			continue;
-		if (fp->flags & FLAG_MOUNT_POINT) {
+		if (fp->flags & FLAG_MOUNT_DIR) {
 			if (verbose > 1)
 				rprintf(FINFO, "cannot delete mount point: %s\n",
 					f_name(fp, NULL));
@@ -338,7 +402,10 @@ static void delete_in_dir(struct file_list *flist, char *fbuf,
 		}
 		if (flist_find(flist, fp) < 0) {
 			f_name(fp, delbuf);
-			delete_item(delbuf, fp->mode, NULL, DEL_RECURSE);
+			if (delete_delay_fp)
+				fprintf(delete_delay_fp, "%o %s%c", (short)fp->mode, delbuf, '\0');
+			else
+				delete_item(delbuf, fp->mode, NULL, DEL_RECURSE);
 		}
 	}
 
@@ -360,7 +427,7 @@ static void do_delete_pass(struct file_list *flist)
 	for (j = 0; j < flist->count; j++) {
 		struct file_struct *file = flist->files[j];
 
-		if (!(file->flags & FLAG_DEL_HERE))
+		if (!(file->flags & FLAG_XFER_DIR))
 			continue;
 
 		f_name(file, fbuf);
@@ -385,10 +452,10 @@ int unchanged_attrs(struct file_struct *file, STRUCT_STAT *st)
 	 && (st->st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
 		return 0;
 
-	if (am_root && preserve_uid && st->st_uid != file->uid)
+	if (am_root && preserve_uid && st->st_uid != F_UID(file))
 		return 0;
 
-	if (preserve_gid && file->gid != GID_NONE && st->st_gid != file->gid)
+	if (preserve_gid && F_GID(file) != GID_NONE && st->st_gid != F_GID(file))
 		return 0;
 
 	return 1;
@@ -402,7 +469,7 @@ void itemize(struct file_struct *file, int ndx, int statret, STRUCT_STAT *st,
 		    : S_ISDIR(file->mode) ? !omit_dir_times
 		    : !S_ISLNK(file->mode);
 
-		if (S_ISREG(file->mode) && file->length != st->st_size)
+		if (S_ISREG(file->mode) && F_LENGTH(file) != st->st_size)
 			iflags |= ITEM_REPORT_SIZE;
 		if ((iflags & (ITEM_TRANSFER|ITEM_LOCAL_CHANGE) && !keep_time
 		  && !(iflags & ITEM_MATCHED)
@@ -411,10 +478,10 @@ void itemize(struct file_struct *file, int ndx, int statret, STRUCT_STAT *st,
 			iflags |= ITEM_REPORT_TIME;
 		if ((file->mode & CHMOD_BITS) != (st->st_mode & CHMOD_BITS))
 			iflags |= ITEM_REPORT_PERMS;
-		if (preserve_uid && am_root && file->uid != st->st_uid)
+		if (preserve_uid && am_root && F_UID(file) != st->st_uid)
 			iflags |= ITEM_REPORT_OWNER;
-		if (preserve_gid && file->gid != GID_NONE
-		    && st->st_gid != file->gid)
+		if (preserve_gid && F_GID(file) != GID_NONE
+		    && st->st_gid != F_GID(file))
 			iflags |= ITEM_REPORT_GROUP;
 	} else
 		iflags |= ITEM_IS_NEW;
@@ -441,7 +508,7 @@ void itemize(struct file_struct *file, int ndx, int statret, STRUCT_STAT *st,
 /* Perform our quick-check heuristic for determining if a file is unchanged. */
 int unchanged_file(char *fn, struct file_struct *file, STRUCT_STAT *st)
 {
-	if (st->st_size != file->length)
+	if (st->st_size != F_LENGTH(file))
 		return 0;
 
 	/* if always checksum is set then we use the checksum instead
@@ -449,7 +516,7 @@ int unchanged_file(char *fn, struct file_struct *file, STRUCT_STAT *st)
 	if (always_checksum && S_ISREG(st->st_mode)) {
 		char sum[MD4_SUM_LENGTH];
 		file_checksum(fn, sum, st->st_size);
-		return memcmp(sum, file->u.sum, checksum_len) == 0;
+		return memcmp(sum, F_SUM(file), checksum_len) == 0;
 	}
 
 	if (size_only)
@@ -526,8 +593,8 @@ static void sum_sizes_sqroot(struct sum_struct *sum, int64 len)
 	sum->flength	= len;
 	sum->blength	= blength;
 	sum->s2length	= s2length;
-	sum->remainder	= len % blength;
-	sum->count	= len / blength + (sum->remainder != 0);
+	sum->remainder	= (int32)(len % blength);
+	sum->count	= (int32)(len / blength) + (sum->remainder != 0);
 
 	if (sum->count && verbose > 2) {
 		rprintf(FINFO,
@@ -598,7 +665,7 @@ static void generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
 static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
 {
 	int fname_len, fname_suf_len;
-	const char *fname_suf, *fname = file->basename;
+	const char *fname_suf, *fname = F_BASENAME(file);
 	uint32 lowest_dist = 25 << 16; /* ignore a distance greater than 25 */
 	int j, lowest_j = -1;
 
@@ -611,13 +678,12 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
 		int len, suf_len;
 		uint32 dist;
 
-		if (!S_ISREG(fp->mode) || !fp->length
-		    || fp->flags & FLAG_NO_FUZZY)
+		if (!S_ISREG(fp->mode) || !F_LENGTH(fp) || fp->flags & FLAG_SENT)
 			continue;
 
-		name = fp->basename;
+		name = F_BASENAME(fp);
 
-		if (fp->length == file->length
+		if (F_LENGTH(fp) == F_LENGTH(file)
 		    && cmp_time(fp->modtime, file->modtime) == 0) {
 			if (verbose > 4) {
 				rprintf(FINFO,
@@ -647,6 +713,7 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
 	return lowest_j;
 }
 
+#ifdef SUPPORT_HARD_LINKS
 void check_for_finished_hlinks(int itemizing, enum logcode code)
 {
 	struct file_struct *file;
@@ -657,12 +724,13 @@ void check_for_finished_hlinks(int itemizing, enum logcode code)
 			continue;
 
 		file = the_file_list->files[ndx];
-		if (!file->link_u.links)
+		if (!F_IS_HLINKED(file))
 			continue;
 
-		hard_link_cluster(file, ndx, itemizing, code);
+		hard_link_cluster(file, ndx, itemizing, code, -1);
 	}
 }
+#endif
 
 /* This is only called for regular files.  We return -2 if we've finished
  * handling the file, -1 if no dest-linking occurred, or a non-negative
@@ -720,11 +788,8 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 			if (hard_link_one(file, ndx, fname, 0, stp,
 					  cmpbuf, 1, i, code) < 0)
 				goto try_a_copy;
-			if (preserve_hard_links && file->link_u.links) {
-				if (dry_run)
-					file->link_u.links->link_dest_used = j + 1;
-				hard_link_cluster(file, ndx, itemizing, code);
-			}
+			if (preserve_hard_links && F_IS_HLINKED(file))
+				hard_link_cluster(file, ndx, itemizing, code, j);
 		} else
 #endif
 		if (itemizing)
@@ -754,8 +819,10 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 			rprintf(code, "%s%s\n", fname,
 				match_level == 3 ? " is uptodate" : "");
 		}
-		if (preserve_hard_links && file->link_u.links)
-			hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file))
+			hard_link_cluster(file, ndx, itemizing, code, j);
+#endif
 		return -2;
 	}
 
@@ -772,6 +839,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 	char lnk[MAXPATHLEN];
 	int best_match = -1;
 	int match_level = 0;
+	uint32 *devp;
 	enum nonregtype type;
 	int len, j = 0;
 
@@ -829,7 +897,8 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 			break;
 		case TYPE_SPECIAL:
 		case TYPE_DEVICE:
-			if (stp->st_rdev != file->u.rdev)
+			devp = F_RDEV_P(file);
+			if (stp->st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
 				continue;
 			break;
 #ifdef SUPPORT_LINKS
@@ -837,7 +906,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 			if ((len = readlink(cmpbuf, lnk, MAXPATHLEN-1)) <= 0)
 				continue;
 			lnk[len] = '\0';
-			if (strcmp(lnk, file->u.link) != 0)
+			if (strcmp(lnk, F_SYMLINK(file)) != 0)
 				continue;
 			break;
 #endif
@@ -879,8 +948,8 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 					cmpbuf, fname);
 				return j;
 			}
-			if (preserve_hard_links && file->link_u.links)
-				hard_link_cluster(file, ndx, itemizing, code);
+			if (preserve_hard_links && F_IS_HLINKED(file))
+				hard_link_cluster(file, ndx, itemizing, code, -1);
 		} else
 #endif
 			match_level = 2;
@@ -1072,7 +1141,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 				rsyserr(FERROR, errno,
 					"recv_generator: mkdir %s failed",
 					full_fname(fname));
-				file->flags |= FLAG_MISSING;
+				file->flags |= FLAG_MISSING_DIR;
 				if (ndx+1 < the_file_list->count
 				 && the_file_list->files[ndx+1]->dir.depth > file->dir.depth) {
 					rprintf(FERROR,
@@ -1088,25 +1157,28 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 		if (real_ret != 0 && one_file_system)
 			real_st.st_dev = filesystem_dev;
 		if (delete_during && f_out != -1 && !phase && dry_run < 2
-		    && (file->flags & FLAG_DEL_HERE))
+		    && (file->flags & FLAG_XFER_DIR))
 			delete_in_dir(the_file_list, fname, file, &real_st);
 		return;
 	}
 
-	if (preserve_hard_links && file->link_u.links
+#ifdef SUPPORT_HARD_LINKS
+	if (preserve_hard_links && F_IS_HLINKED(file)
 	    && hard_link_check(file, ndx, fname, statret, &st,
 			       itemizing, code, HL_CHECK_MASTER))
 		return;
+#endif
 
 	if (preserve_links && S_ISLNK(file->mode)) {
 #ifdef SUPPORT_LINKS
-		if (safe_symlinks && unsafe_symlink(file->u.link, fname)) {
+		const char *sl = F_SYMLINK(file);
+		if (safe_symlinks && unsafe_symlink(sl, fname)) {
 			if (verbose) {
-				if (the_file_list->count == 1)
+				if (solo_file)
 					fname = f_name(file, NULL);
 				rprintf(FINFO,
 					"ignoring unsafe symlink %s -> \"%s\"\n",
-					full_fname(fname), file->u.link);
+					full_fname(fname), sl);
 			}
 			return;
 		}
@@ -1117,14 +1189,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			if (!S_ISLNK(st.st_mode))
 				statret = -1;
 			else if ((len = readlink(fname, lnk, MAXPATHLEN-1)) > 0
-			      && strncmp(lnk, file->u.link, len) == 0
-			      && file->u.link[len] == '\0') {
+			      && strncmp(lnk, sl, len) == 0 && sl[len] == '\0') {
 				/* The link is pointing to the right place. */
 				if (itemizing)
 					itemize(file, ndx, 0, &st, 0, 0, NULL);
 				set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
-				if (preserve_hard_links && file->link_u.links)
-					hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+				if (preserve_hard_links && F_IS_HLINKED(file))
+					hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 				if (remove_source_files == 1)
 					goto return_with_success;
 				return;
@@ -1149,13 +1222,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			} else if (j >= 0)
 				statret = 1;
 		}
-		if (preserve_hard_links && file->link_u.links
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file)
 		    && hard_link_check(file, ndx, fname, -1, &st,
 				       itemizing, code, HL_SKIP))
 			return;
-		if (do_symlink(file->u.link, fname) != 0) {
+#endif
+		if (do_symlink(sl, fname) != 0) {
 			rsyserr(FERROR, errno, "symlink %s -> \"%s\" failed",
-				full_fname(fname), file->u.link);
+				full_fname(fname), sl);
 		} else {
 			set_file_attrs(fname, file, NULL, 0);
 			if (itemizing) {
@@ -1163,9 +1238,11 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 					ITEM_LOCAL_CHANGE, 0, NULL);
 			}
 			if (code != FNONE && verbose)
-				rprintf(code, "%s -> %s\n", fname, file->u.link);
-			if (preserve_hard_links && file->link_u.links)
-				hard_link_cluster(file, ndx, itemizing, code);
+				rprintf(code, "%s -> %s\n", fname, sl);
+#ifdef SUPPORT_HARD_LINKS
+			if (preserve_hard_links && F_IS_HLINKED(file))
+				hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 			/* This does not check remove_source_files == 1
 			 * because this is one of the items that the old
 			 * --remove-sent-files option would remove. */
@@ -1178,6 +1255,8 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
 	if ((am_root && preserve_devices && IS_DEVICE(file->mode))
 	 || (preserve_specials && IS_SPECIAL(file->mode))) {
+		uint32 *devp = F_RDEV_P(file);
+		dev_t rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
 		if (statret == 0) {
 			char *t;
 			if (IS_DEVICE(file->mode)) {
@@ -1191,13 +1270,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			}
 			if (statret == 0
 			 && (st.st_mode & ~CHMOD_BITS) == (file->mode & ~CHMOD_BITS)
-			 && st.st_rdev == file->u.rdev) {
+			 && st.st_rdev == rdev) {
 				/* The device or special file is identical. */
 				if (itemizing)
 					itemize(file, ndx, 0, &st, 0, 0, NULL);
 				set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
-				if (preserve_hard_links && file->link_u.links)
-					hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+				if (preserve_hard_links && F_IS_HLINKED(file))
+					hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 				if (remove_source_files == 1)
 					goto return_with_success;
 				return;
@@ -1220,15 +1301,18 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			} else if (j >= 0)
 				statret = 1;
 		}
-		if (preserve_hard_links && file->link_u.links
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file)
 		    && hard_link_check(file, ndx, fname, -1, &st,
 				       itemizing, code, HL_SKIP))
 			return;
+#endif
 		if (verbose > 2) {
-			rprintf(FINFO,"mknod(%s,0%o,0x%x)\n",
-				fname, (int)file->mode, (int)file->u.rdev);
+			rprintf(FINFO, "mknod(%s, 0%o, [%ld,%ld])\n",
+				fname, (int)file->mode,
+				(long)major(rdev), (long)minor(rdev));
 		}
-		if (do_mknod(fname, file->mode, file->u.rdev) < 0) {
+		if (do_mknod(fname, file->mode, rdev) < 0) {
 			rsyserr(FERROR, errno, "mknod %s failed",
 				full_fname(fname));
 		} else {
@@ -1239,8 +1323,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			}
 			if (code != FNONE && verbose)
 				rprintf(code, "%s\n", fname);
-			if (preserve_hard_links && file->link_u.links)
-				hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+			if (preserve_hard_links && F_IS_HLINKED(file))
+				hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 			if (remove_source_files == 1)
 				goto return_with_success;
 		}
@@ -1248,23 +1334,23 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 	}
 
 	if (!S_ISREG(file->mode)) {
-		if (the_file_list->count == 1)
+		if (solo_file)
 			fname = f_name(file, NULL);
 		rprintf(FINFO, "skipping non-regular file \"%s\"\n", fname);
 		return;
 	}
 
-	if (max_size && file->length > max_size) {
+	if (max_size && F_LENGTH(file) > max_size) {
 		if (verbose > 1) {
-			if (the_file_list->count == 1)
+			if (solo_file)
 				fname = f_name(file, NULL);
 			rprintf(FINFO, "%s is over max-size\n", fname);
 		}
 		return;
 	}
-	if (min_size && file->length < min_size) {
+	if (min_size && F_LENGTH(file) < min_size) {
 		if (verbose > 1) {
-			if (the_file_list->count == 1)
+			if (solo_file)
 				fname = f_name(file, NULL);
 			rprintf(FINFO, "%s is under min-size\n", fname);
 		}
@@ -1329,7 +1415,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 				rprintf(FINFO, "fuzzy basis selected for %s: %s\n",
 					fname, fnamecmpbuf);
 			}
-			st.st_size = fuzzy_file->length;
+			st.st_size = F_LENGTH(fuzzy_file);
 			statret = 0;
 			fnamecmp = fnamecmpbuf;
 			fnamecmp_type = FNAMECMP_FUZZY;
@@ -1337,10 +1423,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 	}
 
 	if (statret != 0) {
-		if (preserve_hard_links && file->link_u.links
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file)
 		    && hard_link_check(file, ndx, fname, statret, &st,
 				       itemizing, code, HL_SKIP))
 			return;
+#endif
 		if (stat_errno == ENOENT)
 			goto notify_others;
 		rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s",
@@ -1348,7 +1436,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 		return;
 	}
 
-	if (append_mode && st.st_size > file->length)
+	if (append_mode && st.st_size > F_LENGTH(file))
 		return;
 
 	if (fnamecmp_type <= FNAMECMP_BASIS_DIR_HIGH)
@@ -1365,16 +1453,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 				0, 0, NULL);
 		}
 		set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
-		if (preserve_hard_links && file->link_u.links)
-			hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file))
+			hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 		if (remove_source_files != 1)
 			return;
 	  return_with_success:
-		if (!dry_run) {
-			char numbuf[4];
-			SIVAL(numbuf, 0, ndx);
-			send_msg(MSG_SUCCESS, numbuf, 4);
-		}
+		if (!dry_run)
+			send_msg_int(MSG_SUCCESS, ndx);
 		return;
 	}
 
@@ -1392,7 +1479,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 	if (fuzzy_dirlist) {
 		int j = flist_find(fuzzy_dirlist, file);
 		if (j >= 0) /* don't use changing file as future fuzzy basis */
-			fuzzy_dirlist->files[j]->flags |= FLAG_NO_FUZZY;
+			fuzzy_dirlist->files[j]->flags |= FLAG_SENT;
 	}
 
 	/* open the file */
@@ -1403,10 +1490,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			full_fname(fnamecmp));
 	  pretend_missing:
 		/* pretend the file didn't exist */
-		if (preserve_hard_links && file->link_u.links
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file)
 		    && hard_link_check(file, ndx, fname, statret, &st,
 				       itemizing, code, HL_SKIP))
 			return;
+#endif
 		statret = real_ret = -1;
 		goto notify_others;
 	}
@@ -1423,7 +1512,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 		if (robust_unlink(backupptr) && errno != ENOENT) {
 			rsyserr(FERROR, errno, "unlink %s",
 				full_fname(backupptr));
-			free(back_file);
+			unmake_file(back_file);
 			close(fd);
 			return;
 		}
@@ -1431,7 +1520,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 		    O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
 			rsyserr(FERROR, errno, "open %s",
 				full_fname(backupptr));
-			free(back_file);
+			unmake_file(back_file);
 			close(fd);
 			return;
 		}
@@ -1459,12 +1548,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 		if (fnamecmp_type == FNAMECMP_FUZZY)
 			iflags |= ITEM_XNAME_FOLLOWS;
 		itemize(file, -1, real_ret, &real_st, iflags, fnamecmp_type,
-			fuzzy_file ? fuzzy_file->basename : NULL);
+			fuzzy_file ? F_BASENAME(fuzzy_file) : NULL);
 	}
 
 	if (!do_xfers) {
-		if (preserve_hard_links && file->link_u.links)
-			hard_link_cluster(file, ndx, itemizing, code);
+#ifdef SUPPORT_HARD_LINKS
+		if (preserve_hard_links && F_IS_HLINKED(file))
+			hard_link_cluster(file, ndx, itemizing, code, -1);
+#endif
 		return;
 	}
 	if (read_batch)
@@ -1484,7 +1575,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 			rprintf(FINFO, "backed up %s to %s\n",
 				fname, backupptr);
 		}
-		free(back_file);
+		unmake_file(back_file);
 	}
 
 	close(fd);
@@ -1522,6 +1613,7 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 		maybe_ATTRS_REPORT = ATTRS_REPORT;
 		code = FINFO;
 	}
+	solo_file = local_name != NULL;
 
 	if (verbose > 2) {
 		rprintf(FINFO, "generator starting pid=%ld count=%d\n",
@@ -1530,6 +1622,8 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 
 	if (delete_before && !local_name && flist->count > 0)
 		do_delete_pass(flist);
+	if (delete_during == 2)
+		start_delete_temp();
 	do_progress = 0;
 
 	if (append_mode || whole_file < 0)
@@ -1550,7 +1644,7 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 	for (i = 0; i < flist->count; i++) {
 		struct file_struct *file = flist->files[i];
 
-		if (!file->basename)
+		if (!F_IS_ACTIVE(file))
 			continue;
 
 		if (local_name)
@@ -1577,8 +1671,10 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 		}
 #endif
 
+#ifdef SUPPORT_HARD_LINKS
 		if (preserve_hard_links)
 			check_for_finished_hlinks(itemizing, code);
+#endif
 
 		if (allowed_lull && !(i % lull_mod))
 			maybe_send_keepalive();
@@ -1599,9 +1695,9 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 	make_backups = 0; /* avoid a duplicate backup for inplace processing */
 
 	if (verbose > 2)
-		rprintf(FINFO,"generate_files phase=%d\n",phase);
+		rprintf(FINFO, "generate_files phase=%d\n", phase);
 
-	write_int(f_out, -1);
+	write_int(f_out, NDX_DONE);
 
 	/* files can cycle through the system more than once
 	 * to catch initial checksum errors */
@@ -1621,12 +1717,12 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 	make_backups = save_make_backups;
 
 	if (verbose > 2)
-		rprintf(FINFO,"generate_files phase=%d\n",phase);
+		rprintf(FINFO, "generate_files phase=%d\n", phase);
 
-	write_int(f_out, -1);
+	write_int(f_out, NDX_DONE);
 	/* Reduce round-trip lag-time for a useless delay-updates phase. */
 	if (protocol_version >= 29 && !delay_updates)
-		write_int(f_out, -1);
+		write_int(f_out, NDX_DONE);
 
 	/* Read MSG_DONE for the redo phase (and any prior messages). */
 	get_redo_num(itemizing, code);
@@ -1636,12 +1732,14 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 		if (verbose > 2)
 			rprintf(FINFO, "generate_files phase=%d\n", phase);
 		if (delay_updates)
-			write_int(f_out, -1);
+			write_int(f_out, NDX_DONE);
 		/* Read MSG_DONE for delay-updates phase & prior messages. */
 		get_redo_num(itemizing, code);
 	}
 
 	do_progress = save_do_progress;
+	if (delete_delay_fp)
+		delayed_deletions(fbuf);
 	if (delete_after && !local_name && flist->count > 0)
 		do_delete_pass(flist);
 
@@ -1652,12 +1750,11 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 		 * modified-time values. */
 		for (i = 0; i < flist->count; i++) {
 			struct file_struct *file = flist->files[i];
-
-			if (!file->basename || !S_ISDIR(file->mode))
+			if (!F_IS_ACTIVE(file) || !S_ISDIR(file->mode))
 				continue;
 			if (!need_retouch_dir_times && file->mode & S_IWUSR)
 				continue;
-			if (file->flags & FLAG_MISSING) {
+			if (file->flags & FLAG_MISSING_DIR) {
 				int missing = file->dir.depth;
 				while (++i < flist->count) {
 					file = flist->files[i];
@@ -1685,5 +1782,5 @@ void generate_files(int f_out, struct file_list *flist, char *local_name)
 	}
 
 	if (verbose > 2)
-		rprintf(FINFO,"generate_files finished\n");
+		rprintf(FINFO, "generate_files finished\n");
 }