X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/3ef526f5fa28b6a77ef55d3bf37ec37789dde8ae..7ef6aa6405c90db2d64cc1ec230cef258af43791:/clientserver.c

diff --git a/clientserver.c b/clientserver.c
index 0f543610..4a16b6a6 100644
--- a/clientserver.c
+++ b/clientserver.c
@@ -42,10 +42,10 @@ int start_socket_client(char *host, char *path, int argc, char *argv[])
 	char *p, *user=NULL;
 	extern int remote_version;
 	extern int am_sender;
-	extern struct in_addr socket_address;
 	extern char *shell_cmd;
 	extern int kludge_around_eof;
-	
+	extern char *bind_address;
+       
 	if (argc == 0 && !am_sender) {
 		extern int list_only;
 		list_only = 1;
@@ -78,7 +78,7 @@ int start_socket_client(char *host, char *path, int argc, char *argv[])
 	if (!user) user = getenv("USER");
 	if (!user) user = getenv("LOGNAME");
 
-	fd = open_socket_out_wrapped (host, rsync_port, &socket_address);
+	fd = open_socket_out_wrapped (host, rsync_port, bind_address);
 	if (fd == -1) {
 		exit_cleanup(RERR_SOCKETIO);
 	}
@@ -244,10 +244,18 @@ static int rsync_module(int fd, int i)
 	log_init();
 
 	if (use_chroot) {
-		/* TODO: If we're not running as root, then we'll get
-		 * an error here.  I wonder if we should perhaps just
-		 * log a warning here, and continue anyhow using the
-		 * push_dir feature? -- mbp 2001-08-31 */
+		/*
+		 * XXX: The 'use chroot' flag is a fairly reliable
+		 * source of confusion, because it fails under two
+		 * important circumstances: running as non-root,
+		 * running on Win32 (or possibly others).  On the
+		 * other hand, if you are running as root, then it
+		 * might be better to always use chroot.
+		 *
+		 * So, perhaps if we can't chroot we should just issue
+		 * a warning, unless a "require chroot" flag is set,
+		 * in which case we fail.
+		 */
 		if (chroot(lp_path(i))) {
 			rsyserr(FERROR, errno, "chroot %s failed", lp_path(i));
 			io_printf(fd,"@ERROR: chroot failed\n");