X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/3296f91bb01a376e0fe751ba2155ec25d7bcbb6b..6d7b3d52dc3a9caa73e765b60994b9781643753b:/options.c

diff --git a/options.c b/options.c
index 44619b6f..4d3d0385 100644
--- a/options.c
+++ b/options.c
@@ -142,6 +142,7 @@ int basis_dir_cnt = 0;
 int verbose = 0;
 int quiet = 0;
 int itemize_changes = 0;
+int log_before_transfer = 0;
 int always_checksum = 0;
 int list_only = 0;
 
@@ -151,7 +152,7 @@ char *batch_name = NULL;
 static int daemon_opt;   /* sets am_daemon after option error-reporting */
 static int F_option_cnt = 0;
 static int modify_window_set;
-static int refused_verbose, refused_delete, refused_archive_part;
+static int refused_delete, refused_archive_part;
 static int refused_partial, refused_progress, refused_delete_before;
 static char *dest_option = NULL;
 static char *max_size_arg;
@@ -547,9 +548,6 @@ static void set_refuse_options(char *bp)
 				/* These flags are set to let us easily check
 				 * an implied option later in the code. */
 				switch (*shortname) {
-				case 'v':
-					refused_verbose = op->val;
-					break;
 				case 'r': case 'd': case 'l': case 'p':
 				case 't': case 'g': case 'o': case 'D':
 					refused_archive_part = op->val;
@@ -1057,12 +1055,24 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
 		return 0;
 	}
 
-	if (do_progress && !verbose && !itemize_changes) {
-		if (refused_verbose) {
-			create_refuse_error(refused_verbose);
-			return 0;
-		}
+	if (log_format) {
+		if (strstr(log_format, "%i") != NULL)
+			itemize_changes = 1;
+		if (strstr(log_format, "%b") == NULL
+		 && strstr(log_format, "%c") == NULL)
+			log_before_transfer = !am_server;
+	} else if (itemize_changes) {
+		log_format = "%i %n%L";
+		log_before_transfer = !am_server;
+	}
+
+	if ((do_progress || dry_run) && !verbose && !log_before_transfer
+	    && !am_server)
 		verbose = 1;
+
+	if (verbose && !log_format) {
+		log_format = "%n%L";
+		log_before_transfer = !am_server;
 	}
 
 	if (daemon_bwlimit && (!bwlimit || bwlimit > daemon_bwlimit))
@@ -1214,7 +1224,7 @@ void server_options(char **args,int *argc)
 	 * default for remote transfers, and in any case old versions
 	 * of rsync will not understand it. */
 
-	if (itemize_changes && am_sender)
+	if (itemize_changes)
 		argstr[x++] = 'i';
 	if (preserve_hard_links)
 		argstr[x++] = 'H';
@@ -1261,6 +1271,11 @@ void server_options(char **args,int *argc)
 	if (list_only > 1)
 		args[ac++] = "--list-only";
 
+	/* The server side doesn't use our log-format, but if verbose isn't
+	 * on, they may need to know that we want some extra messages. */
+	if (log_format && !verbose && !itemize_changes)
+		args[ac++] = "--log-format=specified";
+
 	if (block_size) {
 		if (asprintf(&arg, "-B%lu", block_size) < 0)
 			goto oom;