X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/1c3344a105f656a45f6b46e1710c3fc4ab862a9a..a217c4535951943e00d6dd991cc6f775034ca4a9:/acls.c

diff --git a/acls.c b/acls.c
index e73eec3d..bfb12c7b 100644
--- a/acls.c
+++ b/acls.c
@@ -6,9 +6,8 @@
  * Copyright (C) 2006 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -510,7 +509,7 @@ static int get_rsync_acl(const char *fname, rsync_acl *racl,
 		if (!ok) {
 			return -1;
 		}
-	} else if (errno == ENOTSUP || errno == ENOSYS) {
+	} else if (no_acl_syscall_error(errno)) {
 		/* ACLs are not supported, so pretend we have a basic ACL. */
 		if (type == SMB_ACL_TYPE_ACCESS)
 			rsync_acl_fake_perms(racl, mode);
@@ -631,7 +630,6 @@ static void send_rsync_acl(rsync_acl *racl, SMB_ACL_TYPE_T type,
  * This also frees the ACL data. */
 void send_acl(statx *sxp, int f)
 {
-
 	if (!sxp->acc_acl) {
 		sxp->acc_acl = create_racl();
 		rsync_acl_fake_perms(sxp->acc_acl, sxp->st.st_mode);
@@ -674,7 +672,6 @@ static uchar recv_acl_access(uchar *name_follows_val, int f)
 static uchar recv_ida_entries(ida_entries *ent, int user_names, int f)
 {
 	uchar computed_mask_bits = 0;
-	uchar has_name;
 	int i, count = read_abbrevint(f);
 
 	if (count) {
@@ -686,6 +683,7 @@ static uchar recv_ida_entries(ida_entries *ent, int user_names, int f)
 	ent->count = count;
 
 	for (i = 0; i < count; i++) {
+		uchar has_name;
 		id_t id = read_abbrevint(f);
 		int access = recv_acl_access(&has_name, f);
 
@@ -719,7 +717,7 @@ static int recv_rsync_acl(item_list *racl_list, SMB_ACL_TYPE_T type, int f)
 
 	if (ndx < 0 || (size_t)ndx > racl_list->count) {
 		rprintf(FERROR, "recv_acl_index: %s ACL index %d > %d\n",
-			str_acl_type(type), ndx, racl_list->count);
+			str_acl_type(type), ndx, (int)racl_list->count);
 		exit_cleanup(RERR_STREAMIO);
 	}
 
@@ -969,63 +967,30 @@ int set_acl(const char *fname, const struct file_struct *file, statx *sxp)
 	return unchanged;
 }
 
-/* === Enumeration functions for uid mapping === */
-
-/* Context -- one and only one.  Should be cycled through once on uid
- * mapping and once on gid mapping. */
-static item_list *_enum_racl_lists[] = {
-	&access_acl_list, &default_acl_list, NULL
-};
-
-static item_list **enum_racl_list = &_enum_racl_lists[0];
-static int enum_ida_index = 0;
-static size_t enum_racl_index = 0;
-
-/* This returns the next tag_type id from the given ACL for the next entry,
- * or it returns 0 if there are no more tag_type ids in the acl. */
-static id_t *next_ace_id(SMB_ACL_TAG_T tag_type, const rsync_acl *racl)
-{
-	const ida_entries *idal = tag_type == SMB_ACL_USER ? &racl->users : &racl->groups;
-	if (enum_ida_index < idal->count) {
-		id_access *ida = &idal->idas[enum_ida_index++];
-		return &ida->id;
-	}
-	enum_ida_index = 0;
-	return NULL;
-}
-
-static id_t *next_acl_id(SMB_ACL_TAG_T tag_type, const item_list *racl_list)
+/* Non-incremental recursion needs to convert all the received IDs
+ * in a single pass after the file-list is complete. */
+static void match_racl_ids(const item_list *racl_list)
 {
-	for (; enum_racl_index < racl_list->count; enum_racl_index++) {
-		id_t *id;
-		acl_duo *duo_item = racl_list->items;
-		duo_item += enum_racl_index;
-		if ((id = next_ace_id(tag_type, &duo_item->racl)) != NULL)
-			return id;
-	}
-	enum_racl_index = 0;
-	return NULL;
-}
-
-static id_t *next_acl_list_id(SMB_ACL_TAG_T tag_type)
-{
-	for (; *enum_racl_list; enum_racl_list++) {
-		id_t *id = next_acl_id(tag_type, *enum_racl_list);
-		if (id)
-			return id;
+	int list_cnt, name_cnt;
+	acl_duo *duo_item = racl_list->items;
+	for (list_cnt = racl_list->count; list_cnt--; duo_item++) {
+		ida_entries *idal = &duo_item->racl.users;
+		for (name_cnt = idal->count; name_cnt--; idal++) {
+			id_access *ida = idal->idas;
+			ida->id = match_uid(ida->id);
+		}
+		idal = &duo_item->racl.groups;
+		for (name_cnt = idal->count; name_cnt--; idal++) {
+			id_access *ida = idal->idas;
+			ida->id = match_gid(ida->id);
+		}
 	}
-	enum_racl_list = &_enum_racl_lists[0];
-	return NULL;
 }
 
-id_t *next_acl_uid()
+void match_acl_ids(void)
 {
-	return next_acl_list_id(SMB_ACL_USER);
-}
-
-id_t *next_acl_gid()
-{
-	return next_acl_list_id(SMB_ACL_GROUP);
+	match_racl_ids(&access_acl_list);
+	match_racl_ids(&default_acl_list);
 }
 
 /* This is used by dest_mode(). */
@@ -1044,7 +1009,9 @@ int default_perms_for_dir(const char *dir)
 	if (sacl == NULL) {
 		/* Couldn't get an ACL.  Darn. */
 		switch (errno) {
+#ifdef ENOTSUP
 		case ENOTSUP:
+#endif
 		case ENOSYS:
 			/* No ACLs are available. */
 			break;