X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/0c5a792ac7e8d9f415aaafd18f7500256de133af..fd2dd2aa231954db2bcc0b60f2a696bc38161aa9:/log.c diff --git a/log.c b/log.c index aef3ac8a..a826b185 100644 --- a/log.c +++ b/log.c @@ -67,6 +67,59 @@ static char const *rerr_name(int code) return NULL; } +struct err_list { + struct err_list *next; + char *buf; + int len; + int written; /* how many bytes we have written so far */ +}; + +static struct err_list *err_list_head; +static struct err_list *err_list_tail; + +/* add an error message to the pending error list */ +static void err_list_add(int code, char *buf, int len) +{ + struct err_list *el; + el = (struct err_list *)malloc(sizeof(*el)); + if (!el) exit_cleanup(RERR_MALLOC); + el->next = NULL; + el->buf = malloc(len+4); + if (!el->buf) exit_cleanup(RERR_MALLOC); + memcpy(el->buf+4, buf, len); + SIVAL(el->buf, 0, ((code+MPLEX_BASE)<<24) | len); + el->len = len+4; + el->written = 0; + if (err_list_tail) { + err_list_tail->next = el; + } else { + err_list_head = el; + } + err_list_tail = el; +} + + +/* try to push errors off the error list onto the wire */ +void err_list_push(void) +{ + if (log_error_fd == -1) return; + + while (err_list_head) { + struct err_list *el = err_list_head; + int n = write(log_error_fd, el->buf+el->written, el->len - el->written); + if (n == -1) break; + if (n > 0) { + el->written += n; + } + if (el->written == el->len) { + free(el->buf); + err_list_head = el->next; + if (!err_list_head) err_list_tail = NULL; + free(el); + } + } +} + static void logit(int priority, char *buf) { @@ -144,6 +197,7 @@ void log_close() void set_error_fd(int fd) { log_error_fd = fd; + set_nonblocking(log_error_fd); } /* this is the underlying (unformatted) rsync debugging function. Call @@ -167,8 +221,10 @@ void rwrite(enum logcode code, char *buf, int len) return; } - /* first try to pass it off the our sibling */ - if (am_server && io_error_write(log_error_fd, code, buf, len)) { + /* first try to pass it off to our sibling */ + if (am_server && log_error_fd != -1) { + err_list_add(code, buf, len); + err_list_push(); return; }