X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/blobdiff_plain/0ba481368c2a44d6d6a2f361fa12df432d9d304b..1ac15cd8adfb364965189261a860a94ca37c9b6b:/main.c

diff --git a/main.c b/main.c
index ca2b456f..d12dea36 100644
--- a/main.c
+++ b/main.c
@@ -1,6 +1,6 @@
 /* -*- c-file-style: "linux" -*-
    
-   Copyright (C) 1996-2000 by Andrew Tridgell 
+   Copyright (C) 1996-2001 by Andrew Tridgell <tridge@samba.org>
    Copyright (C) Paul Mackerras 1996
    
    This program is free software; you can redistribute it and/or modify
@@ -36,6 +36,12 @@ void wait_process(pid_t pid, int *status)
 		msleep(20);
 		io_flush();
 	}
+        
+        /* TODO: If the child exited on a signal, then log an
+         * appropriate error message.  Perhaps we should also accept a
+         * message describing the purpose of the child.  Also indicate
+         * this to the caller so that thhey know something went
+         * wrong.  */
 	*status = WEXITSTATUS(*status);
 }
 
@@ -119,6 +125,20 @@ static void report(int f)
 }
 
 
+/* Start the remote shell. */
+/* TODO: When the shell exits, look at its return value, as this may
+ * well tell us if something went wrong in trying to connect to the
+ * remote machine.  Although it doesn't seem to be specified anywhere,
+ * ssh and the shell seem to return these values:
+ *
+ * 124 if the command exited with status 255
+ * 125 if the command is killed by a signal
+ * 126 if the command cannot be run
+ * 127 if the command is not found
+ *
+ * and we could use this to give a better explanation if the remote
+ * command is not found.
+ */
 static int do_cmd(char *cmd,char *machine,char *user,char *path,int *f_in,int *f_out)
 {
 	char *args[100];
@@ -707,14 +727,13 @@ int main(int argc,char *argv[])
 	   carried across */
 	orig_umask = (int)umask(0);
 
-	if (!parse_arguments(argc, argv, 1)) {
+	if (!parse_arguments(&argc, (const char ***) &argv, 1)) {
+                /* FIXME: We ought to call the same error-handling
+                 * code here, rather than relying on getopt. */
+		option_error();
 		exit_cleanup(RERR_SYNTAX);
 	}
 
-	argc -= optind;
-	argv += optind;
-	optind = 0;
-
 	signal(SIGCHLD,SIG_IGN);
 	signal(SIGINT,SIGNAL_CAST sig_int);
 	signal(SIGPIPE,SIGNAL_CAST sig_int);