Fixed several issues with preserving xattrs when using --backup.
[rsync/rsync.git] / generator.c
index 80ce378..27e5b97 100644 (file)
@@ -4,11 +4,11 @@
  * Copyright (C) 1996-2000 Andrew Tridgell
  * Copyright (C) 1996 Paul Mackerras
  * Copyright (C) 2002 Martin Pool <mbp@samba.org>
- * Copyright (C) 2003, 2004, 2005, 2006 Wayne Davison
+ * Copyright (C) 2003-2008 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -17,8 +17,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
+ * with this program; if not, visit the http://fsf.org website.
  */
 
 #include "rsync.h"
@@ -31,25 +30,27 @@ extern int logfile_format_has_i;
 extern int am_root;
 extern int am_server;
 extern int am_daemon;
-extern int incremental;
+extern int inc_recurse;
 extern int do_progress;
 extern int relative_paths;
 extern int implied_dirs;
 extern int keep_dirlinks;
+extern int preserve_acls;
+extern int preserve_xattrs;
 extern int preserve_links;
 extern int preserve_devices;
 extern int preserve_specials;
 extern int preserve_hard_links;
+extern int preserve_executability;
 extern int preserve_perms;
-extern int preserve_uid;
-extern int preserve_gid;
 extern int preserve_times;
-extern int omit_dir_times;
+extern int uid_ndx;
+extern int gid_ndx;
 extern int delete_mode;
 extern int delete_before;
 extern int delete_during;
 extern int delete_after;
-extern int done_cnt;
+extern int msgdone_cnt;
 extern int ignore_errors;
 extern int remove_source_files;
 extern int delay_updates;
@@ -81,20 +82,22 @@ extern int copy_dest;
 extern int link_dest;
 extern int whole_file;
 extern int list_only;
-extern int new_root_dir;
 extern int read_batch;
 extern int safe_symlinks;
 extern long block_size; /* "long" because popt can't set an int32. */
+extern int unsort_ndx;
 extern int max_delete;
 extern int force_delete;
 extern int one_file_system;
 extern struct stats stats;
 extern dev_t filesystem_dev;
+extern mode_t orig_umask;
+extern uid_t our_uid;
 extern char *backup_dir;
 extern char *backup_suffix;
 extern int backup_suffix_len;
 extern struct file_list *cur_flist, *first_flist, *dir_flist;
-extern struct filter_list_struct server_filter_list;
+extern struct filter_list_struct daemon_filter_list;
 
 int ignore_perishable = 0;
 int non_perishable_cnt = 0;
@@ -105,11 +108,24 @@ static int deletion_count = 0; /* used to implement --max-delete */
 static int deldelay_size = 0, deldelay_cnt = 0;
 static char *deldelay_buf = NULL;
 static int deldelay_fd = -1;
-static BOOL solo_file = 0;
+static int lull_mod;
+static int dir_tweaking;
+static int symlink_timeset_failed_flags;
+static int need_retouch_dir_times;
+static int need_retouch_dir_perms;
+static const char *solo_file = NULL;
 
 /* For calling delete_item() and delete_dir_contents(). */
-#define DEL_RECURSE            (1<<1) /* recurse */
+#define DEL_NO_UID_WRITE       (1<<0) /* file/dir has our uid w/o write perm */
+#define DEL_RECURSE            (1<<1) /* if dir, delete all contents */
 #define DEL_DIR_IS_EMPTY       (1<<2) /* internal delete_FUNCTIONS use only */
+#define DEL_FOR_FILE           (1<<3) /* making room for a replacement file */
+#define DEL_FOR_DIR            (1<<4) /* making room for a replacement dir */
+#define DEL_FOR_SYMLINK        (1<<5) /* making room for a replacement symlink */
+#define DEL_FOR_DEVICE         (1<<6) /* making room for a replacement device */
+#define DEL_FOR_SPECIAL        (1<<7) /* making room for a replacement special */
+
+#define DEL_MAKE_ROOM (DEL_FOR_FILE|DEL_FOR_DIR|DEL_FOR_SYMLINK|DEL_FOR_DEVICE|DEL_FOR_SPECIAL)
 
 enum nonregtype {
     TYPE_DIR, TYPE_SPECIAL, TYPE_DEVICE, TYPE_SYMLINK
@@ -119,9 +135,12 @@ enum delret {
     DR_SUCCESS = 0, DR_FAILURE, DR_AT_LIMIT, DR_NOT_EMPTY
 };
 
-/* Forward declaration for delete_item(). */
-static enum delret delete_dir_contents(char *fname, int flags);
-
+/* Forward declarations. */
+static enum delret delete_dir_contents(char *fname, uint16 flags);
+#ifdef SUPPORT_HARD_LINKS
+static void handle_skipped_hlink(struct file_struct *file, int itemizing,
+                                enum logcode code, int f_out);
+#endif
 
 static int is_backup_file(char *fn)
 {
@@ -135,7 +154,7 @@ static int is_backup_file(char *fn)
  * Note that fbuf must point to a MAXPATHLEN buffer if the mode indicates it's
  * a directory! (The buffer is used for recursion, but returned unchanged.)
  */
-static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
+static enum delret delete_item(char *fbuf, uint16 mode, uint16 flags)
 {
        enum delret ret;
        char *what;
@@ -143,20 +162,32 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
 
        if (verbose > 2) {
                rprintf(FINFO, "delete_item(%s) mode=%o flags=%d\n",
-                       fbuf, mode, flags);
+                       fbuf, (int)mode, (int)flags);
        }
 
+       if (flags & DEL_NO_UID_WRITE)
+               do_chmod(fbuf, mode | S_IWUSR);
+
        if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) {
+               int save_uid_ndx = uid_ndx;
+               /* This only happens on the first call to delete_item() since
+                * delete_dir_contents() always calls us w/DEL_DIR_IS_EMPTY. */
+               if (!uid_ndx)
+                       uid_ndx = ++file_extra_cnt;
                ignore_perishable = 1;
                /* If DEL_RECURSE is not set, this just reports emptiness. */
                ret = delete_dir_contents(fbuf, flags);
                ignore_perishable = 0;
+               if (!save_uid_ndx) {
+                       --file_extra_cnt;
+                       uid_ndx = 0;
+               }
                if (ret == DR_NOT_EMPTY || ret == DR_AT_LIMIT)
                        goto check_ret;
                /* OK: try to delete the directory. */
        }
 
-       if (!replace && max_delete >= 0 && ++deletion_count > max_delete)
+       if (!(flags & DEL_MAKE_ROOM) && max_delete >= 0 && ++deletion_count > max_delete)
                return DR_AT_LIMIT;
 
        if (S_ISDIR(mode)) {
@@ -171,7 +202,7 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
        }
 
        if (ok) {
-               if (!replace)
+               if (!(flags & DEL_MAKE_ROOM))
                        log_delete(fbuf, mode);
                ret = DR_SUCCESS;
        } else {
@@ -190,9 +221,18 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
        }
 
   check_ret:
-       if (replace && ret != DR_SUCCESS) {
-               rprintf(FERROR, "could not make way for new %s: %s\n",
-                       replace, fbuf);
+       if (ret != DR_SUCCESS && flags & DEL_MAKE_ROOM) {
+               const char *desc;
+               switch (flags & DEL_MAKE_ROOM) {
+               case DEL_FOR_FILE: desc = "regular file"; break;
+               case DEL_FOR_DIR: desc = "directory"; break;
+               case DEL_FOR_SYMLINK: desc = "symlink"; break;
+               case DEL_FOR_DEVICE: desc = "device file"; break;
+               case DEL_FOR_SPECIAL: desc = "special file"; break;
+               default: exit_cleanup(RERR_UNSUPPORTED); /* IMPOSSIBLE */
+               }
+               rprintf(FERROR_XFER, "could not make way for new %s: %s\n",
+                       desc, fbuf);
        }
        return ret;
 }
@@ -202,7 +242,7 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
  * DR_NOT_EMPTY.  Note that fname must point to a MAXPATHLEN buffer!  (The
  * buffer is used for recursion, but returned unchanged.)
  */
-static enum delret delete_dir_contents(char *fname, int flags)
+static enum delret delete_dir_contents(char *fname, uint16 flags)
 {
        struct file_list *dirlist;
        enum delret ret;
@@ -223,7 +263,7 @@ static enum delret delete_dir_contents(char *fname, int flags)
        dirlist = get_dirlist(fname, dlen, 0);
        ret = non_perishable_cnt ? DR_NOT_EMPTY : DR_SUCCESS;
 
-       if (!dirlist->count)
+       if (!dirlist->used)
                goto done;
 
        if (!(flags & DEL_RECURSE)) {
@@ -237,12 +277,13 @@ static enum delret delete_dir_contents(char *fname, int flags)
        remainder = MAXPATHLEN - (p - fname);
 
        /* We do our own recursion, so make delete_item() non-recursive. */
-       flags = (flags & ~DEL_RECURSE) | DEL_DIR_IS_EMPTY;
+       flags = (flags & ~(DEL_RECURSE|DEL_MAKE_ROOM|DEL_NO_UID_WRITE))
+             | DEL_DIR_IS_EMPTY;
 
-       for (j = dirlist->count; j--; ) {
+       for (j = dirlist->used; j--; ) {
                struct file_struct *fp = dirlist->files[j];
 
-               if (fp->flags & FLAG_MOUNT_DIR) {
+               if (fp->flags & FLAG_MOUNT_DIR && S_ISDIR(fp->mode)) {
                        if (verbose > 1) {
                                rprintf(FINFO,
                                    "mount point, %s, pins parent directory\n",
@@ -253,11 +294,14 @@ static enum delret delete_dir_contents(char *fname, int flags)
                }
 
                strlcpy(p, fp->basename, remainder);
+               if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid)
+                       do_chmod(fname, fp->mode | S_IWUSR);
                /* Save stack by recursing to ourself directly. */
-               if (S_ISDIR(fp->mode)
-                && delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
-                       ret = DR_NOT_EMPTY;
-               if (delete_item(fname, fp->mode, NULL, flags) != DR_SUCCESS)
+               if (S_ISDIR(fp->mode)) {
+                       if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
+                               ret = DR_NOT_EMPTY;
+               }
+               if (delete_item(fname, fp->mode, flags) != DR_SUCCESS)
                        ret = DR_NOT_EMPTY;
        }
 
@@ -282,10 +326,10 @@ static int start_delete_delay_temp(void)
        dry_run = 0;
        if (!get_tmpname(fnametmp, "deldelay")
         || (deldelay_fd = do_mkstemp(fnametmp, 0600)) < 0) {
-               rprintf(FINFO, "NOTE: Unable to create delete-delay temp file--"
-                       "switching to --delete-after.\n");
+               rprintf(FINFO, "NOTE: Unable to create delete-delay temp file%s.\n",
+                       inc_recurse ? "" : " -- switching to --delete-after");
                delete_during = 0;
-               delete_after = 1;
+               delete_after = !inc_recurse;
                dry_run = save_dry_run;
                return 0;
        }
@@ -296,10 +340,12 @@ static int start_delete_delay_temp(void)
 
 static int flush_delete_delay(void)
 {
+       if (deldelay_fd < 0 && !start_delete_delay_temp())
+               return 0;
        if (write(deldelay_fd, deldelay_buf, deldelay_cnt) != deldelay_cnt) {
                rsyserr(FERROR, errno, "flush of delete-delay buffer");
                delete_during = 0;
-               delete_after = 1;
+               delete_after = !inc_recurse;
                close(deldelay_fd);
                return 0;
        }
@@ -307,18 +353,23 @@ static int flush_delete_delay(void)
        return 1;
 }
 
-static int remember_delete(struct file_struct *file, const char *fname)
+static int remember_delete(struct file_struct *file, const char *fname, int flags)
 {
        int len;
-       
+
+       if (deldelay_cnt == deldelay_size && !flush_delete_delay())
+               return 0;
+
+       if (flags & DEL_NO_UID_WRITE)
+               deldelay_buf[deldelay_cnt++] = '!';
+
        while (1) {
                len = snprintf(deldelay_buf + deldelay_cnt,
                               deldelay_size - deldelay_cnt,
-                              "%x %s%c", (int)file->mode, fname, '\0');
+                              "%x %s%c",
+                              (int)file->mode, fname, '\0');
                if ((deldelay_cnt += len) <= deldelay_size)
                        break;
-               if (deldelay_fd < 0 && !start_delete_delay_temp())
-                       return 0;
                deldelay_cnt -= len;
                if (!flush_delete_delay())
                        return 0;
@@ -327,7 +378,7 @@ static int remember_delete(struct file_struct *file, const char *fname)
        return 1;
 }
 
-static int read_delay_line(char *buf)
+static int read_delay_line(char *buf, int *flags_p)
 {
        static int read_pos = 0;
        int j, len, mode;
@@ -368,6 +419,11 @@ static int read_delay_line(char *buf)
        }
 
        bp = deldelay_buf + read_pos;
+       if (*bp == '!') {
+               bp++;
+               *flags_p = DEL_NO_UID_WRITE;
+       } else
+               *flags_p = 0;
 
        if (sscanf(bp, "%x ", &mode) != 1) {
          invalid_data:
@@ -392,15 +448,15 @@ static int read_delay_line(char *buf)
 
 static void do_delayed_deletions(char *delbuf)
 {
-       int mode;
+       int mode, flags;
 
        if (deldelay_fd >= 0) {
                if (deldelay_cnt && !flush_delete_delay())
                        return;
                lseek(deldelay_fd, 0, 0);
        }
-       while ((mode = read_delay_line(delbuf)) >= 0)
-               delete_item(delbuf, mode, NULL, DEL_RECURSE);
+       while ((mode = read_delay_line(delbuf, &flags)) >= 0)
+               delete_item(delbuf, mode, flags | DEL_RECURSE);
        if (deldelay_fd >= 0)
                close(deldelay_fd);
 }
@@ -410,15 +466,15 @@ static void do_delayed_deletions(char *delbuf)
  * MAXPATHLEN buffer with the name of the directory in it (the functions we
  * call will append names onto the end, but the old dir value will be restored
  * on exit). */
-static void delete_in_dir(struct file_list *flist, char *fbuf,
-                         struct file_struct *file, dev_t *fs_dev)
+static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
 {
        static int already_warned = 0;
        struct file_list *dirlist;
        char delbuf[MAXPATHLEN];
        int dlen, i;
+       int save_uid_ndx = uid_ndx;
 
-       if (!flist) {
+       if (!fbuf) {
                change_local_filter_dir(NULL, 0, 0);
                return;
        }
@@ -448,36 +504,47 @@ static void delete_in_dir(struct file_list *flist, char *fbuf,
                        return;
        }
 
+       if (!uid_ndx)
+               uid_ndx = ++file_extra_cnt;
+
        dirlist = get_dirlist(fbuf, dlen, 0);
 
        /* If an item in dirlist is not found in flist, delete it
         * from the filesystem. */
-       for (i = dirlist->count; i--; ) {
+       for (i = dirlist->used; i--; ) {
                struct file_struct *fp = dirlist->files[i];
                if (!F_IS_ACTIVE(fp))
                        continue;
-               if (fp->flags & FLAG_MOUNT_DIR) {
+               if (fp->flags & FLAG_MOUNT_DIR && S_ISDIR(fp->mode)) {
                        if (verbose > 1)
                                rprintf(FINFO, "cannot delete mount point: %s\n",
                                        f_name(fp, NULL));
                        continue;
                }
-               if (flist_find(flist, fp) < 0) {
+               if (flist_find(cur_flist, fp) < 0) {
+                       int flags = DEL_RECURSE;
+                       if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid)
+                               flags |= DEL_NO_UID_WRITE;
                        f_name(fp, delbuf);
                        if (delete_during == 2) {
-                               if (!remember_delete(fp, delbuf))
+                               if (!remember_delete(fp, delbuf, flags))
                                        break;
                        } else
-                               delete_item(delbuf, fp->mode, NULL, DEL_RECURSE);
+                               delete_item(delbuf, fp->mode, flags);
                }
        }
 
        flist_free(dirlist);
+
+       if (!save_uid_ndx) {
+               --file_extra_cnt;
+               uid_ndx = 0;
+       }
 }
 
 /* This deletes any files on the receiving side that are not present on the
  * sending side.  This is used by --delete-before and --delete-after. */
-static void do_delete_pass(struct file_list *flist)
+static void do_delete_pass(void)
 {
        char fbuf[MAXPATHLEN];
        STRUCT_STAT st;
@@ -487,13 +554,16 @@ static void do_delete_pass(struct file_list *flist)
        if (dry_run > 1 || list_only)
                return;
 
-       for (j = 0; j < flist->count; j++) {
-               struct file_struct *file = flist->files[j];
+       for (j = 0; j < cur_flist->used; j++) {
+               struct file_struct *file = cur_flist->sorted[j];
+
+               f_name(file, fbuf);
 
-               if (!(file->flags & FLAG_XFER_DIR))
+               if (!(file->flags & FLAG_CONTENT_DIR)) {
+                       change_local_filter_dir(fbuf, strlen(fbuf), F_DEPTH(file));
                        continue;
+               }
 
-               f_name(file, fbuf);
                if (verbose > 1 && file->flags & FLAG_TOP_DIR)
                        rprintf(FINFO, "deleting in %s\n", fbuf);
 
@@ -501,65 +571,135 @@ static void do_delete_pass(struct file_list *flist)
                 || !S_ISDIR(st.st_mode))
                        continue;
 
-               delete_in_dir(flist, fbuf, file, &st.st_dev);
+               delete_in_dir(fbuf, file, &st.st_dev);
        }
-       delete_in_dir(NULL, NULL, NULL, &dev_zero);
+       delete_in_dir(NULL, NULL, &dev_zero);
 
        if (do_progress && !am_server)
                rprintf(FINFO, "                    \r");
 }
 
-int unchanged_attrs(struct file_struct *file, STRUCT_STAT *st)
+int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
 {
-       if (preserve_perms && !BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
+#if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
+       if (S_ISLNK(file->mode)) {
+               ;
+       } else
+#endif
+       if (preserve_times && cmp_time(sxp->st.st_mtime, file->modtime) != 0)
                return 0;
 
-       if (am_root && preserve_uid && st->st_uid != F_UID(file))
+       if (preserve_perms) {
+               if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
+                       return 0;
+       } else if (preserve_executability
+        && ((sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0)))
                return 0;
 
-       if (preserve_gid && F_GID(file) != GID_NONE && st->st_gid != F_GID(file))
+       if (am_root && uid_ndx && sxp->st.st_uid != (uid_t)F_OWNER(file))
                return 0;
 
+       if (gid_ndx && !(file->flags & FLAG_SKIP_GROUP) && sxp->st.st_gid != (gid_t)F_GROUP(file))
+               return 0;
+
+#ifdef SUPPORT_ACLS
+       if (preserve_acls && !S_ISLNK(file->mode)) {
+               if (!ACL_READY(*sxp))
+                       get_acl(fname, sxp);
+               if (set_acl(NULL, file, sxp) == 0)
+                       return 0;
+       }
+#endif
+#ifdef SUPPORT_XATTRS
+       if (preserve_xattrs) {
+               if (!XATTR_READY(*sxp))
+                       get_xattr(fname, sxp);
+               if (xattr_diff(file, sxp, 0))
+                       return 0;
+       }
+#endif
+
        return 1;
 }
 
-void itemize(struct file_struct *file, int ndx, int statret,
-            STRUCT_STAT *st, int32 iflags, uchar fnamecmp_type,
+void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statret,
+            stat_x *sxp, int32 iflags, uchar fnamecmp_type,
             const char *xname)
 {
        if (statret >= 0) { /* A from-dest-dir statret can == 1! */
                int keep_time = !preserve_times ? 0
-                   : S_ISDIR(file->mode) ? !omit_dir_times
-                   : !S_ISLNK(file->mode);
+                   : S_ISDIR(file->mode) ? preserve_times > 1 :
+#if defined HAVE_LUTIMES && defined HAVE_UTIMES
+                   1;
+#else
+                   !S_ISLNK(file->mode);
+#endif
 
-               if (S_ISREG(file->mode) && F_LENGTH(file) != st->st_size)
+               if (S_ISREG(file->mode) && F_LENGTH(file) != sxp->st.st_size)
                        iflags |= ITEM_REPORT_SIZE;
-               if ((iflags & (ITEM_TRANSFER|ITEM_LOCAL_CHANGE) && !keep_time
-                 && !(iflags & ITEM_MATCHED)
+               if (file->flags & FLAG_TIME_FAILED) { /* symlinks only */
+                       if (iflags & ITEM_LOCAL_CHANGE)
+                               iflags |= symlink_timeset_failed_flags;
+               } else if (keep_time
+                ? cmp_time(file->modtime, sxp->st.st_mtime) != 0
+                : iflags & (ITEM_TRANSFER|ITEM_LOCAL_CHANGE) && !(iflags & ITEM_MATCHED)
                  && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
-                || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
                        iflags |= ITEM_REPORT_TIME;
-               if (!BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
+#if !defined HAVE_LCHMOD && !defined HAVE_SETATTRLIST
+               if (S_ISLNK(file->mode)) {
+                       ;
+               } else
+#endif
+               if (preserve_perms) {
+                       if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
+                               iflags |= ITEM_REPORT_PERMS;
+               } else if (preserve_executability
+                && ((sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0)))
                        iflags |= ITEM_REPORT_PERMS;
-               if (preserve_uid && am_root && F_UID(file) != st->st_uid)
+               if (uid_ndx && am_root && (uid_t)F_OWNER(file) != sxp->st.st_uid)
                        iflags |= ITEM_REPORT_OWNER;
-               if (preserve_gid && F_GID(file) != GID_NONE
-                   && st->st_gid != F_GID(file))
+               if (gid_ndx && !(file->flags & FLAG_SKIP_GROUP)
+                   && sxp->st.st_gid != (gid_t)F_GROUP(file))
                        iflags |= ITEM_REPORT_GROUP;
-       } else
+#ifdef SUPPORT_ACLS
+               if (preserve_acls && !S_ISLNK(file->mode)) {
+                       if (!ACL_READY(*sxp))
+                               get_acl(fnamecmp, sxp);
+                       if (set_acl(NULL, file, sxp) == 0)
+                               iflags |= ITEM_REPORT_ACL;
+               }
+#endif
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs) {
+                       if (!XATTR_READY(*sxp))
+                               get_xattr(fnamecmp, sxp);
+                       if (xattr_diff(file, sxp, 1))
+                               iflags |= ITEM_REPORT_XATTR;
+               }
+#endif
+       } else {
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs && xattr_diff(file, NULL, 1))
+                       iflags |= ITEM_REPORT_XATTR;
+#endif
                iflags |= ITEM_IS_NEW;
+       }
 
        iflags &= 0xffff;
-       if ((iflags & SIGNIFICANT_ITEM_FLAGS || verbose > 1
+       if ((iflags & (SIGNIFICANT_ITEM_FLAGS|ITEM_REPORT_XATTR) || verbose > 1
          || stdout_format_has_i > 1 || (xname && *xname)) && !read_batch) {
                if (protocol_version >= 29) {
                        if (ndx >= 0)
-                               write_int(sock_f_out, ndx + cur_flist->ndx_start);
+                               write_ndx(sock_f_out, ndx);
                        write_shortint(sock_f_out, iflags);
                        if (iflags & ITEM_BASIS_TYPE_FOLLOWS)
                                write_byte(sock_f_out, fnamecmp_type);
                        if (iflags & ITEM_XNAME_FOLLOWS)
                                write_vstring(sock_f_out, xname, strlen(xname));
+#ifdef SUPPORT_XATTRS
+                       if (iflags & ITEM_REPORT_XATTR && !dry_run)
+                               send_xattr_request(NULL, file, sock_f_out);
+#endif
                } else if (ndx >= 0) {
                        enum logcode code = logfile_format_has_i ? FINFO : FCLIENT;
                        log_item(code, file, &stats, iflags, xname);
@@ -577,7 +717,7 @@ int unchanged_file(char *fn, struct file_struct *file, STRUCT_STAT *st)
        /* if always checksum is set then we use the checksum instead
           of the file time to determine whether to sync */
        if (always_checksum > 0 && S_ISREG(st->st_mode)) {
-               char sum[MD4_SUM_LENGTH];
+               char sum[MAX_DIGEST_LEN];
                file_checksum(fn, sum, st->st_size);
                return memcmp(sum, F_SUM(file), checksum_len) == 0;
        }
@@ -735,7 +875,7 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
        fname_len = strlen(fname);
        fname_suf = find_filename_suffix(fname, fname_len, &fname_suf_len);
 
-       for (j = 0; j < dirlist->count; j++) {
+       for (j = 0; j < dirlist->used; j++) {
                struct file_struct *fp = dirlist->files[j];
                const char *suf, *name;
                int len, suf_len;
@@ -777,29 +917,45 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
        return lowest_j;
 }
 
-#ifdef SUPPORT_HARD_LINKS
-void check_for_finished_hlinks(int itemizing, enum logcode code)
+/* Copy a file found in our --copy-dest handling. */
+static int copy_altdest_file(const char *src, const char *dest, struct file_struct *file)
 {
-       struct file_struct *file;
-       struct file_list *flist;
-       char fbuf[MAXPATHLEN];
-       int ndx;
-
-       while ((ndx = get_hlink_num()) != -1) {
-               flist = flist_for_ndx(ndx);
-               assert(flist != NULL);
-               file = flist->files[ndx];
-               assert(file->flags & FLAG_HLINKED);
-               finish_hard_link(file, f_name(file, fbuf), NULL, itemizing, code, -1);
+       char buf[MAXPATHLEN];
+       const char *copy_to, *partialptr;
+       int ok, fd_w;
+
+       if (inplace) {
+               /* Let copy_file open the destination in place. */
+               fd_w = -1;
+               copy_to = dest;
+       } else {
+               fd_w = open_tmpfile(buf, dest, file);
+               if (fd_w < 0)
+                       return -1;
+               copy_to = buf;
        }
+       cleanup_set(copy_to, NULL, NULL, -1, -1);
+       if (copy_file(src, copy_to, fd_w, file->mode, 0) < 0) {
+               if (verbose) {
+                       rsyserr(FINFO, errno, "copy_file %s => %s",
+                               full_fname(src), copy_to);
+               }
+               /* Try to clean up. */
+               unlink(copy_to);
+               cleanup_disable();
+               return -1;
+       }
+       partialptr = partial_dir ? partial_dir_fname(dest) : NULL;
+       ok = finish_transfer(dest, copy_to, src, partialptr, file, 1, 0);
+       cleanup_disable();
+       return ok ? 0 : -1;
 }
-#endif
 
 /* This is only called for regular files.  We return -2 if we've finished
  * handling the file, -1 if no dest-linking occurred, or a non-negative
  * value if we found an alternate basis file. */
 static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
-                        char *cmpbuf, STRUCT_STAT *stp, int itemizing,
+                        char *cmpbuf, stat_x *sxp, int itemizing,
                         enum logcode code)
 {
        int best_match = -1;
@@ -808,7 +964,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 
        do {
                pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
-               if (link_stat(cmpbuf, stp, 0) < 0 || !S_ISREG(stp->st_mode))
+               if (link_stat(cmpbuf, &sxp->st, 0) < 0 || !S_ISREG(sxp->st.st_mode))
                        continue;
                switch (match_level) {
                case 0:
@@ -816,16 +972,13 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                        match_level = 1;
                        /* FALL THROUGH */
                case 1:
-                       if (!unchanged_file(cmpbuf, file, stp))
+                       if (!unchanged_file(cmpbuf, file, &sxp->st))
                                continue;
                        best_match = j;
                        match_level = 2;
                        /* FALL THROUGH */
                case 2:
-                       if (!unchanged_attrs(file, stp))
-                               continue;
-                       if (always_checksum > 0 && preserve_times
-                        && cmp_time(stp->st_mtime, file->modtime))
+                       if (!unchanged_attrs(cmpbuf, file, sxp))
                                continue;
                        best_match = j;
                        match_level = 3;
@@ -840,7 +993,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
        if (j != best_match) {
                j = best_match;
                pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
-               if (link_stat(cmpbuf, stp, 0) < 0)
+               if (link_stat(cmpbuf, &sxp->st, 0) < 0)
                        return -1;
        }
 
@@ -850,16 +1003,16 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                        if (!hard_link_one(file, fname, cmpbuf, 1))
                                goto try_a_copy;
                        if (preserve_hard_links && F_IS_HLINKED(file))
-                               finish_hard_link(file, fname, stp, itemizing, code, j);
-                       if (itemizing && (verbose > 1 || stdout_format_has_i > 1)) {
-                               itemize(file, ndx, 1, stp,
+                               finish_hard_link(file, fname, ndx, &sxp->st, itemizing, code, j);
+                       if (!maybe_ATTRS_REPORT && (verbose > 1 || stdout_format_has_i > 1)) {
+                               itemize(cmpbuf, file, ndx, 1, sxp,
                                        ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
                                        0, "");
                        }
                } else
 #endif
                if (itemizing)
-                       itemize(file, ndx, 0, stp, 0, 0, NULL);
+                       itemize(cmpbuf, file, ndx, 0, sxp, 0, 0, NULL);
                if (verbose > 1 && maybe_ATTRS_REPORT)
                        rprintf(FCLIENT, "%s is uptodate\n", fname);
                return -2;
@@ -869,16 +1022,10 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 #ifdef SUPPORT_HARD_LINKS
          try_a_copy: /* Copy the file locally. */
 #endif
-               if (copy_file(cmpbuf, fname, file->mode) < 0) {
-                       if (verbose) {
-                               rsyserr(FINFO, errno, "copy_file %s => %s",
-                                       full_fname(cmpbuf), fname);
-                       }
+               if (!dry_run && copy_altdest_file(cmpbuf, fname, file) < 0)
                        return -1;
-               }
                if (itemizing)
-                       itemize(file, ndx, 0, stp, ITEM_LOCAL_CHANGE, 0, NULL);
-               set_file_attrs(fname, file, NULL, 0);
+                       itemize(cmpbuf, file, ndx, 0, sxp, ITEM_LOCAL_CHANGE, 0, NULL);
                if (maybe_ATTRS_REPORT
                 && ((!itemizing && verbose && match_level == 2)
                  || (verbose > 1 && match_level == 3))) {
@@ -888,7 +1035,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                }
 #ifdef SUPPORT_HARD_LINKS
                if (preserve_hard_links && F_IS_HLINKED(file))
-                       finish_hard_link(file, fname, stp, itemizing, code, -1);
+                       finish_hard_link(file, fname, ndx, &sxp->st, itemizing, code, -1);
 #endif
                return -2;
        }
@@ -900,7 +1047,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
  * handling the file, or -1 if no dest-linking occurred, or a non-negative
  * value if we found an alternate basis file. */
 static int try_dests_non(struct file_struct *file, char *fname, int ndx,
-                        char *cmpbuf, STRUCT_STAT *stp, int itemizing,
+                        char *cmpbuf, stat_x *sxp, int itemizing,
                         enum logcode code)
 {
        char lnk[MAXPATHLEN];
@@ -933,24 +1080,24 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 
        do {
                pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
-               if (link_stat(cmpbuf, stp, 0) < 0)
+               if (link_stat(cmpbuf, &sxp->st, 0) < 0)
                        continue;
                switch (type) {
                case TYPE_DIR:
-                       if (!S_ISDIR(stp->st_mode))
+                       if (!S_ISDIR(sxp->st.st_mode))
                                continue;
                        break;
                case TYPE_SPECIAL:
-                       if (!IS_SPECIAL(stp->st_mode))
+                       if (!IS_SPECIAL(sxp->st.st_mode))
                                continue;
                        break;
                case TYPE_DEVICE:
-                       if (!IS_DEVICE(stp->st_mode))
+                       if (!IS_DEVICE(sxp->st.st_mode))
                                continue;
                        break;
 #ifdef SUPPORT_LINKS
                case TYPE_SYMLINK:
-                       if (!S_ISLNK(stp->st_mode))
+                       if (!S_ISLNK(sxp->st.st_mode))
                                continue;
                        break;
 #endif
@@ -965,7 +1112,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
                case TYPE_SPECIAL:
                case TYPE_DEVICE:
                        devp = F_RDEV_P(file);
-                       if (stp->st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
+                       if (sxp->st.st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
                                continue;
                        break;
 #ifdef SUPPORT_LINKS
@@ -982,7 +1129,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
                        match_level = 2;
                        best_match = j;
                }
-               if (unchanged_attrs(file, stp)) {
+               if (unchanged_attrs(cmpbuf, file, sxp)) {
                        match_level = 3;
                        best_match = j;
                        break;
@@ -995,7 +1142,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
        if (j != best_match) {
                j = best_match;
                pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
-               if (link_stat(cmpbuf, stp, 0) < 0)
+               if (link_stat(cmpbuf, &sxp->st, 0) < 0)
                        return -1;
        }
 
@@ -1010,23 +1157,22 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 #endif
                 && !S_ISDIR(file->mode)) {
                        if (do_link(cmpbuf, fname) < 0) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "failed to hard-link %s with %s",
                                        cmpbuf, fname);
                                return j;
                        }
                        if (preserve_hard_links && F_IS_HLINKED(file))
-                               finish_hard_link(file, fname, NULL, itemizing, code, -1);
+                               finish_hard_link(file, fname, ndx, NULL, itemizing, code, -1);
                } else
 #endif
                        match_level = 2;
                if (itemizing && stdout_format_has_i
                 && (verbose > 1 || stdout_format_has_i > 1)) {
                        int chg = compare_dest && type != TYPE_DIR ? 0
-                           : ITEM_LOCAL_CHANGE
-                            + (match_level == 3 ? ITEM_XNAME_FOLLOWS : 0);
+                           : ITEM_LOCAL_CHANGE + (match_level == 3 ? ITEM_XNAME_FOLLOWS : 0);
                        char *lp = match_level == 3 ? "" : NULL;
-                       itemize(file, ndx, 0, stp, chg + ITEM_MATCHED, 0, lp);
+                       itemize(cmpbuf, file, ndx, 0, sxp, chg + ITEM_MATCHED, 0, lp);
                }
                if (verbose > 1 && maybe_ATTRS_REPORT) {
                        rprintf(FCLIENT, "%s%s is uptodate\n",
@@ -1038,73 +1184,131 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
        return j;
 }
 
+static void list_file_entry(struct file_struct *f)
+{
+       char permbuf[PERMSTRING_SIZE];
+       double len;
+
+       if (!F_IS_ACTIVE(f)) {
+               /* this can happen if duplicate names were removed */
+               return;
+       }
+
+       permstring(permbuf, f->mode);
+       len = F_LENGTH(f);
+
+       /* TODO: indicate '+' if the entry has an ACL. */
+
+#ifdef SUPPORT_LINKS
+       if (preserve_links && S_ISLNK(f->mode)) {
+               rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
+                       permbuf, len, timestring(f->modtime),
+                       f_name(f, NULL), F_SYMLINK(f));
+       } else
+#endif
+       {
+               rprintf(FINFO, "%s %11.0f %s %s\n",
+                       permbuf, len, timestring(f->modtime),
+                       f_name(f, NULL));
+       }
+}
+
 static int phase = 0;
+static int dflt_perms;
+
+static int implied_dirs_are_missing;
+/* Helper for recv_generator's skip_dir and dry_missing_dir tests. */
+static BOOL is_below(struct file_struct *file, struct file_struct *subtree)
+{
+       return F_DEPTH(file) > F_DEPTH(subtree)
+               && (!implied_dirs_are_missing || f_name_has_prefix(file, subtree));
+}
 
-/* Acts on cur_flist->file's ndx'th item, whose name is fname.  If a dir,
+/* Acts on the indicated item in cur_flist whose name is fname.  If a dir,
  * make sure it exists, and has the right permissions/timestamp info.  For
  * all other non-regular files (symlinks, etc.) we create them here.  For
  * regular files that have changed, we try to find a basis file and then
- * start sending checksums.
+ * start sending checksums.  The ndx is the file's unique index value.
  *
- * When fname is non-null, it must point to a MAXPATHLEN buffer!
+ * The fname parameter must point to a MAXPATHLEN buffer!  (e.g it gets
+ * passed to delete_item(), which can use it during a recursive delete.)
  *
  * Note that f_out is set to -1 when doing final directory-permission and
  * modification-time repair. */
 static void recv_generator(char *fname, struct file_struct *file, int ndx,
                           int itemizing, enum logcode code, int f_out)
 {
-       static int missing_below = -1, excluded_below = -1;
        static const char *parent_dirname = "";
+       /* Missing dir not created due to --dry-run; will still be scanned. */
+       static struct file_struct *dry_missing_dir = NULL;
+       /* Missing dir whose contents are skipped altogether due to
+        * --ignore-non-existing, daemon exclude, or mkdir failure. */
+       static struct file_struct *skip_dir = NULL;
        static struct file_list *fuzzy_dirlist = NULL;
        static int need_fuzzy_dirlist = 0;
        struct file_struct *fuzzy_file = NULL;
        int fd = -1, f_copy = -1;
-       STRUCT_STAT st, real_st, partial_st;
+       stat_x sx, real_sx;
+       STRUCT_STAT partial_st;
        struct file_struct *back_file = NULL;
        int statret, real_ret, stat_errno;
        char *fnamecmp, *partialptr, *backupptr = NULL;
        char fnamecmpbuf[MAXPATHLEN];
        uchar fnamecmp_type;
        int del_opts = delete_mode || force_delete ? DEL_RECURSE : 0;
-
-       if (list_only)
-               return;
+       int is_dir = !S_ISDIR(file->mode) ? 0
+                  : inc_recurse && ndx != cur_flist->ndx_start - 1 ? -1
+                  : 1;
 
        if (verbose > 2)
                rprintf(FINFO, "recv_generator(%s,%d)\n", fname, ndx);
 
-       if (server_filter_list.head) {
-               if (excluded_below >= 0) {
-                       if (F_DEPTH(file) > excluded_below)
-                               goto skipping;
-                       excluded_below = -1;
-               }
-               if (check_filter(&server_filter_list, fname,
-                                S_ISDIR(file->mode)) < 0) {
-                       if (S_ISDIR(file->mode))
-                               excluded_below = F_DEPTH(file);
-                 skipping:
-                       if (verbose) {
-                               rprintf(FINFO,
-                                       "skipping server-excluded file \"%s\"\n",
-                                       fname);
-                       }
+       if (list_only) {
+               if (is_dir < 0
+                || (is_dir && !implied_dirs && file->flags & FLAG_IMPLIED_DIR))
                        return;
-               }
+               list_file_entry(file);
+               return;
        }
 
-       if (missing_below >= 0) {
-               if (F_DEPTH(file) <= missing_below) {
-                       if (dry_run)
-                               dry_run--;
-                       missing_below = -1;
-               } else if (!dry_run) {
-                       if (S_ISDIR(file->mode))
+       if (skip_dir) {
+               if (is_below(file, skip_dir)) {
+                       if (is_dir)
                                file->flags |= FLAG_MISSING_DIR;
+#ifdef SUPPORT_HARD_LINKS
+                       else if (F_IS_HLINKED(file))
+                               handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
+                       return;
+               }
+               skip_dir = NULL;
+       }
+
+       if (daemon_filter_list.head && (*fname != '.' || fname[1])) {
+               if (check_filter(&daemon_filter_list, FLOG, fname, is_dir) < 0) {
+                       if (is_dir < 0)
+                               return;
+#ifdef SUPPORT_HARD_LINKS
+                       if (F_IS_HLINKED(file))
+                               handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
+                       rprintf(FERROR_XFER,
+                               "skipping daemon-excluded %s \"%s\"\n",
+                               is_dir ? "directory" : "file", fname);
+                       if (is_dir)
+                               goto skipping_dir_contents;
                        return;
                }
        }
-       if (dry_run > 1) {
+
+#ifdef SUPPORT_ACLS
+       sx.acc_acl = sx.def_acl = NULL;
+#endif
+#ifdef SUPPORT_XATTRS
+       sx.xattr = NULL;
+#endif
+       if (dry_run > 1 || (dry_missing_dir && is_below(file, dry_missing_dir))) {
+         parent_is_dry_missing:
                if (fuzzy_dirlist) {
                        flist_free(fuzzy_dirlist);
                        fuzzy_dirlist = NULL;
@@ -1114,13 +1318,17 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                stat_errno = ENOENT;
        } else {
                const char *dn = file->dirname ? file->dirname : ".";
+               dry_missing_dir = NULL;
                if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) {
                        if (relative_paths && !implied_dirs
-                        && do_stat(dn, &st) < 0
-                        && create_directory_path(fname) < 0) {
-                               rsyserr(FERROR, errno,
-                                       "recv_generator: mkdir %s failed",
-                                       full_fname(dn));
+                        && do_stat(dn, &sx.st) < 0) {
+                               if (dry_run)
+                                       goto parent_is_dry_missing;
+                               if (create_directory_path(fname) < 0) {
+                                       rsyserr(FERROR_XFER, errno,
+                                               "recv_generator: mkdir %s failed",
+                                               full_fname(dn));
+                               }
                        }
                        if (fuzzy_dirlist) {
                                flist_free(fuzzy_dirlist);
@@ -1128,6 +1336,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        }
                        if (fuzzy_basis)
                                need_fuzzy_dirlist = 1;
+#ifdef SUPPORT_ACLS
+                       if (!preserve_perms)
+                               dflt_perms = default_perms_for_dir(dn);
+#endif
                }
                parent_dirname = dn;
 
@@ -1137,60 +1349,85 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        need_fuzzy_dirlist = 0;
                }
 
-               statret = link_stat(fname, &st,
-                                   keep_dirlinks && S_ISDIR(file->mode));
+               statret = link_stat(fname, &sx.st, keep_dirlinks && is_dir);
                stat_errno = errno;
        }
 
        if (ignore_non_existing > 0 && statret == -1 && stat_errno == ENOENT) {
+               if (is_dir) {
+                       if (is_dir < 0)
+                               return;
+                       skip_dir = file;
+                       file->flags |= FLAG_MISSING_DIR;
+               }
+#ifdef SUPPORT_HARD_LINKS
+               else if (F_IS_HLINKED(file))
+                       handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
                if (verbose > 1) {
                        rprintf(FINFO, "not creating new %s \"%s\"\n",
-                               S_ISDIR(file->mode) ? "directory" : "file",
-                               fname);
-               }
-               if (S_ISDIR(file->mode)) {
-                       if (missing_below < 0) {
-                               if (dry_run)
-                                       dry_run++;
-                               missing_below = F_DEPTH(file);
-                       }
-                       file->flags |= FLAG_MISSING_DIR;
+                               is_dir ? "directory" : "file", fname);
                }
                return;
        }
 
-       /* If we're not preserving permissions, change the file-list's
-        * mode based on the local permissions and some heuristics. */
-       if (!preserve_perms) {
-               int exists = statret == 0
-                         && S_ISDIR(st.st_mode) == S_ISDIR(file->mode);
-               file->mode = dest_mode(file->mode, st.st_mode, exists);
-       }
+       if (statret == 0 && !(sx.st.st_mode & S_IWUSR)
+        && !am_root && sx.st.st_uid == our_uid)
+               del_opts |= DEL_NO_UID_WRITE;
 
-       if (S_ISDIR(file->mode)) {
+       if (ignore_existing > 0 && statret == 0
+        && (!is_dir || !S_ISDIR(sx.st.st_mode))) {
+               if (verbose > 1 && is_dir >= 0)
+                       rprintf(FINFO, "%s exists\n", fname);
+#ifdef SUPPORT_HARD_LINKS
+               if (F_IS_HLINKED(file))
+                       handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
+               goto cleanup;
+       }
+
+       if (is_dir) {
+               if (!implied_dirs && file->flags & FLAG_IMPLIED_DIR)
+                       goto cleanup;
+               if (is_dir < 0) {
+                       /* In inc_recurse mode we want to make sure any missing
+                        * directories get created while we're still processing
+                        * the parent dir (which allows us to touch the parent
+                        * dir's mtime right away).  We will handle the dir in
+                        * full later (right before we handle its contents). */
+                       if (statret == 0
+                        && (S_ISDIR(sx.st.st_mode)
+                         || delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_DIR) != 0))
+                               goto cleanup; /* Any errors get reported later. */
+                       if (do_mkdir(fname, file->mode & 0700) == 0)
+                               file->flags |= FLAG_DIR_CREATED;
+                       goto cleanup;
+               }
                /* The file to be received is a directory, so we need
                 * to prepare appropriately.  If there is already a
                 * file of that name and it is *not* a directory, then
                 * we need to delete it.  If it doesn't exist, then
                 * (perhaps recursively) create it. */
-               if (statret == 0 && !S_ISDIR(st.st_mode)) {
-                       if (delete_item(fname, st.st_mode, "directory", del_opts) != 0)
-                               return;
+               if (statret == 0 && !S_ISDIR(sx.st.st_mode)) {
+                       if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_DIR) != 0)
+                               goto skipping_dir_contents;
                        statret = -1;
                }
-               if (dry_run && statret != 0 && missing_below < 0) {
-                       missing_below = F_DEPTH(file);
-                       dry_run++;
+               if (dry_run && statret != 0) {
+                       if (!dry_missing_dir)
+                               dry_missing_dir = file;
+                       file->flags |= FLAG_MISSING_DIR;
                }
                real_ret = statret;
-               real_st = st;
-               if (new_root_dir) {
-                       if (*fname == '.' && fname[1] == '\0')
-                               statret = -1;
-                       new_root_dir = 0;
+               real_sx = sx;
+               if (file->flags & FLAG_DIR_CREATED)
+                       statret = -1;
+               if (!preserve_perms) { /* See comment in non-dir code below. */
+                       file->mode = dest_mode(file->mode, sx.st.st_mode,
+                                              dflt_perms, statret == 0);
                }
                if (statret != 0 && basis_dir[0] != NULL) {
-                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
+                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
                                              itemizing, code);
                        if (j == -2) {
                                itemizing = 0;
@@ -1199,45 +1436,74 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                statret = 1;
                }
                if (itemizing && f_out != -1) {
-                       itemize(file, ndx, statret, &st,
+                       itemize(fname, file, ndx, statret, &sx,
                                statret ? ITEM_LOCAL_CHANGE : 0, 0, NULL);
                }
                if (real_ret != 0 && do_mkdir(fname,file->mode) < 0 && errno != EEXIST) {
                        if (!relative_paths || errno != ENOENT
                            || create_directory_path(fname) < 0
                            || (do_mkdir(fname, file->mode) < 0 && errno != EEXIST)) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "recv_generator: mkdir %s failed",
                                        full_fname(fname));
+                         skipping_dir_contents:
                                rprintf(FERROR,
                                    "*** Skipping any contents from this failed directory ***\n");
-                               missing_below = F_DEPTH(file);
+                               skip_dir = file;
                                file->flags |= FLAG_MISSING_DIR;
-                               return;
+                               goto cleanup;
                        }
                }
-               if (set_file_attrs(fname, file, real_ret ? NULL : &real_st, 0)
+               if (set_file_attrs(fname, file, real_ret ? NULL : &real_sx, NULL, 0)
                    && verbose && code != FNONE && f_out != -1)
                        rprintf(code, "%s/\n", fname);
+
+               /* We need to ensure that the dirs in the transfer have writable
+                * permissions during the time we are putting files within them.
+                * This is then fixed after the transfer is done. */
+#ifdef HAVE_CHMOD
+               if (!am_root && !(file->mode & S_IWUSR) && dir_tweaking) {
+                       mode_t mode = file->mode | S_IWUSR;
+                       if (do_chmod(fname, mode) < 0) {
+                               rsyserr(FERROR_XFER, errno,
+                                       "failed to modify permissions on %s",
+                                       full_fname(fname));
+                       }
+                       need_retouch_dir_perms = 1;
+               }
+#endif
+
                if (real_ret != 0 && one_file_system)
-                       real_st.st_dev = filesystem_dev;
-               if (incremental) {
+                       real_sx.st.st_dev = filesystem_dev;
+               if (inc_recurse) {
                        if (one_file_system) {
-                               uint32 *devp = F_DIRDEV_P(file);
-                               DEV_MAJOR(devp) = major(real_st.st_dev);
-                               DEV_MINOR(devp) = minor(real_st.st_dev);
+                               uint32 *devp = F_DIR_DEV_P(file);
+                               DEV_MAJOR(devp) = major(real_sx.st.st_dev);
+                               DEV_MINOR(devp) = minor(real_sx.st.st_dev);
                        }
                }
-               else if (delete_during && f_out != -1 && !phase && dry_run < 2
-                   && (file->flags & FLAG_XFER_DIR))
-                       delete_in_dir(cur_flist, fname, file, &real_st.st_dev);
-               return;
+               else if (delete_during && f_out != -1 && !phase
+                   && !(file->flags & FLAG_MISSING_DIR)) {
+                       if (file->flags & FLAG_CONTENT_DIR)
+                               delete_in_dir(fname, file, &real_sx.st.st_dev);
+                       else
+                               change_local_filter_dir(fname, strlen(fname), F_DEPTH(file));
+               }
+               goto cleanup;
+       }
+
+       /* If we're not preserving permissions, change the file-list's
+        * mode based on the local permissions and some heuristics. */
+       if (!preserve_perms) {
+               int exists = statret == 0 && !S_ISDIR(sx.st.st_mode);
+               file->mode = dest_mode(file->mode, sx.st.st_mode, dflt_perms,
+                                      exists);
        }
 
 #ifdef SUPPORT_HARD_LINKS
        if (preserve_hard_links && F_HLINK_NOT_FIRST(file)
-        && hard_link_check(file, ndx, fname, statret, &st, itemizing, code))
-               return;
+        && hard_link_check(file, ndx, fname, statret, &sx, itemizing, code))
+               goto cleanup;
 #endif
 
        if (preserve_links && S_ISLNK(file->mode)) {
@@ -1257,28 +1523,28 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        char lnk[MAXPATHLEN];
                        int len;
 
-                       if (!S_ISLNK(st.st_mode))
+                       if (!S_ISLNK(sx.st.st_mode))
                                statret = -1;
                        else if ((len = readlink(fname, lnk, MAXPATHLEN-1)) > 0
                              && strncmp(lnk, sl, len) == 0 && sl[len] == '\0') {
                                /* The link is pointing to the right place. */
+                               set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                                if (itemizing)
-                                       itemize(file, ndx, 0, &st, 0, 0, NULL);
-                               set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
-#ifdef SUPPORT_HARD_LINKS
+                                       itemize(fname, file, ndx, 0, &sx, 0, 0, NULL);
+#if defined SUPPORT_HARD_LINKS && defined CAN_HARDLINK_SYMLINK
                                if (preserve_hard_links && F_IS_HLINKED(file))
-                                       finish_hard_link(file, fname, &st, itemizing, code, -1);
+                                       finish_hard_link(file, fname, ndx, &sx.st, itemizing, code, -1);
 #endif
                                if (remove_source_files == 1)
                                        goto return_with_success;
-                               return;
+                               goto cleanup;
                        }
                        /* Not the right symlink (or not a symlink), so
                         * delete it. */
-                       if (delete_item(fname, st.st_mode, "symlink", del_opts) != 0)
-                               return;
+                       if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_SYMLINK) != 0)
+                               goto cleanup;
                } else if (basis_dir[0] != NULL) {
-                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
+                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
                                              itemizing, code);
                        if (j == -2) {
 #ifndef CAN_HARDLINK_SYMLINK
@@ -1287,30 +1553,32 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                } else
 #endif
                                if (!copy_dest)
-                                       return;
+                                       goto cleanup;
                                itemizing = 0;
                                code = FNONE;
                        } else if (j >= 0)
                                statret = 1;
                }
 #ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file))
-                       return;
+               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
+                       cur_flist->in_progress++;
+                       goto cleanup;
+               }
 #endif
                if (do_symlink(sl, fname) != 0) {
-                       rsyserr(FERROR, errno, "symlink %s -> \"%s\" failed",
+                       rsyserr(FERROR_XFER, errno, "symlink %s -> \"%s\" failed",
                                full_fname(fname), sl);
                } else {
-                       set_file_attrs(fname, file, NULL, 0);
+                       set_file_attrs(fname, file, NULL, NULL, 0);
                        if (itemizing) {
-                               itemize(file, ndx, statret, &st,
-                                       ITEM_LOCAL_CHANGE, 0, NULL);
+                               itemize(fname, file, ndx, statret, &sx,
+                                       ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL);
                        }
                        if (code != FNONE && verbose)
                                rprintf(code, "%s -> %s\n", fname, sl);
 #ifdef SUPPORT_HARD_LINKS
                        if (preserve_hard_links && F_IS_HLINKED(file))
-                               finish_hard_link(file, fname, NULL, itemizing, code, -1);
+                               finish_hard_link(file, fname, ndx, NULL, itemizing, code, -1);
 #endif
                        /* This does not check remove_source_files == 1
                         * because this is one of the items that the old
@@ -1319,7 +1587,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                goto return_with_success;
                }
 #endif
-               return;
+               goto cleanup;
        }
 
        if ((am_root && preserve_devices && IS_DEVICE(file->mode))
@@ -1327,35 +1595,35 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                uint32 *devp = F_RDEV_P(file);
                dev_t rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
                if (statret == 0) {
-                       char *t;
+                       int del_for_flag;
                        if (IS_DEVICE(file->mode)) {
-                               if (!IS_DEVICE(st.st_mode))
+                               if (!IS_DEVICE(sx.st.st_mode))
                                        statret = -1;
-                               t = "device file";
+                               del_for_flag = DEL_FOR_DEVICE;
                        } else {
-                               if (!IS_SPECIAL(st.st_mode))
+                               if (!IS_SPECIAL(sx.st.st_mode))
                                        statret = -1;
-                               t = "special file";
+                               del_for_flag = DEL_FOR_SPECIAL;
                        }
                        if (statret == 0
-                        && BITS_EQUAL(st.st_mode, file->mode, _S_IFMT)
-                        && st.st_rdev == rdev) {
+                        && BITS_EQUAL(sx.st.st_mode, file->mode, _S_IFMT)
+                        && sx.st.st_rdev == rdev) {
                                /* The device or special file is identical. */
+                               set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                                if (itemizing)
-                                       itemize(file, ndx, 0, &st, 0, 0, NULL);
-                               set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
+                                       itemize(fname, file, ndx, 0, &sx, 0, 0, NULL);
 #ifdef SUPPORT_HARD_LINKS
                                if (preserve_hard_links && F_IS_HLINKED(file))
-                                       finish_hard_link(file, fname, &st, itemizing, code, -1);
+                                       finish_hard_link(file, fname, ndx, &sx.st, itemizing, code, -1);
 #endif
                                if (remove_source_files == 1)
                                        goto return_with_success;
-                               return;
+                               goto cleanup;
                        }
-                       if (delete_item(fname, st.st_mode, t, del_opts) != 0)
-                               return;
+                       if (delete_item(fname, sx.st.st_mode, del_opts | del_for_flag) != 0)
+                               goto cleanup;
                } else if (basis_dir[0] != NULL) {
-                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
+                       int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
                                              itemizing, code);
                        if (j == -2) {
 #ifndef CAN_HARDLINK_SPECIAL
@@ -1364,15 +1632,17 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                } else
 #endif
                                if (!copy_dest)
-                                       return;
+                                       goto cleanup;
                                itemizing = 0;
                                code = FNONE;
                        } else if (j >= 0)
                                statret = 1;
                }
 #ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file))
-                       return;
+               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
+                       cur_flist->in_progress++;
+                       goto cleanup;
+               }
 #endif
                if (verbose > 2) {
                        rprintf(FINFO, "mknod(%s, 0%o, [%ld,%ld])\n",
@@ -1380,31 +1650,31 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                (long)major(rdev), (long)minor(rdev));
                }
                if (do_mknod(fname, file->mode, rdev) < 0) {
-                       rsyserr(FERROR, errno, "mknod %s failed",
+                       rsyserr(FERROR_XFER, errno, "mknod %s failed",
                                full_fname(fname));
                } else {
-                       set_file_attrs(fname, file, NULL, 0);
+                       set_file_attrs(fname, file, NULL, NULL, 0);
                        if (itemizing) {
-                               itemize(file, ndx, statret, &st,
-                                       ITEM_LOCAL_CHANGE, 0, NULL);
+                               itemize(fname, file, ndx, statret, &sx,
+                                       ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL);
                        }
                        if (code != FNONE && verbose)
                                rprintf(code, "%s\n", fname);
 #ifdef SUPPORT_HARD_LINKS
                        if (preserve_hard_links && F_IS_HLINKED(file))
-                               finish_hard_link(file, fname, NULL, itemizing, code, -1);
+                               finish_hard_link(file, fname, ndx, NULL, itemizing, code, -1);
 #endif
                        if (remove_source_files == 1)
                                goto return_with_success;
                }
-               return;
+               goto cleanup;
        }
 
        if (!S_ISREG(file->mode)) {
                if (solo_file)
                        fname = f_name(file, NULL);
                rprintf(FINFO, "skipping non-regular file \"%s\"\n", fname);
-               return;
+               goto cleanup;
        }
 
        if (max_size > 0 && F_LENGTH(file) > max_size) {
@@ -1413,7 +1683,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                fname = f_name(file, NULL);
                        rprintf(FINFO, "%s is over max-size\n", fname);
                }
-               return;
+               goto cleanup;
        }
        if (min_size > 0 && F_LENGTH(file) < min_size) {
                if (verbose > 1) {
@@ -1421,39 +1691,37 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                fname = f_name(file, NULL);
                        rprintf(FINFO, "%s is under min-size\n", fname);
                }
-               return;
-       }
-
-       if (ignore_existing > 0 && statret == 0) {
-               if (verbose > 1)
-                       rprintf(FINFO, "%s exists\n", fname);
-               return;
+               goto cleanup;
        }
 
        if (update_only > 0 && statret == 0
-           && cmp_time(st.st_mtime, file->modtime) > 0) {
+           && cmp_time(sx.st.st_mtime, file->modtime) > 0) {
                if (verbose > 1)
                        rprintf(FINFO, "%s is newer\n", fname);
-               return;
+#ifdef SUPPORT_HARD_LINKS
+               if (F_IS_HLINKED(file))
+                       handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
+               goto cleanup;
        }
 
        fnamecmp = fname;
        fnamecmp_type = FNAMECMP_FNAME;
 
-       if (statret == 0 && !S_ISREG(st.st_mode)) {
-               if (delete_item(fname, st.st_mode, "regular file", del_opts) != 0)
-                       return;
+       if (statret == 0 && !S_ISREG(sx.st.st_mode)) {
+               if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_FILE) != 0)
+                       goto cleanup;
                statret = -1;
                stat_errno = ENOENT;
        }
 
        if (statret != 0 && basis_dir[0] != NULL) {
-               int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &st,
+               int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &sx,
                                      itemizing, code);
                if (j == -2) {
                        if (remove_source_files == 1)
                                goto return_with_success;
-                       return;
+                       goto cleanup;
                }
                if (j >= 0) {
                        fnamecmp = fnamecmpbuf;
@@ -1463,7 +1731,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        }
 
        real_ret = statret;
-       real_st = st;
+       real_sx = sx;
 
        if (partial_dir && (partialptr = partial_dir_fname(fname)) != NULL
            && link_stat(partialptr, &partial_st, 0) == 0
@@ -1473,7 +1741,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        } else
                partialptr = NULL;
 
-       if (statret != 0 && fuzzy_dirlist && dry_run <= 1) {
+       if (statret != 0 && fuzzy_dirlist) {
                int j = find_fuzzy(file, fuzzy_dirlist);
                if (j >= 0) {
                        fuzzy_file = fuzzy_dirlist->files[j];
@@ -1482,7 +1750,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                rprintf(FINFO, "fuzzy basis selected for %s: %s\n",
                                        fname, fnamecmpbuf);
                        }
-                       st.st_size = F_LENGTH(fuzzy_file);
+                       sx.st.st_size = F_LENGTH(fuzzy_file);
                        statret = 0;
                        fnamecmp = fnamecmpbuf;
                        fnamecmp_type = FNAMECMP_FUZZY;
@@ -1491,53 +1759,75 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
        if (statret != 0) {
 #ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file))
-                       return;
+               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
+                       cur_flist->in_progress++;
+                       goto cleanup;
+               }
 #endif
                if (stat_errno == ENOENT)
                        goto notify_others;
-               rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s",
+               rsyserr(FERROR_XFER, stat_errno, "recv_generator: failed to stat %s",
                        full_fname(fname));
-               return;
+               goto cleanup;
        }
 
-       if (append_mode > 0 && st.st_size > F_LENGTH(file))
-               return;
-
        if (fnamecmp_type <= FNAMECMP_BASIS_DIR_HIGH)
                ;
        else if (fnamecmp_type == FNAMECMP_FUZZY)
                ;
-       else if (unchanged_file(fnamecmp, file, &st)) {
+       else if (unchanged_file(fnamecmp, file, &sx.st)) {
                if (partialptr) {
                        do_unlink(partialptr);
                        handle_partial_dir(partialptr, PDIR_DELETE);
                }
+               set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                if (itemizing)
-                       itemize(file, ndx, statret, &st, 0, 0, NULL);
-               set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
+                       itemize(fnamecmp, file, ndx, statret, &sx, 0, 0, NULL);
 #ifdef SUPPORT_HARD_LINKS
                if (preserve_hard_links && F_IS_HLINKED(file))
-                       finish_hard_link(file, fname, &st, itemizing, code, -1);
+                       finish_hard_link(file, fname, ndx, &sx.st, itemizing, code, -1);
 #endif
                if (remove_source_files != 1)
-                       return;
+                       goto cleanup;
          return_with_success:
                if (!dry_run)
-                       send_msg_int(MSG_SUCCESS, ndx + cur_flist->ndx_start);
-               return;
+                       send_msg_int(MSG_SUCCESS, ndx);
+               goto cleanup;
+       }
+
+       if (append_mode > 0 && sx.st.st_size >= F_LENGTH(file)) {
+#ifdef SUPPORT_HARD_LINKS
+               if (F_IS_HLINKED(file))
+                       handle_skipped_hlink(file, itemizing, code, f_out);
+#endif
+               goto cleanup;
        }
 
   prepare_to_open:
        if (partialptr) {
-               st = partial_st;
+               sx.st = partial_st;
                fnamecmp = partialptr;
                fnamecmp_type = FNAMECMP_PARTIAL_DIR;
                statret = 0;
        }
 
-       if (!do_xfers || read_batch || whole_file)
+       if (!do_xfers)
+               goto notify_others;
+
+       if (read_batch || whole_file) {
+               if (inplace && make_backups > 0 && fnamecmp_type == FNAMECMP_FNAME) {
+                       if (!(backupptr = get_backup_name(fname)))
+                               goto cleanup;
+                       if (!(back_file = make_file(fname, NULL, NULL, 0, NO_FILTERS)))
+                               goto pretend_missing;
+                       if (copy_file(fname, backupptr, -1, back_file->mode, 1) < 0) {
+                               unmake_file(back_file);
+                               back_file = NULL;
+                               goto cleanup;
+                       }
+               }
                goto notify_others;
+       }
 
        if (fuzzy_dirlist) {
                int j = flist_find(fuzzy_dirlist, file);
@@ -1546,16 +1836,16 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        }
 
        /* open the file */
-       fd = do_open(fnamecmp, O_RDONLY, 0);
-
-       if (fd == -1) {
+       if ((fd = do_open(fnamecmp, O_RDONLY, 0)) < 0) {
                rsyserr(FERROR, errno, "failed to open %s, continuing",
                        full_fname(fnamecmp));
          pretend_missing:
                /* pretend the file didn't exist */
 #ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file))
-                       return;
+               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
+                       cur_flist->in_progress++;
+                       goto cleanup;
+               }
 #endif
                statret = real_ret = -1;
                goto notify_others;
@@ -1564,80 +1854,106 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        if (inplace && make_backups > 0 && fnamecmp_type == FNAMECMP_FNAME) {
                if (!(backupptr = get_backup_name(fname))) {
                        close(fd);
-                       return;
+                       goto cleanup;
                }
                if (!(back_file = make_file(fname, NULL, NULL, 0, NO_FILTERS))) {
                        close(fd);
                        goto pretend_missing;
                }
                if (robust_unlink(backupptr) && errno != ENOENT) {
-                       rsyserr(FERROR, errno, "unlink %s",
+                       rsyserr(FERROR_XFER, errno, "unlink %s",
                                full_fname(backupptr));
                        unmake_file(back_file);
+                       back_file = NULL;
                        close(fd);
-                       return;
+                       goto cleanup;
                }
-               if ((f_copy = do_open(backupptr,
-                   O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
-                       rsyserr(FERROR, errno, "open %s",
-                               full_fname(backupptr));
-                       unmake_file(back_file);
-                       close(fd);
-                       return;
+               if ((f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
+                       int save_errno = errno ? errno : EINVAL; /* 0 paranoia */
+                       if (errno == ENOENT && make_bak_dir(backupptr) == 0) {
+                               if ((f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0)
+                                       save_errno = errno ? errno : save_errno;
+                               else
+                                       save_errno = 0;
+                       }
+                       if (save_errno) {
+                               rsyserr(FERROR_XFER, save_errno, "open %s", full_fname(backupptr));
+                               unmake_file(back_file);
+                               back_file = NULL;
+                               close(fd);
+                               goto cleanup;
+                       }
                }
                fnamecmp_type = FNAMECMP_BACKUP;
        }
 
        if (verbose > 3) {
                rprintf(FINFO, "gen mapped %s of size %.0f\n",
-                       fnamecmp, (double)st.st_size);
+                       fnamecmp, (double)sx.st.st_size);
        }
 
        if (verbose > 2)
                rprintf(FINFO, "generating and sending sums for %d\n", ndx);
 
   notify_others:
-       if (remove_source_files && !delay_updates && !phase)
+       if (remove_source_files && !delay_updates && !phase && !dry_run)
                increment_active_files(ndx, itemizing, code);
-       if (incremental && !dry_run)
+       if (inc_recurse && !dry_run)
                cur_flist->in_progress++;
 #ifdef SUPPORT_HARD_LINKS
        if (preserve_hard_links && F_IS_HLINKED(file))
                file->flags |= FLAG_FILE_SENT;
 #endif
-       write_int(f_out, ndx + cur_flist->ndx_start);
+       write_ndx(f_out, ndx);
        if (itemizing) {
                int iflags = ITEM_TRANSFER;
                if (always_checksum > 0)
-                       iflags |= ITEM_REPORT_CHECKSUM;
+                       iflags |= ITEM_REPORT_CHANGE;
                if (fnamecmp_type != FNAMECMP_FNAME)
                        iflags |= ITEM_BASIS_TYPE_FOLLOWS;
                if (fnamecmp_type == FNAMECMP_FUZZY)
                        iflags |= ITEM_XNAME_FOLLOWS;
-               itemize(file, -1, real_ret, &real_st, iflags, fnamecmp_type,
+               itemize(fnamecmp, file, -1, real_ret, &real_sx, iflags, fnamecmp_type,
                        fuzzy_file ? fuzzy_file->basename : NULL);
+#ifdef SUPPORT_ACLS
+               if (preserve_acls)
+                       free_acl(&real_sx);
+#endif
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs)
+                       free_xattr(&real_sx);
+#endif
        }
 
        if (!do_xfers) {
 #ifdef SUPPORT_HARD_LINKS
                if (preserve_hard_links && F_IS_HLINKED(file))
-                       finish_hard_link(file, fname, &st, itemizing, code, -1);
+                       finish_hard_link(file, fname, ndx, &sx.st, itemizing, code, -1);
 #endif
-               return;
+               goto cleanup;
        }
        if (read_batch)
-               return;
+               goto cleanup;
 
-       if (statret != 0 || whole_file) {
+       if (statret != 0 || whole_file)
                write_sum_head(f_out, NULL);
-               return;
-       }
-
-       generate_and_send_sums(fd, st.st_size, f_out, f_copy);
-
-       if (f_copy >= 0) {
-               close(f_copy);
-               set_file_attrs(backupptr, back_file, NULL, 0);
+       else {
+               generate_and_send_sums(fd, sx.st.st_size, f_out, f_copy);
+               close(fd);
+       }
+
+  cleanup:
+       if (back_file) {
+               int save_preserve_xattrs = preserve_xattrs;
+               if (f_copy >= 0)
+                       close(f_copy);
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs)
+                       copy_xattrs(fname, backupptr);
+#endif
+               preserve_xattrs = 0;
+               set_file_attrs(backupptr, back_file, NULL, NULL, 0);
+               preserve_xattrs = save_preserve_xattrs;
                if (verbose > 1) {
                        rprintf(FINFO, "backed up %s to %s\n",
                                fname, backupptr);
@@ -1645,21 +1961,171 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                unmake_file(back_file);
        }
 
-       close(fd);
+#ifdef SUPPORT_ACLS
+       if (preserve_acls)
+               free_acl(&sx);
+#endif
+#ifdef SUPPORT_XATTRS
+       if (preserve_xattrs)
+               free_xattr(&sx);
+#endif
+       return;
+}
+
+#ifdef SUPPORT_HARD_LINKS
+static void handle_skipped_hlink(struct file_struct *file, int itemizing,
+                                enum logcode code, int f_out)
+{
+       char fbuf[MAXPATHLEN];
+       int new_last_ndx;
+       struct file_list *save_flist = cur_flist;
+
+       /* If we skip the last item in a chain of links and there was a
+        * prior non-skipped hard-link waiting to finish, finish it now. */
+       if ((new_last_ndx = skip_hard_link(file, &cur_flist)) < 0)
+               return;
+
+       file = cur_flist->files[new_last_ndx - cur_flist->ndx_start];
+       cur_flist->in_progress--; /* undo prior increment */
+       f_name(file, fbuf);
+       recv_generator(fbuf, file, new_last_ndx, itemizing, code, f_out);
+
+       cur_flist = save_flist;
+}
+#endif
+
+static void touch_up_dirs(struct file_list *flist, int ndx)
+{
+       static int counter = 0;
+       struct file_struct *file;
+       char *fname;
+       int i, start, end;
+
+       if (ndx < 0) {
+               start = 0;
+               end = flist->used - 1;
+       } else
+               start = end = ndx;
+
+       /* Fix any directory permissions that were modified during the
+        * transfer and/or re-set any tweaked modified-time values. */
+       for (i = start; i <= end; i++, counter++) {
+               file = flist->files[i];
+               if (!S_ISDIR(file->mode)
+                || (!implied_dirs && file->flags & FLAG_IMPLIED_DIR))
+                       continue;
+               if (verbose > 3) {
+                       fname = f_name(file, NULL);
+                       rprintf(FINFO, "touch_up_dirs: %s (%d)\n",
+                               NS(fname), i);
+               }
+               if (!F_IS_ACTIVE(file) || file->flags & FLAG_MISSING_DIR
+                || (!need_retouch_dir_times && file->mode & S_IWUSR))
+                       continue;
+               fname = f_name(file, NULL);
+               if (!(file->mode & S_IWUSR))
+                       do_chmod(fname, file->mode);
+               if (need_retouch_dir_times) {
+                       STRUCT_STAT st;
+                       if (link_stat(fname, &st, 0) == 0
+                        && cmp_time(st.st_mtime, file->modtime) != 0)
+                               set_modtime(fname, file->modtime, file->mode);
+               }
+               if (allowed_lull && !(counter % lull_mod))
+                       maybe_send_keepalive();
+               else if (!(counter & 0xFF))
+                       maybe_flush_socket(0);
+       }
 }
 
-void generate_files(int f_out, char *local_name)
+void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
 {
-       int i;
+       struct file_struct *file;
+       struct file_list *flist;
+       char fbuf[MAXPATHLEN];
+       int ndx;
+
+       while (1) {
+#ifdef SUPPORT_HARD_LINKS
+               if (preserve_hard_links && (ndx = get_hlink_num()) != -1) {
+                       flist = flist_for_ndx(ndx);
+                       assert(flist != NULL);
+                       file = flist->files[ndx - flist->ndx_start];
+                       assert(file->flags & FLAG_HLINKED);
+                       finish_hard_link(file, f_name(file, fbuf), ndx, NULL, itemizing, code, -1);
+                       flist->in_progress--;
+                       continue;
+               }
+#endif
+
+               if (check_redo && (ndx = get_redo_num()) != -1) {
+                       csum_length = SUM_LENGTH;
+                       max_size = -max_size;
+                       min_size = -min_size;
+                       ignore_existing = -ignore_existing;
+                       ignore_non_existing = -ignore_non_existing;
+                       update_only = -update_only;
+                       always_checksum = -always_checksum;
+                       size_only = -size_only;
+                       append_mode = -append_mode;
+                       make_backups = -make_backups; /* avoid dup backup w/inplace */
+                       ignore_times++;
+
+                       flist = cur_flist;
+                       cur_flist = flist_for_ndx(ndx);
+
+                       file = cur_flist->files[ndx - cur_flist->ndx_start];
+                       if (solo_file)
+                               strlcpy(fbuf, solo_file, sizeof fbuf);
+                       else
+                               f_name(file, fbuf);
+                       recv_generator(fbuf, file, ndx, itemizing, code, sock_f_out);
+                       cur_flist->to_redo--;
+
+                       cur_flist = flist;
+
+                       csum_length = SHORT_SUM_LENGTH;
+                       max_size = -max_size;
+                       min_size = -min_size;
+                       ignore_existing = -ignore_existing;
+                       ignore_non_existing = -ignore_non_existing;
+                       update_only = -update_only;
+                       always_checksum = -always_checksum;
+                       size_only = -size_only;
+                       append_mode = -append_mode;
+                       make_backups = -make_backups;
+                       ignore_times--;
+                       continue;
+               }
+
+               if (cur_flist == first_flist)
+                       break;
+
+               /* We only get here if inc_recurse is enabled. */
+               if (first_flist->in_progress || first_flist->to_redo)
+                       break;
+
+               if (!read_batch) {
+                       write_ndx(sock_f_out, NDX_DONE);
+                       maybe_flush_socket(1);
+               }
+
+               if (delete_during == 2 || !dir_tweaking) {
+                       /* Skip directory touch-up. */
+               } else if (first_flist->parent_ndx >= 0)
+                       touch_up_dirs(dir_flist, first_flist->parent_ndx);
+
+               flist_free(first_flist); /* updates first_flist */
+       }
+}
+
+void generate_files(int f_out, const char *local_name)
+{
+       int i, ndx;
        char fbuf[MAXPATHLEN];
        int itemizing;
        enum logcode code;
-       struct file_list *next_flist;
-       int lull_mod = allowed_lull * 5;
-       int need_retouch_dir_times = preserve_times && !omit_dir_times;
-       int need_retouch_dir_perms = 0;
        int save_do_progress = do_progress;
-       int dir_tweaking = !(list_only || local_name || dry_run);
 
        if (protocol_version >= 29) {
                itemizing = 1;
@@ -1678,13 +2144,19 @@ void generate_files(int f_out, char *local_name)
                maybe_ATTRS_REPORT = ATTRS_REPORT;
                code = FINFO;
        }
-       solo_file = local_name != NULL;
+       solo_file = local_name;
+       dir_tweaking = !(list_only || solo_file || dry_run);
+       need_retouch_dir_times = preserve_times > 1;
+       lull_mod = allowed_lull * 5;
+       symlink_timeset_failed_flags = ITEM_REPORT_TIME
+           | (protocol_version >= 30 || !am_server ? ITEM_REPORT_TIMEFAIL : 0);
+       implied_dirs_are_missing = relative_paths && !implied_dirs && protocol_version < 30;
 
        if (verbose > 2)
                rprintf(FINFO, "generator starting pid=%ld\n", (long)getpid());
 
-       if (delete_before && !local_name && cur_flist->count > 0)
-               do_delete_pass(cur_flist);
+       if (delete_before && !solo_file && cur_flist->used > 0)
+               do_delete_pass();
        if (delete_during == 2) {
                deldelay_size = BIGPATHBUFLEN * 4;
                deldelay_buf = new_array(char, deldelay_size);
@@ -1708,182 +2180,100 @@ void generate_files(int f_out, char *local_name)
         * notice that and let us know via the redo pipe (or its closing). */
        ignore_timeout = 1;
 
+       dflt_perms = (ACCESSPERMS & ~orig_umask);
+
        do {
-               if (incremental && delete_during && cur_flist->ndx_start) {
+#ifdef SUPPORT_HARD_LINKS
+               if (preserve_hard_links && inc_recurse) {
+                       while (!flist_eof && file_total < FILECNT_LOOKAHEAD/2)
+                               wait_for_receiver();
+               }
+#endif
+
+               if (inc_recurse && cur_flist->parent_ndx >= 0) {
                        struct file_struct *fp = dir_flist->files[cur_flist->parent_ndx];
-                       if (BITS_SETnUNSET(fp->flags, FLAG_XFER_DIR, FLAG_MISSING_DIR)) {
-                               dev_t dirdev;
-                               if (one_file_system) {
-                                       uint32 *devp = F_DIRDEV_P(fp);
-                                       dirdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
+                       f_name(fp, fbuf);
+                       ndx = cur_flist->ndx_start - 1;
+                       recv_generator(fbuf, fp, ndx, itemizing, code, f_out);
+                       if (delete_during && dry_run < 2 && !list_only
+                        && !(fp->flags & FLAG_MISSING_DIR)) {
+                               if (fp->flags & FLAG_CONTENT_DIR) {
+                                       dev_t dirdev;
+                                       if (one_file_system) {
+                                               uint32 *devp = F_DIR_DEV_P(fp);
+                                               dirdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
+                                       } else
+                                               dirdev = MAKEDEV(0, 0);
+                                       delete_in_dir(fbuf, fp, &dirdev);
                                } else
-                                       dirdev = MAKEDEV(0, 0);
-                               delete_in_dir(cur_flist, f_name(fp, fbuf), fp, &dirdev);
+                                       change_local_filter_dir(fbuf, strlen(fbuf), F_DEPTH(fp));
                        }
                }
                for (i = cur_flist->low; i <= cur_flist->high; i++) {
-                       struct file_struct *file = cur_flist->files[i];
+                       struct file_struct *file = cur_flist->sorted[i];
 
                        if (!F_IS_ACTIVE(file))
                                continue;
 
-                       if (local_name)
-                               strlcpy(fbuf, local_name, sizeof fbuf);
+                       if (unsort_ndx)
+                               ndx = F_NDX(file);
                        else
-                               f_name(file, fbuf);
-                       recv_generator(fbuf, file, i, itemizing, code, f_out);
+                               ndx = i + cur_flist->ndx_start;
 
-                       /* We need to ensure that any dirs we create have
-                        * writeable permissions during the time we are putting
-                        * files within them.  This is then fixed after the
-                        * transfer is done. */
-#ifdef HAVE_CHMOD
-                       if (!am_root && S_ISDIR(file->mode)
-                        && !(file->mode & S_IWUSR) && dir_tweaking) {
-                               mode_t mode = file->mode | S_IWUSR;
-                               char *fname = local_name ? local_name : fbuf;
-                               if (do_chmod(fname, mode) < 0) {
-                                       rsyserr(FERROR, errno,
-                                           "failed to modify permissions on %s",
-                                           full_fname(fname));
-                               }
-                               need_retouch_dir_perms = 1;
-                       }
-#endif
+                       if (solo_file)
+                               strlcpy(fbuf, solo_file, sizeof fbuf);
+                       else
+                               f_name(file, fbuf);
+                       recv_generator(fbuf, file, ndx, itemizing, code, f_out);
 
-#ifdef SUPPORT_HARD_LINKS
-                       if (preserve_hard_links)
-                               check_for_finished_hlinks(itemizing, code);
-#endif
+                       check_for_finished_files(itemizing, code, 0);
 
                        if (allowed_lull && !(i % lull_mod))
                                maybe_send_keepalive();
-                       else if (!(i % 200))
-                               maybe_flush_socket();
-               }
-
-               if (!incremental) {
-                       if (delete_during)
-                               delete_in_dir(NULL, NULL, NULL, &dev_zero);
-                       phase++;
-                       if (verbose > 2) {
-                               rprintf(FINFO, "generate_files phase=%d\n",
-                                       phase);
-                       }
-
-                       write_int(f_out, NDX_DONE);
+                       else if (!(i & 0xFF))
+                               maybe_flush_socket(0);
                }
 
-               csum_length = SUM_LENGTH;
-               max_size = -max_size;
-               min_size = -min_size;
-               ignore_existing = -ignore_existing;
-               ignore_non_existing = -ignore_non_existing;
-               update_only = -update_only;
-               always_checksum = -always_checksum;
-               size_only = -size_only;
-               append_mode = -append_mode;
-               make_backups = -make_backups; /* avoid dup backup w/inplace */
-               ignore_times++;
-
-               /* Files can cycle through the system more than once
-                * to catch initial checksum errors. */
-               while (!done_cnt) {
-                       struct file_struct *file;
-                       struct file_list *save_flist;
-
-                       check_for_finished_hlinks(itemizing, code);
-
-                       if ((i = get_redo_num()) == -1) {
-                               if (incremental)
-                                       break;
-                               wait_for_receiver();
-                               continue;
-                       }
-
-                       save_flist = cur_flist;
-                       cur_flist = flist_for_ndx(i);
-                       file = cur_flist->files[i];
-                       if (local_name)
-                               strlcpy(fbuf, local_name, sizeof fbuf);
-                       else
-                               f_name(file, fbuf);
-                       recv_generator(fbuf, file, i, itemizing, code, f_out);
-                       cur_flist->to_redo--;
-                       cur_flist = save_flist;
-               }
-
-               csum_length = SHORT_SUM_LENGTH;
-               max_size = -max_size;
-               min_size = -min_size;
-               ignore_existing = -ignore_existing;
-               ignore_non_existing = -ignore_non_existing;
-               update_only = -update_only;
-               always_checksum = -always_checksum;
-               size_only = -size_only;
-               append_mode = -append_mode;
-               make_backups = -make_backups;
-               ignore_times--;
-
-               if (!incremental)
+               if (!inc_recurse) {
+                       write_ndx(f_out, NDX_DONE);
                        break;
+               }
 
-               while (!cur_flist->next && !flist_eof)
+               while (1) {
+                       check_for_finished_files(itemizing, code, 1);
+                       if (cur_flist->next || flist_eof)
+                               break;
                        wait_for_receiver();
-               next_flist = cur_flist->next;
-               while (first_flist != next_flist) {
-                       struct file_struct *fp;
-                       if (first_flist->in_progress || first_flist->to_redo) {
-                               if (next_flist)
-                                       break;
-                               wait_for_receiver();
-                               continue;
-                       }
-
-                       cur_flist = first_flist;
-                       if (cur_flist->ndx_start != 0) {
-                               fp = dir_flist->files[cur_flist->parent_ndx];
-                               if (!(fp->flags & FLAG_MISSING_DIR)) {
-                                       f_name(fp, fbuf);
-                                       if (!(fp->mode & S_IWUSR))
-                                               do_chmod(fbuf, fp->mode);
-                                       if (preserve_times && !omit_dir_times) {
-                                               set_modtime(fbuf, fp->modtime,
-                                                           fp->mode);
-                                       }
-                               }
-                       } else if (relative_paths && implied_dirs
-                           && preserve_times && !omit_dir_times) {
-                               /* Set mtime on implied dirs */
-                               for (i = 0; i < cur_flist->count; i++) {
-                                       fp = cur_flist->files[i];
-                                       if (!S_ISDIR(fp->mode)
-                                        || fp->flags & (FLAG_XFER_DIR|FLAG_MISSING_DIR))
-                                               continue;
-                                       f_name(fp, fbuf);
-                                       set_modtime(fbuf, fp->modtime, fp->mode);
-                               }
-                       }
+               }
+       } while ((cur_flist = cur_flist->next) != NULL);
 
-                       flist_free(cur_flist);
+       if (delete_during)
+               delete_in_dir(NULL, NULL, &dev_zero);
+       phase++;
+       if (verbose > 2)
+               rprintf(FINFO, "generate_files phase=%d\n", phase);
 
-                       if (!read_batch)
-                               write_int(f_out, NDX_DONE);
-               }
-       } while ((cur_flist = next_flist) != NULL);
+       while (1) {
+               check_for_finished_files(itemizing, code, 1);
+               if (msgdone_cnt)
+                       break;
+               wait_for_receiver();
+       }
 
        phase++;
        if (verbose > 2)
                rprintf(FINFO, "generate_files phase=%d\n", phase);
 
-       write_int(f_out, NDX_DONE);
+       write_ndx(f_out, NDX_DONE);
        /* Reduce round-trip lag-time for a useless delay-updates phase. */
        if (protocol_version >= 29 && !delay_updates)
-               write_int(f_out, NDX_DONE);
+               write_ndx(f_out, NDX_DONE);
 
        /* Read MSG_DONE for the redo phase (and any prior messages). */
-       while (done_cnt <= 1) {
-               check_for_finished_hlinks(itemizing, code);
+       while (1) {
+               check_for_finished_files(itemizing, code, 0);
+               if (msgdone_cnt > 1)
+                       break;
                wait_for_receiver();
        }
 
@@ -1892,48 +2282,21 @@ void generate_files(int f_out, char *local_name)
                if (verbose > 2)
                        rprintf(FINFO, "generate_files phase=%d\n", phase);
                if (delay_updates)
-                       write_int(f_out, NDX_DONE);
+                       write_ndx(f_out, NDX_DONE);
                /* Read MSG_DONE for delay-updates phase & prior messages. */
-               while (done_cnt == 2)
+               while (msgdone_cnt == 2)
                        wait_for_receiver();
        }
 
        do_progress = save_do_progress;
        if (delete_during == 2)
                do_delayed_deletions(fbuf);
-       if (delete_after && !local_name && file_total > 0)
-               do_delete_pass(cur_flist);
+       if (delete_after && !solo_file && file_total > 0)
+               do_delete_pass();
 
        if ((need_retouch_dir_perms || need_retouch_dir_times)
-        && dir_tweaking && !incremental) {
-               int j = 0;
-               /* Now we need to fix any directory permissions that were
-                * modified during the transfer and/or re-set any tweaked
-                * modified-time values. */
-               for (i = 0; i < cur_flist->count; i++) {
-                       struct file_struct *file = cur_flist->files[i];
-                       if (!F_IS_ACTIVE(file) || !S_ISDIR(file->mode))
-                               continue;
-                       if (!need_retouch_dir_times && file->mode & S_IWUSR)
-                               continue;
-                       if (file->flags & FLAG_MISSING_DIR) {
-                               int missing = F_DEPTH(file);
-                               while (++i < cur_flist->count) {
-                                       file = cur_flist->files[i];
-                                       if (F_DEPTH(file) <= missing)
-                                               break;
-                               }
-                               i--;
-                               continue;
-                       }
-                       recv_generator(f_name(file, NULL), file, i, itemizing,
-                                      code, -1);
-                       if (allowed_lull && !(++j % lull_mod))
-                               maybe_send_keepalive();
-                       else if (!(j % 200))
-                               maybe_flush_socket();
-               }
-       }
+        && dir_tweaking && (!inc_recurse || delete_during == 2))
+               touch_up_dirs(dir_flist, -1);
 
        if (max_delete >= 0 && deletion_count > max_delete) {
                rprintf(FINFO,