Avoid changing file_extra_cnt during deletion.
[rsync/rsync.git] / generator.c
index 7c329f2..d17e3b9 100644 (file)
@@ -4,7 +4,7 @@
  * Copyright (C) 1996-2000 Andrew Tridgell
  * Copyright (C) 1996 Paul Mackerras
  * Copyright (C) 2002 Martin Pool <mbp@samba.org>
- * Copyright (C) 2003-2008 Wayne Davison
+ * Copyright (C) 2003-2009 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -21,8 +21,9 @@
  */
 
 #include "rsync.h"
+#include "inums.h"
+#include "ifuncs.h"
 
-extern int verbose;
 extern int dry_run;
 extern int do_xfers;
 extern int stdout_format_has_i;
@@ -31,7 +32,6 @@ extern int am_root;
 extern int am_server;
 extern int am_daemon;
 extern int inc_recurse;
-extern int do_progress;
 extern int relative_paths;
 extern int implied_dirs;
 extern int keep_dirlinks;
@@ -44,17 +44,17 @@ extern int preserve_hard_links;
 extern int preserve_executability;
 extern int preserve_perms;
 extern int preserve_times;
-extern int uid_ndx;
-extern int gid_ndx;
 extern int delete_mode;
 extern int delete_before;
 extern int delete_during;
 extern int delete_after;
+extern int missing_args;
 extern int msgdone_cnt;
 extern int ignore_errors;
 extern int remove_source_files;
 extern int delay_updates;
 extern int update_only;
+extern int human_readable;
 extern int ignore_existing;
 extern int ignore_non_existing;
 extern int inplace;
@@ -69,14 +69,12 @@ extern int io_error;
 extern int flist_eof;
 extern int allowed_lull;
 extern int sock_f_out;
-extern int ignore_timeout;
 extern int protocol_version;
 extern int file_total;
 extern int fuzzy_basis;
 extern int always_checksum;
 extern int checksum_len;
 extern char *partial_dir;
-extern char *basis_dir[];
 extern int compare_dest;
 extern int copy_dest;
 extern int link_dest;
@@ -89,234 +87,40 @@ extern int unsort_ndx;
 extern int max_delete;
 extern int force_delete;
 extern int one_file_system;
-extern struct stats stats;
+extern int skipped_deletes;
 extern dev_t filesystem_dev;
 extern mode_t orig_umask;
 extern uid_t our_uid;
-extern char *backup_dir;
-extern char *backup_suffix;
-extern int backup_suffix_len;
+extern char *tmpdir;
+extern char *basis_dir[MAX_BASIS_DIRS+1];
 extern struct file_list *cur_flist, *first_flist, *dir_flist;
-extern struct filter_list_struct daemon_filter_list;
+extern filter_rule_list filter_list, daemon_filter_list;
 
-int ignore_perishable = 0;
-int non_perishable_cnt = 0;
 int maybe_ATTRS_REPORT = 0;
 
 static dev_t dev_zero;
-static int deletion_count = 0; /* used to implement --max-delete */
 static int deldelay_size = 0, deldelay_cnt = 0;
 static char *deldelay_buf = NULL;
 static int deldelay_fd = -1;
-static int lull_mod;
+static int loopchk_limit;
 static int dir_tweaking;
 static int symlink_timeset_failed_flags;
 static int need_retouch_dir_times;
 static int need_retouch_dir_perms;
 static const char *solo_file = NULL;
 
-/* For calling delete_item() and delete_dir_contents(). */
-#define DEL_NO_UID_WRITE       (1<<0) /* file/dir has our uid w/o write perm */
-#define DEL_RECURSE            (1<<1) /* if dir, delete all contents */
-#define DEL_DIR_IS_EMPTY       (1<<2) /* internal delete_FUNCTIONS use only */
-#define DEL_FOR_FILE           (1<<3) /* making room for a replacement file */
-#define DEL_FOR_DIR            (1<<4) /* making room for a replacement dir */
-#define DEL_FOR_SYMLINK        (1<<5) /* making room for a replacement symlink */
-#define DEL_FOR_DEVICE         (1<<6) /* making room for a replacement device */
-#define DEL_FOR_SPECIAL        (1<<7) /* making room for a replacement special */
-
-#define DEL_MAKE_ROOM (DEL_FOR_FILE|DEL_FOR_DIR|DEL_FOR_SYMLINK|DEL_FOR_DEVICE|DEL_FOR_SPECIAL)
-
 enum nonregtype {
     TYPE_DIR, TYPE_SPECIAL, TYPE_DEVICE, TYPE_SYMLINK
 };
 
-enum delret {
-    DR_SUCCESS = 0, DR_FAILURE, DR_AT_LIMIT, DR_NOT_EMPTY
-};
-
 /* Forward declarations. */
-static enum delret delete_dir_contents(char *fname, uint16 flags);
 #ifdef SUPPORT_HARD_LINKS
 static void handle_skipped_hlink(struct file_struct *file, int itemizing,
                                 enum logcode code, int f_out);
 #endif
 
-static int is_backup_file(char *fn)
-{
-       int k = strlen(fn) - backup_suffix_len;
-       return k > 0 && strcmp(fn+k, backup_suffix) == 0;
-}
-
-/* Delete a file or directory.  If DEL_RECURSE is set in the flags, this will
- * delete recursively.
- *
- * Note that fbuf must point to a MAXPATHLEN buffer if the mode indicates it's
- * a directory! (The buffer is used for recursion, but returned unchanged.)
- */
-static enum delret delete_item(char *fbuf, uint16 mode, uint16 flags)
-{
-       enum delret ret;
-       char *what;
-       int ok;
-
-       if (verbose > 2) {
-               rprintf(FINFO, "delete_item(%s) mode=%o flags=%d\n",
-                       fbuf, (int)mode, (int)flags);
-       }
-
-       if (flags & DEL_NO_UID_WRITE)
-               do_chmod(fbuf, mode | S_IWUSR);
-
-       if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) {
-               int save_uid_ndx = uid_ndx;
-               /* This only happens on the first call to delete_item() since
-                * delete_dir_contents() always calls us w/DEL_DIR_IS_EMPTY. */
-               if (!uid_ndx)
-                       uid_ndx = ++file_extra_cnt;
-               ignore_perishable = 1;
-               /* If DEL_RECURSE is not set, this just reports emptiness. */
-               ret = delete_dir_contents(fbuf, flags);
-               ignore_perishable = 0;
-               if (!save_uid_ndx) {
-                       --file_extra_cnt;
-                       uid_ndx = 0;
-               }
-               if (ret == DR_NOT_EMPTY || ret == DR_AT_LIMIT)
-                       goto check_ret;
-               /* OK: try to delete the directory. */
-       }
-
-       if (!(flags & DEL_MAKE_ROOM) && max_delete >= 0 && ++deletion_count > max_delete)
-               return DR_AT_LIMIT;
-
-       if (S_ISDIR(mode)) {
-               what = "rmdir";
-               ok = do_rmdir(fbuf) == 0;
-       } else if (make_backups > 0 && (backup_dir || !is_backup_file(fbuf))) {
-               what = "make_backup";
-               ok = make_backup(fbuf);
-       } else {
-               what = "unlink";
-               ok = robust_unlink(fbuf) == 0;
-       }
-
-       if (ok) {
-               if (!(flags & DEL_MAKE_ROOM))
-                       log_delete(fbuf, mode);
-               ret = DR_SUCCESS;
-       } else {
-               if (S_ISDIR(mode) && errno == ENOTEMPTY) {
-                       rprintf(FINFO, "cannot delete non-empty directory: %s\n",
-                               fbuf);
-                       ret = DR_NOT_EMPTY;
-               } else if (errno != ENOENT) {
-                       rsyserr(FERROR, errno, "delete_file: %s(%s) failed",
-                               what, fbuf);
-                       ret = DR_FAILURE;
-               } else {
-                       deletion_count--;
-                       ret = DR_SUCCESS;
-               }
-       }
-
-  check_ret:
-       if (ret != DR_SUCCESS && flags & DEL_MAKE_ROOM) {
-               const char *desc;
-               switch (flags & DEL_MAKE_ROOM) {
-               case DEL_FOR_FILE: desc = "regular file"; break;
-               case DEL_FOR_DIR: desc = "directory"; break;
-               case DEL_FOR_SYMLINK: desc = "symlink"; break;
-               case DEL_FOR_DEVICE: desc = "device file"; break;
-               case DEL_FOR_SPECIAL: desc = "special file"; break;
-               default: exit_cleanup(RERR_UNSUPPORTED); /* IMPOSSIBLE */
-               }
-               rprintf(FERROR_XFER, "could not make way for new %s: %s\n",
-                       desc, fbuf);
-       }
-       return ret;
-}
-
-/* The directory is about to be deleted: if DEL_RECURSE is given, delete all
- * its contents, otherwise just checks for content.  Returns DR_SUCCESS or
- * DR_NOT_EMPTY.  Note that fname must point to a MAXPATHLEN buffer!  (The
- * buffer is used for recursion, but returned unchanged.)
- */
-static enum delret delete_dir_contents(char *fname, uint16 flags)
-{
-       struct file_list *dirlist;
-       enum delret ret;
-       unsigned remainder;
-       void *save_filters;
-       int j, dlen;
-       char *p;
-
-       if (verbose > 3) {
-               rprintf(FINFO, "delete_dir_contents(%s) flags=%d\n",
-                       fname, flags);
-       }
-
-       dlen = strlen(fname);
-       save_filters = push_local_filters(fname, dlen);
-
-       non_perishable_cnt = 0;
-       dirlist = get_dirlist(fname, dlen, 0);
-       ret = non_perishable_cnt ? DR_NOT_EMPTY : DR_SUCCESS;
-
-       if (!dirlist->used)
-               goto done;
-
-       if (!(flags & DEL_RECURSE)) {
-               ret = DR_NOT_EMPTY;
-               goto done;
-       }
-
-       p = fname + dlen;
-       if (dlen != 1 || *fname != '/')
-               *p++ = '/';
-       remainder = MAXPATHLEN - (p - fname);
-
-       /* We do our own recursion, so make delete_item() non-recursive. */
-       flags = (flags & ~(DEL_RECURSE|DEL_MAKE_ROOM|DEL_NO_UID_WRITE))
-             | DEL_DIR_IS_EMPTY;
-
-       for (j = dirlist->used; j--; ) {
-               struct file_struct *fp = dirlist->files[j];
-
-               if (fp->flags & FLAG_MOUNT_DIR && S_ISDIR(fp->mode)) {
-                       if (verbose > 1) {
-                               rprintf(FINFO,
-                                   "mount point, %s, pins parent directory\n",
-                                   f_name(fp, NULL));
-                       }
-                       ret = DR_NOT_EMPTY;
-                       continue;
-               }
-
-               strlcpy(p, fp->basename, remainder);
-               if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid)
-                       do_chmod(fname, fp->mode | S_IWUSR);
-               /* Save stack by recursing to ourself directly. */
-               if (S_ISDIR(fp->mode)) {
-                       if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
-                               ret = DR_NOT_EMPTY;
-               }
-               if (delete_item(fname, fp->mode, flags) != DR_SUCCESS)
-                       ret = DR_NOT_EMPTY;
-       }
-
-       fname[dlen] = '\0';
-
-  done:
-       flist_free(dirlist);
-       pop_local_filters(save_filters);
-
-       if (ret == DR_NOT_EMPTY) {
-               rprintf(FINFO, "cannot delete non-empty directory: %s\n",
-                       fname);
-       }
-       return ret;
-}
+#define EARLY_DELAY_DONE_MSG() (!delay_updates)
+#define EARLY_DELETE_DONE_MSG() (!(delete_during == 2 || delete_after))
 
 static int start_delete_delay_temp(void)
 {
@@ -324,7 +128,7 @@ static int start_delete_delay_temp(void)
        int save_dry_run = dry_run;
 
        dry_run = 0;
-       if (!get_tmpname(fnametmp, "deldelay")
+       if (!get_tmpname(fnametmp, "deldelay", False)
         || (deldelay_fd = do_mkstemp(fnametmp, 0600)) < 0) {
                rprintf(FINFO, "NOTE: Unable to create delete-delay temp file%s.\n",
                        inc_recurse ? "" : " -- switching to --delete-after");
@@ -472,18 +276,17 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
        struct file_list *dirlist;
        char delbuf[MAXPATHLEN];
        int dlen, i;
-       int save_uid_ndx = uid_ndx;
 
        if (!fbuf) {
                change_local_filter_dir(NULL, 0, 0);
                return;
        }
 
-       if (verbose > 2)
+       if (DEBUG_GTE(DEL, 2))
                rprintf(FINFO, "delete_in_dir(%s)\n", fbuf);
 
        if (allowed_lull)
-               maybe_send_keepalive();
+               maybe_send_keepalive(time(NULL), MSK_ALLOW_FLUSH);
 
        if (io_error && !ignore_errors) {
                if (already_warned)
@@ -504,9 +307,6 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
                        return;
        }
 
-       if (!uid_ndx)
-               uid_ndx = ++file_extra_cnt;
-
        dirlist = get_dirlist(fbuf, dlen, 0);
 
        /* If an item in dirlist is not found in flist, delete it
@@ -516,14 +316,17 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
                if (!F_IS_ACTIVE(fp))
                        continue;
                if (fp->flags & FLAG_MOUNT_DIR && S_ISDIR(fp->mode)) {
-                       if (verbose > 1)
+                       if (INFO_GTE(MOUNT, 1))
                                rprintf(FINFO, "cannot delete mount point: %s\n",
                                        f_name(fp, NULL));
                        continue;
                }
-               if (flist_find(cur_flist, fp) < 0) {
+               /* Here we want to match regardless of file type.  Replacement
+                * of a file with one of another type is handled separately by
+                * a delete_item call with a DEL_MAKE_ROOM flag. */
+               if (flist_find_ignore_dirness(cur_flist, fp) < 0) {
                        int flags = DEL_RECURSE;
-                       if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid)
+                       if (!(fp->mode & S_IWUSR) && !am_root && fp->flags & FLAG_OWNED_BY_US)
                                flags |= DEL_NO_UID_WRITE;
                        f_name(fp, delbuf);
                        if (delete_during == 2) {
@@ -535,11 +338,6 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
        }
 
        flist_free(dirlist);
-
-       if (!save_uid_ndx) {
-               --file_extra_cnt;
-               uid_ndx = 0;
-       }
 }
 
 /* This deletes any files on the receiving side that are not present on the
@@ -564,7 +362,7 @@ static void do_delete_pass(void)
                        continue;
                }
 
-               if (verbose > 1 && file->flags & FLAG_TOP_DIR)
+               if (DEBUG_GTE(DEL, 1) && file->flags & FLAG_TOP_DIR)
                        rprintf(FINFO, "deleting in %s\n", fbuf);
 
                if (link_stat(fbuf, &st, keep_dirlinks) < 0
@@ -575,50 +373,105 @@ static void do_delete_pass(void)
        }
        delete_in_dir(NULL, NULL, &dev_zero);
 
-       if (do_progress && !am_server)
+       if (INFO_GTE(FLIST, 2) && !am_server)
                rprintf(FINFO, "                    \r");
 }
 
-int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
+static inline int time_differs(struct file_struct *file, stat_x *sxp)
 {
-#if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
-       if (S_ISLNK(file->mode)) {
-               ;
-       } else
-#endif
-       if (preserve_times && cmp_time(sxp->st.st_mtime, file->modtime) != 0)
-               return 0;
+       return cmp_time(sxp->st.st_mtime, file->modtime);
+}
 
-       if (preserve_perms) {
-               if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
-                       return 0;
-       } else if (preserve_executability
-        && ((sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0)))
-               return 0;
+static inline int perms_differ(struct file_struct *file, stat_x *sxp)
+{
+       if (preserve_perms)
+               return !BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS);
+
+       if (preserve_executability)
+               return (sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0);
+
+       return 0;
+}
 
+static inline int ownership_differs(struct file_struct *file, stat_x *sxp)
+{
        if (am_root && uid_ndx && sxp->st.st_uid != (uid_t)F_OWNER(file))
-               return 0;
+               return 1;
 
        if (gid_ndx && !(file->flags & FLAG_SKIP_GROUP) && sxp->st.st_gid != (gid_t)F_GROUP(file))
-               return 0;
+               return 1;
+
+       return 0;
+}
 
 #ifdef SUPPORT_ACLS
-       if (preserve_acls && !S_ISLNK(file->mode)) {
+static inline int acls_differ(const char *fname, struct file_struct *file, stat_x *sxp)
+{
+       if (preserve_acls) {
                if (!ACL_READY(*sxp))
                        get_acl(fname, sxp);
-               if (set_acl(NULL, file, sxp) == 0)
-                       return 0;
+               if (set_acl(NULL, file, sxp, file->mode))
+                       return 1;
        }
+
+       return 0;
+}
 #endif
+
 #ifdef SUPPORT_XATTRS
+static inline int xattrs_differ(const char *fname, struct file_struct *file, stat_x *sxp)
+{
        if (preserve_xattrs) {
                if (!XATTR_READY(*sxp))
                        get_xattr(fname, sxp);
                if (xattr_diff(file, sxp, 0))
-                       return 0;
+                       return 1;
        }
+
+       return 0;
+}
 #endif
 
+int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
+{
+       if (S_ISLNK(file->mode)) {
+#ifdef CAN_SET_SYMLINK_TIMES
+               if (preserve_times & PRESERVE_LINK_TIMES && time_differs(file, sxp))
+                       return 0;
+#endif
+#ifdef CAN_CHMOD_SYMLINK
+               if (perms_differ(file, sxp))
+                       return 0;
+#endif
+#ifndef CAN_CHOWN_SYMLINK
+               if (ownership_differs(file, sxp))
+                       return 0;
+#endif
+#if defined SUPPORT_ACLS && 0 /* no current symlink-ACL support */
+               if (acls_differ(fname, file, sxp))
+                       return 0;
+#endif
+#if defined SUPPORT_XATTRS && !defined NO_SYMLINK_XATTRS
+               if (xattrs_differ(fname, file, sxp))
+                       return 0;
+#endif
+       } else {
+               if (preserve_times && time_differs(file, sxp))
+                       return 0;
+               if (perms_differ(file, sxp))
+                       return 0;
+               if (ownership_differs(file, sxp))
+                       return 0;
+#ifdef SUPPORT_ACLS
+               if (acls_differ(fname, file, sxp))
+                       return 0;
+#endif
+#ifdef SUPPORT_XATTRS
+               if (xattrs_differ(fname, file, sxp))
+                       return 0;
+#endif
+       }
+
        return 1;
 }
 
@@ -628,12 +481,9 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
 {
        if (statret >= 0) { /* A from-dest-dir statret can == 1! */
                int keep_time = !preserve_times ? 0
-                   : S_ISDIR(file->mode) ? preserve_times > 1 :
-#if defined HAVE_LUTIMES && defined HAVE_UTIMES
-                   1;
-#else
-                   !S_ISLNK(file->mode);
-#endif
+                   : S_ISDIR(file->mode) ? preserve_times & PRESERVE_DIR_TIMES
+                   : S_ISLNK(file->mode) ? preserve_times & PRESERVE_LINK_TIMES
+                   : 1;
 
                if (S_ISREG(file->mode) && F_LENGTH(file) != sxp->st.st_size)
                        iflags |= ITEM_REPORT_SIZE;
@@ -665,7 +515,7 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
                if (preserve_acls && !S_ISLNK(file->mode)) {
                        if (!ACL_READY(*sxp))
                                get_acl(fnamecmp, sxp);
-                       if (set_acl(NULL, file, sxp) == 0)
+                       if (set_acl(NULL, file, sxp, file->mode))
                                iflags |= ITEM_REPORT_ACL;
                }
 #endif
@@ -686,7 +536,7 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
        }
 
        iflags &= 0xffff;
-       if ((iflags & (SIGNIFICANT_ITEM_FLAGS|ITEM_REPORT_XATTR) || verbose > 1
+       if ((iflags & (SIGNIFICANT_ITEM_FLAGS|ITEM_REPORT_XATTR) || INFO_GTE(NAME, 2)
          || stdout_format_has_i > 1 || (xname && *xname)) && !read_batch) {
                if (protocol_version >= 29) {
                        if (ndx >= 0)
@@ -697,12 +547,15 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
                        if (iflags & ITEM_XNAME_FOLLOWS)
                                write_vstring(sock_f_out, xname, strlen(xname));
 #ifdef SUPPORT_XATTRS
-                       if (iflags & ITEM_REPORT_XATTR && !dry_run)
-                               send_xattr_request(NULL, file, sock_f_out);
+                       if (preserve_xattrs && do_xfers
+                        && iflags & (ITEM_REPORT_XATTR|ITEM_TRANSFER)) {
+                               send_xattr_request(NULL, file,
+                                       iflags & ITEM_REPORT_XATTR ? sock_f_out : -1);
+                       }
 #endif
                } else if (ndx >= 0) {
                        enum logcode code = logfile_format_has_i ? FINFO : FCLIENT;
-                       log_item(code, file, &stats, iflags, xname);
+                       log_item(code, file, iflags, xname);
                }
        }
 }
@@ -753,18 +606,25 @@ static void sum_sizes_sqroot(struct sum_struct *sum, int64 len)
 {
        int32 blength;
        int s2length;
+       int64 l;
+
+       if (len < 0) {
+               /* The file length overflowed our int64 var, so we can't process this file. */
+               sum->count = -1; /* indicate overflow error */
+               return;
+       }
 
        if (block_size)
                blength = block_size;
        else if (len <= BLOCK_SIZE * BLOCK_SIZE)
                blength = BLOCK_SIZE;
        else {
+               int32 max_blength = protocol_version < 30 ? OLD_MAX_BLOCK_SIZE : MAX_BLOCK_SIZE;
                int32 c;
-               int64 l;
                int cnt;
                for (c = 1, l = len, cnt = 0; l >>= 2; c <<= 1, cnt++) {}
-               if (cnt >= 31 || c >= MAX_BLOCK_SIZE)
-                       blength = MAX_BLOCK_SIZE;
+               if (c < 0 || c >= max_blength)
+                       blength = max_blength;
                else {
                    blength = 0;
                    do {
@@ -783,7 +643,6 @@ static void sum_sizes_sqroot(struct sum_struct *sum, int64 len)
                s2length = SUM_LENGTH;
        } else {
                int32 c;
-               int64 l;
                int b = BLOCKSUM_BIAS;
                for (l = len; l >>= 1; b += 2) {}
                for (c = blength; (c >>= 1) && b; b--) {}
@@ -797,13 +656,16 @@ static void sum_sizes_sqroot(struct sum_struct *sum, int64 len)
        sum->blength    = blength;
        sum->s2length   = s2length;
        sum->remainder  = (int32)(len % blength);
-       sum->count      = (int32)(len / blength) + (sum->remainder != 0);
+       sum->count      = (int32)(l = (len / blength) + (sum->remainder != 0));
 
-       if (sum->count && verbose > 2) {
+       if ((int64)sum->count != l)
+               sum->count = -1;
+
+       if (sum->count && DEBUG_GTE(DELTASUM, 2)) {
                rprintf(FINFO,
-                       "count=%.0f rem=%ld blength=%ld s2length=%d flength=%.0f\n",
-                       (double)sum->count, (long)sum->remainder, (long)sum->blength,
-                       sum->s2length, (double)sum->flength);
+                       "count=%s rem=%ld blength=%ld s2length=%d flength=%s\n",
+                       big_num(sum->count), (long)sum->remainder, (long)sum->blength,
+                       sum->s2length, big_num(sum->flength));
        }
 }
 
@@ -813,7 +675,7 @@ static void sum_sizes_sqroot(struct sum_struct *sum, int64 len)
  *
  * Generate approximately one checksum every block_len bytes.
  */
-static void generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
+static int generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
 {
        int32 i;
        struct map_struct *mapbuf;
@@ -821,10 +683,12 @@ static void generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
        OFF_T offset = 0;
 
        sum_sizes_sqroot(&sum, len);
+       if (sum.count < 0)
+               return -1;
        write_sum_head(f_out, &sum);
 
        if (append_mode > 0 && f_copy < 0)
-               return;
+               return 0;
 
        if (len > 0)
                mapbuf = map_file(fd, len, MAX_MAP_SIZE, sum.blength);
@@ -849,10 +713,10 @@ static void generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
                sum1 = get_checksum1(map, n1);
                get_checksum2(map, n1, sum2);
 
-               if (verbose > 3) {
+               if (DEBUG_GTE(DELTASUM, 3)) {
                        rprintf(FINFO,
-                               "chunk[%.0f] offset=%.0f len=%ld sum1=%08lx\n",
-                               (double)i, (double)offset - n1, (long)n1,
+                               "chunk[%s] offset=%s len=%ld sum1=%08lx\n",
+                               big_num(i), big_num(offset - n1), (long)n1,
                                (unsigned long)sum1);
                }
                write_int(f_out, sum1);
@@ -861,6 +725,8 @@ static void generate_and_send_sums(int fd, OFF_T len, int f_out, int f_copy)
 
        if (mapbuf)
                unmap_file(mapbuf);
+
+       return 0;
 }
 
 
@@ -889,7 +755,7 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
 
                if (F_LENGTH(fp) == F_LENGTH(file)
                    && cmp_time(fp->modtime, file->modtime) == 0) {
-                       if (verbose > 4) {
+                       if (DEBUG_GTE(FUZZY, 2)) {
                                rprintf(FINFO,
                                        "fuzzy size/modtime match for %s\n",
                                        name);
@@ -904,7 +770,7 @@ static int find_fuzzy(struct file_struct *file, struct file_list *dirlist)
                /* Add some extra weight to how well the suffixes match. */
                dist += fuzzy_distance(suf, suf_len, fname_suf, fname_suf_len)
                      * 10;
-               if (verbose > 4) {
+               if (DEBUG_GTE(FUZZY, 2)) {
                        rprintf(FINFO, "fuzzy distance for %s = %d.%05d\n",
                                name, (int)(dist>>16), (int)(dist&0xFFFF));
                }
@@ -922,6 +788,7 @@ static int copy_altdest_file(const char *src, const char *dest, struct file_stru
 {
        char buf[MAXPATHLEN];
        const char *copy_to, *partialptr;
+       int save_preserve_xattrs = preserve_xattrs;
        int ok, fd_w;
 
        if (inplace) {
@@ -935,8 +802,8 @@ static int copy_altdest_file(const char *src, const char *dest, struct file_stru
                copy_to = buf;
        }
        cleanup_set(copy_to, NULL, NULL, -1, -1);
-       if (copy_file(src, copy_to, fd_w, file->mode, 0) < 0) {
-               if (verbose) {
+       if (copy_file(src, copy_to, fd_w, file->mode) < 0) {
+               if (INFO_GTE(COPY, 1)) {
                        rsyserr(FINFO, errno, "copy_file %s => %s",
                                full_fname(src), copy_to);
                }
@@ -946,7 +813,9 @@ static int copy_altdest_file(const char *src, const char *dest, struct file_stru
                return -1;
        }
        partialptr = partial_dir ? partial_dir_fname(dest) : NULL;
+       preserve_xattrs = 0; /* xattrs were copied with file */
        ok = finish_transfer(dest, copy_to, src, partialptr, file, 1, 0);
+       preserve_xattrs = save_preserve_xattrs;
        cleanup_disable();
        return ok ? 0 : -1;
 }
@@ -1004,7 +873,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                                goto try_a_copy;
                        if (preserve_hard_links && F_IS_HLINKED(file))
                                finish_hard_link(file, fname, ndx, &sxp->st, itemizing, code, j);
-                       if (!maybe_ATTRS_REPORT && (verbose > 1 || stdout_format_has_i > 1)) {
+                       if (!maybe_ATTRS_REPORT && (INFO_GTE(NAME, 2) || stdout_format_has_i > 1)) {
                                itemize(cmpbuf, file, ndx, 1, sxp,
                                        ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
                                        0, "");
@@ -1013,7 +882,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 #endif
                if (itemizing)
                        itemize(cmpbuf, file, ndx, 0, sxp, 0, 0, NULL);
-               if (verbose > 1 && maybe_ATTRS_REPORT)
+               if (INFO_GTE(NAME, 2) && maybe_ATTRS_REPORT)
                        rprintf(FCLIENT, "%s is uptodate\n", fname);
                return -2;
        }
@@ -1027,8 +896,8 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                if (itemizing)
                        itemize(cmpbuf, file, ndx, 0, sxp, ITEM_LOCAL_CHANGE, 0, NULL);
                if (maybe_ATTRS_REPORT
-                && ((!itemizing && verbose && match_level == 2)
-                 || (verbose > 1 && match_level == 3))) {
+                && ((!itemizing && INFO_GTE(NAME, 1) && match_level == 2)
+                 || (INFO_GTE(NAME, 2) && match_level == 3))) {
                        code = match_level == 3 ? FCLIENT : FINFO;
                        rprintf(code, "%s%s\n", fname,
                                match_level == 3 ? " is uptodate" : "");
@@ -1050,12 +919,15 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
                         char *cmpbuf, stat_x *sxp, int itemizing,
                         enum logcode code)
 {
-       char lnk[MAXPATHLEN];
        int best_match = -1;
        int match_level = 0;
        enum nonregtype type;
        uint32 *devp;
-       int len, j = 0;
+#ifdef SUPPORT_LINKS
+       char lnk[MAXPATHLEN];
+       int len;
+#endif
+       int j = 0;
 
 #ifndef SUPPORT_LINKS
        if (S_ISLNK(file->mode))
@@ -1095,11 +967,13 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
                        if (!IS_DEVICE(sxp->st.st_mode))
                                continue;
                        break;
-#ifdef SUPPORT_LINKS
                case TYPE_SYMLINK:
+#ifdef SUPPORT_LINKS
                        if (!S_ISLNK(sxp->st.st_mode))
                                continue;
                        break;
+#else
+                       return -1;
 #endif
                }
                if (match_level < 1) {
@@ -1108,21 +982,23 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
                }
                switch (type) {
                case TYPE_DIR:
-                       break;
                case TYPE_SPECIAL:
+                       break;
                case TYPE_DEVICE:
                        devp = F_RDEV_P(file);
                        if (sxp->st.st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
                                continue;
                        break;
-#ifdef SUPPORT_LINKS
                case TYPE_SYMLINK:
-                       if ((len = readlink(cmpbuf, lnk, MAXPATHLEN-1)) <= 0)
+#ifdef SUPPORT_LINKS
+                       if ((len = do_readlink(cmpbuf, lnk, MAXPATHLEN-1)) <= 0)
                                continue;
                        lnk[len] = '\0';
                        if (strcmp(lnk, F_SYMLINK(file)) != 0)
                                continue;
                        break;
+#else
+                       return -1;
 #endif
                }
                if (match_level < 2) {
@@ -1168,13 +1044,13 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 #endif
                        match_level = 2;
                if (itemizing && stdout_format_has_i
-                && (verbose > 1 || stdout_format_has_i > 1)) {
+                && (INFO_GTE(NAME, 2) || stdout_format_has_i > 1)) {
                        int chg = compare_dest && type != TYPE_DIR ? 0
                            : ITEM_LOCAL_CHANGE + (match_level == 3 ? ITEM_XNAME_FOLLOWS : 0);
                        char *lp = match_level == 3 ? "" : NULL;
                        itemize(cmpbuf, file, ndx, 0, sxp, chg + ITEM_MATCHED, 0, lp);
                }
-               if (verbose > 1 && maybe_ATTRS_REPORT) {
+               if (INFO_GTE(NAME, 2) && maybe_ATTRS_REPORT) {
                        rprintf(FCLIENT, "%s%s is uptodate\n",
                                fname, type == TYPE_DIR ? "/" : "");
                }
@@ -1187,7 +1063,8 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 static void list_file_entry(struct file_struct *f)
 {
        char permbuf[PERMSTRING_SIZE];
-       double len;
+       int64 len;
+       int colwidth = human_readable ? 14 : 11;
 
        if (!F_IS_ACTIVE(f)) {
                /* this can happen if duplicate names were removed */
@@ -1201,15 +1078,20 @@ static void list_file_entry(struct file_struct *f)
 
 #ifdef SUPPORT_LINKS
        if (preserve_links && S_ISLNK(f->mode)) {
-               rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
-                       permbuf, len, timestring(f->modtime),
-                       f_name(f, NULL), F_SYMLINK(f));
+               rprintf(FINFO, "%s %*s %s %s -> %s\n",
+                       permbuf, colwidth, human_num(len),
+                       timestring(f->modtime), f_name(f, NULL),
+                       F_SYMLINK(f));
        } else
 #endif
-       {
-               rprintf(FINFO, "%s %11.0f %s %s\n",
-                       permbuf, len, timestring(f->modtime),
+       if (missing_args == 2 && f->mode == 0) {
+               rprintf(FINFO, "%-*s %s\n",
+                       colwidth + 31, "*missing",
                        f_name(f, NULL));
+       } else {
+               rprintf(FINFO, "%s %*s %s %s\n",
+                       permbuf, colwidth, human_num(len),
+                       timestring(f->modtime), f_name(f, NULL));
        }
 }
 
@@ -1260,7 +1142,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                   : inc_recurse && ndx != cur_flist->ndx_start - 1 ? -1
                   : 1;
 
-       if (verbose > 2)
+       if (DEBUG_GTE(GENR, 1))
                rprintf(FINFO, "recv_generator(%s,%d)\n", fname, ndx);
 
        if (list_only) {
@@ -1284,7 +1166,8 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                skip_dir = NULL;
        }
 
-       if (daemon_filter_list.head) {
+       init_stat_x(&sx);
+       if (daemon_filter_list.head && (*fname != '.' || fname[1])) {
                if (check_filter(&daemon_filter_list, FLOG, fname, is_dir) < 0) {
                        if (is_dir < 0)
                                return;
@@ -1301,12 +1184,6 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                }
        }
 
-#ifdef SUPPORT_ACLS
-       sx.acc_acl = sx.def_acl = NULL;
-#endif
-#ifdef SUPPORT_XATTRS
-       sx.xattr = NULL;
-#endif
        if (dry_run > 1 || (dry_missing_dir && is_below(file, dry_missing_dir))) {
          parent_is_dry_missing:
                if (fuzzy_dirlist) {
@@ -1324,7 +1201,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                         && do_stat(dn, &sx.st) < 0) {
                                if (dry_run)
                                        goto parent_is_dry_missing;
-                               if (create_directory_path(fname) < 0) {
+                               if (make_path(fname, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0) {
                                        rsyserr(FERROR_XFER, errno,
                                                "recv_generator: mkdir %s failed",
                                                full_fname(dn));
@@ -1345,7 +1222,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
                if (need_fuzzy_dirlist && S_ISREG(file->mode)) {
                        strlcpy(fnamecmpbuf, dn, sizeof fnamecmpbuf);
-                       fuzzy_dirlist = get_dirlist(fnamecmpbuf, -1, 1);
+                       fuzzy_dirlist = get_dirlist(fnamecmpbuf, -1, GDL_IGNORE_FILTER_RULES);
                        need_fuzzy_dirlist = 0;
                }
 
@@ -1353,6 +1230,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                stat_errno = errno;
        }
 
+       if (missing_args == 2 && file->mode == 0) {
+               if (filter_list.head && check_filter(&filter_list, FINFO, fname, is_dir) < 0)
+                       return;
+               if (statret == 0)
+                       delete_item(fname, sx.st.st_mode, del_opts);
+               return;
+       }
+
        if (ignore_non_existing > 0 && statret == -1 && stat_errno == ENOENT) {
                if (is_dir) {
                        if (is_dir < 0)
@@ -1364,7 +1249,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                else if (F_IS_HLINKED(file))
                        handle_skipped_hlink(file, itemizing, code, f_out);
 #endif
-               if (verbose > 1) {
+               if (INFO_GTE(SKIP, 1)) {
                        rprintf(FINFO, "not creating new %s \"%s\"\n",
                                is_dir ? "directory" : "file", fname);
                }
@@ -1377,7 +1262,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
        if (ignore_existing > 0 && statret == 0
         && (!is_dir || !S_ISDIR(sx.st.st_mode))) {
-               if (verbose > 1 && is_dir >= 0)
+               if (INFO_GTE(SKIP, 1) && is_dir >= 0)
                        rprintf(FINFO, "%s exists\n", fname);
 #ifdef SUPPORT_HARD_LINKS
                if (F_IS_HLINKED(file))
@@ -1386,9 +1271,18 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                goto cleanup;
        }
 
+       fnamecmp = fname;
+
        if (is_dir) {
+               mode_t added_perms;
                if (!implied_dirs && file->flags & FLAG_IMPLIED_DIR)
                        goto cleanup;
+               if (am_root < 0) {
+                       /* For --fake-super, the dir must be useable by the copying
+                        * user, just like it would be for root. */
+                       added_perms = S_IRUSR|S_IWUSR|S_IXUSR;
+               } else
+                       added_perms = 0;
                if (is_dir < 0) {
                        /* In inc_recurse mode we want to make sure any missing
                         * directories get created while we're still processing
@@ -1399,7 +1293,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                         && (S_ISDIR(sx.st.st_mode)
                          || delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_DIR) != 0))
                                goto cleanup; /* Any errors get reported later. */
-                       if (do_mkdir(fname, file->mode & 0700) == 0)
+                       if (do_mkdir(fname, (file->mode|added_perms) & 0700) == 0)
                                file->flags |= FLAG_DIR_CREATED;
                        goto cleanup;
                }
@@ -1432,17 +1326,20 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        if (j == -2) {
                                itemizing = 0;
                                code = FNONE;
-                       } else if (j >= 0)
                                statret = 1;
+                       } else if (j >= 0) {
+                               statret = 1;
+                               fnamecmp = fnamecmpbuf;
+                       }
                }
                if (itemizing && f_out != -1) {
-                       itemize(fname, file, ndx, statret, &sx,
+                       itemize(fnamecmp, file, ndx, statret, &sx,
                                statret ? ITEM_LOCAL_CHANGE : 0, 0, NULL);
                }
-               if (real_ret != 0 && do_mkdir(fname,file->mode) < 0 && errno != EEXIST) {
+               if (real_ret != 0 && do_mkdir(fname,file->mode|added_perms) < 0 && errno != EEXIST) {
                        if (!relative_paths || errno != ENOENT
-                           || create_directory_path(fname) < 0
-                           || (do_mkdir(fname, file->mode) < 0 && errno != EEXIST)) {
+                        || make_path(fname, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0
+                        || (do_mkdir(fname, file->mode|added_perms) < 0 && errno != EEXIST)) {
                                rsyserr(FERROR_XFER, errno,
                                        "recv_generator: mkdir %s failed",
                                        full_fname(fname));
@@ -1454,8 +1351,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                goto cleanup;
                        }
                }
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs && statret == 1)
+                       copy_xattrs(fnamecmpbuf, fname);
+#endif
                if (set_file_attrs(fname, file, real_ret ? NULL : &real_sx, NULL, 0)
-                   && verbose && code != FNONE && f_out != -1)
+                   && INFO_GTE(NAME, 1) && code != FNONE && f_out != -1)
                        rprintf(code, "%s/\n", fname);
 
                /* We need to ensure that the dirs in the transfer have writable
@@ -1510,12 +1411,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 #ifdef SUPPORT_LINKS
                const char *sl = F_SYMLINK(file);
                if (safe_symlinks && unsafe_symlink(sl, fname)) {
-                       if (verbose) {
-                               if (solo_file)
+                       if (INFO_GTE(NAME, 1)) {
+                               if (solo_file) {
+                                       /* fname contains the destination path, but we
+                                        * want to report the source path. */
                                        fname = f_name(file, NULL);
+                               }
                                rprintf(FINFO,
-                                       "ignoring unsafe symlink %s -> \"%s\"\n",
-                                       full_fname(fname), sl);
+                                       "ignoring unsafe symlink \"%s\" -> \"%s\"\n",
+                                       fname, sl);
                        }
                        return;
                }
@@ -1523,10 +1427,9 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        char lnk[MAXPATHLEN];
                        int len;
 
-                       if (!S_ISLNK(sx.st.st_mode))
-                               statret = -1;
-                       else if ((len = readlink(fname, lnk, MAXPATHLEN-1)) > 0
-                             && strncmp(lnk, sl, len) == 0 && sl[len] == '\0') {
+                       if (S_ISLNK(sx.st.st_mode)
+                        && (len = do_readlink(fname, lnk, MAXPATHLEN-1)) > 0
+                        && strncmp(lnk, sl, len) == 0 && sl[len] == '\0') {
                                /* The link is pointing to the right place. */
                                set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                                if (itemizing)
@@ -1539,10 +1442,6 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                        goto return_with_success;
                                goto cleanup;
                        }
-                       /* Not the right symlink (or not a symlink), so
-                        * delete it. */
-                       if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_SYMLINK) != 0)
-                               goto cleanup;
                } else if (basis_dir[0] != NULL) {
                        int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
                                              itemizing, code);
@@ -1559,22 +1458,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        } else if (j >= 0)
                                statret = 1;
                }
-#ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
-                       cur_flist->in_progress++;
-                       goto cleanup;
-               }
-#endif
-               if (do_symlink(sl, fname) != 0) {
-                       rsyserr(FERROR_XFER, errno, "symlink %s -> \"%s\" failed",
-                               full_fname(fname), sl);
-               } else {
+               if (atomic_create(file, fname, sl, MAKEDEV(0, 0), &sx, statret == 0 ? DEL_FOR_SYMLINK : 0)) {
                        set_file_attrs(fname, file, NULL, NULL, 0);
                        if (itemizing) {
+                               if (statret == 0 && !S_ISLNK(sx.st.st_mode))
+                                       statret = -1;
                                itemize(fname, file, ndx, statret, &sx,
                                        ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL);
                        }
-                       if (code != FNONE && verbose)
+                       if (code != FNONE && INFO_GTE(NAME, 1))
                                rprintf(code, "%s -> %s\n", fname, sl);
 #ifdef SUPPORT_HARD_LINKS
                        if (preserve_hard_links && F_IS_HLINKED(file))
@@ -1592,10 +1484,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
        if ((am_root && preserve_devices && IS_DEVICE(file->mode))
         || (preserve_specials && IS_SPECIAL(file->mode))) {
-               uint32 *devp = F_RDEV_P(file);
-               dev_t rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
+               dev_t rdev;
+               int del_for_flag = 0;
+               if (IS_DEVICE(file->mode)) {
+                       uint32 *devp = F_RDEV_P(file);
+                       rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
+               } else
+                       rdev = 0;
                if (statret == 0) {
-                       int del_for_flag;
                        if (IS_DEVICE(file->mode)) {
                                if (!IS_DEVICE(sx.st.st_mode))
                                        statret = -1;
@@ -1607,7 +1503,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        }
                        if (statret == 0
                         && BITS_EQUAL(sx.st.st_mode, file->mode, _S_IFMT)
-                        && sx.st.st_rdev == rdev) {
+                        && (IS_SPECIAL(sx.st.st_mode) || sx.st.st_rdev == rdev)) {
                                /* The device or special file is identical. */
                                set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                                if (itemizing)
@@ -1620,8 +1516,6 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                        goto return_with_success;
                                goto cleanup;
                        }
-                       if (delete_item(fname, sx.st.st_mode, del_opts | del_for_flag) != 0)
-                               goto cleanup;
                } else if (basis_dir[0] != NULL) {
                        int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
                                              itemizing, code);
@@ -1638,27 +1532,18 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        } else if (j >= 0)
                                statret = 1;
                }
-#ifdef SUPPORT_HARD_LINKS
-               if (preserve_hard_links && F_HLINK_NOT_LAST(file)) {
-                       cur_flist->in_progress++;
-                       goto cleanup;
-               }
-#endif
-               if (verbose > 2) {
+               if (DEBUG_GTE(GENR, 1)) {
                        rprintf(FINFO, "mknod(%s, 0%o, [%ld,%ld])\n",
                                fname, (int)file->mode,
                                (long)major(rdev), (long)minor(rdev));
                }
-               if (do_mknod(fname, file->mode, rdev) < 0) {
-                       rsyserr(FERROR_XFER, errno, "mknod %s failed",
-                               full_fname(fname));
-               } else {
+               if (atomic_create(file, fname, NULL, rdev, &sx, del_for_flag)) {
                        set_file_attrs(fname, file, NULL, NULL, 0);
                        if (itemizing) {
                                itemize(fname, file, ndx, statret, &sx,
                                        ITEM_LOCAL_CHANGE|ITEM_REPORT_CHANGE, 0, NULL);
                        }
-                       if (code != FNONE && verbose)
+                       if (code != FNONE && INFO_GTE(NAME, 1))
                                rprintf(code, "%s\n", fname);
 #ifdef SUPPORT_HARD_LINKS
                        if (preserve_hard_links && F_IS_HLINKED(file))
@@ -1678,7 +1563,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        }
 
        if (max_size > 0 && F_LENGTH(file) > max_size) {
-               if (verbose > 1) {
+               if (INFO_GTE(SKIP, 1)) {
                        if (solo_file)
                                fname = f_name(file, NULL);
                        rprintf(FINFO, "%s is over max-size\n", fname);
@@ -1686,7 +1571,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                goto cleanup;
        }
        if (min_size > 0 && F_LENGTH(file) < min_size) {
-               if (verbose > 1) {
+               if (INFO_GTE(SKIP, 1)) {
                        if (solo_file)
                                fname = f_name(file, NULL);
                        rprintf(FINFO, "%s is under min-size\n", fname);
@@ -1696,7 +1581,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
        if (update_only > 0 && statret == 0
            && cmp_time(sx.st.st_mtime, file->modtime) > 0) {
-               if (verbose > 1)
+               if (INFO_GTE(SKIP, 1))
                        rprintf(FINFO, "%s is newer\n", fname);
 #ifdef SUPPORT_HARD_LINKS
                if (F_IS_HLINKED(file))
@@ -1705,7 +1590,6 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                goto cleanup;
        }
 
-       fnamecmp = fname;
        fnamecmp_type = FNAMECMP_FNAME;
 
        if (statret == 0 && !S_ISREG(sx.st.st_mode)) {
@@ -1746,7 +1630,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                if (j >= 0) {
                        fuzzy_file = fuzzy_dirlist->files[j];
                        f_name(fuzzy_file, fnamecmpbuf);
-                       if (verbose > 2) {
+                       if (DEBUG_GTE(FUZZY, 1)) {
                                rprintf(FINFO, "fuzzy basis selected for %s: %s\n",
                                        fname, fnamecmpbuf);
                        }
@@ -1820,7 +1704,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                goto cleanup;
                        if (!(back_file = make_file(fname, NULL, NULL, 0, NO_FILTERS)))
                                goto pretend_missing;
-                       if (copy_file(fname, backupptr, -1, back_file->mode, 1) < 0) {
+                       if (copy_file(fname, backupptr, -1, back_file->mode) < 0) {
                                unmake_file(back_file);
                                back_file = NULL;
                                goto cleanup;
@@ -1868,11 +1752,8 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        close(fd);
                        goto cleanup;
                }
-               if ((f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0
-                && (errno != ENOENT || make_bak_dir(backupptr) < 0
-                 || (f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0)) {
-                       rsyserr(FERROR_XFER, errno, "open %s",
-                               full_fname(backupptr));
+               if ((f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
+                       rsyserr(FERROR_XFER, errno, "open %s", full_fname(backupptr));
                        unmake_file(back_file);
                        back_file = NULL;
                        close(fd);
@@ -1881,12 +1762,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                fnamecmp_type = FNAMECMP_BACKUP;
        }
 
-       if (verbose > 3) {
-               rprintf(FINFO, "gen mapped %s of size %.0f\n",
-                       fnamecmp, (double)sx.st.st_size);
+       if (DEBUG_GTE(DELTASUM, 3)) {
+               rprintf(FINFO, "gen mapped %s of size %s\n",
+                       fnamecmp, big_num(sx.st.st_size));
        }
 
-       if (verbose > 2)
+       if (DEBUG_GTE(DELTASUM, 2))
                rprintf(FINFO, "generating and sending sums for %d\n", ndx);
 
   notify_others:
@@ -1931,17 +1812,33 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 
        if (statret != 0 || whole_file)
                write_sum_head(f_out, NULL);
-       else {
-               generate_and_send_sums(fd, sx.st.st_size, f_out, f_copy);
+       else if (sx.st.st_size <= 0) {
+               write_sum_head(f_out, NULL);
+               close(fd);
+       } else {
+               if (generate_and_send_sums(fd, sx.st.st_size, f_out, f_copy) < 0) {
+                       rprintf(FWARNING,
+                           "WARNING: file is too large for checksum sending: %s\n",
+                           fnamecmp);
+                       write_sum_head(f_out, NULL);
+               }
                close(fd);
        }
 
   cleanup:
        if (back_file) {
+               int save_preserve_xattrs = preserve_xattrs;
                if (f_copy >= 0)
                        close(f_copy);
+#ifdef SUPPORT_XATTRS
+               if (preserve_xattrs) {
+                       copy_xattrs(fname, backupptr);
+                       preserve_xattrs = 0;
+               }
+#endif
                set_file_attrs(backupptr, back_file, NULL, NULL, 0);
-               if (verbose > 1) {
+               preserve_xattrs = save_preserve_xattrs;
+               if (INFO_GTE(BACKUP, 1)) {
                        rprintf(FINFO, "backed up %s to %s\n",
                                fname, backupptr);
                }
@@ -1959,6 +1856,74 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        return;
 }
 
+/* If we are replacing an existing hard link, symlink, device, or special file,
+ * create a temp-name item and rename it into place.  Only a symlink or hard
+ * link puts a non-NULL value into the lnk arg.  Only a device puts a non-0
+ * value into the rdev arg.  Specify 0 for the del_for_flag if there is not a
+ * file to replace.  This returns 1 on success and 0 on failure. */
+int atomic_create(struct file_struct *file, char *fname, const char *lnk,
+                 dev_t rdev, stat_x *sxp, int del_for_flag)
+{
+       char tmpname[MAXPATHLEN];
+       const char *create_name;
+       int skip_atomic, dir_in_the_way = del_for_flag && S_ISDIR(sxp->st.st_mode);
+
+       if (!del_for_flag || dir_in_the_way || tmpdir || !get_tmpname(tmpname, fname, True))
+               skip_atomic = 1;
+       else
+               skip_atomic = 0;
+
+       if (del_for_flag) {
+               if (make_backups > 0 && !dir_in_the_way) {
+                       if (!make_backup(fname, skip_atomic))
+                               return 0;
+               } else if (skip_atomic) {
+                       int del_opts = delete_mode || force_delete ? DEL_RECURSE : 0;
+                       if (delete_item(fname, sxp->st.st_mode, del_opts | del_for_flag) != 0)
+                               return 0;
+               }
+       }
+
+       create_name = skip_atomic ? fname : tmpname;
+
+       if (lnk) {
+#ifdef SUPPORT_LINKS
+               if (S_ISLNK(file->mode)
+#ifdef SUPPORT_HARD_LINKS /* The first symlink in a hard-linked cluster is always created. */
+                && (!F_IS_HLINKED(file) || file->flags & FLAG_HLINK_FIRST)
+#endif
+                ) {
+                       if (do_symlink(lnk, create_name) < 0) {
+                               rsyserr(FERROR_XFER, errno, "symlink %s -> \"%s\" failed",
+                                       full_fname(create_name), lnk);
+                               return 0;
+                       }
+               } else
+#endif
+#ifdef SUPPORT_HARD_LINKS
+               if (!hard_link_one(file, create_name, lnk, 0))
+                       return 0;
+#endif
+       } else {
+               if (do_mknod(create_name, file->mode, rdev) < 0) {
+                       rsyserr(FERROR_XFER, errno, "mknod %s failed",
+                               full_fname(create_name));
+                       return 0;
+               }
+       }
+
+       if (!skip_atomic) {
+               if (do_rename(tmpname, fname) < 0) {
+                       rsyserr(FERROR_XFER, errno, "rename %s -> \"%s\" failed",
+                               full_fname(tmpname), full_fname(fname));
+                       do_unlink(tmpname);
+                       return 0;
+               }
+       }
+
+       return 1;
+}
+
 #ifdef SUPPORT_HARD_LINKS
 static void handle_skipped_hlink(struct file_struct *file, int itemizing,
                                 enum logcode code, int f_out)
@@ -1986,6 +1951,7 @@ static void touch_up_dirs(struct file_list *flist, int ndx)
        static int counter = 0;
        struct file_struct *file;
        char *fname;
+       BOOL fix_dir_perms;
        int i, start, end;
 
        if (ndx < 0) {
@@ -2001,27 +1967,32 @@ static void touch_up_dirs(struct file_list *flist, int ndx)
                if (!S_ISDIR(file->mode)
                 || (!implied_dirs && file->flags & FLAG_IMPLIED_DIR))
                        continue;
-               if (verbose > 3) {
+               if (DEBUG_GTE(TIME, 2)) {
                        fname = f_name(file, NULL);
                        rprintf(FINFO, "touch_up_dirs: %s (%d)\n",
                                NS(fname), i);
                }
+               /* Be sure not to retouch permissions with --fake-super. */
+               fix_dir_perms = !am_root && !(file->mode & S_IWUSR);
                if (!F_IS_ACTIVE(file) || file->flags & FLAG_MISSING_DIR
-                || (!need_retouch_dir_times && file->mode & S_IWUSR))
+                || !(need_retouch_dir_times || fix_dir_perms))
                        continue;
                fname = f_name(file, NULL);
-               if (!(file->mode & S_IWUSR))
+               if (fix_dir_perms)
                        do_chmod(fname, file->mode);
                if (need_retouch_dir_times) {
                        STRUCT_STAT st;
                        if (link_stat(fname, &st, 0) == 0
                         && cmp_time(st.st_mtime, file->modtime) != 0)
-                               set_modtime(fname, file->modtime, file->mode);
+                               set_modtime(fname, file->modtime, F_MOD_NSEC(file), file->mode);
+               }
+               if (counter >= loopchk_limit) {
+                       if (allowed_lull)
+                               maybe_send_keepalive(time(NULL), MSK_ALLOW_FLUSH);
+                       else
+                               maybe_flush_socket(0);
+                       counter = 0;
                }
-               if (allowed_lull && !(counter % lull_mod))
-                       maybe_send_keepalive();
-               else if (!(counter & 0xFF))
-                       maybe_flush_socket(0);
        }
 }
 
@@ -2035,8 +2006,7 @@ void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
        while (1) {
 #ifdef SUPPORT_HARD_LINKS
                if (preserve_hard_links && (ndx = get_hlink_num()) != -1) {
-                       flist = flist_for_ndx(ndx);
-                       assert(flist != NULL);
+                       flist = flist_for_ndx(ndx, "check_for_finished_files.1");
                        file = flist->files[ndx - flist->ndx_start];
                        assert(file->flags & FLAG_HLINKED);
                        finish_hard_link(file, f_name(file, fbuf), ndx, NULL, itemizing, code, -1);
@@ -2059,7 +2029,7 @@ void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
                        ignore_times++;
 
                        flist = cur_flist;
-                       cur_flist = flist_for_ndx(ndx);
+                       cur_flist = flist_for_ndx(ndx, "check_for_finished_files.2");
 
                        file = cur_flist->files[ndx - cur_flist->ndx_start];
                        if (solo_file)
@@ -2092,9 +2062,12 @@ void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
                if (first_flist->in_progress || first_flist->to_redo)
                        break;
 
-               if (!read_batch) {
-                       write_ndx(sock_f_out, NDX_DONE);
-                       maybe_flush_socket(1);
+               write_ndx(sock_f_out, NDX_DONE);
+               if (!read_batch && !flist_eof) {
+                       int old_total = 0;
+                       for (flist = first_flist; flist != cur_flist; flist = flist->next)
+                               old_total += flist->used;
+                       maybe_flush_socket(!flist_eof && file_total - old_total < MIN_FILECNT_LOOKAHEAD/2);
                }
 
                if (delete_during == 2 || !dir_tweaking) {
@@ -2108,11 +2081,12 @@ void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
 
 void generate_files(int f_out, const char *local_name)
 {
-       int i, ndx;
+       int i, ndx, next_loopchk = 0;
        char fbuf[MAXPATHLEN];
        int itemizing;
        enum logcode code;
-       int save_do_progress = do_progress;
+       int save_info_flist = info_levels[INFO_FLIST];
+       int save_info_progress = info_levels[INFO_PROGRESS];
 
        if (protocol_version >= 29) {
                itemizing = 1;
@@ -2133,13 +2107,13 @@ void generate_files(int f_out, const char *local_name)
        }
        solo_file = local_name;
        dir_tweaking = !(list_only || solo_file || dry_run);
-       need_retouch_dir_times = preserve_times > 1;
-       lull_mod = allowed_lull * 5;
+       need_retouch_dir_times = preserve_times & PRESERVE_DIR_TIMES;
+       loopchk_limit = allowed_lull ? allowed_lull * 5 : 200;
        symlink_timeset_failed_flags = ITEM_REPORT_TIME
            | (protocol_version >= 30 || !am_server ? ITEM_REPORT_TIMEFAIL : 0);
        implied_dirs_are_missing = relative_paths && !implied_dirs && protocol_version < 30;
 
-       if (verbose > 2)
+       if (DEBUG_GTE(GENR, 1))
                rprintf(FINFO, "generator starting pid=%ld\n", (long)getpid());
 
        if (delete_before && !solo_file && cur_flist->used > 0)
@@ -2150,36 +2124,33 @@ void generate_files(int f_out, const char *local_name)
                if (!deldelay_buf)
                        out_of_memory("delete-delay");
        }
-       do_progress = 0;
+       info_levels[INFO_FLIST] = info_levels[INFO_PROGRESS] = 0;
 
        if (append_mode > 0 || whole_file < 0)
                whole_file = 0;
-       if (verbose >= 2) {
+       if (DEBUG_GTE(FLIST, 1)) {
                rprintf(FINFO, "delta-transmission %s\n",
                        whole_file
                        ? "disabled for local transfer or --whole-file"
                        : "enabled");
        }
 
-       /* Since we often fill up the outgoing socket and then just sit around
-        * waiting for the other 2 processes to do their thing, we don't want
-        * to exit on a timeout.  If the data stops flowing, the receiver will
-        * notice that and let us know via the redo pipe (or its closing). */
-       ignore_timeout = 1;
-
        dflt_perms = (ACCESSPERMS & ~orig_umask);
 
        do {
 #ifdef SUPPORT_HARD_LINKS
                if (preserve_hard_links && inc_recurse) {
-                       while (!flist_eof && file_total < FILECNT_LOOKAHEAD/2)
+                       while (!flist_eof && file_total < MIN_FILECNT_LOOKAHEAD/2)
                                wait_for_receiver();
                }
 #endif
 
                if (inc_recurse && cur_flist->parent_ndx >= 0) {
                        struct file_struct *fp = dir_flist->files[cur_flist->parent_ndx];
-                       f_name(fp, fbuf);
+                       if (solo_file)
+                               strlcpy(fbuf, solo_file, sizeof fbuf);
+                       else
+                               f_name(fp, fbuf);
                        ndx = cur_flist->ndx_start - 1;
                        recv_generator(fbuf, fp, ndx, itemizing, code, f_out);
                        if (delete_during && dry_run < 2 && !list_only
@@ -2215,10 +2186,13 @@ void generate_files(int f_out, const char *local_name)
 
                        check_for_finished_files(itemizing, code, 0);
 
-                       if (allowed_lull && !(i % lull_mod))
-                               maybe_send_keepalive();
-                       else if (!(i & 0xFF))
-                               maybe_flush_socket(0);
+                       if (i + cur_flist->ndx_start >= next_loopchk) {
+                               if (allowed_lull)
+                                       maybe_send_keepalive(time(NULL), MSK_ALLOW_FLUSH);
+                               else
+                                       maybe_flush_socket(0);
+                               next_loopchk += loopchk_limit;
+                       }
                }
 
                if (!inc_recurse) {
@@ -2237,7 +2211,7 @@ void generate_files(int f_out, const char *local_name)
        if (delete_during)
                delete_in_dir(NULL, NULL, &dev_zero);
        phase++;
-       if (verbose > 2)
+       if (DEBUG_GTE(GENR, 1))
                rprintf(FINFO, "generate_files phase=%d\n", phase);
 
        while (1) {
@@ -2248,14 +2222,22 @@ void generate_files(int f_out, const char *local_name)
        }
 
        phase++;
-       if (verbose > 2)
+       if (DEBUG_GTE(GENR, 1))
                rprintf(FINFO, "generate_files phase=%d\n", phase);
 
        write_ndx(f_out, NDX_DONE);
+
        /* Reduce round-trip lag-time for a useless delay-updates phase. */
-       if (protocol_version >= 29 && !delay_updates)
+       if (protocol_version >= 29 && EARLY_DELAY_DONE_MSG())
                write_ndx(f_out, NDX_DONE);
 
+       if (protocol_version >= 31 && EARLY_DELETE_DONE_MSG()) {
+               if ((INFO_GTE(STATS, 2) && (delete_mode || force_delete)) || read_batch)
+                       write_del_stats(f_out);
+               if (EARLY_DELAY_DONE_MSG()) /* Can't send this before delay */
+                       write_ndx(f_out, NDX_DONE);
+       }
+
        /* Read MSG_DONE for the redo phase (and any prior messages). */
        while (1) {
                check_for_finished_files(itemizing, code, 0);
@@ -2266,32 +2248,49 @@ void generate_files(int f_out, const char *local_name)
 
        if (protocol_version >= 29) {
                phase++;
-               if (verbose > 2)
+               if (DEBUG_GTE(GENR, 1))
                        rprintf(FINFO, "generate_files phase=%d\n", phase);
-               if (delay_updates)
+               if (!EARLY_DELAY_DONE_MSG()) {
                        write_ndx(f_out, NDX_DONE);
+                       if (protocol_version >= 31 && EARLY_DELETE_DONE_MSG())
+                               write_ndx(f_out, NDX_DONE);
+               }
                /* Read MSG_DONE for delay-updates phase & prior messages. */
                while (msgdone_cnt == 2)
                        wait_for_receiver();
        }
 
-       do_progress = save_do_progress;
+       info_levels[INFO_FLIST] = save_info_flist;
+       info_levels[INFO_PROGRESS] = save_info_progress;
+
        if (delete_during == 2)
                do_delayed_deletions(fbuf);
        if (delete_after && !solo_file && file_total > 0)
                do_delete_pass();
 
-       if ((need_retouch_dir_perms || need_retouch_dir_times)
-        && dir_tweaking && (!inc_recurse || delete_during == 2))
-               touch_up_dirs(dir_flist, -1);
-
-       if (max_delete >= 0 && deletion_count > max_delete) {
-               rprintf(FINFO,
+       if (max_delete >= 0 && skipped_deletes) {
+               rprintf(FWARNING,
                        "Deletions stopped due to --max-delete limit (%d skipped)\n",
-                       deletion_count - max_delete);
+                       skipped_deletes);
                io_error |= IOERR_DEL_LIMIT;
        }
 
-       if (verbose > 2)
+       if (protocol_version >= 31) {
+               if (!EARLY_DELETE_DONE_MSG()) {
+                       if (INFO_GTE(STATS, 2) || read_batch)
+                               write_del_stats(f_out);
+                       write_ndx(f_out, NDX_DONE);
+               }
+
+               /* Read MSG_DONE for late-delete phase & prior messages. */
+               while (msgdone_cnt == 3)
+                       wait_for_receiver();
+       }
+
+       if ((need_retouch_dir_perms || need_retouch_dir_times)
+        && dir_tweaking && (!inc_recurse || delete_during == 2))
+               touch_up_dirs(dir_flist, -1);
+
+       if (DEBUG_GTE(GENR, 1))
                rprintf(FINFO, "generate_files finished\n");
 }