Tweaking the license text a bit more.
[rsync/rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index 9ff21cc..e33cd58 100644 (file)
--- a/flist.c
+++ b/flist.c
@@ -7,8 +7,9 @@
  * Copyright (C) 2002-2007 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -16,8 +17,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
+ * with this program; if not, visit the http://fsf.org website.
  */
 
 #include "rsync.h"
@@ -38,6 +38,7 @@ extern int module_id;
 extern int ignore_errors;
 extern int numeric_ids;
 extern int recurse;
+extern int use_qsort;
 extern int xfer_dirs;
 extern int filesfrom_fd;
 extern int one_file_system;
@@ -49,8 +50,8 @@ extern int preserve_links;
 extern int preserve_hard_links;
 extern int preserve_devices;
 extern int preserve_specials;
-extern int preserve_uid;
-extern int preserve_gid;
+extern int uid_ndx;
+extern int gid_ndx;
 extern int relative_paths;
 extern int implied_dirs;
 extern int file_extra_cnt;
@@ -76,6 +77,8 @@ extern int need_unsorted_flist;
 extern iconv_t ic_send, ic_recv;
 #endif
 
+#define PTR_SIZE (sizeof (struct file_struct *))
+
 int io_error;
 int checksum_len;
 dev_t filesystem_dev; /* used to implement -x */
@@ -97,6 +100,7 @@ static char tmp_sum[MAX_DIGEST_LEN];
 
 static char empty_sum[MAX_DIGEST_LEN];
 static int flist_count_offset; /* for --delete --progress */
+static int dir_count = 0;
 
 static void clean_flist(struct file_list *flist, int strip_root);
 static void output_flist(struct file_list *flist);
@@ -141,7 +145,7 @@ static void finish_filelist_progress(const struct file_list *flist)
        if (do_progress) {
                /* This overwrites the progress line */
                rprintf(FINFO, "%d file%sto consider\n",
-                       flist->count, flist->count == 1 ? " " : "s ");
+                       flist->used, flist->used == 1 ? " " : "s ");
        } else
                rprintf(FINFO, "done\n");
 }
@@ -268,15 +272,12 @@ static const char *pathname, *orig_dir;
 static int pathname_len;
 
 
-/**
- * Make sure @p flist is big enough to hold at least @p flist->count
- * entries.
- **/
-void flist_expand(struct file_list *flist)
+/* Make sure flist can hold at least flist->used + extra entries. */
+static void flist_expand(struct file_list *flist, int extra)
 {
        struct file_struct **new_ptr;
 
-       if (flist->count < flist->malloced)
+       if (flist->used + extra <= flist->malloced)
                return;
 
        if (flist->malloced < FLIST_START)
@@ -288,15 +289,8 @@ void flist_expand(struct file_list *flist)
 
        /* In case count jumped or we are starting the list
         * with a known size just set it. */
-       if (flist->malloced < flist->count)
-               flist->malloced = flist->count;
-
-#ifdef ICONV_OPTION
-       if (inc_recurse && flist == dir_flist && need_unsorted_flist) {
-               flist->sorted = realloc_array(flist->sorted, struct file_struct *,
-                                             flist->malloced);
-       }
-#endif
+       if (flist->malloced < flist->used + extra)
+               flist->malloced = flist->used + extra;
 
        new_ptr = realloc_array(flist->files, struct file_struct *,
                                flist->malloced);
@@ -314,6 +308,15 @@ void flist_expand(struct file_list *flist)
                out_of_memory("flist_expand");
 }
 
+static void flist_done_allocating(struct file_list *flist)
+{
+       void *ptr = pool_boundary(flist->file_pool, 8*1024);
+       if (flist->pool_boundary == ptr)
+               flist->pool_boundary = NULL; /* list didn't use any pool memory */
+       else
+               flist->pool_boundary = ptr;
+}
+
 int push_pathname(const char *dir, int len)
 {
        if (dir == pathname)
@@ -411,24 +414,24 @@ static void send_file_entry(int f, struct file_struct *file, int ndx)
                }
        } else if (protocol_version < 28)
                rdev = MAKEDEV(0, 0);
-       if (preserve_uid) {
-               if (F_UID(file) == uid && *lastname)
+       if (uid_ndx) {
+               if ((uid_t)F_OWNER(file) == uid && *lastname)
                        flags |= XMIT_SAME_UID;
                else {
-                       uid = F_UID(file);
-                       if (preserve_uid && !numeric_ids) {
+                       uid = F_OWNER(file);
+                       if (uid_ndx && !numeric_ids) {
                                user_name = add_uid(uid);
                                if (inc_recurse && user_name)
                                        flags |= XMIT_USER_NAME_FOLLOWS;
                        }
                }
        }
-       if (preserve_gid) {
-               if (F_GID(file) == gid && *lastname)
+       if (gid_ndx) {
+               if ((gid_t)F_GROUP(file) == gid && *lastname)
                        flags |= XMIT_SAME_GID;
                else {
-                       gid = F_GID(file);
-                       if (preserve_gid && !numeric_ids) {
+                       gid = F_GROUP(file);
+                       if (gid_ndx && !numeric_ids) {
                                group_name = add_gid(gid);
                                if (inc_recurse && group_name)
                                        flags |= XMIT_GROUP_NAME_FOLLOWS;
@@ -510,7 +513,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx)
        }
        if (!(flags & XMIT_SAME_MODE))
                write_int(f, to_wire_mode(mode));
-       if (preserve_uid && !(flags & XMIT_SAME_UID)) {
+       if (uid_ndx && !(flags & XMIT_SAME_UID)) {
                if (protocol_version < 30)
                        write_int(f, uid);
                else {
@@ -522,7 +525,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx)
                        }
                }
        }
-       if (preserve_gid && !(flags & XMIT_SAME_GID)) {
+       if (gid_ndx && !(flags & XMIT_SAME_GID)) {
                if (protocol_version < 30)
                        write_int(f, gid);
                else {
@@ -594,7 +597,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx)
 }
 
 static struct file_struct *recv_file_entry(struct file_list *flist,
-                                          int flags, int f)
+                                          int xflags, int f)
 {
        static int64 modtime;
        static mode_t mode;
@@ -603,6 +606,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        static uint32 rdev_major;
        static uid_t uid;
        static gid_t gid;
+       static uint16 gid_flags;
        static char lastname[MAXPATHLEN], *lastdir;
        static int lastdir_depth, lastdir_len = -1;
        static unsigned int del_hier_name_len = 0;
@@ -618,18 +622,18 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        alloc_pool_t *pool;
        char *bp;
 
-       if (flags & XMIT_SAME_NAME)
+       if (xflags & XMIT_SAME_NAME)
                l1 = read_byte(f);
 
-       if (flags & XMIT_LONG_NAME)
+       if (xflags & XMIT_LONG_NAME)
                l2 = read_varint30(f);
        else
                l2 = read_byte(f);
 
        if (l2 >= MAXPATHLEN - l1) {
                rprintf(FERROR,
-                       "overflow: flags=0x%x l1=%d l2=%d lastname=%s [%s]\n",
-                       flags, l1, l2, lastname, who_am_i());
+                       "overflow: xflags=0x%x l1=%d l2=%d lastname=%s [%s]\n",
+                       xflags, l1, l2, lastname, who_am_i());
                overflow_exit("recv_file_entry");
        }
 
@@ -642,7 +646,8 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 
 #ifdef ICONV_OPTION
        if (ic_recv != (iconv_t)-1) {
-               char *obuf = thisname, *ibuf = lastname;
+               char *obuf = thisname;
+               ICONV_CONST char *ibuf = (ICONV_CONST char *)lastname;
                size_t ocnt = MAXPATHLEN, icnt = basename_len;
 
                if (icnt >= MAXPATHLEN) {
@@ -683,28 +688,28 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 
 #ifdef SUPPORT_HARD_LINKS
        if (protocol_version >= 30
-        && BITS_SETnUNSET(flags, XMIT_HLINKED, XMIT_HLINK_FIRST)) {
+        && BITS_SETnUNSET(xflags, XMIT_HLINKED, XMIT_HLINK_FIRST)) {
                struct file_struct *first;
                first_hlink_ndx = read_varint30(f);
-               if (first_hlink_ndx < 0 || first_hlink_ndx >= flist->count) {
+               if (first_hlink_ndx < 0 || first_hlink_ndx >= flist->used) {
                        rprintf(FERROR,
                                "hard-link reference out of range: %d (%d)\n",
-                               first_hlink_ndx, flist->count);
+                               first_hlink_ndx, flist->used);
                        exit_cleanup(RERR_PROTOCOL);
                }
                first = flist->files[first_hlink_ndx];
                file_length = F_LENGTH(first);
                modtime = first->modtime;
                mode = first->mode;
-               if (preserve_uid)
-                       uid = F_UID(first);
-               if (preserve_gid)
-                       gid = F_GID(first);
+               if (uid_ndx)
+                       uid = F_OWNER(first);
+               if (gid_ndx)
+                       gid = F_GROUP(first);
                if ((preserve_devices && IS_DEVICE(mode))
                 || (preserve_specials && IS_SPECIAL(mode))) {
                        uint32 *devp = F_RDEV_P(first);
                        rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
-                       extra_len += 2 * EXTRA_LEN;
+                       extra_len += DEV_EXTRA_CNT * EXTRA_LEN;
                }
                if (preserve_links && S_ISLNK(mode))
                        linkname_len = strlen(F_SYMLINK(first)) + 1;
@@ -715,7 +720,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 #endif
 
        file_length = read_varlong30(f, 3);
-       if (!(flags & XMIT_SAME_TIME)) {
+       if (!(xflags & XMIT_SAME_TIME)) {
                if (protocol_version >= 30) {
                        modtime = read_varlong(f, 4);
 #if SIZEOF_TIME_T < SIZEOF_INT64
@@ -728,53 +733,54 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                } else
                        modtime = read_int(f);
        }
-       if (!(flags & XMIT_SAME_MODE))
+       if (!(xflags & XMIT_SAME_MODE))
                mode = from_wire_mode(read_int(f));
 
        if (chmod_modes && !S_ISLNK(mode))
                mode = tweak_mode(mode, chmod_modes);
 
-       if (preserve_uid && !(flags & XMIT_SAME_UID)) {
+       if (uid_ndx && !(xflags & XMIT_SAME_UID)) {
                if (protocol_version < 30)
                        uid = (uid_t)read_int(f);
                else {
                        uid = (uid_t)read_varint(f);
-                       if (flags & XMIT_USER_NAME_FOLLOWS)
+                       if (xflags & XMIT_USER_NAME_FOLLOWS)
                                uid = recv_user_name(f, uid);
                        else if (inc_recurse && am_root && !numeric_ids)
                                uid = match_uid(uid);
                }
        }
-       if (preserve_gid && !(flags & XMIT_SAME_GID)) {
+       if (gid_ndx && !(xflags & XMIT_SAME_GID)) {
                if (protocol_version < 30)
                        gid = (gid_t)read_int(f);
                else {
                        gid = (gid_t)read_varint(f);
-                       if (flags & XMIT_GROUP_NAME_FOLLOWS)
-                               gid = recv_group_name(f, gid);
+                       gid_flags = 0;
+                       if (xflags & XMIT_GROUP_NAME_FOLLOWS)
+                               gid = recv_group_name(f, gid, &gid_flags);
                        else if (inc_recurse && (!am_root || !numeric_ids))
-                               gid = match_gid(gid);
+                               gid = match_gid(gid, &gid_flags);
                }
        }
 
        if ((preserve_devices && IS_DEVICE(mode))
         || (preserve_specials && IS_SPECIAL(mode))) {
                if (protocol_version < 28) {
-                       if (!(flags & XMIT_SAME_RDEV_pre28))
+                       if (!(xflags & XMIT_SAME_RDEV_pre28))
                                rdev = (dev_t)read_int(f);
                } else {
                        uint32 rdev_minor;
-                       if (!(flags & XMIT_SAME_RDEV_MAJOR))
+                       if (!(xflags & XMIT_SAME_RDEV_MAJOR))
                                rdev_major = read_varint30(f);
                        if (protocol_version >= 30)
                                rdev_minor = read_varint(f);
-                       else if (flags & XMIT_RDEV_MINOR_8_pre30)
+                       else if (xflags & XMIT_RDEV_MINOR_8_pre30)
                                rdev_minor = read_byte(f);
                        else
                                rdev_minor = read_int(f);
                        rdev = MAKEDEV(rdev_major, rdev_minor);
                }
-               extra_len += 2 * EXTRA_LEN;
+               extra_len += DEV_EXTRA_CNT * EXTRA_LEN;
                file_length = 0;
        } else if (protocol_version < 28)
                rdev = MAKEDEV(0, 0);
@@ -796,8 +802,8 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
   create_object:
        if (preserve_hard_links) {
                if (protocol_version < 28 && S_ISREG(mode))
-                       flags |= XMIT_HLINKED;
-               if (flags & XMIT_HLINKED)
+                       xflags |= XMIT_HLINKED;
+               if (xflags & XMIT_HLINKED)
                        extra_len += EXTRA_LEN;
        }
 #endif
@@ -822,7 +828,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (inc_recurse && S_ISDIR(mode)) {
                if (one_file_system) {
                        /* Room to save the dir's device for -x */
-                       extra_len += 2 * EXTRA_LEN;
+                       extra_len += DEV_EXTRA_CNT * EXTRA_LEN;
                }
                pool = dir_flist->file_pool;
        } else
@@ -841,7 +847,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        bp += basename_len + linkname_len; /* skip space for symlink too */
 
 #ifdef SUPPORT_HARD_LINKS
-       if (flags & XMIT_HLINKED)
+       if (xflags & XMIT_HLINKED)
                file->flags |= FLAG_HLINKED;
 #endif
        file->modtime = (time_t)modtime;
@@ -851,13 +857,15 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                OPT_EXTRA(file, 0)->unum = (uint32)(file_length >> 32);
        }
        file->mode = mode;
-       if (preserve_uid)
+       if (uid_ndx)
                F_OWNER(file) = uid;
-       if (preserve_gid)
+       if (gid_ndx) {
                F_GROUP(file) = gid;
+               file->flags |= gid_flags;
+       }
 #ifdef ICONV_OPTION
        if (ic_ndx)
-               F_NDX(file) = flist->count + flist->ndx_start;
+               F_NDX(file) = flist->used + flist->ndx_start;
 #endif
 
        if (basename != thisname) {
@@ -869,7 +877,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (S_ISDIR(mode)) {
                if (basename_len == 1+1 && *basename == '.') /* +1 for '\0' */
                        F_DEPTH(file)--;
-               if (flags & XMIT_TOP_DIR) {
+               if (xflags & XMIT_TOP_DIR) {
                        in_del_hier = recurse;
                        del_hier_name_len = F_DEPTH(file) == 0 ? 0 : l1 + l2;
                        if (relative_paths && del_hier_name_len > 2
@@ -908,10 +916,10 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 #endif
 
 #ifdef SUPPORT_HARD_LINKS
-       if (preserve_hard_links && flags & XMIT_HLINKED) {
+       if (preserve_hard_links && xflags & XMIT_HLINKED) {
                if (protocol_version >= 30) {
-                       F_HL_GNUM(file) = flags & XMIT_HLINK_FIRST
-                                       ? flist->count : first_hlink_ndx;
+                       F_HL_GNUM(file) = xflags & XMIT_HLINK_FIRST
+                                       ? flist->used : first_hlink_ndx;
                } else {
                        static int32 cnt = 0;
                        struct idev_node *np;
@@ -921,7 +929,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                                dev = read_int(f);
                                ino = read_int(f);
                        } else {
-                               if (!(flags & XMIT_SAME_DEV_pre30))
+                               if (!(xflags & XMIT_SAME_DEV_pre30))
                                        dev = read_longint(f);
                                ino = read_longint(f);
                        }
@@ -938,7 +946,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 
        if (always_checksum && (S_ISREG(mode) || protocol_version < 28)) {
                if (S_ISREG(mode))
-                       bp = (char*)F_SUM(file);
+                       bp = F_SUM(file);
                else {
                        /* Prior to 28, we get a useless set of nulls. */
                        bp = tmp_sum;
@@ -992,10 +1000,10 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        int alloc_len, basename_len, linkname_len;
        int extra_len = file_extra_cnt * EXTRA_LEN;
        const char *basename;
+       alloc_pool_t *pool;
        char *bp;
 
-       if (strlcpy(thisname, fname, sizeof thisname)
-           >= sizeof thisname - pathname_len) {
+       if (strlcpy(thisname, fname, sizeof thisname) >= sizeof thisname) {
                rprintf(FINFO, "skipping overly long name: %s\n", fname);
                return NULL;
        }
@@ -1082,12 +1090,17 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
   skip_filters:
 
        /* Only divert a directory in the main transfer. */
-       if (flist && flist->prev && S_ISDIR(st.st_mode)
-        && flags & FLAG_DIVERT_DIRS) {
-               flist = dir_flist;
-               /* Room for parent/sibling/next-child info. */
-               extra_len += 3 * EXTRA_LEN;
-       }
+       if (flist) {
+               if (flist->prev && S_ISDIR(st.st_mode)
+                && flags & FLAG_DIVERT_DIRS) {
+                       /* Room for parent/sibling/next-child info. */
+                       extra_len += DIRNODE_EXTRA_CNT * EXTRA_LEN;
+                       dir_count++;
+                       pool = dir_flist->file_pool;
+               } else
+                       pool = flist->file_pool;
+       } else
+               pool = NULL;
 
        if (verbose > 2) {
                rprintf(FINFO, "[%s] make_file(%s,*,%d)\n",
@@ -1122,8 +1135,8 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
 
        alloc_len = FILE_STRUCT_LEN + extra_len + basename_len
                  + linkname_len;
-       if (flist)
-               bp = pool_alloc(flist->file_pool, alloc_len, "make_file");
+       if (pool)
+               bp = pool_alloc(pool, alloc_len, "make_file");
        else {
                if (!(bp = new_array(char, alloc_len)))
                        out_of_memory("make_file");
@@ -1164,9 +1177,9 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                OPT_EXTRA(file, 0)->unum = (uint32)(st.st_size >> 32);
        }
        file->mode = st.st_mode;
-       if (preserve_uid)
+       if (uid_ndx)
                F_OWNER(file) = st.st_uid;
-       if (preserve_gid)
+       if (gid_ndx)
                F_GROUP(file) = st.st_gid;
 
        if (basename != thisname)
@@ -1191,13 +1204,13 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                int save_mode = file->mode;
                file->mode = S_IFDIR; /* Find a directory with our name. */
                if (flist_find(dir_flist, file) >= 0
-                   && x_stat(thisname, &st2, NULL) == 0 && S_ISDIR(st2.st_mode)) {
+                && x_stat(thisname, &st2, NULL) == 0 && S_ISDIR(st2.st_mode)) {
                        file->modtime = st2.st_mtime;
                        file->len32 = 0;
                        file->mode = st2.st_mode;
-                       if (preserve_uid)
+                       if (uid_ndx)
                                F_OWNER(file) = st2.st_uid;
-                       if (preserve_gid)
+                       if (gid_ndx)
                                F_GROUP(file) = st2.st_gid;
                } else
                        file->mode = save_mode;
@@ -1206,16 +1219,10 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        if (basename_len == 0+1)
                return NULL;
 
-       if (inc_recurse && flist == dir_flist) {
 #ifdef ICONV_OPTION
-               if (ic_ndx)
-                       F_NDX(file) = dir_flist->count;
+       if (ic_ndx)
+               F_NDX(file) = dir_count - 1;
 #endif
-               flist_expand(dir_flist);
-               if (need_unsorted_flist)
-                       dir_flist->sorted[dir_flist->count] = file;
-               dir_flist->files[dir_flist->count++] = file;
-       }
 
        return file;
 }
@@ -1233,14 +1240,14 @@ void unmake_file(struct file_struct *file)
 
 static struct file_struct *send_file_name(int f, struct file_list *flist,
                                          char *fname, STRUCT_STAT *stp,
-                                         int flags, int filter_flags)
+                                         int flags, int filter_level)
 {
        struct file_struct *file;
 #if defined SUPPORT_ACLS || defined SUPPORT_XATTRS
        statx sx;
 #endif
 
-       file = make_file(fname, flist, stp, flags, filter_flags);
+       file = make_file(fname, flist, stp, flags, filter_level);
        if (!file)
                return NULL;
 
@@ -1263,12 +1270,12 @@ static struct file_struct *send_file_name(int f, struct file_list *flist,
        }
 #endif
 
-       maybe_emit_filelist_progress(flist->count + flist_count_offset);
+       maybe_emit_filelist_progress(flist->used + flist_count_offset);
 
-       flist_expand(flist);
-       flist->files[flist->count++] = file;
+       flist_expand(flist, 1);
+       flist->files[flist->used++] = file;
        if (f >= 0) {
-               send_file_entry(f, file, flist->count - 1);
+               send_file_entry(f, file, flist->used - 1);
 #ifdef SUPPORT_ACLS
                if (preserve_acls && !S_ISLNK(file->mode)) {
                        send_acl(&sx, f);
@@ -1313,36 +1320,106 @@ static void send_if_directory(int f, struct file_list *flist,
        }
 }
 
-static int file_compare(struct file_struct **file1, struct file_struct **file2)
+static int file_compare(const void *file1, const void *file2)
+{
+       return f_name_cmp(*(struct file_struct **)file1,
+                         *(struct file_struct **)file2);
+}
+
+/* The guts of a merge-sort algorithm.  This was derived from the glibc
+ * version, but I (Wayne) changed the merge code to do less copying and
+ * to require only half the amount of temporary memory. */
+static void fsort_tmp(struct file_struct **fp, size_t num,
+                     struct file_struct **tmp)
+{
+       struct file_struct **f1, **f2, **t;
+       size_t n1, n2;
+
+       n1 = num / 2;
+       n2 = num - n1;
+       f1 = fp;
+       f2 = fp + n1;
+
+       if (n1 > 1)
+               fsort_tmp(f1, n1, tmp);
+       if (n2 > 1)
+               fsort_tmp(f2, n2, tmp);
+
+       while (f_name_cmp(*f1, *f2) <= 0) {
+               if (!--n1)
+                       return;
+               f1++;
+       }
+
+       t = tmp;
+       memcpy(t, f1, n1 * PTR_SIZE);
+
+       *f1++ = *f2++, n2--;
+
+       while (n1 > 0 && n2 > 0) {
+               if (f_name_cmp(*t, *f2) <= 0)
+                       *f1++ = *t++, n1--;
+               else
+                       *f1++ = *f2++, n2--;
+       }
+
+       if (n1 > 0)
+               memcpy(f1, t, n1 * PTR_SIZE);
+}
+
+/* This file-struct sorting routine makes sure that any identical names in
+ * the file list stay in the same order as they were in the original list.
+ * This is particularly vital in inc_recurse mode where we expect a sort
+ * on the flist to match the exact order of a sort on the dir_flist. */
+static void fsort(struct file_struct **fp, size_t num)
 {
-       return f_name_cmp(*file1, *file2);
+       if (num <= 1)
+               return;
+
+       if (use_qsort)
+               qsort(fp, num, PTR_SIZE, file_compare);
+       else {
+               struct file_struct **tmp = new_array(struct file_struct *,
+                                                    (num+1) / 2);
+               fsort_tmp(fp, num, tmp);
+               free(tmp);
+       }
 }
 
-/* We take an entire set of sibling dirs from dir_flist (start <= ndx <= end),
- * sort them by name, and link them into the tree, setting the appropriate
- * parent/child/sibling pointers. */
-static void add_dirs_to_tree(int parent_ndx, int start, int end)
+/* We take an entire set of sibling dirs from the sorted flist and link them
+ * into the tree, setting the appropriate parent/child/sibling pointers. */
+static void add_dirs_to_tree(int parent_ndx, struct file_list *from_flist,
+                            int dir_cnt)
 {
        int i;
        int32 *dp = NULL;
        int32 *parent_dp = parent_ndx < 0 ? NULL
-                        : F_DIRNODE_P(dir_flist->sorted[parent_ndx]);
+                        : F_DIR_NODE_P(dir_flist->sorted[parent_ndx]);
+
+       flist_expand(dir_flist, dir_cnt);
+       dir_flist->sorted = dir_flist->files;
+
+       for (i = 0; dir_cnt; i++) {
+               struct file_struct *file = from_flist->sorted[i];
+
+               if (!S_ISDIR(file->mode))
+                       continue;
 
-       qsort(dir_flist->sorted + start, end - start + 1,
-             sizeof dir_flist->sorted[0], (int (*)())file_compare);
+               dir_flist->files[dir_flist->used++] = file;
+               dir_cnt--;
 
-       for (i = start; i <= end; i++) {
-               struct file_struct *file = dir_flist->sorted[i];
                if (!(file->flags & FLAG_XFER_DIR)
                 || file->flags & FLAG_MOUNT_DIR)
                        continue;
+
                if (dp)
-                       DIR_NEXT_SIBLING(dp) = i;
+                       DIR_NEXT_SIBLING(dp) = dir_flist->used - 1;
                else if (parent_dp)
-                       DIR_FIRST_CHILD(parent_dp) = i;
+                       DIR_FIRST_CHILD(parent_dp) = dir_flist->used - 1;
                else
-                       send_dir_ndx = i;
-               dp = F_DIRNODE_P(file);
+                       send_dir_ndx = dir_flist->used - 1;
+
+               dp = F_DIR_NODE_P(file);
                DIR_PARENT(dp) = parent_ndx;
                DIR_FIRST_CHILD(dp) = -1;
        }
@@ -1363,8 +1440,8 @@ static void send_directory(int f, struct file_list *flist, char *fbuf, int len,
        char *p;
        DIR *d;
        int divert_dirs = (flags & FLAG_DIVERT_DIRS) != 0;
-       int start = flist->count;
-       int filter_flags = f == -2 ? SERVER_FILTERS : ALL_FILTERS;
+       int start = flist->used;
+       int filter_level = f == -2 ? SERVER_FILTERS : ALL_FILTERS;
 
        assert(flist != NULL);
 
@@ -1393,7 +1470,7 @@ static void send_directory(int f, struct file_list *flist, char *fbuf, int len,
                        continue;
                }
 
-               send_file_name(f, flist, fbuf, NULL, flags, filter_flags);
+               send_file_name(f, flist, fbuf, NULL, flags, filter_level);
        }
 
        fbuf[len] = '\0';
@@ -1406,8 +1483,8 @@ static void send_directory(int f, struct file_list *flist, char *fbuf, int len,
        closedir(d);
 
        if (f >= 0 && recurse && !divert_dirs) {
-               int i, end = flist->count - 1;
-               /* send_if_directory() bumps flist->count, so use "end". */
+               int i, end = flist->used - 1;
+               /* send_if_directory() bumps flist->used, so use "end". */
                for (i = start; i <= end; i++)
                        send_if_directory(f, flist, flist->files[i], fbuf, len, flags);
        }
@@ -1444,92 +1521,67 @@ void send_extra_file_list(int f, int at_least)
         * files in the upcoming file-lists. */
        if (cur_flist->next) {
                flist = first_flist->prev; /* the newest flist */
-               future_cnt = flist->count + flist->ndx_start
-                          - cur_flist->next->ndx_start;
+               future_cnt = flist->ndx_end - cur_flist->next->ndx_start + 1;
        } else
                future_cnt = 0;
        while (future_cnt < at_least) {
                struct file_struct *file = dir_flist->sorted[send_dir_ndx];
-               int start = dir_flist->count;
+               int dir_ndx, dstart = dir_count;
                int32 *dp;
 
                flist = flist_new(0, "send_extra_file_list");
                start_write = stats.total_written;
 
-               /* If this is the first of a set of duplicate dirs, we must
-                * send all the dirs together in a single file-list.  We must
-                * also send the index of the last dir in the header. */
-               if (file->flags & FLAG_DUPLICATE) {
-                       int dir_ndx, end_ndx = send_dir_ndx;
-                       struct file_struct *fp = file;
-
-                       while (1) {
-                               dp = F_DIRNODE_P(fp);
-                               end_ndx = DIR_NEXT_SIBLING(dp);
-                               fp = dir_flist->sorted[end_ndx];
-                               if (!(fp->flags & FLAG_DUPLICATE))
-                                       break;
-                       }
-
-#ifdef ICONV_OPTION
-                       if (ic_ndx)
-                               dir_ndx = F_NDX(fp);
-                       else
-#endif
-                               dir_ndx = end_ndx;
-                       write_ndx(f, NDX_FLIST_OFFSET - dir_ndx);
-
-                       while (1) {
-                               send1extra(f, file, flist);
-                               if (send_dir_ndx == end_ndx)
-                                       break;
-                               dp = F_DIRNODE_P(file);
-                               send_dir_ndx = DIR_NEXT_SIBLING(dp);
-                               file = dir_flist->sorted[send_dir_ndx];
-                       }
-               } else {
-                       int dir_ndx;
 #ifdef ICONV_OPTION
-                       if (ic_ndx)
-                               dir_ndx = F_NDX(file);
-                       else
+               if (ic_ndx)
+                       dir_ndx = F_NDX(file);
+               else
 #endif
-                               dir_ndx = send_dir_ndx;
-                       write_ndx(f, NDX_FLIST_OFFSET - dir_ndx);
-
+                       dir_ndx = send_dir_ndx;
+               write_ndx(f, NDX_FLIST_OFFSET - dir_ndx);
+               flist->parent_ndx = dir_ndx;
+
+               send1extra(f, file, flist);
+               dp = F_DIR_NODE_P(file);
+
+               /* If there are any duplicate directory names that follow, we
+                * send all the dirs together in one file-list.  The dir_flist
+                * tree links all the child subdirs onto the last dup dir. */
+               while ((dir_ndx = DIR_NEXT_SIBLING(dp)) >= 0
+                   && dir_flist->sorted[dir_ndx]->flags & FLAG_DUPLICATE) {
+                       send_dir_ndx = dir_ndx;
+                       file = dir_flist->sorted[dir_ndx];
                        send1extra(f, file, flist);
+                       dp = F_DIR_NODE_P(file);
                }
-               write_byte(f, 0);
 
-               if (!need_unsorted_flist)
-                       dir_flist->sorted = dir_flist->files;
-               add_dirs_to_tree(send_dir_ndx, start, dir_flist->count - 1);
+               write_byte(f, 0);
 
 #ifdef ICONV_OPTION
                if (need_unsorted_flist) {
-                       if (inc_recurse) {
-                               if (!(flist->sorted = new_array(struct file_struct *, flist->count)))
-                                       out_of_memory("send_extra_file_list");
-                               memcpy(flist->sorted, flist->files,
-                                      flist->count * sizeof (struct file_struct*));
-                               clean_flist(flist, 0);
-                       } else
-                               flist->sorted = flist->files;
+                       if (!(flist->sorted = new_array(struct file_struct *, flist->used)))
+                               out_of_memory("send_extra_file_list");
+                       memcpy(flist->sorted, flist->files,
+                              flist->used * sizeof (struct file_struct*));
                } else
 #endif
-               {
                        flist->sorted = flist->files;
-                       clean_flist(flist, 0);
-               }
 
-               file_total += flist->count;
-               future_cnt += flist->count;
+               clean_flist(flist, 0);
+
+               flist->ndx_end = flist->ndx_start + flist->used - 1
+                              - (dir_count - dstart);
+
+               add_dirs_to_tree(send_dir_ndx, flist, dir_count - dstart);
+               flist_done_allocating(flist);
+
+               file_total += flist->used;
+               future_cnt += flist->used;
                stats.flist_size += stats.total_written - start_write;
-               stats.num_files += flist->count;
+               stats.num_files += flist->used;
                if (verbose > 3)
                        output_flist(flist);
 
-               dp = F_DIRNODE_P(file);
                if (DIR_FIRST_CHILD(dp) >= 0) {
                        send_dir_ndx = DIR_FIRST_CHILD(dp);
                        send_dir_depth++;
@@ -1543,7 +1595,7 @@ void send_extra_file_list(int f, int at_least)
                                }
                                send_dir_depth--;
                                file = dir_flist->sorted[send_dir_ndx];
-                               dp = F_DIRNODE_P(file);
+                               dp = F_DIR_NODE_P(file);
                        }
                        send_dir_ndx = DIR_NEXT_SIBLING(dp);
                }
@@ -1817,23 +1869,30 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 #ifdef ICONV_OPTION
        if (need_unsorted_flist) {
                if (inc_recurse) {
-                       if (!(flist->sorted = new_array(struct file_struct *, flist->count)))
+                       if (!(flist->sorted = new_array(struct file_struct *, flist->used)))
                                out_of_memory("send_file_list");
                        memcpy(flist->sorted, flist->files,
-                              flist->count * sizeof (struct file_struct*));
+                              flist->used * sizeof (struct file_struct*));
                        clean_flist(flist, 0);
-               } else
+               } else {
                        flist->sorted = flist->files;
+                       flist->low = 0;
+                       flist->high = flist->used - 1;
+               }
        } else
 #endif
        {
                flist->sorted = flist->files;
                clean_flist(flist, 0);
        }
-       file_total += flist->count;
+       file_total += flist->used;
+
+       /* We don't subtract dir_count for the first send since we
+        * might have one or more dot dirs which need to get sent. */
+       flist->ndx_end = flist->ndx_start + flist->used - 1;
 
        if (!numeric_ids && !inc_recurse)
-               send_uid_list(f);
+               send_id_list(f);
 
        /* send the io_error flag */
        if (protocol_version < 30)
@@ -1845,7 +1904,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                io_end_buffering_out();
 
        stats.flist_size = stats.total_written - start_write;
-       stats.num_files = flist->count;
+       stats.num_files = flist->used;
 
        if (verbose > 3)
                output_flist(flist);
@@ -1854,9 +1913,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                rprintf(FINFO, "send_file_list done\n");
 
        if (inc_recurse) {
-               if (!need_unsorted_flist)
-                       dir_flist->sorted = dir_flist->files;
-               add_dirs_to_tree(-1, 0, dir_flist->count - 1);
+               add_dirs_to_tree(-1, flist, dir_count);
+               flist_done_allocating(flist);
                if (send_dir_ndx < 0) {
                        write_ndx(f, NDX_FLIST_EOF);
                        flist_eof = 1;
@@ -1897,7 +1955,7 @@ struct file_list *recv_file_list(int f)
        if (inc_recurse) {
                if (flist->ndx_start == 0)
                        dir_flist = flist_new(FLIST_TEMP, "recv_file_list");
-               dstart = dir_flist->count;
+               dstart = dir_flist->used;
        } else {
                dir_flist = flist;
                dstart = 0;
@@ -1906,32 +1964,34 @@ struct file_list *recv_file_list(int f)
        while ((flags = read_byte(f)) != 0) {
                struct file_struct *file;
 
-               flist_expand(flist);
+               flist_expand(flist, 1);
 
                if (protocol_version >= 28 && (flags & XMIT_EXTENDED_FLAGS))
                        flags |= read_byte(f) << 8;
                file = recv_file_entry(flist, flags, f);
 
                if (inc_recurse && S_ISDIR(file->mode)) {
-                       flist_expand(dir_flist);
-                       if (need_unsorted_flist)
-                               dir_flist->sorted[dir_flist->count] = file;
-                       dir_flist->files[dir_flist->count++] = file;
+                       flist_expand(dir_flist, 1);
+                       dir_flist->files[dir_flist->used++] = file;
                }
 
-               flist->files[flist->count++] = file;
+               flist->files[flist->used++] = file;
 
-               maybe_emit_filelist_progress(flist->count);
+               maybe_emit_filelist_progress(flist->used);
 
                if (verbose > 2) {
                        rprintf(FINFO, "recv_file_name(%s)\n",
                                f_name(file, NULL));
                }
        }
-       file_total += flist->count;
+       file_total += flist->used;
+
+       flist->ndx_end = flist->ndx_start + flist->used - 1;
+       if (inc_recurse && flist->ndx_start)
+               flist->ndx_end -= dir_flist->used - dstart;
 
        if (verbose > 2)
-               rprintf(FINFO, "received %d names\n", flist->count);
+               rprintf(FINFO, "received %d names\n", flist->used);
 
        if (show_filelist_p())
                finish_filelist_progress(flist);
@@ -1943,27 +2003,32 @@ struct file_list *recv_file_list(int f)
                 * order and for calling flist_find()).  We keep the "files"
                 * list unsorted for our exchange of index numbers with the
                 * other side (since their names may not sort the same). */
-               if (!(flist->sorted = new_array(struct file_struct *, flist->count)))
+               if (!(flist->sorted = new_array(struct file_struct *, flist->used)))
                        out_of_memory("recv_file_list");
                memcpy(flist->sorted, flist->files,
-                      flist->count * sizeof (struct file_struct*));
-               if (inc_recurse) {
-                       qsort(dir_flist->sorted + dstart, dir_flist->count - dstart,
-                             sizeof (struct file_struct*), (int (*)())file_compare);
+                      flist->used * sizeof (struct file_struct*));
+               if (inc_recurse && dir_flist->used > dstart) {
+                       dir_flist->sorted = realloc_array(dir_flist->sorted,
+                                               struct file_struct *,
+                                               dir_flist->used);
+                       memcpy(dir_flist->sorted + dstart, dir_flist->files + dstart,
+                              (dir_flist->used - dstart) * sizeof (struct file_struct*));
+                       fsort(dir_flist->sorted + dstart, dir_flist->used - dstart);
                }
        } else
 #endif
        {
                flist->sorted = flist->files;
-               if (inc_recurse) {
+               if (inc_recurse && dir_flist->used > dstart) {
                        dir_flist->sorted = dir_flist->files;
-                       qsort(dir_flist->sorted + dstart, dir_flist->count - dstart,
-                             sizeof (struct file_struct*), (int (*)())file_compare);
+                       fsort(dir_flist->sorted + dstart, dir_flist->used - dstart);
                }
        }
 
-       if (!inc_recurse && f >= 0)
-               recv_uid_list(f, flist);
+       if (inc_recurse)
+               flist_done_allocating(flist);
+       else if (f >= 0)
+               recv_id_list(f, flist);
 
        clean_flist(flist, relative_paths);
 
@@ -1980,7 +2045,7 @@ struct file_list *recv_file_list(int f)
 
        if (list_only) {
                int i;
-               for (i = 0; i < flist->count; i++)
+               for (i = flist->low; i <= flist->high; i++)
                        list_file_entry(flist->files[i]);
        }
 
@@ -1988,7 +2053,7 @@ struct file_list *recv_file_list(int f)
                rprintf(FINFO, "recv_file_list done\n");
 
        stats.flist_size += stats.total_read - start_read;
-       stats.num_files += flist->count;
+       stats.num_files += flist->used;
 
        return flist;
 }
@@ -2004,14 +2069,18 @@ void recv_additional_file_list(int f)
                change_local_filter_dir(NULL, 0, 0);
        } else {
                ndx = NDX_FLIST_OFFSET - ndx;
-               if (ndx < 0 || ndx >= dir_flist->count) {
+               if (ndx < 0 || ndx >= dir_flist->used) {
                        ndx = NDX_FLIST_OFFSET - ndx;
                        rprintf(FERROR,
-                               "Invalid dir index: %d (%d - %d)\n",
-                               ndx, NDX_FLIST_OFFSET,
-                               NDX_FLIST_OFFSET - dir_flist->count);
+                               "[%s] Invalid dir index: %d (%d - %d)\n",
+                               who_am_i(), ndx, NDX_FLIST_OFFSET,
+                               NDX_FLIST_OFFSET - dir_flist->used + 1);
                        exit_cleanup(RERR_PROTOCOL);
                }
+               if (verbose > 3) {
+                       rprintf(FINFO, "[%s] receiving flist for dir %d\n",
+                               who_am_i(), ndx);
+               }
                flist = recv_file_list(f);
                flist->parent_ndx = ndx;
        }
@@ -2094,34 +2163,41 @@ struct file_list *flist_new(int flags, char *msg)
 
        memset(flist, 0, sizeof flist[0]);
 
-       if (!(flags & FLIST_TEMP)) {
-               if (first_flist) {
-                       flist->ndx_start = first_flist->prev->ndx_start
-                                        + first_flist->prev->count;
-               }
+       if (flags & FLIST_TEMP) {
+               if (!(flist->file_pool = pool_create(SMALL_EXTENT, 0,
+                                               out_of_memory, POOL_INTERN)))
+                       out_of_memory(msg);
+       } else {
                /* This is a doubly linked list with prev looping back to
                 * the end of the list, but the last next pointer is NULL. */
-               if (!first_flist)
+               if (!first_flist) {
+                       flist->file_pool = pool_create(NORMAL_EXTENT, 0,
+                                               out_of_memory, POOL_INTERN);
+                       if (!flist->file_pool)
+                               out_of_memory(msg);
+
                        first_flist = cur_flist = flist->prev = flist;
-               else {
+               } else {
+                       flist->file_pool = first_flist->file_pool;
+
+                       flist->ndx_start = first_flist->prev->ndx_end + 2;
+
                        flist->prev = first_flist->prev;
                        flist->prev->next = first_flist->prev = flist;
                }
+               flist->pool_boundary = pool_boundary(flist->file_pool, 0);
                flist_cnt++;
        }
 
-       if (!(flist->file_pool = pool_create(FILE_EXTENT, 0, out_of_memory, POOL_INTERN)))
-               out_of_memory(msg);
-
        return flist;
 }
 
 /* Free up all elements in a flist. */
 void flist_free(struct file_list *flist)
 {
-       if (!flist->prev)
-               /* Was FLIST_TEMP dir-list. */
-       else if (flist == flist->prev) {
+       if (!flist->prev) {
+               /* Was FLIST_TEMP dir-list. */
+       else if (flist == flist->prev) {
                first_flist = cur_flist = NULL;
                file_total = 0;
                flist_cnt = 0;
@@ -2136,11 +2212,15 @@ void flist_free(struct file_list *flist)
                                flist->next = first_flist;
                }
                flist->next->prev = flist->prev;
-               file_total -= flist->count;
+               file_total -= flist->used;
                flist_cnt--;
        }
 
-       pool_destroy(flist->file_pool);
+       if (!flist->prev || !flist_cnt)
+               pool_destroy(flist->file_pool);
+       else
+               pool_free_old(flist->file_pool, flist->pool_boundary);
+
        if (flist->sorted && flist->sorted != flist->files)
                free(flist->sorted);
        free(flist->files);
@@ -2156,16 +2236,16 @@ static void clean_flist(struct file_list *flist, int strip_root)
 
        if (!flist)
                return;
-       if (flist->count == 0) {
+       if (flist->used == 0) {
                flist->high = -1;
+               flist->low = 0;
                return;
        }
 
-       qsort(flist->sorted, flist->count,
-           sizeof flist->sorted[0], (int (*)())file_compare);
+       fsort(flist->sorted, flist->used);
 
        if (!am_sender || inc_recurse) {
-               for (i = prev_i = 0; i < flist->count; i++) {
+               for (i = prev_i = 0; i < flist->used; i++) {
                        if (F_IS_ACTIVE(flist->sorted[i])) {
                                prev_i = i;
                                break;
@@ -2173,11 +2253,11 @@ static void clean_flist(struct file_list *flist, int strip_root)
                }
                flist->low = prev_i;
        } else {
-               i = prev_i = flist->count - 1;
+               i = prev_i = flist->used - 1;
                flist->low = 0;
        }
 
-       while (++i < flist->count) {
+       while (++i < flist->used) {
                int j;
                struct file_struct *file = flist->sorted[i];
 
@@ -2196,20 +2276,18 @@ static void clean_flist(struct file_list *flist, int strip_root)
                } else
                        j = -1;
                if (j >= 0) {
-                       struct file_struct *fp = flist->sorted[j];
                        int keep, drop;
                        /* If one is a dir and the other is not, we want to
                         * keep the dir because it might have contents in the
                         * list. */
-                       if (S_ISDIR(file->mode) != S_ISDIR(fp->mode)) {
-                               if (S_ISDIR(file->mode))
+                       if (S_ISDIR(file->mode)) {
+                               struct file_struct *fp = flist->sorted[j];
+                               if (!S_ISDIR(fp->mode))
                                        keep = i, drop = j;
                                else
                                        keep = j, drop = i;
-                       } else if (protocol_version < 27)
+                       } else
                                keep = j, drop = i;
-                       else
-                               keep = i, drop = j;
 
                        if (am_sender)
                                flist->sorted[drop]->flags |= FLAG_DUPLICATE;
@@ -2217,7 +2295,7 @@ static void clean_flist(struct file_list *flist, int strip_root)
                                if (verbose > 1) {
                                        rprintf(FINFO,
                                            "removing duplicate name %s from file list (%d)\n",
-                                           f_name(file, fbuf), drop);
+                                           f_name(file, fbuf), drop + flist->ndx_start);
                                }
                                /* Make sure we don't lose track of a user-specified
                                 * top directory. */
@@ -2331,18 +2409,20 @@ static void output_flist(struct file_list *flist)
        const char *who = who_am_i();
        int i;
 
-       rprintf(FINFO, "[%s] flist start=%d, count=%d, low=%d, high=%d\n",
-               who, flist->ndx_start, flist->count, flist->low, flist->high);
-       for (i = 0; i < flist->count; i++) {
+       rprintf(FINFO, "[%s] flist start=%d, end=%d, used=%d, low=%d, high=%d\n",
+               who, flist->ndx_start, flist->ndx_end, flist->used, flist->low, flist->high);
+       for (i = 0; i < flist->used; i++) {
                file = flist->sorted[i];
-               if ((am_root || am_sender) && preserve_uid) {
-                       snprintf(uidbuf, sizeof uidbuf, " uid=%ld",
-                                (long)F_UID(file));
+               if ((am_root || am_sender) && uid_ndx) {
+                       snprintf(uidbuf, sizeof uidbuf, " uid=%u",
+                                F_OWNER(file));
                } else
                        *uidbuf = '\0';
-               if (preserve_gid && F_GID(file) != GID_NONE) {
-                       snprintf(gidbuf, sizeof gidbuf, " gid=%ld",
-                                (long)F_GID(file));
+               if (gid_ndx) {
+                       static char parens[] = "(\0)\0\0\0";
+                       char *pp = parens + (file->flags & FLAG_SKIP_GROUP ? 0 : 3);
+                       snprintf(gidbuf, sizeof gidbuf, " gid=%s%u%s",
+                                pp, F_GROUP(file), pp + 2);
                } else
                        *gidbuf = '\0';
                if (!am_sender)
@@ -2357,9 +2437,12 @@ static void output_flist(struct file_list *flist)
                        trail = S_ISDIR(file->mode) ? "/" : "";
                } else
                        root = dir = slash = name = trail = "";
-               rprintf(FINFO, "[%s] i=%d %s %s%s%s%s mode=0%o len=%.0f%s%s flags=%x\n",
-                       who, i, root, dir, slash, name, trail, (int)file->mode,
-                       (double)F_LENGTH(file), uidbuf, gidbuf, file->flags);
+               rprintf(FINFO,
+                       "[%s] i=%d %s %s%s%s%s mode=0%o len=%.0f%s%s flags=%x\n",
+                       who, i + flist->ndx_start,
+                       root, dir, slash, name, trail,
+                       (int)file->mode, (double)F_LENGTH(file),
+                       uidbuf, gidbuf, file->flags);
        }
 }
 
@@ -2543,6 +2626,7 @@ struct file_list *get_dirlist(char *dirname, int dlen, int ignore_filter_rules)
        char dirbuf[MAXPATHLEN];
        int save_recurse = recurse;
        int save_xfer_dirs = xfer_dirs;
+       int save_prune_empty_dirs = prune_empty_dirs;
 
        if (dlen < 0) {
                dlen = strlcpy(dirbuf, dirname, MAXPATHLEN);
@@ -2559,10 +2643,12 @@ struct file_list *get_dirlist(char *dirname, int dlen, int ignore_filter_rules)
        xfer_dirs = save_xfer_dirs;
        recurse = save_recurse;
        if (do_progress)
-               flist_count_offset += dirlist->count;
+               flist_count_offset += dirlist->used;
 
+       prune_empty_dirs = 0;
        dirlist->sorted = dirlist->files;
        clean_flist(dirlist, 0);
+       prune_empty_dirs = save_prune_empty_dirs;
 
        if (verbose > 3)
                output_flist(dirlist);