- Updated the address for the FSF in the opening comment.
[rsync/rsync.git] / log.c
diff --git a/log.c b/log.c
index d29e2b9..db21230 100644 (file)
--- a/log.c
+++ b/log.c
@@ -1,47 +1,59 @@
-/* -*- c-file-style: "linux"; -*-
-
-   Copyright (C) 1998-2001 by Andrew Tridgell <tridge@samba.org>
-   Copyright (C) 2000-2001 by Martin Pool <mbp@samba.org>
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-*/
-
 /*
-  Logging and utility functions.
-  tridge, May 1998
+ * Logging and utility functions.
+ *
+ * Copyright (C) 1998-2001 Andrew Tridgell <tridge@samba.org>
+ * Copyright (C) 2000-2001 Martin Pool <mbp@samba.org>
+ * Copyright (C) 2003, 2004, 2005, 2006 Wayne Davison
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
 
-  Mapping to human-readable messages added by Martin Pool
-  <mbp@samba.org>, Oct 2000.
-  */
 #include "rsync.h"
+#if defined HAVE_ICONV_OPEN && defined HAVE_ICONV_H
+#include <iconv.h>
+#endif
 
+extern int verbose;
+extern int dry_run;
 extern int am_daemon;
 extern int am_server;
 extern int am_sender;
+extern int local_server;
 extern int quiet;
 extern int module_id;
 extern int msg_fd_out;
+extern int allow_8bit_chars;
+extern int protocol_version;
+extern int preserve_times;
+extern int log_format_has_i;
+extern int log_format_has_o_or_i;
+extern int daemon_log_format_has_o_or_i;
+extern mode_t orig_umask;
 extern char *auth_user;
 extern char *log_format;
+#if defined HAVE_ICONV_OPEN && defined HAVE_ICONV_H
+extern iconv_t ic_chck;
+#endif
 
 static int log_initialised;
+static int logfile_was_closed;
 static char *logfname;
 static FILE *logfile;
 struct stats stats;
 
-int log_got_error=0;
+int log_got_error = 0;
 
 struct {
         int code;
@@ -57,21 +69,24 @@ struct {
        { RERR_STREAMIO   , "error in rsync protocol data stream" },
        { RERR_MESSAGEIO  , "errors with program diagnostics" },
        { RERR_IPC        , "error in IPC code" },
-       { RERR_SIGNAL     , "received SIGUSR1 or SIGINT" },
-       { RERR_WAITCHILD  , "some error returned by waitpid()" },
+       { RERR_CRASHED    , "sibling process crashed" },
+       { RERR_TERMINATED , "sibling process terminated abnormally" },
+       { RERR_SIGNAL1    , "received SIGUSR1" },
+       { RERR_SIGNAL     , "received SIGINT, SIGTERM, or SIGHUP" },
+       { RERR_WAITCHILD  , "waitpid() failed" },
        { RERR_MALLOC     , "error allocating core memory buffers" },
        { RERR_PARTIAL    , "some files could not be transferred" },
-       { RERR_VANISHED   , "some files vanished before they could be transfered" },
+       { RERR_VANISHED   , "some files vanished before they could be transferred" },
        { RERR_TIMEOUT    , "timeout in data send/receive" },
        { RERR_CMD_FAILED , "remote shell failed" },
        { RERR_CMD_KILLED , "remote shell killed" },
-       { RERR_CMD_RUN,     "remote command could not be run" },
-       { RERR_CMD_NOTFOUND, "remote command not found" },
+       { RERR_CMD_RUN    , "remote command could not be run" },
+       { RERR_CMD_NOTFOUND,"remote command not found" },
+       { RERR_DEL_LIMIT  , "the --max-delete limit stopped deletions" },
        { 0, NULL }
 };
 
 
-
 /*
  * Map from rsync error code to name, or return NULL.
  */
@@ -85,12 +100,11 @@ static char const *rerr_name(int code)
        return NULL;
 }
 
-
 static void logit(int priority, char *buf)
 {
-       if (logfname) {
-               if (!logfile)
-                       log_open();
+       if (logfile_was_closed)
+               logfile_reopen();
+       if (logfile) {
                fprintf(logfile,"%s [%d] %s",
                        timestring(time(NULL)), (int)getpid(), buf);
                fflush(logfile);
@@ -99,29 +113,14 @@ static void logit(int priority, char *buf)
        }
 }
 
-void log_init(void)
+static void syslog_init()
 {
+       static int been_here = 0;
        int options = LOG_PID;
-       time_t t;
 
-       if (log_initialised) return;
-       log_initialised = 1;
-
-       /* this looks pointless, but it is needed in order for the
-        * C library on some systems to fetch the timezone info
-        * before the chroot */
-       t = time(NULL);
-       localtime(&t);
-
-       /* optionally use a log file instead of syslog */
-       logfname = lp_log_file();
-       if (logfname) {
-               if (*logfname) {
-                       log_open();
-                       return;
-               }
-               logfname = NULL;
-       }
+       if (been_here)
+               return;
+       been_here = 1;
 
 #ifdef LOG_NDELAY
        options |= LOG_NDELAY;
@@ -134,137 +133,228 @@ void log_init(void)
 #endif
 
 #ifndef LOG_NDELAY
-       logit(LOG_INFO,"rsyncd started\n");
+       logit(LOG_INFO, "rsyncd started\n");
 #endif
 }
 
-void log_open(void)
+static void logfile_open(void)
 {
-       if (logfname && !logfile) {
-               extern int orig_umask;
-               int old_umask = umask(022 | orig_umask);
-               logfile = fopen(logfname, "a");
-               umask(old_umask);
+       mode_t old_umask = umask(022 | orig_umask);
+       logfile = fopen(logfname, "a");
+       umask(old_umask);
+       if (!logfile) {
+               int fopen_errno = errno;
+               /* Rsync falls back to using syslog on failure. */
+               syslog_init();
+               rsyserr(FERROR, fopen_errno,
+                       "failed to open log-file %s", logfname);
+               rprintf(FINFO, "Ignoring \"log file\" setting.\n");
        }
 }
 
-void log_close(void)
+void log_init(void)
+{
+       time_t t;
+
+       if (log_initialised)
+               return;
+       log_initialised = 1;
+
+       /* this looks pointless, but it is needed in order for the
+        * C library on some systems to fetch the timezone info
+        * before the chroot */
+       t = time(NULL);
+       localtime(&t);
+
+       /* optionally use a log file instead of syslog */
+       logfname = lp_log_file();
+       if (logfname && *logfname)
+               logfile_open();
+       else
+               syslog_init();
+}
+
+void logfile_close(void)
 {
        if (logfile) {
+               logfile_was_closed = 1;
                fclose(logfile);
                logfile = NULL;
        }
 }
 
+void logfile_reopen(void)
+{
+       if (logfile_was_closed) {
+               logfile_was_closed = 0;
+               logfile_open();
+       }
+}
+
+static void filtered_fwrite(FILE *f, const char *buf, int len, int use_isprint)
+{
+       const char *s, *end = buf + len;
+       for (s = buf; s < end; s++) {
+               if ((s < end - 4
+                 && *s == '\\' && s[1] == '#'
+                 && isdigit(*(uchar*)(s+2))
+                 && isdigit(*(uchar*)(s+3))
+                 && isdigit(*(uchar*)(s+4)))
+                || (*s != '\t'
+                 && ((use_isprint && !isprint(*(uchar*)s))
+                  || *(uchar*)s < ' '))) {
+                       if (s != buf && fwrite(buf, s - buf, 1, f) != 1)
+                               exit_cleanup(RERR_MESSAGEIO);
+                       fprintf(f, "\\#%03o", *(uchar*)s);
+                       buf = s + 1;
+               }
+       }
+       if (buf != end && fwrite(buf, end - buf, 1, f) != 1)
+               exit_cleanup(RERR_MESSAGEIO);
+}
+
 /* this is the underlying (unformatted) rsync debugging function. Call
- * it with FINFO, FERROR or FLOG */
+ * it with FINFO, FERROR or FLOG.  Note: recursion can happen with
+ * certain fatal conditions. */
 void rwrite(enum logcode code, char *buf, int len)
 {
-       FILE *f=NULL;
-       /* recursion can happen with certain fatal conditions */
-
-       if (quiet && code == FINFO)
-               return;
+       int trailing_CR_or_NL;
+       FILE *f = NULL;
 
        if (len < 0)
                exit_cleanup(RERR_MESSAGEIO);
 
-       buf[len] = 0;
-
-       if (code == FLOG) {
-               if (am_daemon) logit(LOG_INFO, buf);
+       if (quiet && code == FINFO)
                return;
-       }
 
-       if (am_server) {
-               /* Pass it to non-server side, perhaps through our sibling. */
-               if (msg_fd_out >= 0) {
-                       send_msg((enum msgcode)code, buf, len);
-                       return;
-               }
-               if (io_multiplex_write((enum msgcode)code, buf, len))
-                       return;
+       if (am_server && msg_fd_out >= 0) {
+               /* Pass the message to our sibling. */
+               send_msg((enum msgcode)code, buf, len);
+               return;
        }
 
-       /* otherwise, if in daemon mode and either we are not a server
-        *  (that is, we are not running --daemon over a remote shell) or
-        *  the log has already been initialised, log the message on this
-        *  side because we don't want the client to see most errors for
-        *  security reasons.  We do want early messages when running daemon
-        *  mode over a remote shell to go to the remote side; those will
-        *  fall through to the next case.
-        * Note that this is only for the time before multiplexing is enabled.
-        */
-       if (am_daemon && (!am_server || log_initialised)) {
-               static int depth;
-               int priority = LOG_INFO;
-               if (code == FERROR) priority = LOG_WARNING;
-
-               if (depth) return;
+       if (code == FSOCKERR) /* This gets simplified for a non-sibling. */
+               code = FERROR;
 
-               depth++;
+       if (code == FCLIENT)
+               code = FINFO;
+       else if (am_daemon) {
+               static int in_block;
+               char msg[2048];
+               int priority = code == FERROR ? LOG_WARNING : LOG_INFO;
 
-               log_init();
-               logit(priority, buf);
-
-               depth--;
+               if (in_block)
+                       return;
+               in_block = 1;
+               if (!log_initialised)
+                       log_init();
+               strlcpy(msg, buf, MIN((int)sizeof msg, len + 1));
+               logit(priority, msg);
+               in_block = 0;
+
+               if (code == FLOG || !am_server)
+                       return;
+       } else if (code == FLOG)
                return;
+
+       if (am_server) {
+               /* Pass the message to the non-server side. */
+               if (io_multiplex_write((enum msgcode)code, buf, len))
+                       return;
+               if (am_daemon) {
+                       /* TODO: can we send the error to the user somehow? */
+                       return;
+               }
        }
 
-       if (code == FERROR) {
+       switch (code) {
+       case FERROR:
                log_got_error = 1;
                f = stderr;
+               goto pre_scan;
+       case FINFO:
+               f = am_server ? stderr : stdout;
+       pre_scan:
+               while (len > 1 && *buf == '\n') {
+                       fputc(*buf, f);
+                       buf++;
+                       len--;
+               }
+               break;
+       case FNAME:
+               f = am_server ? stderr : stdout;
+               break;
+       default:
+               exit_cleanup(RERR_MESSAGEIO);
        }
 
-       if (code == FINFO) {
-               if (am_server)
-                       f = stderr;
-               else
-                       f = stdout;
-       }
-
-       if (!f) exit_cleanup(RERR_MESSAGEIO);
-
-       if (fwrite(buf, len, 1, f) != 1) exit_cleanup(RERR_MESSAGEIO);
+       trailing_CR_or_NL = len && (buf[len-1] == '\n' || buf[len-1] == '\r')
+                         ? buf[--len] : 0;
+
+#if defined HAVE_ICONV_OPEN && defined HAVE_ICONV_H
+       if (ic_chck != (iconv_t)-1) {
+               char convbuf[1024];
+               char *in_buf = buf, *out_buf = convbuf;
+               size_t in_cnt = len, out_cnt = sizeof convbuf - 1;
+
+               iconv(ic_chck, NULL, 0, NULL, 0);
+               while (iconv(ic_chck, &in_buf,&in_cnt,
+                                &out_buf,&out_cnt) == (size_t)-1) {
+                       if (out_buf != convbuf) {
+                               filtered_fwrite(f, convbuf, out_buf - convbuf, 0);
+                               out_buf = convbuf;
+                               out_cnt = sizeof convbuf - 1;
+                       }
+                       if (errno == E2BIG)
+                               continue;
+                       fprintf(f, "\\#%03o", *(uchar*)in_buf++);
+                       in_cnt--;
+               }
+               if (out_buf != convbuf)
+                       filtered_fwrite(f, convbuf, out_buf - convbuf, 0);
+       } else
+#endif
+               filtered_fwrite(f, buf, len, !allow_8bit_chars);
 
-       if (buf[len-1] == '\r' || buf[len-1] == '\n') fflush(f);
+       if (trailing_CR_or_NL) {
+               fputc(trailing_CR_or_NL, f);
+               fflush(f);
+       }
 }
-               
 
 /* This is the rsync debugging function. Call it with FINFO, FERROR or
  * FLOG. */
 void rprintf(enum logcode code, const char *format, ...)
 {
        va_list ap;
-       char buf[1024];
-       int len;
+       char buf[BIGPATHBUFLEN];
+       size_t len;
 
        va_start(ap, format);
-       /* Note: might return -1 */
-       len = vsnprintf(buf, sizeof(buf), format, ap);
+       len = vsnprintf(buf, sizeof buf, format, ap);
        va_end(ap);
 
        /* Deal with buffer overruns.  Instead of panicking, just
-        * truncate the resulting string.  Note that some vsnprintf()s
-        * return -1 on truncation, e.g., glibc 2.0.6 and earlier. */
-       if ((size_t) len > sizeof(buf)-1  ||  len < 0) {
-               const char ellipsis[] = "[...]";
+        * truncate the resulting string.  (Note that configure ensures
+        * that we have a vsnprintf() that doesn't ever return -1.) */
+       if (len > sizeof buf - 1) {
+               static const char ellipsis[] = "[...]";
 
                /* Reset length, and zero-terminate the end of our buffer */
-               len = sizeof(buf)-1;
+               len = sizeof buf - 1;
                buf[len] = '\0';
 
                /* Copy the ellipsis to the end of the string, but give
                 * us one extra character:
                 *
-                *                  v--- null byte at buf[sizeof(buf)-1]
+                *                  v--- null byte at buf[sizeof buf - 1]
                 *        abcdefghij0
                 *     -> abcd[...]00  <-- now two null bytes at end
                 *
                 * If the input format string has a trailing newline,
                 * we copy it into that extra null; if it doesn't, well,
                 * all we lose is one byte.  */
-               strncpy(buf+len-sizeof(ellipsis), ellipsis, sizeof(ellipsis));
+               memcpy(buf+len-sizeof ellipsis, ellipsis, sizeof ellipsis);
                if (format[strlen(format)-1] == '\n') {
                        buf[len-1] = '\n';
                }
@@ -273,7 +363,6 @@ void rprintf(enum logcode code, const char *format, ...)
        rwrite(code, buf, len);
 }
 
-
 /* This is like rprintf, but it also tries to print some
  * representation of the error code.  Normally errcode = errno.
  *
@@ -285,42 +374,30 @@ void rprintf(enum logcode code, const char *format, ...)
 void rsyserr(enum logcode code, int errcode, const char *format, ...)
 {
        va_list ap;
-       char buf[1024];
-       int len;
-       size_t sys_len;
-       char *sysmsg;
+       char buf[BIGPATHBUFLEN];
+       size_t len;
+
+       strcpy(buf, RSYNC_NAME ": ");
+       len = (sizeof RSYNC_NAME ": ") - 1;
 
        va_start(ap, format);
-       /* Note: might return <0 */
-       len = vsnprintf(buf, sizeof(buf), format, ap);
+       len += vsnprintf(buf + len, sizeof buf - len, format, ap);
        va_end(ap);
 
-       /* TODO: Put in RSYNC_NAME at the start. */
-
-       if ((size_t) len > sizeof(buf)-1)
-               exit_cleanup(RERR_MESSAGEIO);
-
-       sysmsg = strerror(errcode);
-       sys_len = strlen(sysmsg);
-       if ((size_t) len + 3 + sys_len > sizeof(buf) - 1)
+       if (len < sizeof buf) {
+               len += snprintf(buf + len, sizeof buf - len,
+                               ": %s (%d)\n", strerror(errcode), errcode);
+       }
+       if (len >= sizeof buf)
                exit_cleanup(RERR_MESSAGEIO);
 
-       strcpy(buf + len, ": ");
-       len += 2;
-       strcpy(buf + len, sysmsg);
-       len += sys_len;
-       strcpy(buf + len, "\n");
-       len++;
-
        rwrite(code, buf, len);
 }
 
-
-
 void rflush(enum logcode code)
 {
        FILE *f = NULL;
-       
+
        if (am_daemon) {
                return;
        }
@@ -344,58 +421,143 @@ void rflush(enum logcode code)
        fflush(f);
 }
 
-
-
 /* a generic logging routine for send/recv, with parameter
  * substitiution */
-static void log_formatted(enum logcode code,
-                         char *format, char *op, struct file_struct *file,
-                         struct stats *initial_stats)
+static void log_formatted(enum logcode code, char *format, char *op,
+                         struct file_struct *file, struct stats *initial_stats,
+                         int iflags, char *hlink)
 {
-       char buf[1024];
-       char buf2[1024];
+       char buf[MAXPATHLEN+1024], buf2[MAXPATHLEN], fmt[32];
        char *p, *s, *n;
-       size_t l;
+       size_t len, total;
        int64 b;
 
+       *fmt = '%';
+
        /* We expand % codes one by one in place in buf.  We don't
-        * copy in the terminating nul of the inserted strings, but
-        * rather keep going until we reach the nul of the format.
-        * Just to make sure we don't clobber that nul and therefore
-        * accidentally keep going, we zero the buffer now. */
-       memset(buf, 0, sizeof buf);
-       strlcpy(buf, format, sizeof(buf));
-       
-       for (s = &buf[0]; s && (p = strchr(s,'%')); ) {
+        * copy in the terminating null of the inserted strings, but
+        * rather keep going until we reach the null of the format. */
+       total = strlcpy(buf, format, sizeof buf);
+       if (total > MAXPATHLEN) {
+               rprintf(FERROR, "log-format string is WAY too long!\n");
+               exit_cleanup(RERR_MESSAGEIO);
+       }
+       buf[total++] = '\n';
+       buf[total] = '\0';
+
+       for (p = buf; (p = strchr(p, '%')) != NULL; ) {
+               s = p++;
+               n = fmt + 1;
+               if (*p == '-')
+                       *n++ = *p++;
+               while (isdigit(*(uchar*)p) && n - fmt < (int)(sizeof fmt) - 8)
+                       *n++ = *p++;
+               if (!*p)
+                       break;
+               *n = '\0';
                n = NULL;
-               s = p + 1;
 
-               switch (p[1]) {
-               case 'h': if (am_daemon) n = client_name(0); break;
-               case 'a': if (am_daemon) n = client_addr(0); break;
+               switch (*p) {
+               case 'h':
+                       if (am_daemon)
+                               n = client_name(0);
+                       break;
+               case 'a':
+                       if (am_daemon)
+                               n = client_addr(0);
+                       break;
                case 'l':
-                       snprintf(buf2,sizeof(buf2),"%.0f",
+                       strlcat(fmt, ".0f", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt,
                                 (double)file->length);
                        n = buf2;
                        break;
+               case 'U':
+                       strlcat(fmt, "ld", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt,
+                                (long)file->uid);
+                       n = buf2;
+                       break;
+               case 'G':
+                       if (file->gid == GID_NONE)
+                               n = "DEFAULT";
+                       else {
+                               strlcat(fmt, "ld", sizeof fmt);
+                               snprintf(buf2, sizeof buf2, fmt,
+                                        (long)file->gid);
+                               n = buf2;
+                       }
+                       break;
                case 'p':
-                       snprintf(buf2,sizeof(buf2),"%d",
-                                (int)getpid());
+                       strlcat(fmt, "ld", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt,
+                                (long)getpid());
                        n = buf2;
                        break;
-               case 'o': n = op; break;
+               case 'M':
+                       n = timestring(file->modtime);
+                       {
+                               char *cp = n;
+                               while ((cp = strchr(cp, ' ')) != NULL)
+                                       *cp = '-';
+                       }
+                       break;
+               case 'B':
+                       n = buf2 + MAXPATHLEN - PERMSTRING_SIZE;
+                       permstring(n - 1, file->mode); /* skip the type char */
+                       break;
+               case 'o':
+                       n = op;
+                       break;
                case 'f':
-                       pathjoin(buf2, sizeof buf2,
-                                file->basedir ? file->basedir : "",
-                                f_name(file));
-                       clean_fname(buf2);
+                       n = f_name(file, NULL);
+                       if (am_sender && file->dir.root) {
+                               pathjoin(buf2, sizeof buf2,
+                                        file->dir.root, n);
+                               clean_fname(buf2, 0);
+                               if (fmt[1])
+                                       strlcpy(n, buf2, MAXPATHLEN);
+                               else
+                                       n = buf2;
+                       } else
+                               clean_fname(n, 0);
+                       if (*n == '/')
+                               n++;
+                       break;
+               case 'n':
+                       n = f_name(file, NULL);
+                       if (S_ISDIR(file->mode))
+                               strlcat(n, "/", MAXPATHLEN);
+                       break;
+               case 'L':
+                       if (hlink && *hlink) {
+                               n = hlink;
+                               strcpy(buf2, " => ");
+                       } else if (S_ISLNK(file->mode) && file->u.link) {
+                               n = file->u.link;
+                               strcpy(buf2, " -> ");
+                       } else {
+                               n = "";
+                               if (!fmt[1])
+                                       break;
+                               strcpy(buf2, "    ");
+                       }
+                       strlcat(fmt, "s", sizeof fmt);
+                       snprintf(buf2 + 4, sizeof buf2 - 4, fmt, n);
                        n = buf2;
-                       if (*n == '/') n++;
                        break;
-               case 'm': n = lp_name(module_id); break;
-               case 't': n = timestring(time(NULL)); break;
-               case 'P': n = lp_path(module_id); break;
-               case 'u': n = auth_user; break;
+               case 'm':
+                       n = lp_name(module_id);
+                       break;
+               case 't':
+                       n = timestring(time(NULL));
+                       break;
+               case 'P':
+                       n = lp_path(module_id);
+                       break;
+               case 'u':
+                       n = auth_user;
+                       break;
                case 'b':
                        if (am_sender) {
                                b = stats.total_written -
@@ -404,7 +566,8 @@ static void log_formatted(enum logcode code,
                                b = stats.total_read -
                                        initial_stats->total_read;
                        }
-                       snprintf(buf2,sizeof(buf2),"%.0f", (double)b);
+                       strlcat(fmt, ".0f", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt, (double)b);
                        n = buf2;
                        break;
                case 'c':
@@ -415,63 +578,169 @@ static void log_formatted(enum logcode code,
                                b = stats.total_read -
                                        initial_stats->total_read;
                        }
-                       snprintf(buf2,sizeof(buf2),"%.0f", (double)b);
+                       strlcat(fmt, ".0f", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt, (double)b);
                        n = buf2;
                        break;
+               case 'i':
+                       if (iflags & ITEM_DELETED) {
+                               n = "*deleting";
+                               break;
+                       }
+                       n = buf2 + MAXPATHLEN - 32;
+                       n[0] = iflags & ITEM_LOCAL_CHANGE
+                             ? iflags & ITEM_XNAME_FOLLOWS ? 'h' : 'c'
+                            : !(iflags & ITEM_TRANSFER) ? '.'
+                            : !local_server && *op == 's' ? '<' : '>';
+                       n[1] = S_ISDIR(file->mode) ? 'd'
+                            : IS_SPECIAL(file->mode) ? 'S'
+                            : IS_DEVICE(file->mode) ? 'D'
+                            : S_ISLNK(file->mode) ? 'L' : 'f';
+                       n[2] = !(iflags & ITEM_REPORT_CHECKSUM) ? '.' : 'c';
+                       n[3] = !(iflags & ITEM_REPORT_SIZE) ? '.' : 's';
+                       n[4] = !(iflags & ITEM_REPORT_TIME) ? '.'
+                            : !preserve_times || S_ISLNK(file->mode) ? 'T' : 't';
+                       n[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p';
+                       n[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o';
+                       n[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g';
+                       n[8] = '.';
+                       n[9] = '\0';
+
+                       if (iflags & (ITEM_IS_NEW|ITEM_MISSING_DATA)) {
+                               char ch = iflags & ITEM_IS_NEW ? '+' : '?';
+                               int i;
+                               for (i = 2; n[i]; i++)
+                                       n[i] = ch;
+                       } else if (n[0] == '.' || n[0] == 'h'
+                               || (n[0] == 'c' && n[1] == 'f')) {
+                               int i;
+                               for (i = 2; n[i]; i++) {
+                                       if (n[i] != '.')
+                                               break;
+                               }
+                               if (!n[i]) {
+                                       for (i = 2; n[i]; i++)
+                                               n[i] = ' ';
+                               }
+                       }
+                       break;
                }
 
-               /* n is the string to be inserted in place of this %
-                * code; l is its length not including the trailing
-                * NUL */
+               /* "n" is the string to be inserted in place of this % code. */
                if (!n)
                        continue;
+               if (n != buf2 && fmt[1]) {
+                       strlcat(fmt, "s", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt, n);
+                       n = buf2;
+               }
+               len = strlen(n);
 
-               l = strlen(n);
+               /* Subtract the length of the escape from the string's size. */
+               total -= p - s + 1;
 
-               if (l + ((int)(s - &buf[0])) >= sizeof(buf)) {
-                       rprintf(FERROR,"buffer overflow expanding %%%c - exiting\n",
+               if (len + total >= (size_t)sizeof buf) {
+                       rprintf(FERROR,
+                               "buffer overflow expanding %%%c -- exiting\n",
                                p[0]);
                        exit_cleanup(RERR_MESSAGEIO);
                }
 
                /* Shuffle the rest of the string along to make space for n */
-               if (l != 2) {
-                       memmove(s+(l-1), s+1, strlen(s+1)+1);
-               }
+               if (len != (size_t)(p - s + 1))
+                       memmove(s + len, p + 1, total - (s - buf) + 1);
+               total += len;
 
-               /* Copy in n but NOT its nul, because the format sting
-                * probably continues after this. */
-               memcpy(p, n, l);
+               /* Insert the contents of string "n", but NOT its null. */
+               if (len)
+                       memcpy(s, n, len);
 
                /* Skip over inserted string; continue looking */
-               s = p+l;
+               p = s + len;
        }
 
-       rprintf(code,"%s\n", buf);
+       rwrite(code, buf, total);
 }
 
-/* log the outgoing transfer of a file */
-void log_send(struct file_struct *file, struct stats *initial_stats)
+/* Return 1 if the format escape is in the log-format string (e.g. look for
+ * the 'b' in the "%9b" format escape). */
+int log_format_has(const char *format, char esc)
 {
-       if (lp_transfer_logging(module_id)) {
-               log_formatted(FLOG, lp_log_format(module_id), "send", file, initial_stats);
-       } else if (log_format && !am_server) {
-               log_formatted(FINFO, log_format, "send", file, initial_stats);
+       const char *p;
+
+       if (!format)
+               return 0;
+
+       for (p = format; (p = strchr(p, '%')) != NULL; ) {
+               if (*++p == '-')
+                       p++;
+               while (isdigit(*(uchar*)p))
+                       p++;
+               if (!*p)
+                       break;
+               if (*p == esc)
+                       return 1;
        }
+       return 0;
 }
 
-/* log the incoming transfer of a file */
-void log_recv(struct file_struct *file, struct stats *initial_stats)
+/* log the transfer of a file */
+void log_item(struct file_struct *file, struct stats *initial_stats,
+             int iflags, char *hlink)
 {
+       char *s_or_r = am_sender ? "send" : "recv";
+
        if (lp_transfer_logging(module_id)) {
-               log_formatted(FLOG, lp_log_format(module_id), "recv", file, initial_stats);
+               log_formatted(FLOG, lp_log_format(module_id), s_or_r,
+                             file, initial_stats, iflags, hlink);
        } else if (log_format && !am_server) {
-               log_formatted(FINFO, log_format, "recv", file, initial_stats);
+               log_formatted(FNAME, log_format, s_or_r,
+                             file, initial_stats, iflags, hlink);
        }
 }
 
+void maybe_log_item(struct file_struct *file, int iflags, int itemizing,
+                   char *buf)
+{
+       int significant_flags = iflags & SIGNIFICANT_ITEM_FLAGS;
+       int see_item = itemizing && (significant_flags || *buf
+               || log_format_has_i > 1 || (verbose > 1 && log_format_has_i));
+       int local_change = iflags & ITEM_LOCAL_CHANGE && significant_flags;
+       if (am_server) {
+               if (am_daemon && !dry_run && see_item)
+                       log_item(file, &stats, iflags, buf);
+       } else if (see_item || local_change || *buf
+           || (S_ISDIR(file->mode) && significant_flags))
+               log_item(file, &stats, iflags, buf);
+}
 
+void log_delete(char *fname, int mode)
+{
+       static struct file_struct file;
+       int len = strlen(fname);
+       char *fmt;
+
+       file.mode = mode;
+       file.basename = fname;
+
+       if (!verbose && !log_format)
+               ;
+       else if (am_server && protocol_version >= 29 && len < MAXPATHLEN) {
+               if (S_ISDIR(mode))
+                       len++; /* directories include trailing null */
+               send_msg(MSG_DELETED, fname, len);
+       } else {
+               fmt = log_format_has_o_or_i ? log_format : "deleting %n";
+               log_formatted(FCLIENT, fmt, "del.", &file, &stats,
+                             ITEM_DELETED, NULL);
+       }
+
+       if (!am_daemon || dry_run || !lp_transfer_logging(module_id))
+               return;
 
+       fmt = daemon_log_format_has_o_or_i ? lp_log_format(module_id) : "deleting %n";
+       log_formatted(FLOG, fmt, "del.", &file, &stats, ITEM_DELETED, NULL);
+}
 
 /*
  * Called when the transfer is interrupted for some reason.
@@ -482,7 +751,7 @@ void log_recv(struct file_struct *file, struct stats *initial_stats)
 void log_exit(int code, const char *file, int line)
 {
        if (code == 0) {
-               rprintf(FLOG,"wrote %.0f bytes  read %.0f bytes  total size %.0f\n",
+               rprintf(FLOG,"sent %.0f bytes  received %.0f bytes  total size %.0f\n",
                        (double)stats.total_written,
                        (double)stats.total_read,
                        (double)stats.total_size);
@@ -495,11 +764,11 @@ void log_exit(int code, const char *file, int line)
 
                /* VANISHED is not an error, only a warning */
                if (code == RERR_VANISHED) {
-                       rprintf(FINFO, "rsync warning: %s (code %d) at %s(%d)\n", 
-                               name, code, file, line);
+                       rprintf(FINFO, "rsync warning: %s (code %d) at %s(%d) [%s=%s]\n",
+                               name, code, file, line, who_am_i(), RSYNC_VERSION);
                } else {
-                       rprintf(FERROR, "rsync error: %s (code %d) at %s(%d)\n",
-                               name, code, file, line);
+                       rprintf(FERROR, "rsync error: %s (code %d) at %s(%d) [%s=%s]\n",
+                               name, code, file, line, who_am_i(), RSYNC_VERSION);
                }
        }
 }