Some improvements to the file-name cleaning code:
[rsync/rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index 58ef0c5..dce55c7 100644 (file)
--- a/flist.c
+++ b/flist.c
@@ -4,7 +4,7 @@
  * Copyright (C) 1996 Andrew Tridgell
  * Copyright (C) 1996 Paul Mackerras
  * Copyright (C) 2001, 2002 Martin Pool <mbp@samba.org>
- * Copyright (C) 2002-2007 Wayne Davison
+ * Copyright (C) 2002-2008 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -44,6 +44,8 @@ extern int filesfrom_fd;
 extern int one_file_system;
 extern int copy_dirlinks;
 extern int keep_dirlinks;
+extern int preserve_uid;
+extern int preserve_gid;
 extern int preserve_acls;
 extern int preserve_xattrs;
 extern int preserve_links;
@@ -63,6 +65,7 @@ extern int copy_links;
 extern int copy_unsafe_links;
 extern int protocol_version;
 extern int sanitize_paths;
+extern int munge_symlinks;
 extern int need_unsorted_flist;
 extern int unsort_ndx;
 extern struct stats stats;
@@ -73,7 +76,7 @@ extern char curr_dir[MAXPATHLEN];
 extern struct chmod_mode_struct *chmod_modes;
 
 extern struct filter_list_struct filter_list;
-extern struct filter_list_struct server_filter_list;
+extern struct filter_list_struct daemon_filter_list;
 
 #ifdef ICONV_OPTION
 extern int filesfrom_convert;
@@ -120,9 +123,8 @@ static char tmp_sum[MAX_DIGEST_LEN];
 static char empty_sum[MAX_DIGEST_LEN];
 static int flist_count_offset; /* for --delete --progress */
 static int dir_count = 0;
-static int high_hlink_ndx;
 
-static void clean_flist(struct file_list *flist, int strip_root);
+static void flist_sort_and_clean(struct file_list *flist, int strip_root);
 static void output_flist(struct file_list *flist);
 
 void init_flist(void)
@@ -200,6 +202,11 @@ static int readlink_stat(const char *path, STRUCT_STAT *stp, char *linkbuf)
                        }
                        return x_stat(path, stp, NULL);
                }
+               if (munge_symlinks && am_sender && llen > SYMLINK_PREFIX_LEN
+                && strncmp(linkbuf, SYMLINK_PREFIX, SYMLINK_PREFIX_LEN) == 0) {
+                       memmove(linkbuf, linkbuf + SYMLINK_PREFIX_LEN,
+                               llen - SYMLINK_PREFIX_LEN + 1);
+               }
        }
        return 0;
 #else
@@ -225,10 +232,20 @@ int link_stat(const char *path, STRUCT_STAT *stp, int follow_dirlinks)
 #endif
 }
 
+static inline int is_daemon_excluded(const char *fname, int is_dir)
+{
+       if (daemon_filter_list.head
+        && check_filter(&daemon_filter_list, fname, is_dir) < 0) {
+               errno = ENOENT;
+               return 1;
+       }
+       return 0;
+}
+
 /* This function is used to check if a file should be included/excluded
  * from the list of files based on its name and type etc.  The value of
  * filter_level is set to either SERVER_FILTERS or ALL_FILTERS. */
-static int is_excluded(char *fname, int is_dir, int filter_level)
+static int is_excluded(const char *fname, int is_dir, int filter_level)
 {
 #if 0 /* This currently never happens, so avoid a useless compare. */
        if (filter_level == NO_FILTERS)
@@ -245,8 +262,7 @@ static int is_excluded(char *fname, int is_dir, int filter_level)
                                return 0;
                }
        }
-       if (server_filter_list.head
-           && check_filter(&server_filter_list, fname, is_dir) < 0)
+       if (is_daemon_excluded(fname, is_dir))
                return 1;
        if (filter_level != ALL_FILTERS)
                return 0;
@@ -346,7 +362,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
        static uint32 rdev_major;
        static uid_t uid;
        static gid_t gid;
-       static char *user_name, *group_name;
+       static const char *user_name, *group_name;
        static char lastname[MAXPATHLEN];
        char fname[MAXPATHLEN];
        int first_hlink_ndx = -1;
@@ -384,6 +400,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
 
        /* Initialize starting value of xflags. */
        if (protocol_version >= 30 && S_ISDIR(file->mode)) {
+               dir_count++;
                if (file->flags & FLAG_CONTENT_DIR)
                        xflags = file->flags & FLAG_TOP_DIR;
                else if (file->flags & FLAG_IMPLIED_DIR)
@@ -416,24 +433,24 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
                }
        } else if (protocol_version < 28)
                rdev = MAKEDEV(0, 0);
-       if (uid_ndx) {
+       if (preserve_uid) {
                if ((uid_t)F_OWNER(file) == uid && *lastname)
                        xflags |= XMIT_SAME_UID;
                else {
                        uid = F_OWNER(file);
-                       if (uid_ndx && !numeric_ids) {
+                       if (!numeric_ids) {
                                user_name = add_uid(uid);
                                if (inc_recurse && user_name)
                                        xflags |= XMIT_USER_NAME_FOLLOWS;
                        }
                }
        }
-       if (gid_ndx) {
+       if (preserve_gid) {
                if ((gid_t)F_GROUP(file) == gid && *lastname)
                        xflags |= XMIT_SAME_GID;
                else {
                        gid = F_GROUP(file);
-                       if (gid_ndx && !numeric_ids) {
+                       if (!numeric_ids) {
                                group_name = add_gid(gid);
                                if (inc_recurse && group_name)
                                        xflags |= XMIT_GROUP_NAME_FOLLOWS;
@@ -451,8 +468,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
                        struct ht_int64_node *np = idev_find(tmp_dev, tmp_ino);
                        first_hlink_ndx = (int32)(long)np->data - 1;
                        if (first_hlink_ndx < 0) {
-                               high_hlink_ndx = ndx + first_ndx;
-                               np->data = (void*)(long)(high_hlink_ndx + 1);
+                               np->data = (void*)(long)(first_ndx + ndx + 1);
                                xflags |= XMIT_HLINK_FIRST;
                        }
                        xflags |= XMIT_HLINKED;
@@ -517,7 +533,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
        }
        if (!(xflags & XMIT_SAME_MODE))
                write_int(f, to_wire_mode(mode));
-       if (uid_ndx && !(xflags & XMIT_SAME_UID)) {
+       if (preserve_uid && !(xflags & XMIT_SAME_UID)) {
                if (protocol_version < 30)
                        write_int(f, uid);
                else {
@@ -529,7 +545,7 @@ static void send_file_entry(int f, struct file_struct *file, int ndx, int first_
                        }
                }
        }
-       if (gid_ndx && !(xflags & XMIT_SAME_GID)) {
+       if (preserve_gid && !(xflags & XMIT_SAME_GID)) {
                if (protocol_version < 30)
                        write_int(f, gid);
                else {
@@ -671,7 +687,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        clean_fname(thisname, 0);
 
        if (sanitize_paths)
-               sanitize_path(thisname, thisname, "", 0);
+               sanitize_path(thisname, thisname, "", 0, SP_DEFAULT);
 
        if ((basename = strrchr(thisname, '/')) != NULL) {
                int len = basename++ - thisname;
@@ -701,9 +717,9 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                        file_length = F_LENGTH(first);
                        modtime = first->modtime;
                        mode = first->mode;
-                       if (uid_ndx)
+                       if (preserve_uid)
                                uid = F_OWNER(first);
-                       if (gid_ndx)
+                       if (preserve_gid)
                                gid = F_GROUP(first);
                        if ((preserve_devices && IS_DEVICE(mode))
                         || (preserve_specials && IS_SPECIAL(mode))) {
@@ -725,8 +741,8 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                if (protocol_version >= 30) {
                        modtime = read_varlong(f, 4);
 #if SIZEOF_TIME_T < SIZEOF_INT64
-                       if ((modtime > INT_MAX || modtime < INT_MIN) && !am_generator) {
-                               rprintf(FERROR,
+                       if (!am_generator && (int64)(time_t)modtime != modtime) {
+                               rprintf(FERROR_XFER,
                                    "Time value of %s truncated on receiver.\n",
                                    lastname);
                        }
@@ -740,7 +756,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (chmod_modes && !S_ISLNK(mode))
                mode = tweak_mode(mode, chmod_modes);
 
-       if (uid_ndx && !(xflags & XMIT_SAME_UID)) {
+       if (preserve_uid && !(xflags & XMIT_SAME_UID)) {
                if (protocol_version < 30)
                        uid = (uid_t)read_int(f);
                else {
@@ -751,7 +767,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                                uid = match_uid(uid);
                }
        }
-       if (gid_ndx && !(xflags & XMIT_SAME_GID)) {
+       if (preserve_gid && !(xflags & XMIT_SAME_GID)) {
                if (protocol_version < 30)
                        gid = (gid_t)read_int(f);
                else {
@@ -794,6 +810,8 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                                linkname_len - 1);
                        overflow_exit("recv_file_entry");
                }
+               if (munge_symlinks)
+                       linkname_len += SYMLINK_PREFIX_LEN;
        }
        else
 #endif
@@ -810,9 +828,9 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 #endif
 
 #ifdef SUPPORT_ACLS
-       /* We need one or two index int32s when we're preserving ACLs. */
-       if (preserve_acls)
-               extra_len += (S_ISDIR(mode) ? 2 : 1) * EXTRA_LEN;
+       /* Directories need an extra int32 for the default ACL. */
+       if (preserve_acls && S_ISDIR(mode))
+               extra_len += EXTRA_LEN;
 #endif
 
        if (always_checksum && S_ISREG(mode))
@@ -821,11 +839,6 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (file_length > 0xFFFFFFFFu && S_ISREG(mode))
                extra_len += EXTRA_LEN;
 
-#if EXTRA_ROUNDING > 0
-       if (extra_len & (EXTRA_ROUNDING * EXTRA_LEN))
-               extra_len = (extra_len | (EXTRA_ROUNDING * EXTRA_LEN)) + EXTRA_LEN;
-#endif
-
        if (inc_recurse && S_ISDIR(mode)) {
                if (one_file_system) {
                        /* Room to save the dir's device for -x */
@@ -835,6 +848,11 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        } else
                pool = flist->file_pool;
 
+#if EXTRA_ROUNDING > 0
+       if (extra_len & (EXTRA_ROUNDING * EXTRA_LEN))
+               extra_len = (extra_len | (EXTRA_ROUNDING * EXTRA_LEN)) + EXTRA_LEN;
+#endif
+
        alloc_len = FILE_STRUCT_LEN + extra_len + basename_len
                  + linkname_len;
        bp = pool_alloc(pool, alloc_len, "recv_file_entry");
@@ -845,7 +863,6 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        bp += FILE_STRUCT_LEN;
 
        memcpy(bp, basename, basename_len);
-       bp += basename_len + linkname_len; /* skip space for symlink too */
 
 #ifdef SUPPORT_HARD_LINKS
        if (xflags & XMIT_HLINKED)
@@ -858,9 +875,9 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                OPT_EXTRA(file, 0)->unum = (uint32)(file_length >> 32);
        }
        file->mode = mode;
-       if (uid_ndx)
+       if (preserve_uid)
                F_OWNER(file) = uid;
-       if (gid_ndx) {
+       if (preserve_gid) {
                F_GROUP(file) = gid;
                file->flags |= gid_flags;
        }
@@ -910,14 +927,20 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 
 #ifdef SUPPORT_LINKS
        if (linkname_len) {
-               bp = (char*)file->basename + basename_len;
+               bp += basename_len;
                if (first_hlink_ndx >= flist->ndx_start) {
                        struct file_struct *first = flist->files[first_hlink_ndx - flist->ndx_start];
                        memcpy(bp, F_SYMLINK(first), linkname_len);
-               } else
+               } else if (munge_symlinks) {
+                       strlcpy(bp, SYMLINK_PREFIX, linkname_len);
+                       bp += SYMLINK_PREFIX_LEN;
+                       linkname_len -= SYMLINK_PREFIX_LEN;
+                       read_sbuf(f, bp, linkname_len - 1);
+               } else {
                        read_sbuf(f, bp, linkname_len - 1);
-               if (sanitize_paths)
-                       sanitize_path(bp, bp, "", lastdir_depth);
+                       if (sanitize_paths)
+                               sanitize_path(bp, bp, "", lastdir_depth, SP_DEFAULT);
+               }
        }
 #endif
 
@@ -925,8 +948,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (preserve_hard_links && xflags & XMIT_HLINKED) {
                if (protocol_version >= 30) {
                        if (xflags & XMIT_HLINK_FIRST) {
-                               high_hlink_ndx = flist->ndx_start + flist->used;
-                               F_HL_GNUM(file) = high_hlink_ndx;
+                               F_HL_GNUM(file) = flist->ndx_start + flist->used;
                        } else
                                F_HL_GNUM(file) = first_hlink_ndx;
                } else {
@@ -1008,7 +1030,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        }
        clean_fname(thisname, 0);
        if (sanitize_paths)
-               sanitize_path(thisname, thisname, "", 0);
+               sanitize_path(thisname, thisname, "", 0, SP_DEFAULT);
 
        if (stp && S_ISDIR(stp->st_mode)) {
                st = *stp; /* Needed for "symlink/." with --relative. */
@@ -1025,24 +1047,30 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                }
                if (save_errno == ENOENT) {
 #ifdef SUPPORT_LINKS
-                       /* Avoid "vanished" error if symlink points nowhere. */
-                       if (copy_links && x_lstat(thisname, &st, NULL) == 0
-                           && S_ISLNK(st.st_mode)) {
+                       /* When our options tell us to follow a symlink that
+                        * points nowhere, tell the user about the symlink
+                        * instead of giving a "vanished" message.  We only
+                        * dereference a symlink if one of the --copy*links
+                        * options was specified, so there's no need for the
+                        * extra lstat() if one of these options isn't on. */
+                       if ((copy_links || copy_unsafe_links || copy_dirlinks)
+                        && x_lstat(thisname, &st, NULL) == 0
+                        && S_ISLNK(st.st_mode)) {
                                io_error |= IOERR_GENERAL;
-                               rprintf(FERROR, "symlink has no referent: %s\n",
+                               rprintf(FERROR_XFER, "symlink has no referent: %s\n",
                                        full_fname(thisname));
                        } else
 #endif
                        {
                                enum logcode c = am_daemon && protocol_version < 28
-                                   ? FERROR : FINFO;
+                                              ? FERROR : FWARNING;
                                io_error |= IOERR_VANISHED;
                                rprintf(c, "file has vanished: %s\n",
                                        full_fname(thisname));
                        }
                } else {
                        io_error |= IOERR_GENERAL;
-                       rsyserr(FERROR, save_errno, "readlink %s failed",
+                       rsyserr(FERROR_XFER, save_errno, "readlink %s failed",
                                full_fname(thisname));
                }
                return NULL;
@@ -1100,12 +1128,17 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                        extra_len += DIRNODE_EXTRA_CNT * EXTRA_LEN;
                        if (relative_paths)
                                extra_len += PTR_EXTRA_CNT * EXTRA_LEN;
-                       dir_count++;
                        pool = dir_flist->file_pool;
                } else
                        pool = flist->file_pool;
-       } else
+       } else {
+#ifdef SUPPORT_ACLS
+               /* Directories need an extra int32 for the default ACL. */
+               if (preserve_acls && S_ISDIR(st.st_mode))
+                       extra_len += EXTRA_LEN;
+#endif
                pool = NULL;
+       }
 
        if (verbose > 2) {
                rprintf(FINFO, "[%s] make_file(%s,*,%d)\n",
@@ -1153,7 +1186,6 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        bp += FILE_STRUCT_LEN;
 
        memcpy(bp, basename, basename_len);
-       bp += basename_len + linkname_len; /* skip space for symlink too */
 
 #ifdef SUPPORT_HARD_LINKS
        if (preserve_hard_links && flist && flist->prev) {
@@ -1182,25 +1214,26 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                OPT_EXTRA(file, 0)->unum = (uint32)(st.st_size >> 32);
        }
        file->mode = st.st_mode;
-       if (uid_ndx)
+       if (uid_ndx) /* Check uid_ndx instead of preserve_uid for del support */
                F_OWNER(file) = st.st_uid;
-       if (gid_ndx)
+       if (gid_ndx) /* Check gid_ndx instead of preserve_gid for del support */
                F_GROUP(file) = st.st_gid;
 
        if (basename != thisname)
                file->dirname = lastdir;
 
 #ifdef SUPPORT_LINKS
-       if (linkname_len) {
-               bp = (char*)file->basename + basename_len;
-               memcpy(bp, linkname, linkname_len);
-       }
+       if (linkname_len)
+               memcpy(bp + basename_len, linkname, linkname_len);
 #endif
 
        if (always_checksum && am_sender && S_ISREG(st.st_mode))
                file_checksum(thisname, tmp_sum, st.st_size);
 
-       F_PATHNAME(file) = pathname;
+       if (am_sender)
+               F_PATHNAME(file) = pathname;
+       else if (!pool)
+               F_DEPTH(file) = extra_len / EXTRA_LEN;
 
        /* This code is only used by the receiver when it is building
         * a list of files for a delete pass. */
@@ -1221,11 +1254,14 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                        file->mode = save_mode;
        }
 
-       if (basename_len == 0+1)
+       if (basename_len == 0+1) {
+               if (!pool)
+                       unmake_file(file);
                return NULL;
+       }
 
        if (unsort_ndx)
-               F_NDX(file) = dir_count - 1;
+               F_NDX(file) = dir_count;
 
        return file;
 }
@@ -1233,12 +1269,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
 /* Only called for temporary file_struct entries created by make_file(). */
 void unmake_file(struct file_struct *file)
 {
-       int extra_cnt = file_extra_cnt + LEN64_BUMP(file);
-#if EXTRA_ROUNDING > 0
-       if (extra_cnt & EXTRA_ROUNDING)
-               extra_cnt = (extra_cnt | EXTRA_ROUNDING) + 1;
-#endif
-       free(REQ_EXTRA(file, extra_cnt));
+       free(REQ_EXTRA(file, F_DEPTH(file)));
 }
 
 static struct file_struct *send_file_name(int f, struct file_list *flist,
@@ -1310,7 +1341,7 @@ static void send_if_directory(int f, struct file_list *flist,
                        fbuf[--len] = '\0';
                if (len >= MAXPATHLEN - 1) {
                        io_error |= IOERR_GENERAL;
-                       rprintf(FERROR, "skipping long-named directory: %s\n",
+                       rprintf(FERROR_XFER, "skipping long-named directory: %s\n",
                                full_fname(fbuf));
                        return;
                }
@@ -1449,7 +1480,7 @@ static void send_directory(int f, struct file_list *flist, char *fbuf, int len,
 
        if (!(d = opendir(fbuf))) {
                io_error |= IOERR_GENERAL;
-               rsyserr(FERROR, errno, "opendir %s failed", full_fname(fbuf));
+               rsyserr(FERROR_XFER, errno, "opendir %s failed", full_fname(fbuf));
                return;
        }
 
@@ -1486,7 +1517,7 @@ static void send_directory(int f, struct file_list *flist, char *fbuf, int len,
 
        if (errno) {
                io_error |= IOERR_GENERAL;
-               rsyserr(FERROR, errno, "readdir(%s)", full_fname(fbuf));
+               rsyserr(FERROR_XFER, errno, "readdir(%s)", full_fname(fbuf));
        }
 
        closedir(d);
@@ -1511,8 +1542,10 @@ static void send_implied_dirs(int f, struct file_list *flist, char *fname,
        relnamecache **rnpp;
        char *slash;
        int len, need_new_dir;
+       struct filter_list_struct save_filter_list = filter_list;
 
        flags = (flags | FLAG_IMPLIED_DIR) & ~(FLAG_TOP_DIR | FLAG_CONTENT_DIR);
+       filter_list.head = filter_list.tail = NULL; /* Don't filter implied dirs. */
 
        if (inc_recurse) {
                if (lastpath_struct && F_PATHNAME(lastpath_struct) == pathname
@@ -1554,11 +1587,11 @@ static void send_implied_dirs(int f, struct file_list *flist, char *fname,
                xfer_dirs = save_xfer_dirs;
 
                if (!inc_recurse)
-                       return;
+                       goto done;
        }
 
        if (!lastpath_struct)
-               return; /* dir must have vanished */
+               goto done; /* dir must have vanished */
 
        len = strlen(limit+1);
        memcpy(&relname_list, F_DIR_RELNAMES_P(lastpath_struct), sizeof relname_list);
@@ -1572,6 +1605,9 @@ static void send_implied_dirs(int f, struct file_list *flist, char *fname,
                out_of_memory("send_implied_dirs");
        (*rnpp)->name_type = name_type;
        strlcpy((*rnpp)->fname, limit+1, len + 1);
+
+done:
+       filter_list = save_filter_list;
 }
 
 static void send1extra(int f, struct file_struct *file, struct file_list *flist)
@@ -1596,7 +1632,7 @@ static void send1extra(int f, struct file_struct *file, struct file_list *flist)
                        STRUCT_STAT st;
                        if (link_stat(fbuf, &st, copy_dirlinks) != 0) {
                                io_error |= IOERR_GENERAL;
-                               rsyserr(FERROR, errno, "link_stat %s failed",
+                               rsyserr(FERROR_XFER, errno, "link_stat %s failed",
                                        full_fname(fbuf));
                                return;
                        }
@@ -1633,7 +1669,7 @@ static void send1extra(int f, struct file_struct *file, struct file_list *flist)
                        STRUCT_STAT st;
                        if (link_stat(fbuf, &st, 1) != 0) {
                                io_error |= IOERR_GENERAL;
-                               rsyserr(FERROR, errno, "link_stat %s failed",
+                               rsyserr(FERROR_XFER, errno, "link_stat %s failed",
                                        full_fname(fbuf));
                                continue;
                        }
@@ -1705,11 +1741,7 @@ void send_extra_file_list(int f, int at_least)
                } else
                        flist->sorted = flist->files;
 
-               clean_flist(flist, 0);
-
-               flist->ndx_end = flist->ndx_start + flist->used - 1;
-               if (!need_unsorted_flist)
-                       flist->ndx_end -= (dir_count - dstart);
+               flist_sort_and_clean(flist, 0);
 
                add_dirs_to_tree(send_dir_ndx, flist, dir_count - dstart);
                flist_done_allocating(flist);
@@ -1763,6 +1795,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                     | (filesfrom_convert ? RL_CONVERT : 0)
 #endif
                     | (eol_nulls || reading_remotely ? RL_EOL_NULLS : 0);
+       int implied_dot_dir = 0;
 
        rprintf(FLOG, "building file list\n");
        if (show_filelist_p())
@@ -1791,7 +1824,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
        disable_buffering = io_start_buffering_out(f);
        if (filesfrom_fd >= 0) {
                if (argv[0] && !push_dir(argv[0], 0)) {
-                       rsyserr(FERROR, errno, "push_dir %s failed in %s",
+                       rsyserr(FERROR_XFER, errno, "push_dir %s failed in %s",
                                full_fname(argv[0]), curr_dir);
                        exit_cleanup(RERR_FILESELECT);
                }
@@ -1804,13 +1837,13 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                if (use_ff_fd) {
                        if (read_line(filesfrom_fd, fbuf, sizeof fbuf, rl_flags) == 0)
                                break;
-                       sanitize_path(fbuf, fbuf, "", 0);
+                       sanitize_path(fbuf, fbuf, "", 0, SP_KEEP_DOT_DIRS);
                } else {
                        if (argc-- == 0)
                                break;
                        strlcpy(fbuf, *argv++, MAXPATHLEN);
                        if (sanitize_paths)
-                               sanitize_path(fbuf, fbuf, "", 0);
+                               sanitize_path(fbuf, fbuf, "", 0, SP_KEEP_DOT_DIRS);
                }
 
                len = strlen(fbuf);
@@ -1820,7 +1853,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                } else if (!len || fbuf[len - 1] == '/') {
                        if (len == 2 && fbuf[0] == '.') {
                                /* Turn "./" into just "." rather than "./." */
-                               fbuf[1] = '\0';
+                               fbuf[--len] = '\0';
                        } else {
                                if (len + 1 >= MAXPATHLEN)
                                        overflow_exit("send_file_list");
@@ -1860,8 +1893,10 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                                *p = '\0';
                                if (p == fbuf)
                                        dir = "/";
-                               else
+                               else {
                                        dir = fbuf;
+                                       clean_fname(dir, 0);
+                               }
                                fn = p + 3;
                                while (*fn == '/')
                                        fn++;
@@ -1869,8 +1904,15 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                                        *--fn = '\0'; /* ensure room for '.' */
                        } else
                                fn = fbuf;
-                       len = clean_fname(fn, CFN_KEEP_LEADING_DOT_DIR
-                                           | CFN_KEEP_TRAILING_SLASH
+                       /* A leading ./ can be used in relative mode to affect
+                        * the dest dir without its name being in the path. */
+                       if (*fn == '.' && fn[1] == '/' && !implied_dot_dir) {
+                               send_file_name(f, flist, ".", NULL,
+                                   (flags | FLAG_IMPLIED_DIR) & ~FLAG_CONTENT_DIR,
+                                   ALL_FILTERS);
+                               implied_dot_dir = 1;
+                       }
+                       len = clean_fname(fn, CFN_KEEP_TRAILING_SLASH
                                            | CFN_DROP_TRAILING_DOT_DIR);
                        if (len == 1) {
                                if (fn[0] == '/') {
@@ -1916,9 +1958,10 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                if (fn != fbuf)
                        memmove(fbuf, fn, len + 1);
 
-               if (link_stat(fbuf, &st, copy_dirlinks || name_type != NORMAL_NAME) != 0) {
+               if (link_stat(fbuf, &st, copy_dirlinks || name_type != NORMAL_NAME) != 0
+                || is_daemon_excluded(fbuf, S_ISDIR(st.st_mode) != 0)) {
                        io_error |= IOERR_GENERAL;
-                       rsyserr(FERROR, errno, "link_stat %s failed",
+                       rsyserr(FERROR_XFER, errno, "link_stat %s failed",
                                full_fname(fbuf));
                        continue;
                }
@@ -1963,6 +2006,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                        int top_flags = FLAG_TOP_DIR | FLAG_CONTENT_DIR | flags;
                        file = send_file_name(f, flist, fbuf, &st,
                                              top_flags, ALL_FILTERS);
+                       if (!file)
+                               continue;
                        if (inc_recurse) {
                                if (name_type == DOT_NAME) {
                                        if (send_dir_depth < 0) {
@@ -1971,7 +2016,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                                        }
                                        send_directory(f, flist, fbuf, len, flags);
                                }
-                       } else if (file)
+                       } else
                                send_if_directory(f, flist, file, fbuf, len, flags);
                } else
                        send_file_name(f, flist, fbuf, &st, flags, ALL_FILTERS);
@@ -2007,28 +2052,16 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
         * recursion mode, the sender marks duplicate dirs so that it can
         * send them together in a single file-list. */
        if (need_unsorted_flist) {
-               if (inc_recurse) {
-                       if (!(flist->sorted = new_array(struct file_struct *, flist->used)))
-                               out_of_memory("send_file_list");
-                       memcpy(flist->sorted, flist->files,
-                              flist->used * sizeof (struct file_struct*));
-                       clean_flist(flist, 0);
-               } else {
-                       flist->sorted = flist->files;
-                       flist->low = 0;
-                       flist->high = flist->used - 1;
-               }
-       } else {
+               if (!(flist->sorted = new_array(struct file_struct *, flist->used)))
+                       out_of_memory("send_file_list");
+               memcpy(flist->sorted, flist->files,
+                      flist->used * sizeof (struct file_struct*));
+       } else
                flist->sorted = flist->files;
-               clean_flist(flist, 0);
-       }
+       flist_sort_and_clean(flist, 0);
        file_total += flist->used;
 
-       /* We don't subtract dir_count for the first send since we
-        * might have one or more dot dirs which need to get sent. */
-       flist->ndx_end = flist->ndx_start + flist->used - 1;
-
-       if (!numeric_ids && !inc_recurse)
+       if (numeric_ids <= 0 && !inc_recurse)
                send_id_list(f);
 
        /* send the io_error flag */
@@ -2126,10 +2159,6 @@ struct file_list *recv_file_list(int f)
        }
        file_total += flist->used;
 
-       flist->ndx_end = flist->ndx_start + flist->used - 1;
-       if (inc_recurse && !need_unsorted_flist && flist->ndx_start > 1)
-               flist->ndx_end -= dir_flist->used - dstart;
-
        if (verbose > 2)
                rprintf(FINFO, "received %d names\n", flist->used);
 
@@ -2147,9 +2176,13 @@ struct file_list *recv_file_list(int f)
                memcpy(flist->sorted, flist->files,
                       flist->used * sizeof (struct file_struct*));
                if (inc_recurse && dir_flist->used > dstart) {
-                       dir_flist->sorted = realloc_array(dir_flist->sorted,
-                                               struct file_struct *,
-                                               dir_flist->used);
+                       static int dir_flist_malloced = 0;
+                       if (dir_flist_malloced < dir_flist->malloced) {
+                               dir_flist->sorted = realloc_array(dir_flist->sorted,
+                                                       struct file_struct *,
+                                                       dir_flist->malloced);
+                               dir_flist_malloced = dir_flist->malloced;
+                       }
                        memcpy(dir_flist->sorted + dstart, dir_flist->files + dstart,
                               (dir_flist->used - dstart) * sizeof (struct file_struct*));
                        fsort(dir_flist->sorted + dstart, dir_flist->used - dstart);
@@ -2167,7 +2200,7 @@ struct file_list *recv_file_list(int f)
        else if (f >= 0)
                recv_id_list(f, flist);
 
-       clean_flist(flist, relative_paths);
+       flist_sort_and_clean(flist, relative_paths);
 
        if (protocol_version < 30) {
                /* Recv the io_error flag */
@@ -2307,18 +2340,19 @@ struct file_list *flist_new(int flags, char *msg)
                        if (!flist->file_pool)
                                out_of_memory(msg);
 
-                       flist->ndx_start = inc_recurse ? 1 : 0;
+                       flist->ndx_start = flist->flist_num = inc_recurse ? 1 : 0;
 
                        first_flist = cur_flist = flist->prev = flist;
                } else {
+                       struct file_list *prev = first_flist->prev;
+
                        flist->file_pool = first_flist->file_pool;
 
-                       flist->ndx_start = first_flist->prev->ndx_end + 2;
-                       if (flist->ndx_start <= high_hlink_ndx)
-                               flist->ndx_start = high_hlink_ndx + 1;
+                       flist->ndx_start = prev->ndx_start + prev->used + 1;
+                       flist->flist_num = prev->flist_num + 1;
 
-                       flist->prev = first_flist->prev;
-                       flist->prev->next = first_flist->prev = flist;
+                       flist->prev = prev;
+                       prev->next = first_flist->prev = flist;
                }
                flist->pool_boundary = pool_boundary(flist->file_pool, 0);
                flist_cnt++;
@@ -2364,7 +2398,7 @@ void flist_free(struct file_list *flist)
 
 /* This routine ensures we don't have any duplicate names in our file list.
  * duplicate names can cause corruption because of the pipelining. */
-static void clean_flist(struct file_list *flist, int strip_root)
+static void flist_sort_and_clean(struct file_list *flist, int strip_root)
 {
        char fbuf[MAXPATHLEN];
        int i, prev_i;
@@ -2544,8 +2578,8 @@ static void output_flist(struct file_list *flist)
        const char *who = who_am_i();
        int i;
 
-       rprintf(FINFO, "[%s] flist start=%d, end=%d, used=%d, low=%d, high=%d\n",
-               who, flist->ndx_start, flist->ndx_end, flist->used, flist->low, flist->high);
+       rprintf(FINFO, "[%s] flist start=%d, used=%d, low=%d, high=%d\n",
+               who, flist->ndx_start, flist->used, flist->low, flist->high);
        for (i = 0; i < flist->used; i++) {
                file = flist->files[i];
                if ((am_root || am_sender) && uid_ndx) {
@@ -2795,7 +2829,7 @@ struct file_list *get_dirlist(char *dirname, int dlen, int ignore_filter_rules)
 
        prune_empty_dirs = 0;
        dirlist->sorted = dirlist->files;
-       clean_flist(dirlist, 0);
+       flist_sort_and_clean(dirlist, 0);
        prune_empty_dirs = save_prune_empty_dirs;
 
        if (verbose > 3)