Make idev, hlink and file_struct + strings use allocation
[rsync/rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index 58e3da0..19931a5 100644 (file)
--- a/flist.c
+++ b/flist.c
 /** @file flist.c
  * Generate and receive file lists
  *
- * @todo Get rid of the string_area optimization.  Efficiently
- * allocating blocks is the responsibility of the system's malloc
- * library, not of rsync.
- *
  * @sa http://lists.samba.org/pipermail/rsync/2000-June/002351.html
  *
  **/
@@ -35,10 +31,12 @@ extern struct stats stats;
 
 extern int verbose;
 extern int do_progress;
+extern int am_root;
 extern int am_server;
 extern int always_checksum;
 extern int module_id;
 extern int ignore_errors;
+extern int numeric_ids;
 
 extern int cvs_exclude;
 
@@ -72,10 +70,19 @@ extern struct exclude_struct **local_exclude_list;
 
 int io_error;
 
-static struct file_struct null_file;
 static char empty_sum[MD4_SUM_LENGTH];
+static unsigned int file_struct_len;
 
 static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
+static void output_flist(struct file_list *flist);
+
+void init_flist(void)
+{
+       struct file_struct f;
+
+       /* Figure out how big the file_struct is without trailing padding */
+       file_struct_len = ((char*)&f.flags - (char*)&f) + sizeof f.flags;
+}
 
 
 static int show_filelist_p(void)
@@ -121,60 +128,6 @@ void show_flist_stats(void)
 }
 
 
-static struct string_area *string_area_new(int size)
-{
-       struct string_area *a;
-
-       if (size <= 0)
-               size = ARENA_SIZE;
-       a = new(struct string_area);
-       if (!a)
-               out_of_memory("string_area_new");
-       a->current = a->base = new_array(char, size);
-       if (!a->current)
-               out_of_memory("string_area_new buffer");
-       a->end = a->base + size;
-       a->next = NULL;
-
-       return a;
-}
-
-static void string_area_free(struct string_area *a)
-{
-       struct string_area *next;
-
-       for (; a; a = next) {
-               next = a->next;
-               free(a->base);
-       }
-}
-
-static char *string_area_malloc(struct string_area **ap, int size)
-{
-       char *p;
-       struct string_area *a;
-
-       /* does the request fit into the current space? */
-       a = *ap;
-       if (a->current + size >= a->end) {
-               /* no; get space, move new string_area to front of the list */
-               a = string_area_new(size > ARENA_SIZE ? size : ARENA_SIZE);
-               a->next = *ap;
-               *ap = a;
-       }
-
-       /* have space; do the "allocation." */
-       p = a->current;
-       a->current += size;
-       return p;
-}
-
-static char *string_area_strdup(struct string_area **ap, const char *src)
-{
-       char *dest = string_area_malloc(ap, strlen(src) + 1);
-       return strcpy(dest, src);
-}
-
 static void list_file_entry(struct file_struct *f)
 {
        char perms[11];
@@ -325,38 +278,45 @@ static int flist_dir_len;
  * Make sure @p flist is big enough to hold at least @p flist->count
  * entries.
  **/
-static void flist_expand(struct file_list *flist)
+void flist_expand(struct file_list *flist)
 {
-       if (flist->count >= flist->malloced) {
-               void *new_ptr;
+       void *new_ptr;
 
-               if (flist->malloced < 1000)
-                       flist->malloced += 1000;
-               else
-                       flist->malloced *= 2;
+       if (flist->count < flist->malloced)
+               return;
 
-               if (flist->files) {
-                       new_ptr = realloc_array(flist->files,
-                                               struct file_struct *,
-                                               flist->malloced);
-               } else {
-                       new_ptr = new_array(struct file_struct *,
-                                           flist->malloced);
-               }
+       if (flist->malloced < FLIST_START)
+               flist->malloced = FLIST_START;
+       else if (flist->malloced >= FLIST_LINEAR)
+               flist->malloced += FLIST_LINEAR;
+       else
+               flist->malloced *= 2;
+
+       /*
+        * In case count jumped or we are starting the list
+        * with a known size just set it.
+        */
+       if (flist->malloced < flist->count)
+               flist->malloced = flist->count;
+
+       if (flist->files) {
+               new_ptr = realloc_array(flist->files,
+                   struct file_struct *, flist->malloced);
+       } else {
+               new_ptr = new_array(struct file_struct *, flist->malloced);
+       }
 
-               if (verbose >= 2) {
-                       rprintf(FINFO, "[%s] expand file_list to %.0f bytes, did%s move\n",
-                               who_am_i(),
-                               (double)sizeof(flist->files[0])
-                               * flist->malloced,
-                               (new_ptr == flist->files) ? " not" : "");
-               }
+       if (verbose >= 2) {
+               rprintf(FINFO, "[%s] expand file_list to %.0f bytes, did%s move\n",
+                   who_am_i(),
+                   (double) sizeof flist->files[0] * flist->malloced,
+                   (new_ptr == flist->files) ? " not" : "");
+       }
 
-               flist->files = (struct file_struct **) new_ptr;
+       flist->files = (struct file_struct **) new_ptr;
 
-               if (!flist->files)
-                       out_of_memory("flist_expand");
-       }
+       if (!flist->files)
+               out_of_memory("flist_expand");
 }
 
 void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
@@ -427,6 +387,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
                flags |= XMIT_SAME_TIME;
        else
                modtime = file->modtime;
+
 #if SUPPORT_HARD_LINKS
        if (file->link_u.idev) {
                if (file->F_DEV == dev) {
@@ -482,11 +443,13 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
        if (!(flags & XMIT_SAME_MODE))
                write_int(f, to_wire_mode(mode));
        if (preserve_uid && !(flags & XMIT_SAME_UID)) {
-               add_uid(uid);
+               if (!numeric_ids)
+                       add_uid(uid);
                write_int(f, uid);
        }
        if (preserve_gid && !(flags & XMIT_SAME_GID)) {
-               add_gid(gid);
+               if (!numeric_ids)
+                       add_gid(gid);
                write_int(f, gid);
        }
        if (preserve_devices && IS_DEVICE(mode)) {
@@ -543,7 +506,8 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
 
 
 
-void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
+void receive_file_entry(struct file_struct **fptr, unsigned short flags,
+    struct file_list *flist, int f)
 {
        static time_t modtime;
        static mode_t mode;
@@ -551,10 +515,13 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
        static DEV64_T dev;
        static uid_t uid;
        static gid_t gid;
-       static char lastname[MAXPATHLEN];
+       static char lastname[MAXPATHLEN], *lastdir;
+       static int lastdir_len = -1;
        char thisname[MAXPATHLEN];
        unsigned int l1 = 0, l2 = 0;
-       char *p;
+       int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
+       OFF_T file_length;
+       char *basename, *dirname, *bp;
        struct file_struct *file;
 
        if (!fptr) {
@@ -573,12 +540,6 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
        else
                l2 = read_byte(f);
 
-       file = new(struct file_struct);
-       if (!file)
-               out_of_memory("receive_file_entry");
-       memset((char *) file, 0, sizeof(*file));
-       (*fptr) = file;
-
        if (l2 >= MAXPATHLEN - l1) {
                rprintf(FERROR,
                        "overflow: flags=0x%x l1=%d l2=%d lastname=%s\n",
@@ -597,49 +558,37 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
        if (sanitize_paths)
                sanitize_path(thisname, NULL);
 
-       if ((p = strrchr(thisname, '/'))) {
-               static char *lastdir;
-               *p = 0;
-               if (lastdir && strcmp(thisname, lastdir) == 0)
-                       file->dirname = lastdir;
-               else {
-                       file->dirname = strdup(thisname);
-                       lastdir = file->dirname;
-               }
-               file->basename = strdup(p + 1);
+       if ((basename = strrchr(thisname, '/')) != NULL) {
+               dirname_len = ++basename - thisname; /* counts future '\0' */
+               if (lastdir_len == dirname_len - 1
+                   && strncmp(thisname, lastdir, lastdir_len) == 0) {
+                       dirname = lastdir;
+                       dirname_len = 0; /* indicates no copy is needed */
+               } else
+                       dirname = thisname;
        } else {
-               file->dirname = NULL;
-               file->basename = strdup(thisname);
+               basename = thisname;
+               dirname = NULL;
+               dirname_len = 0;
        }
+       basename_len = strlen(basename) + 1; /* count the '\0' */
 
-       if (!file->basename)
-               out_of_memory("receive_file_entry 1");
-
-       file->flags = flags & XMIT_TOP_DIR ? FLAG_TOP_DIR : 0;
-       file->length = read_longint(f);
+       file_length = read_longint(f);
        if (!(flags & XMIT_SAME_TIME))
                modtime = (time_t)read_int(f);
-       file->modtime = modtime;
        if (!(flags & XMIT_SAME_MODE))
                mode = from_wire_mode(read_int(f));
-       file->mode = mode;
 
-       if (preserve_uid) {
-               if (!(flags & XMIT_SAME_UID))
-                       uid = (uid_t)read_int(f);
-               file->uid = uid;
-       }
-       if (preserve_gid) {
-               if (!(flags & XMIT_SAME_GID))
-                       gid = (gid_t)read_int(f);
-               file->gid = gid;
-       }
+       if (preserve_uid && !(flags & XMIT_SAME_UID))
+               uid = (uid_t)read_int(f);
+       if (preserve_gid && !(flags & XMIT_SAME_GID))
+               gid = (gid_t)read_int(f);
+
        if (preserve_devices) {
                if (protocol_version < 28) {
                        if (IS_DEVICE(mode)) {
                                if (!(flags & XMIT_SAME_RDEV_pre28))
                                        rdev = (DEV64_T)read_int(f);
-                               file->u.rdev = rdev;
                        } else
                                rdev = 0;
                } else if (IS_DEVICE(mode)) {
@@ -648,49 +597,92 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
                                rdev_high = rdev & ~0xFF;
                        } else
                                rdev = rdev_high | (DEV64_T)read_byte(f);
-                       file->u.rdev = rdev;
                }
        }
 
 #if SUPPORT_LINKS
        if (preserve_links && S_ISLNK(mode)) {
-               int len = read_int(f);
-               if (len < 0 || len >= MAXPATHLEN) {
-                       rprintf(FERROR, "overflow: len=%d\n", len);
+               linkname_len = read_int(f) + 1; /* count the '\0' */
+               if (linkname_len <= 0 || linkname_len > MAXPATHLEN) {
+                       rprintf(FERROR, "overflow: linkname_len=%d\n",
+                               linkname_len - 1);
                        overflow("receive_file_entry");
                }
-               if (!(file->u.link = new_array(char, len + 1)))
-                       out_of_memory("receive_file_entry 2");
-               read_sbuf(f, file->u.link, len);
+       }
+       else
+#endif
+               linkname_len = 0;
+
+       sum_len = always_checksum && S_ISREG(mode) ? MD4_SUM_LENGTH : 0;
+
+       alloc_len = file_struct_len + dirname_len + basename_len
+                 + linkname_len + sum_len;
+       bp = pool_alloc(flist->file_pool, alloc_len, "receive_file_entry");
+
+       file = *fptr = (struct file_struct *)bp;
+       memset(bp, 0, file_struct_len);
+       bp += file_struct_len;
+
+       file->flags = flags & XMIT_TOP_DIR ? FLAG_TOP_DIR : 0;
+       file->modtime = modtime;
+       file->length = file_length;
+       file->mode = mode;
+       file->uid = uid;
+       file->gid = gid;
+
+       if (dirname_len) {
+               file->dirname = lastdir = bp;
+               lastdir_len = dirname_len - 1;
+               memcpy(bp, dirname, dirname_len - 1);
+               bp += dirname_len;
+               bp[-1] = '\0';
+       } else if (dirname)
+               file->dirname = dirname;
+
+       file->basename = bp;
+       memcpy(bp, basename, basename_len);
+       bp += basename_len;
+
+       if (preserve_devices && IS_DEVICE(mode))
+               file->u.rdev = rdev;
+
+#if SUPPORT_LINKS
+       if (linkname_len) {
+               file->u.link = bp;
+               read_sbuf(f, bp, linkname_len - 1);
                if (sanitize_paths)
-                       sanitize_path(file->u.link, file->dirname);
+                       sanitize_path(bp, lastdir);
+               bp += linkname_len;
        }
 #endif
 
 #if SUPPORT_HARD_LINKS
        if (preserve_hard_links && protocol_version < 28 && S_ISREG(mode))
                flags |= XMIT_HAS_IDEV_DATA;
-       if (flags & XMIT_HAS_IDEV_DATA) {
-               if (!(file->link_u.idev = new(struct idev)))
-                       out_of_memory("file inode data");
+       if (flags & XMIT_HAS_IDEV_DATA && flist->hlink_pool) {
+               INO64_T inode;
+               file->link_u.idev = pool_talloc(flist->hlink_pool,
+                   struct idev, 1, "inode_table");
                if (protocol_version < 26) {
                        dev = read_int(f);
-                       file->F_INODE = read_int(f);
+                       inode = read_int(f);
                } else {
                        if (!(flags & XMIT_SAME_DEV))
                                dev = read_longint(f);
-                       file->F_INODE = read_longint(f);
+                       inode = read_longint(f);
+               }
+               if (flist->hlink_pool) {
+                       file->F_INODE = inode;
+                       file->F_DEV = dev;
                }
-               file->F_DEV = dev;
        }
 #endif
 
        if (always_checksum) {
                char *sum;
-               if (S_ISREG(mode)) {
-                       sum = file->u.sum = new_array(char, MD4_SUM_LENGTH);
-                       if (!sum)
-                               out_of_memory("md4 sum");
+               if (sum_len) {
+                       file->u.sum = sum = bp;
+                       /*bp += sum_len;*/
                } else if (protocol_version < 28) {
                        /* Prior to 28, we get a useless set of nulls. */
                        sum = empty_sum;
@@ -711,10 +703,6 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
 }
 
 
-#define STRDUP(ap, p)  (ap ? string_area_strdup(ap, p) : strdup(p))
-/* IRIX cc cares that the operands to the ternary have the same type. */
-#define MALLOC(ap, i)  (ap ? (void*) string_area_malloc(ap, i) : malloc(i))
-
 /**
  * Create a file_struct for a named file by reading its stat()
  * information and performing extensive checks against global
@@ -730,17 +718,21 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags, int f)
  * statting directories if we're not recursing, but this is not a very
  * important case.  Some systems may not have d_type.
  **/
-struct file_struct *make_file(char *fname, struct string_area **ap,
-                             int exclude_level)
+struct file_struct *make_file(char *fname,
+    struct file_list *flist, int exclude_level)
 {
+       static char *lastdir;
+       static int lastdir_len = -1;
        struct file_struct *file;
        STRUCT_STAT st;
        char sum[SUM_LENGTH];
-       char *p;
        char thisname[MAXPATHLEN];
        char linkname[MAXPATHLEN];
+       int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
+       char *basename, *dirname, *bp;
        unsigned short flags = 0;
 
+
        if (strlcpy(thisname, fname, sizeof thisname)
            >= sizeof thisname - flist_dir_len) {
                rprintf(FINFO, "skipping overly long name: %s\n", fname);
@@ -778,13 +770,12 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
                return NULL;
        }
 
-       if (one_file_system && st.st_dev != filesystem_dev) {
-               /* We allow a directory though to preserve the mount point.
-                * However, flag it so that we don't recurse. */
-               if (!S_ISDIR(st.st_mode))
-                       return NULL;
+       /* We only care about directories because we need to avoid recursing
+        * into a mount-point directory, not to avoid copying a symlinked
+        * file if -L (or similar) was specified. */
+       if (one_file_system && st.st_dev != filesystem_dev
+           && S_ISDIR(st.st_mode))
                flags |= FLAG_MOUNT_POINT;
-       }
 
        if (check_exclude_file(thisname, S_ISDIR(st.st_mode) != 0, exclude_level))
                return NULL;
@@ -799,60 +790,100 @@ struct file_struct *make_file(char *fname, struct string_area **ap,
                        who_am_i(), thisname, exclude_level);
        }
 
-       file = new(struct file_struct);
-       if (!file)
-               out_of_memory("make_file");
-       memset((char *) file, 0, sizeof(*file));
-       file->flags = flags;
+       if ((basename = strrchr(thisname, '/')) != NULL) {
+               dirname_len = ++basename - thisname; /* counts future '\0' */
+               if (lastdir_len == dirname_len - 1
+                   && strncmp(thisname, lastdir, lastdir_len) == 0) {
+                       dirname = lastdir;
+                       dirname_len = 0; /* indicates no copy is needed */
+               } else
+                       dirname = thisname;
+       } else {
+               basename = thisname;
+               dirname = NULL;
+               dirname_len = 0;
+       }
+       basename_len = strlen(basename) + 1; /* count the '\0' */
 
-       if ((p = strrchr(thisname, '/'))) {
-               static char *lastdir;
-               *p = 0;
-               if (lastdir && strcmp(thisname, lastdir) == 0)
-                       file->dirname = lastdir;
-               else {
-                       file->dirname = strdup(thisname);
-                       lastdir = file->dirname;
-               }
-               file->basename = STRDUP(ap, p + 1);
-               *p = '/';
+#if SUPPORT_LINKS
+       linkname_len = S_ISLNK(st.st_mode) ? strlen(linkname) + 1 : 0;
+#else
+       linkname_len = 0;
+#endif
+
+       sum_len = always_checksum && S_ISREG(st.st_mode) ? MD4_SUM_LENGTH : 0;
+
+       alloc_len = file_struct_len + dirname_len + basename_len
+           + linkname_len + sum_len;
+       if (flist) {
+               bp = pool_alloc(flist->file_pool, alloc_len,
+                   "receive_file_entry");
        } else {
-               file->dirname = NULL;
-               file->basename = STRDUP(ap, thisname);
+               if (!(bp = new_array(char, alloc_len)))
+                       out_of_memory("receive_file_entry");
        }
 
+       file = (struct file_struct *)bp;
+       memset(bp, 0, file_struct_len);
+       bp += file_struct_len;
+
+       file->flags = flags;
        file->modtime = st.st_mtime;
        file->length = st.st_size;
        file->mode = st.st_mode;
        file->uid = st.st_uid;
        file->gid = st.st_gid;
 
+#if SUPPORT_HARD_LINKS
+       if (flist && flist->hlink_pool) {
+               if (protocol_version < 28) {
+                       if (S_ISREG(st.st_mode))
+                               file->link_u.idev = pool_talloc(
+                                   flist->hlink_pool, struct idev, 1,
+                                   "inode_table");
+               } else {
+                       if (!S_ISDIR(st.st_mode) && st.st_nlink > 1)
+                               file->link_u.idev = pool_talloc(
+                                   flist->hlink_pool, struct idev, 1,
+                                   "inode_table");
+               }
+       }
+       if (file->link_u.idev) {
+               file->F_DEV = st.st_dev;
+               file->F_INODE = st.st_ino;
+       }
+#endif
+
+       if (dirname_len) {
+               file->dirname = lastdir = bp;
+               lastdir_len = dirname_len - 1;
+               memcpy(bp, dirname, dirname_len - 1);
+               bp += dirname_len;
+               bp[-1] = '\0';
+       } else if (dirname)
+               file->dirname = dirname;
+
+       file->basename = bp;
+       memcpy(bp, basename, basename_len);
+       bp += basename_len;
+
 #ifdef HAVE_STRUCT_STAT_ST_RDEV
        if (preserve_devices && IS_DEVICE(st.st_mode))
                file->u.rdev = st.st_rdev;
 #endif
 
 #if SUPPORT_LINKS
-       if (S_ISLNK(st.st_mode))
-               file->u.link = STRDUP(ap, linkname);
-#endif
-
-#if SUPPORT_HARD_LINKS
-       if (preserve_hard_links) {
-               if (protocol_version < 28 ? S_ISREG(st.st_mode)
-                   : !S_ISDIR(st.st_mode) && st.st_nlink > 1) {
-                       if (!(file->link_u.idev = new(struct idev)))
-                               out_of_memory("file inode data");
-                       file->F_DEV = st.st_dev;
-                       file->F_INODE = st.st_ino;
-               }
+       if (linkname_len) {
+               file->u.link = bp;
+               memcpy(bp, linkname, linkname_len);
+               bp += linkname_len;
        }
 #endif
 
-       if (always_checksum && S_ISREG(st.st_mode)) {
-               if (!(file->u.sum = (char*)MALLOC(ap, MD4_SUM_LENGTH)))
-                       out_of_memory("md4 sum");
-               file_checksum(thisname, file->u.sum, st.st_size);
+       if (sum_len) {
+               file->u.sum = bp;
+               file_checksum(thisname, bp, st.st_size);
+               /*bp += sum_len;*/
        }
 
        file->basedir = flist_dir;
@@ -872,9 +903,8 @@ void send_file_name(int f, struct file_list *flist, char *fname,
        extern int delete_excluded;
 
        /* f is set to -1 when calculating deletion file list */
-       file = make_file(fname, &flist->string_area,
-                        f == -1 && delete_excluded? SERVER_EXCLUDES
-                                                  : ALL_EXCLUDES);
+       file = make_file(fname, flist,
+           f == -1 && delete_excluded? SERVER_EXCLUDES : ALL_EXCLUDES);
 
        if (!file)
                return;
@@ -993,7 +1023,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 
        start_write = stats.total_written;
 
-       flist = flist_new();
+       flist = flist_new(f == -1 ? WITHOUT_HLINK : WITH_HLINK,
+           "send_file_list");
 
        if (f != -1) {
                io_start_buffering_out(f);
@@ -1144,6 +1175,12 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                        finish_filelist_progress(flist);
        }
 
+       if (flist->hlink_pool)
+       {
+               pool_destroy(flist->hlink_pool);
+               flist->hlink_pool = NULL;
+       }
+
        clean_flist(flist, 0, 0);
 
        if (f != -1) {
@@ -1161,6 +1198,9 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                        write_batch_flist_info(flist->count, flist->files);
        }
 
+       if (verbose > 3)
+               output_flist(flist);
+
        if (verbose > 2)
                rprintf(FINFO, "send_file_list done\n");
 
@@ -1180,9 +1220,7 @@ struct file_list *recv_file_list(int f)
 
        start_read = stats.total_read;
 
-       flist = new(struct file_list);
-       if (!flist)
-               goto oom;
+       flist = flist_new(WITH_HLINK, "recv_file_list");
 
        flist->count = 0;
        flist->malloced = 1000;
@@ -1198,7 +1236,7 @@ struct file_list *recv_file_list(int f)
 
                if (protocol_version >= 28 && (flags & XMIT_EXTENDED_FLAGS))
                        flags |= read_byte(f) << 8;
-               receive_file_entry(&flist->files[i], flags, f);
+               receive_file_entry(&flist->files[i], flags, flist, f);
 
                if (S_ISREG(flist->files[i]->mode))
                        stats.total_size += flist->files[i]->length;
@@ -1212,7 +1250,7 @@ struct file_list *recv_file_list(int f)
                                f_name(flist->files[i]));
                }
        }
-       receive_file_entry(NULL, 0, 0); /* Signal that we're done. */
+       receive_file_entry(NULL, 0, NULL, 0); /* Signal that we're done. */
 
        if (verbose > 2)
                rprintf(FINFO, "received %d names\n", flist->count);
@@ -1236,6 +1274,9 @@ struct file_list *recv_file_list(int f)
                }
        }
 
+       if (verbose > 3)
+               output_flist(flist);
+
        if (list_only) {
                int i;
                for (i = 0; i < flist->count; i++)
@@ -1298,46 +1339,43 @@ int flist_find(struct file_list *flist, struct file_struct *f)
        return -1;
 }
 
-
 /*
- * free up one file
+ * Free up any resources a file_struct has allocated
+ * and clear the file.
  */
-void free_file(struct file_struct *file)
+void clear_file(int i, struct file_list *flist)
 {
-       if (!file)
-               return;
-       if (file->basename)
-               free(file->basename);
-       if (!IS_DEVICE(file->mode) && file->u.sum)
-               free(file->u.sum); /* Handles u.link too. */
-#if SUPPORT_HARD_LINKS
-       if (file->link_u.idev)
-               free((char*)file->link_u.idev); /* Handles link_u.links too. */
-#endif
-       *file = null_file;
+       if (flist->hlink_pool && flist->files[i]->link_u.idev)
+               pool_free(flist->hlink_pool, 0, flist->files[i]->link_u.idev);
+       memset(flist->files[i], 0, file_struct_len);
 }
 
 
 /*
  * allocate a new file list
  */
-struct file_list *flist_new(void)
+struct file_list *flist_new(int with_hlink, char *msg)
 {
        struct file_list *flist;
 
        flist = new(struct file_list);
        if (!flist)
-               out_of_memory("send_file_list");
+               out_of_memory(msg);
 
-       flist->count = 0;
-       flist->malloced = 0;
-       flist->files = NULL;
+       memset(flist, 0, sizeof (struct file_list));
 
-#if ARENA_SIZE > 0
-       flist->string_area = string_area_new(0);
-#else
-       flist->string_area = NULL;
+       if (!(flist->file_pool = pool_create(FILE_EXTENT, 0,
+           out_of_memory, POOL_INTERN)))
+               out_of_memory(msg);
+
+#if SUPPORT_HARD_LINKS
+       if (with_hlink && preserve_hard_links) {
+               if (!(flist->hlink_pool = pool_create(HLINK_EXTENT, 
+                   sizeof (struct idev), out_of_memory, POOL_INTERN)))
+                       out_of_memory(msg);
+       }
 #endif
+
        return flist;
 }
 
@@ -1346,22 +1384,9 @@ struct file_list *flist_new(void)
  */
 void flist_free(struct file_list *flist)
 {
-       int i;
-       for (i = 1; i < flist->count; i++) {
-               if (!flist->string_area)
-                       free_file(flist->files[i]);
-               free(flist->files[i]);
-       }
-       /* FIXME: I don't think we generally need to blank the flist
-        * since it's about to be freed.  This will just cause more
-        * memory traffic.  If you want a freed-memory debugger, you
-        * know where to get it. */
-       memset((char *) flist->files, 0,
-              sizeof(flist->files[0]) * flist->count);
+       pool_destroy(flist->file_pool);
+       pool_destroy(flist->hlink_pool);
        free(flist->files);
-       if (flist->string_area)
-               string_area_free(flist->string_area);
-       memset((char *) flist, 0, sizeof(*flist));
        free(flist);
 }
 
@@ -1378,7 +1403,7 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
                return;
 
        qsort(flist->files, flist->count,
-             sizeof(flist->files[0]), (int (*)()) file_compare);
+             sizeof flist->files[0], (int (*)()) file_compare);
 
        for (i = no_dups? 0 : flist->count; i < flist->count; i++) {
                if (flist->files[i]->basename) {
@@ -1400,14 +1425,8 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
                         * else deletions will mysteriously fail with -R). */
                        if (flist->files[i]->flags & FLAG_TOP_DIR)
                                flist->files[prev_i]->flags |= FLAG_TOP_DIR;
-                       /* it's not great that the flist knows the semantics of
-                        * the file memory usage, but i'd rather not add a flag
-                        * byte to that struct.
-                        * XXX can i use a bit in the flags field? */
-                       if (flist->string_area)
-                               flist->files[i][0] = null_file;
-                       else
-                               free_file(flist->files[i]);
+
+                       clear_file(i, flist);
                } else
                        prev_i = i;
        }
@@ -1430,18 +1449,28 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
                        }
                }
        }
+}
 
-       if (verbose <= 3)
-               return;
+static void output_flist(struct file_list *flist)
+{
+       char uidbuf[16], gidbuf[16];
+       struct file_struct *file;
+       int i;
 
        for (i = 0; i < flist->count; i++) {
-               rprintf(FINFO, "[%s] i=%d %s %s %s mode=0%o len=%.0f\n",
-                       who_am_i(), i,
-                       NS(flist->files[i]->basedir),
-                       NS(flist->files[i]->dirname),
-                       NS(flist->files[i]->basename),
-                       (int) flist->files[i]->mode,
-                       (double) flist->files[i]->length);
+               file = flist->files[i];
+               if (am_root && preserve_uid)
+                       sprintf(uidbuf, " uid=%ld", (long)file->uid);
+               else
+                       *uidbuf = '\0';
+               if (preserve_gid && file->gid != GID_NONE)
+                       sprintf(gidbuf, " gid=%ld", (long)file->gid);
+               else
+                       *gidbuf = '\0';
+               rprintf(FINFO, "[%s] i=%d %s %s %s mode=0%o len=%.0f%s%s\n",
+                       who_am_i(), i, NS(file->basedir), NS(file->dirname),
+                       NS(file->basename), (int) file->mode,
+                       (double) file->length, uidbuf, gidbuf);
        }
 }