X-Git-Url: https://mattmccutchen.net/rsync/rsync-patches.git/blobdiff_plain/e66d6d511b675d31a3c55b51fd28d5d2558d094a..0ef5abcbbb95298fa9faf1d3eb275a9e76e1d951:/catch_crash_signals.diff diff --git a/catch_crash_signals.diff b/catch_crash_signals.diff index bdab91f..cceeaa8 100644 --- a/catch_crash_signals.diff +++ b/catch_crash_signals.diff @@ -1,18 +1,18 @@ Igor Yu. Zhbanov wrote: -> I am using rsync compiled with Cygwin on windows. +> I am using rsync compiled with Cygwin on windows. > I must call rsync from the *.bat script (I don't want to use a bash on Windows) > and I have noticed that in the case when program compiled by Cygwin crashes > via segmentation fault and default SIGSEGV handler is called, then it > terminates process with exit status 0 as I see it from my *.bat script. > (But if I invoke a program from bash (compiled with Cygwin too) I will see > error code 139 as expected.) -> +> > It is a Cygwin's problem, not an rsync's, but to use it on windows and > to distinguish situations when rsync crashes and when it exits normally, > I have written signal handler which terminates process with code 50. > You may use conventional 139. Also signal handler writes corresponding > message to log file. -> +> > By the way. When I terminate rsync in daemon mode by pressing Control-C, > it writes an error to log. May be this is not an error but info or notice? @@ -40,14 +40,14 @@ diff --git a/errcode.h b/errcode.h diff --git a/log.c b/log.c --- a/log.c +++ b/log.c -@@ -82,6 +82,7 @@ struct { +@@ -83,6 +83,7 @@ struct { { RERR_TERMINATED , "sibling process terminated abnormally" }, { RERR_SIGNAL1 , "received SIGUSR1" }, { RERR_SIGNAL , "received SIGINT, SIGTERM, or SIGHUP" }, + { RERR_WECRASHED , "rsync caught a CRASH-causing signal" }, { RERR_WAITCHILD , "waitpid() failed" }, { RERR_MALLOC , "error allocating core memory buffers" }, - { RERR_PARTIAL , "some files could not be transferred" }, + { RERR_PARTIAL , "some files/attrs were not transferred (see previous errors)" }, diff --git a/main.c b/main.c --- a/main.c +++ b/main.c @@ -64,7 +64,7 @@ diff --git a/main.c b/main.c } /* This function gets called from all 3 processes. We want the client side -@@ -1314,6 +1317,14 @@ RETSIGTYPE remember_children(UNUSED(int val)) +@@ -1315,6 +1318,14 @@ RETSIGTYPE remember_children(UNUSED(int val)) break; } } @@ -79,7 +79,7 @@ diff --git a/main.c b/main.c } #endif #ifndef HAVE_SIGACTION -@@ -1372,6 +1383,12 @@ static RETSIGTYPE rsync_panic_handler(UNUSED(int whatsig)) +@@ -1373,6 +1384,12 @@ static RETSIGTYPE rsync_panic_handler(UNUSED(int whatsig)) } #endif @@ -92,7 +92,7 @@ diff --git a/main.c b/main.c int main(int argc,char *argv[]) { -@@ -1394,6 +1411,11 @@ int main(int argc,char *argv[]) +@@ -1395,6 +1412,11 @@ int main(int argc,char *argv[]) SIGACTMASK(SIGFPE, rsync_panic_handler); SIGACTMASK(SIGABRT, rsync_panic_handler); SIGACTMASK(SIGBUS, rsync_panic_handler);