X-Git-Url: https://mattmccutchen.net/rsync/rsync-patches.git/blobdiff_plain/c0c7984e7f6009b6ab18ad3da998a56a9c0f083d..refs/heads/master:/catch_crash_signals.diff diff --git a/catch_crash_signals.diff b/catch_crash_signals.diff index d7c0e12..3ecf176 100644 --- a/catch_crash_signals.diff +++ b/catch_crash_signals.diff @@ -1,18 +1,18 @@ Igor Yu. Zhbanov wrote: -> I am using rsync compiled with Cygwin on windows. +> I am using rsync compiled with Cygwin on windows. > I must call rsync from the *.bat script (I don't want to use a bash on Windows) > and I have noticed that in the case when program compiled by Cygwin crashes > via segmentation fault and default SIGSEGV handler is called, then it > terminates process with exit status 0 as I see it from my *.bat script. > (But if I invoke a program from bash (compiled with Cygwin too) I will see > error code 139 as expected.) -> +> > It is a Cygwin's problem, not an rsync's, but to use it on windows and > to distinguish situations when rsync crashes and when it exits normally, > I have written signal handler which terminates process with code 50. > You may use conventional 139. Also signal handler writes corresponding > message to log file. -> +> > By the way. When I terminate rsync in daemon mode by pressing Control-C, > it writes an error to log. May be this is not an error but info or notice? @@ -25,6 +25,7 @@ To use this patch, run these commands for a successful build: ./configure (optional if already run) make +based-on: a01e3b490eb36ccf9e704840e1b6683dab867550 diff --git a/errcode.h b/errcode.h --- a/errcode.h +++ b/errcode.h @@ -40,18 +41,18 @@ diff --git a/errcode.h b/errcode.h diff --git a/log.c b/log.c --- a/log.c +++ b/log.c -@@ -82,6 +82,7 @@ struct { +@@ -93,6 +93,7 @@ struct { { RERR_TERMINATED , "sibling process terminated abnormally" }, { RERR_SIGNAL1 , "received SIGUSR1" }, { RERR_SIGNAL , "received SIGINT, SIGTERM, or SIGHUP" }, + { RERR_WECRASHED , "rsync caught a CRASH-causing signal" }, { RERR_WAITCHILD , "waitpid() failed" }, { RERR_MALLOC , "error allocating core memory buffers" }, - { RERR_PARTIAL , "some files could not be transferred" }, + { RERR_PARTIAL , "some files/attrs were not transferred (see previous errors)" }, diff --git a/main.c b/main.c --- a/main.c +++ b/main.c -@@ -163,8 +163,11 @@ static void wait_process_with_flush(pid_t pid, int *exit_code_ptr) +@@ -180,8 +180,11 @@ static void wait_process_with_flush(pid_t pid, int *exit_code_ptr) *exit_code_ptr = RERR_TERMINATED; else *exit_code_ptr = RERR_WAITCHILD; @@ -63,8 +64,8 @@ diff --git a/main.c b/main.c + } } - /* This function gets called from all 3 processes. We want the client side -@@ -1306,6 +1309,14 @@ RETSIGTYPE remember_children(UNUSED(int val)) + void write_del_stats(int f) +@@ -1432,6 +1435,14 @@ RETSIGTYPE remember_children(UNUSED(int val)) break; } } @@ -79,7 +80,7 @@ diff --git a/main.c b/main.c } #endif #ifndef HAVE_SIGACTION -@@ -1364,6 +1375,12 @@ static RETSIGTYPE rsync_panic_handler(UNUSED(int whatsig)) +@@ -1490,6 +1501,12 @@ static RETSIGTYPE rsync_panic_handler(UNUSED(int whatsig)) } #endif @@ -92,7 +93,7 @@ diff --git a/main.c b/main.c int main(int argc,char *argv[]) { -@@ -1386,6 +1403,11 @@ int main(int argc,char *argv[]) +@@ -1512,6 +1529,11 @@ int main(int argc,char *argv[]) SIGACTMASK(SIGFPE, rsync_panic_handler); SIGACTMASK(SIGABRT, rsync_panic_handler); SIGACTMASK(SIGBUS, rsync_panic_handler); @@ -107,7 +108,7 @@ diff --git a/main.c b/main.c diff --git a/socket.c b/socket.c --- a/socket.c +++ b/socket.c -@@ -512,7 +512,17 @@ int is_a_socket(int fd) +@@ -518,7 +518,17 @@ int is_a_socket(int fd) static RETSIGTYPE sigchld_handler(UNUSED(int val)) { #ifdef WNOHANG