X-Git-Url: https://mattmccutchen.net/rsync/rsync-patches.git/blobdiff_plain/9127013998bd097f699897b0f2b142fe2ba71e9d..refs/heads/master:/fileflags.diff diff --git a/fileflags.diff b/fileflags.diff index f3acbf4..963fdbe 100644 --- a/fileflags.diff +++ b/fileflags.diff @@ -8,10 +8,11 @@ To use this patch, run these commands for a successful build: ./configure make +based-on: afccb3d3263b4867eb0a22cf29a3bb75f4cf0d71 diff --git a/Makefile.in b/Makefile.in --- a/Makefile.in +++ b/Makefile.in -@@ -42,7 +42,7 @@ popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \ +@@ -43,7 +43,7 @@ popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \ popt/popthelp.o popt/poptparse.o OBJS=$(OBJS1) $(OBJS2) $(OBJS3) $(DAEMON_OBJ) $(LIBOBJ) $(ZLIBOBJ) @BUILD_POPT@ @@ -20,7 +21,7 @@ diff --git a/Makefile.in b/Makefile.in # Programs we must have to run the test cases CHECK_PROGS = rsync$(EXEEXT) tls$(EXEEXT) getgroups$(EXEEXT) getfsdev$(EXEEXT) \ -@@ -107,7 +107,7 @@ getgroups$(EXEEXT): getgroups.o +@@ -111,7 +111,7 @@ getgroups$(EXEEXT): getgroups.o getfsdev$(EXEEXT): getfsdev.o $(CC) $(CFLAGS) $(LDFLAGS) -o $@ getfsdev.o $(LIBS) @@ -44,7 +45,7 @@ diff --git a/compat.c b/compat.c extern int preserve_acls; extern int preserve_xattrs; extern int need_messages_from_generator; -@@ -60,7 +62,7 @@ extern iconv_t ic_send, ic_recv; +@@ -61,7 +63,7 @@ extern char *iconv_opt; #endif /* These index values are for the file-list's extra-attribute array. */ @@ -52,8 +53,8 @@ diff --git a/compat.c b/compat.c +int uid_ndx, gid_ndx, fileflags_ndx, acls_ndx, xattrs_ndx, unsort_ndx; int receiver_symlink_times = 0; /* receiver can set the time on a symlink */ - -@@ -134,6 +136,8 @@ void setup_protocol(int f_out,int f_in) + int sender_symlink_iconv = 0; /* sender should convert symlink content */ +@@ -138,6 +140,8 @@ void setup_protocol(int f_out,int f_in) uid_ndx = ++file_extra_cnt; if (preserve_gid) gid_ndx = ++file_extra_cnt; @@ -65,27 +66,75 @@ diff --git a/compat.c b/compat.c diff --git a/configure.in b/configure.in --- a/configure.in +++ b/configure.in -@@ -553,7 +553,7 @@ AC_CHECK_FUNCS(waitpid wait4 getcwd strdup chown chmod lchmod mknod mkfifo \ - memmove lchown vsnprintf snprintf vasprintf asprintf setsid strpbrk \ - strlcat strlcpy strtol mallinfo getgroups setgroups geteuid getegid \ +@@ -589,7 +589,7 @@ AC_CHECK_FUNCS(waitpid wait4 getcwd strdup chown chmod lchmod mknod mkfifo \ setlocale setmode open64 lseek64 mkstemp64 mtrace va_copy __va_copy \ -- strerror putenv iconv_open locale_charset nl_langinfo getxattr \ -+ chflags strerror putenv iconv_open locale_charset nl_langinfo getxattr \ - extattr_get_link sigaction sigprocmask setattrlist) + seteuid strerror putenv iconv_open locale_charset nl_langinfo getxattr \ + extattr_get_link sigaction sigprocmask setattrlist getgrouplist \ +- initgroups utimensat) ++ initgroups utimensat chflags) dnl cygwin iconv.h defines iconv_open as libiconv_open + if test x"$ac_cv_func_iconv_open" != x"yes"; then +diff --git a/delete.c b/delete.c +--- a/delete.c ++++ b/delete.c +@@ -25,6 +25,7 @@ + extern int am_root; + extern int make_backups; + extern int max_delete; ++extern int force_change; + extern char *backup_dir; + extern char *backup_suffix; + extern int backup_suffix_len; +@@ -98,8 +99,12 @@ static enum delret delete_dir_contents(char *fname, uint16 flags) + } + + strlcpy(p, fp->basename, remainder); ++#ifdef SUPPORT_FORCE_CHANGE ++ if (force_change) ++ make_mutable(fname, fp->mode, F_FFLAGS(fp), force_change); ++#endif + if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid) +- do_chmod(fname, fp->mode | S_IWUSR); ++ do_chmod(fname, fp->mode | S_IWUSR, NO_FFLAGS); + /* Save stack by recursing to ourself directly. */ + if (S_ISDIR(fp->mode)) { + if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS) +@@ -140,7 +145,7 @@ enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) + } + + if (flags & DEL_NO_UID_WRITE) +- do_chmod(fbuf, mode | S_IWUSR); ++ do_chmod(fbuf, mode | S_IWUSR, NO_FFLAGS); + + if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) { + int save_uid_ndx = uid_ndx; +@@ -148,6 +153,13 @@ enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) + * delete_dir_contents() always calls us w/DEL_DIR_IS_EMPTY. */ + if (!uid_ndx) + uid_ndx = ++file_extra_cnt; ++#ifdef SUPPORT_FORCE_CHANGE ++ if (force_change) { ++ STRUCT_STAT st; ++ if (x_lstat(fbuf, &st, NULL) == 0) ++ make_mutable(fbuf, st.st_mode, st.st_flags, force_change); ++ } ++#endif + ignore_perishable = 1; + /* If DEL_RECURSE is not set, this just reports emptiness. */ + ret = delete_dir_contents(fbuf, flags); diff --git a/flist.c b/flist.c --- a/flist.c +++ b/flist.c -@@ -52,6 +52,7 @@ extern int preserve_links; +@@ -50,6 +50,7 @@ extern int preserve_links; extern int preserve_hard_links; extern int preserve_devices; extern int preserve_specials; +extern int preserve_fileflags; + extern int delete_during; + extern int missing_args; extern int uid_ndx; - extern int gid_ndx; - extern int eol_nulls; -@@ -390,6 +391,9 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, +@@ -408,6 +409,9 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, { static time_t modtime; static mode_t mode; @@ -95,7 +144,7 @@ diff --git a/flist.c b/flist.c #ifdef SUPPORT_HARD_LINKS static int64 dev; #endif -@@ -419,6 +423,14 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, +@@ -451,6 +455,14 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, xflags |= XMIT_SAME_MODE; else mode = file->mode; @@ -108,10 +157,10 @@ diff --git a/flist.c b/flist.c + } +#endif - if ((preserve_devices && IS_DEVICE(mode)) - || (preserve_specials && IS_SPECIAL(mode))) { -@@ -533,6 +545,10 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, - } + if (preserve_devices && IS_DEVICE(mode)) { + if (protocol_version < 28) { +@@ -592,6 +604,10 @@ static void send_file_entry(int f, const char *fname, struct file_struct *file, + write_varint(f, F_MOD_NSEC(file)); if (!(xflags & XMIT_SAME_MODE)) write_int(f, to_wire_mode(mode)); +#ifdef SUPPORT_FILEFLAGS @@ -121,7 +170,7 @@ diff --git a/flist.c b/flist.c if (preserve_uid && !(xflags & XMIT_SAME_UID)) { if (protocol_version < 30) write_int(f, uid); -@@ -621,6 +637,9 @@ static struct file_struct *recv_file_entry(struct file_list *flist, +@@ -679,6 +695,9 @@ static struct file_struct *recv_file_entry(int f, struct file_list *flist, int x { static int64 modtime; static mode_t mode; @@ -131,9 +180,9 @@ diff --git a/flist.c b/flist.c #ifdef SUPPORT_HARD_LINKS static int64 dev; #endif -@@ -756,6 +775,10 @@ static struct file_struct *recv_file_entry(struct file_list *flist, +@@ -824,6 +843,10 @@ static struct file_struct *recv_file_entry(int f, struct file_list *flist, int x - if (chmod_modes && !S_ISLNK(mode)) + if (chmod_modes && !S_ISLNK(mode) && mode) mode = tweak_mode(mode, chmod_modes); +#ifdef SUPPORT_FILEFLAGS + if (preserve_fileflags && !(xflags & XMIT_SAME_FLAGS)) @@ -142,9 +191,9 @@ diff --git a/flist.c b/flist.c if (preserve_uid && !(xflags & XMIT_SAME_UID)) { if (protocol_version < 30) -@@ -876,6 +899,10 @@ static struct file_struct *recv_file_entry(struct file_list *flist, - OPT_EXTRA(file, 0)->unum = (uint32)(file_length >> 32); +@@ -975,6 +998,10 @@ static struct file_struct *recv_file_entry(int f, struct file_list *flist, int x } + #endif file->mode = mode; +#ifdef SUPPORT_FILEFLAGS + if (preserve_fileflags) @@ -153,9 +202,9 @@ diff --git a/flist.c b/flist.c if (preserve_uid) F_OWNER(file) = uid; if (preserve_gid) { -@@ -1226,6 +1253,10 @@ struct file_struct *make_file(const char *fname, struct file_list *flist, - OPT_EXTRA(file, 0)->unum = (uint32)(st.st_size >> 32); +@@ -1372,6 +1399,10 @@ struct file_struct *make_file(const char *fname, struct file_list *flist, } + #endif file->mode = st.st_mode; +#if defined SUPPORT_FILEFLAGS || defined SUPPORT_FORCE_CHANGE + if (fileflags_ndx) @@ -178,44 +227,7 @@ diff --git a/generator.c b/generator.c extern int uid_ndx; extern int gid_ndx; extern int delete_mode; -@@ -166,7 +168,7 @@ static enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) - } - - if (flags & DEL_NO_UID_WRITE) -- do_chmod(fbuf, mode | S_IWUSR); -+ do_chmod(fbuf, mode | S_IWUSR, NO_FFLAGS); - - if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) { - int save_uid_ndx = uid_ndx; -@@ -174,6 +176,13 @@ static enum delret delete_item(char *fbuf, uint16 mode, uint16 flags) - * delete_dir_contents() always calls us w/DEL_DIR_IS_EMPTY. */ - if (!uid_ndx) - uid_ndx = ++file_extra_cnt; -+#ifdef SUPPORT_FORCE_CHANGE -+ if (force_change) { -+ STRUCT_STAT st; -+ if (x_lstat(fbuf, &st, NULL) == 0) -+ make_mutable(fbuf, st.st_mode, st.st_flags, force_change); -+ } -+#endif - ignore_perishable = 1; - /* If DEL_RECURSE is not set, this just reports emptiness. */ - ret = delete_dir_contents(fbuf, flags); -@@ -294,8 +303,12 @@ static enum delret delete_dir_contents(char *fname, uint16 flags) - } - - strlcpy(p, fp->basename, remainder); -+#ifdef SUPPORT_FORCE_CHANGE -+ if (force_change) -+ make_mutable(fname, fp->mode, F_FFLAGS(fp), force_change); -+#endif - if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid) -- do_chmod(fname, fp->mode | S_IWUSR); -+ do_chmod(fname, fp->mode | S_IWUSR, NO_FFLAGS); - /* Save stack by recursing to ourself directly. */ - if (S_ISDIR(fp->mode)) { - if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS) -@@ -596,6 +609,11 @@ int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp) +@@ -405,6 +407,11 @@ int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp) && ((sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0))) return 0; @@ -227,7 +239,7 @@ diff --git a/generator.c b/generator.c if (am_root && uid_ndx && sxp->st.st_uid != (uid_t)F_OWNER(file)) return 0; -@@ -661,6 +679,11 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre +@@ -470,6 +477,11 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre if (gid_ndx && !(file->flags & FLAG_SKIP_GROUP) && sxp->st.st_gid != (gid_t)F_GROUP(file)) iflags |= ITEM_REPORT_GROUP; @@ -239,7 +251,7 @@ diff --git a/generator.c b/generator.c #ifdef SUPPORT_ACLS if (preserve_acls && !S_ISLNK(file->mode)) { if (!ACL_READY(*sxp)) -@@ -1426,6 +1449,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, +@@ -1264,6 +1276,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, file->mode = dest_mode(file->mode, sx.st.st_mode, dflt_perms, statret == 0); } @@ -250,7 +262,7 @@ diff --git a/generator.c b/generator.c if (statret != 0 && basis_dir[0] != NULL) { int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx, itemizing, code); -@@ -1461,10 +1488,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, +@@ -1304,10 +1320,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, /* We need to ensure that the dirs in the transfer have writable * permissions during the time we are putting files within them. * This is then fixed after the transfer is done. */ @@ -267,7 +279,7 @@ diff --git a/generator.c b/generator.c rsyserr(FERROR_XFER, errno, "failed to modify permissions on %s", full_fname(fname)); -@@ -1499,6 +1531,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, +@@ -1342,6 +1363,10 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, file->mode = dest_mode(file->mode, sx.st.st_mode, dflt_perms, exists); } @@ -278,30 +290,30 @@ diff --git a/generator.c b/generator.c #ifdef SUPPORT_HARD_LINKS if (preserve_hard_links && F_HLINK_NOT_FIRST(file) -@@ -2024,13 +2060,17 @@ static void touch_up_dirs(struct file_list *flist, int ndx) +@@ -1919,13 +1944,17 @@ static void touch_up_dirs(struct file_list *flist, int ndx) continue; fname = f_name(file, NULL); - if (!(file->mode & S_IWUSR)) + if (fix_dir_perms) - do_chmod(fname, file->mode); + do_chmod(fname, file->mode, 0); if (need_retouch_dir_times) { STRUCT_STAT st; if (link_stat(fname, &st, 0) == 0 && cmp_time(st.st_mtime, file->modtime) != 0) -- set_modtime(fname, file->modtime, file->mode); -+ set_modtime(fname, file->modtime, file->mode, 0); +- set_modtime(fname, file->modtime, F_MOD_NSEC(file), file->mode); ++ set_modtime(fname, file->modtime, F_MOD_NSEC(file), file->mode, 0); } +#ifdef SUPPORT_FORCE_CHANGE + if (force_change && F_FFLAGS(file) & force_change) + undo_make_mutable(fname, F_FFLAGS(file)); +#endif - if (allowed_lull && !(counter % lull_mod)) - maybe_send_keepalive(); - else if (!(counter & 0xFF)) + if (counter >= loopchk_limit) { + if (allowed_lull) + maybe_send_keepalive(time(NULL), MSK_ALLOW_FLUSH); diff --git a/log.c b/log.c --- a/log.c +++ b/log.c -@@ -650,7 +650,7 @@ static void log_formatted(enum logcode code, const char *format, const char *op, +@@ -733,7 +733,7 @@ static void log_formatted(enum logcode code, const char *format, const char *op, c[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p'; c[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o'; c[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g'; @@ -321,15 +333,15 @@ diff --git a/options.c b/options.c int preserve_executability = 0; int preserve_devices = 0; int preserve_specials = 0; -@@ -85,6 +86,7 @@ int implied_dirs = 1; - int numeric_ids = 0; +@@ -86,6 +87,7 @@ int numeric_ids = 0; + int msgs2stderr = 0; int allow_8bit_chars = 0; int force_delete = 0; +int force_change = 0; int io_timeout = 0; - int allowed_lull = 0; int prune_empty_dirs = 0; -@@ -225,6 +227,7 @@ static void print_rsync_version(enum logcode f) + int use_qsort = 0; +@@ -567,6 +569,7 @@ static void print_rsync_version(enum logcode f) char const *links = "no "; char const *iconv = "no "; char const *ipv6 = "no "; @@ -337,8 +349,8 @@ diff --git a/options.c b/options.c STRUCT_STAT *dumstat; #if SUBPROTOCOL_VERSION != 0 -@@ -257,6 +260,9 @@ static void print_rsync_version(enum logcode f) - #if defined HAVE_LUTIMES && defined HAVE_UTIMES +@@ -600,6 +603,9 @@ static void print_rsync_version(enum logcode f) + #ifdef CAN_SET_SYMLINK_TIMES symtimes = ""; #endif +#ifdef SUPPORT_FILEFLAGS @@ -347,7 +359,7 @@ diff --git a/options.c b/options.c rprintf(f, "%s version %s protocol version %d%s\n", RSYNC_NAME, RSYNC_VERSION, PROTOCOL_VERSION, subprotocol); -@@ -270,8 +276,8 @@ static void print_rsync_version(enum logcode f) +@@ -613,8 +619,8 @@ static void print_rsync_version(enum logcode f) (int)(sizeof (int64) * 8)); rprintf(f, " %ssocketpairs, %shardlinks, %ssymlinks, %sIPv6, batchfiles, %sinplace,\n", got_socketpair, hardlinks, links, ipv6, have_inplace); @@ -358,7 +370,7 @@ diff --git a/options.c b/options.c #ifdef MAINTAINER_MODE rprintf(f, "Panic Action: \"%s\"\n", get_panic_action()); -@@ -338,6 +344,9 @@ void usage(enum logcode F) +@@ -684,6 +690,9 @@ void usage(enum logcode F) rprintf(F," -K, --keep-dirlinks treat symlinked dir on receiver as dir\n"); rprintf(F," -H, --hard-links preserve hard links\n"); rprintf(F," -p, --perms preserve permissions\n"); @@ -368,9 +380,9 @@ diff --git a/options.c b/options.c rprintf(F," -E, --executability preserve the file's executability\n"); rprintf(F," --chmod=CHMOD affect file and/or directory permissions\n"); #ifdef SUPPORT_ACLS -@@ -375,7 +384,12 @@ void usage(enum logcode F) - rprintf(F," --delete-after receiver deletes after transfer, not during\n"); - rprintf(F," --delete-excluded also delete excluded files from destination dirs\n"); +@@ -723,7 +732,12 @@ void usage(enum logcode F) + rprintf(F," --ignore-missing-args ignore missing source args without error\n"); + rprintf(F," --delete-missing-args delete missing source args from destination\n"); rprintf(F," --ignore-errors delete even if there are I/O errors\n"); - rprintf(F," --force force deletion of directories even if not empty\n"); + rprintf(F," --force-delete force deletion of directories even if not empty\n"); @@ -382,7 +394,7 @@ diff --git a/options.c b/options.c rprintf(F," --max-delete=NUM don't delete more than NUM files\n"); rprintf(F," --max-size=SIZE don't transfer any file larger than SIZE\n"); rprintf(F," --min-size=SIZE don't transfer any file smaller than SIZE\n"); -@@ -480,6 +494,10 @@ static struct poptOption long_options[] = { +@@ -836,6 +850,10 @@ static struct poptOption long_options[] = { {"perms", 'p', POPT_ARG_VAL, &preserve_perms, 1, 0, 0 }, {"no-perms", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 }, {"no-p", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 }, @@ -393,7 +405,7 @@ diff --git a/options.c b/options.c {"executability", 'E', POPT_ARG_NONE, &preserve_executability, 0, 0, 0 }, {"acls", 'A', POPT_ARG_NONE, 0, 'A', 0, 0 }, {"no-acls", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 }, -@@ -558,6 +576,14 @@ static struct poptOption long_options[] = { +@@ -918,6 +936,14 @@ static struct poptOption long_options[] = { {"remove-source-files",0,POPT_ARG_VAL, &remove_source_files, 1, 0, 0 }, {"force", 0, POPT_ARG_VAL, &force_delete, 1, 0, 0 }, {"no-force", 0, POPT_ARG_VAL, &force_delete, 0, 0, 0 }, @@ -408,7 +420,7 @@ diff --git a/options.c b/options.c {"ignore-errors", 0, POPT_ARG_VAL, &ignore_errors, 1, 0, 0 }, {"no-ignore-errors", 0, POPT_ARG_VAL, &ignore_errors, 0, 0, 0 }, {"max-delete", 0, POPT_ARG_INT, &max_delete, 0, 0, 0 }, -@@ -1852,6 +1878,9 @@ void server_options(char **args, int *argc_p) +@@ -2435,6 +2461,9 @@ void server_options(char **args, int *argc_p) if (xfer_dirs && !recurse && delete_mode && am_sender) args[ac++] = "--no-r"; @@ -418,7 +430,7 @@ diff --git a/options.c b/options.c if (do_compression && def_compress_level != Z_DEFAULT_COMPRESSION) { if (asprintf(&arg, "--compress-level=%d", def_compress_level) < 0) goto oom; -@@ -1939,6 +1968,16 @@ void server_options(char **args, int *argc_p) +@@ -2522,6 +2551,16 @@ void server_options(char **args, int *argc_p) args[ac++] = "--delete-excluded"; if (force_delete) args[ac++] = "--force"; @@ -438,7 +450,7 @@ diff --git a/options.c b/options.c diff --git a/rsync.c b/rsync.c --- a/rsync.c +++ b/rsync.c -@@ -32,6 +32,7 @@ extern int dry_run; +@@ -31,6 +31,7 @@ extern int dry_run; extern int preserve_acls; extern int preserve_xattrs; extern int preserve_perms; @@ -446,7 +458,7 @@ diff --git a/rsync.c b/rsync.c extern int preserve_executability; extern int preserve_times; extern int am_root; -@@ -374,6 +375,39 @@ mode_t dest_mode(mode_t flist_mode, mode_t stat_mode, int dflt_perms, +@@ -445,6 +446,39 @@ mode_t dest_mode(mode_t flist_mode, mode_t stat_mode, int dflt_perms, return new_mode; } @@ -486,16 +498,16 @@ diff --git a/rsync.c b/rsync.c int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, const char *fnamecmp, int flags) { -@@ -427,7 +461,7 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, +@@ -493,7 +527,7 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, flags |= ATTRS_SKIP_MTIME; if (!(flags & ATTRS_SKIP_MTIME) && cmp_time(sxp->st.st_mtime, file->modtime) != 0) { -- int ret = set_modtime(fname, file->modtime, sxp->st.st_mode); -+ int ret = set_modtime(fname, file->modtime, sxp->st.st_mode, ST_FLAGS(sxp->st)); +- int ret = set_modtime(fname, file->modtime, F_MOD_NSEC(file), sxp->st.st_mode); ++ int ret = set_modtime(fname, file->modtime, F_MOD_NSEC(file), sxp->st.st_mode, ST_FLAGS(sxp->st)); if (ret < 0) { rsyserr(FERROR_XFER, errno, "failed to set times on %s", full_fname(fname)); -@@ -463,7 +497,8 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, +@@ -529,7 +563,8 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, if (am_root >= 0) { if (do_lchown(fname, change_uid ? (uid_t)F_OWNER(file) : sxp->st.st_uid, @@ -505,7 +517,7 @@ diff --git a/rsync.c b/rsync.c /* We shouldn't have attempted to change uid * or gid unless have the privilege. */ rsyserr(FERROR_XFER, errno, "%s %s failed", -@@ -495,7 +530,7 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, +@@ -563,7 +598,7 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, #ifdef HAVE_CHMOD if (!BITS_EQUAL(sxp->st.st_mode, new_mode, CHMOD_BITS)) { @@ -514,7 +526,7 @@ diff --git a/rsync.c b/rsync.c if (ret < 0) { rsyserr(FERROR_XFER, errno, "failed to set permissions on %s", -@@ -507,6 +542,19 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, +@@ -575,6 +610,19 @@ int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, } #endif @@ -531,10 +543,10 @@ diff --git a/rsync.c b/rsync.c + } +#endif + - if (verbose > 1 && flags & ATTRS_REPORT) { + if (INFO_GTE(NAME, 2) && flags & ATTRS_REPORT) { if (updated) rprintf(FCLIENT, "%s\n", fname); -@@ -569,7 +617,8 @@ int finish_transfer(const char *fname, const char *fnametmp, +@@ -639,7 +687,8 @@ int finish_transfer(const char *fname, const char *fnametmp, /* Change permissions before putting the file into place. */ set_file_attrs(fnametmp, file, NULL, fnamecmp, @@ -543,8 +555,8 @@ diff --git a/rsync.c b/rsync.c + | (ok_to_set_time ? 0 : ATTRS_SKIP_MTIME)); /* move tmp file over real file */ - if (verbose > 2) -@@ -588,6 +637,10 @@ int finish_transfer(const char *fname, const char *fnametmp, + if (DEBUG_GTE(RECV, 1)) +@@ -658,6 +707,10 @@ int finish_transfer(const char *fname, const char *fnametmp, } if (ret == 0) { /* The file was moved into place (not copied), so it's done. */ @@ -558,15 +570,15 @@ diff --git a/rsync.c b/rsync.c diff --git a/rsync.h b/rsync.h --- a/rsync.h +++ b/rsync.h -@@ -60,6 +60,7 @@ - #define XMIT_RDEV_MINOR_8_pre30 (1<<11) /* protocols 28 - 29 */ - #define XMIT_GROUP_NAME_FOLLOWS (1<<11) /* protocols 30 - now */ +@@ -62,6 +62,7 @@ #define XMIT_HLINK_FIRST (1<<12) /* protocols 30 - now (HLINKED files only) */ + #define XMIT_IO_ERROR_ENDLIST (1<<12) /* protocols 31 - now (w/XMIT_EXTENDED_FLAGS) */ + #define XMIT_MOD_NSEC (1<<13) /* protocols 31 - now */ +#define XMIT_SAME_FLAGS (1<<14) /* protocols ?? - now */ /* These flags are used in the live flist data. */ -@@ -152,6 +153,7 @@ +@@ -160,6 +161,7 @@ #define ATTRS_REPORT (1<<0) #define ATTRS_SKIP_MTIME (1<<1) @@ -574,7 +586,7 @@ diff --git a/rsync.h b/rsync.h #define FULL_FLUSH 1 #define NORMAL_FLUSH 0 -@@ -178,6 +180,7 @@ +@@ -186,6 +188,7 @@ #define ITEM_REPORT_GROUP (1<<6) #define ITEM_REPORT_ACL (1<<7) #define ITEM_REPORT_XATTR (1<<8) @@ -582,7 +594,7 @@ diff --git a/rsync.h b/rsync.h #define ITEM_BASIS_TYPE_FOLLOWS (1<<11) #define ITEM_XNAME_FOLLOWS (1<<12) #define ITEM_IS_NEW (1<<13) -@@ -458,6 +461,28 @@ typedef unsigned int size_t; +@@ -498,6 +501,28 @@ typedef unsigned int size_t; #endif #endif @@ -611,7 +623,7 @@ diff --git a/rsync.h b/rsync.h /* Find a variable that is either exactly 32-bits or longer. * If some code depends on 32-bit truncation, it will need to * take special action in a "#if SIZEOF_INT32 > 4" section. */ -@@ -626,6 +651,7 @@ extern int file_extra_cnt; +@@ -668,6 +693,7 @@ extern int file_extra_cnt; extern int inc_recurse; extern int uid_ndx; extern int gid_ndx; @@ -619,7 +631,7 @@ diff --git a/rsync.h b/rsync.h extern int acls_ndx; extern int xattrs_ndx; -@@ -663,6 +689,11 @@ extern int xattrs_ndx; +@@ -709,6 +735,11 @@ extern int xattrs_ndx; /* When the associated option is on, all entries will have these present: */ #define F_OWNER(f) REQ_EXTRA(f, uid_ndx)->unum #define F_GROUP(f) REQ_EXTRA(f, gid_ndx)->unum @@ -634,7 +646,7 @@ diff --git a/rsync.h b/rsync.h diff --git a/rsync.yo b/rsync.yo --- a/rsync.yo +++ b/rsync.yo -@@ -338,6 +338,7 @@ to the detailed description below for a complete description. verb( +@@ -345,6 +345,7 @@ to the detailed description below for a complete description. verb( -K, --keep-dirlinks treat symlinked dir on receiver as dir -H, --hard-links preserve hard links -p, --perms preserve permissions @@ -642,9 +654,9 @@ diff --git a/rsync.yo b/rsync.yo -E, --executability preserve executability --chmod=CHMOD affect file and/or directory permissions -A, --acls preserve ACLs (implies -p) -@@ -369,7 +370,10 @@ to the detailed description below for a complete description. verb( - --delete-after receiver deletes after transfer, not before - --delete-excluded also delete excluded files from dest dirs +@@ -378,7 +379,10 @@ to the detailed description below for a complete description. verb( + --ignore-missing-args ignore missing source args without error + --delete-missing-args delete missing source args from destination --ignore-errors delete even if there are I/O errors - --force force deletion of dirs even if not empty + --force-delete force deletion of dirs even if not empty @@ -654,7 +666,7 @@ diff --git a/rsync.yo b/rsync.yo --max-delete=NUM don't delete more than NUM files --max-size=SIZE don't transfer any file larger than SIZE --min-size=SIZE don't transfer any file smaller than SIZE -@@ -540,7 +544,8 @@ specified, in which case bf(-r) is not implied. +@@ -595,7 +599,8 @@ specified, in which case bf(-r) is not implied. Note that bf(-a) bf(does not preserve hardlinks), because finding multiply-linked files is expensive. You must separately @@ -664,7 +676,7 @@ diff --git a/rsync.yo b/rsync.yo dit(--no-OPTION) You may turn off one or more implied options by prefixing the option name with "no-". Not all options may be prefixed with a "no-": -@@ -798,7 +803,7 @@ they would be using bf(--copy-links). +@@ -876,7 +881,7 @@ they would be using bf(--copy-links). Without this option, if the sending side has replaced a directory with a symlink to a directory, the receiving side will delete anything that is in the way of the new symlink, including a directory hierarchy (as long as @@ -673,9 +685,9 @@ diff --git a/rsync.yo b/rsync.yo See also bf(--keep-dirlinks) for an analogous option for the receiving side. -@@ -935,6 +940,29 @@ super-user copies all namespaces except system.*. A normal user only copies - the user.* namespace. To be able to backup and restore non-user namespaces as - a normal user, see the bf(--fake-super) option. +@@ -1017,6 +1022,29 @@ Note that this option does not copy rsyncs special xattr values (e.g. those + used by bf(--fake-super)) unless you repeat the option (e.g. -XX). This + "copy all xattrs" mode cannot be used with bf(--fake-super). +dit(bf(--fileflags)) This option causes rsync to update the file-flags to be +the same as the source files and directories (if your OS supports the @@ -702,8 +714,8 @@ diff --git a/rsync.yo b/rsync.yo + dit(bf(--chmod)) This option tells rsync to apply one or more comma-separated "chmod" strings to the permission of the files in the - transfer. The resulting value is treated as though it was the permissions -@@ -1190,12 +1218,13 @@ See bf(--delete) (which is implied) for more details on file-deletion. + transfer. The resulting value is treated as though it were the permissions +@@ -1305,12 +1333,13 @@ display as a "*missing" entry in the bf(--list-only) output. dit(bf(--ignore-errors)) Tells bf(--delete) to go ahead and delete files even when there are I/O errors. @@ -720,7 +732,7 @@ diff --git a/rsync.yo b/rsync.yo bf(--recursive) option was also enabled. dit(bf(--max-delete=NUM)) This tells rsync not to delete more than NUM -@@ -1651,7 +1680,7 @@ with older versions of rsync, but that also turns on the output of other +@@ -1893,7 +1922,7 @@ with older versions of rsync, but that also turns on the output of other verbose messages). The "%i" escape has a cryptic output that is 11 letters long. The general @@ -729,7 +741,7 @@ diff --git a/rsync.yo b/rsync.yo type of update being done, bf(X) is replaced by the file-type, and the other letters represent attributes that may be output if they are being modified. -@@ -1707,7 +1736,7 @@ quote(itemization( +@@ -1949,7 +1978,7 @@ quote(itemization( sender's value (requires bf(--owner) and super-user privileges). it() A bf(g) means the group is different and is being updated to the sender's value (requires bf(--group) and the authority to set the group). @@ -741,15 +753,15 @@ diff --git a/rsync.yo b/rsync.yo diff --git a/syscall.c b/syscall.c --- a/syscall.c +++ b/syscall.c -@@ -33,6 +33,7 @@ extern int dry_run; - extern int am_root; +@@ -34,6 +34,7 @@ extern int am_root; + extern int am_sender; extern int read_only; extern int list_only; +extern int force_change; extern int preserve_perms; extern int preserve_executability; -@@ -50,7 +51,23 @@ int do_unlink(const char *fname) +@@ -51,7 +52,23 @@ int do_unlink(const char *fname) { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; @@ -773,8 +785,8 @@ diff --git a/syscall.c b/syscall.c + return -1; } - int do_symlink(const char *fname1, const char *fname2) -@@ -69,14 +86,37 @@ int do_link(const char *fname1, const char *fname2) + #ifdef SUPPORT_LINKS +@@ -112,14 +129,37 @@ int do_link(const char *fname1, const char *fname2) } #endif @@ -814,7 +826,7 @@ diff --git a/syscall.c b/syscall.c } int do_mknod(const char *pathname, mode_t mode, dev_t dev) -@@ -116,7 +156,7 @@ int do_mknod(const char *pathname, mode_t mode, dev_t dev) +@@ -159,7 +199,7 @@ int do_mknod(const char *pathname, mode_t mode, dev_t dev) return -1; close(sock); #ifdef HAVE_CHMOD @@ -823,7 +835,7 @@ diff --git a/syscall.c b/syscall.c #else return 0; #endif -@@ -133,7 +173,22 @@ int do_rmdir(const char *pathname) +@@ -176,7 +216,22 @@ int do_rmdir(const char *pathname) { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; @@ -847,7 +859,7 @@ diff --git a/syscall.c b/syscall.c } int do_open(const char *pathname, int flags, mode_t mode) -@@ -147,7 +202,7 @@ int do_open(const char *pathname, int flags, mode_t mode) +@@ -190,7 +245,7 @@ int do_open(const char *pathname, int flags, mode_t mode) } #ifdef HAVE_CHMOD @@ -856,10 +868,10 @@ diff --git a/syscall.c b/syscall.c { int code; if (dry_run) return 0; -@@ -168,17 +223,74 @@ int do_chmod(const char *path, mode_t mode) - #endif +@@ -213,17 +268,74 @@ int do_chmod(const char *path, mode_t mode) } else code = chmod(path, mode & CHMOD_BITS); /* DISCOURAGED FUNCTION */ + #endif /* !HAVE_LCHMOD */ +#ifdef SUPPORT_FORCE_CHANGE + if (code < 0 && force_change && errno == EPERM && !S_ISLNK(mode)) { + if (fileflags == NO_FFLAGS) { @@ -935,15 +947,15 @@ diff --git a/syscall.c b/syscall.c diff --git a/t_stub.c b/t_stub.c --- a/t_stub.c +++ b/t_stub.c -@@ -26,6 +26,7 @@ int module_id = -1; +@@ -25,6 +25,7 @@ int modify_window = 0; + int module_id = -1; int relative_paths = 0; - int human_readable = 0; int module_dirlen = 0; +int force_change = 0; int preserve_xattrs = 0; mode_t orig_umask = 002; - char *partial_dir; -@@ -89,3 +90,23 @@ struct filter_list_struct daemon_filter_list; + char number_separator = ','; +@@ -84,3 +85,23 @@ filter_rule_list daemon_filter_list; { return "tester"; } @@ -970,37 +982,53 @@ diff --git a/t_stub.c b/t_stub.c diff --git a/util.c b/util.c --- a/util.c +++ b/util.c -@@ -29,6 +29,7 @@ extern int module_id; +@@ -30,6 +30,7 @@ extern int module_id; extern int modify_window; extern int relative_paths; - extern int human_readable; -+extern int force_change; extern int preserve_xattrs; ++extern int force_change; extern char *module_dir; extern unsigned int module_dirlen; + extern mode_t orig_umask; @@ -123,7 +124,7 @@ NORETURN void overflow_exit(const char *str) exit_cleanup(RERR_MALLOC); } --int set_modtime(const char *fname, time_t modtime, mode_t mode) -+int set_modtime(const char *fname, time_t modtime, mode_t mode, uint32 fileflags) +-int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode) ++int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode, uint32 fileflags) { - #if !defined HAVE_LUTIMES || !defined HAVE_UTIMES + #ifndef CAN_SET_SYMLINK_TIMES if (S_ISLNK(mode)) -@@ -140,6 +141,7 @@ int set_modtime(const char *fname, time_t modtime, mode_t mode) +@@ -140,15 +141,14 @@ int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode) return 0; { + int ret; - #ifdef HAVE_UTIMES + #ifdef HAVE_UTIMENSAT + struct timespec t[2]; + t[0].tv_sec = 0; + t[0].tv_nsec = UTIME_NOW; + t[1].tv_sec = modtime; + t[1].tv_nsec = mod_nsec; +- if (utimensat(AT_FDCWD, fname, t, AT_SYMLINK_NOFOLLOW) < 0) +- return S_ISLNK(mode) && errno == ENOSYS ? 1 : -1; +- return 0; ++#define SET_THE_TIME(fn) utimensat(AT_FDCWD, fn, t, AT_SYMLINK_NOFOLLOW) + #elif defined HAVE_UTIMES || defined HAVE_LUTIMES struct timeval t[2]; t[0].tv_sec = time(NULL); -@@ -153,20 +155,39 @@ int set_modtime(const char *fname, time_t modtime, mode_t mode) - return 0; - } - # endif +@@ -156,25 +156,44 @@ int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode) + t[1].tv_sec = modtime; + t[1].tv_usec = mod_nsec / 1000; + # ifdef HAVE_LUTIMES +- if (lutimes(fname, t) < 0) +- return S_ISLNK(mode) && errno == ENOSYS ? 1 : -1; +- return 0; ++#define SET_THE_TIME(fn) lutimes(fn, t) + # else - return utimes(fname, t); +#define SET_THE_TIME(fn) utimes(fn, t) + # endif #elif defined HAVE_STRUCT_UTIMBUF struct utimbuf tbuf; tbuf.actime = time(NULL); @@ -1017,6 +1045,8 @@ diff --git a/util.c b/util.c #error No file-time-modification routine found! #endif + ret = SET_THE_TIME(fname); ++ if (ret != 0 && S_ISLNK(mode) && errno == ENOSYS) ++ return 1; +#ifdef SUPPORT_FORCE_CHANGE + if (ret != 0 && force_change && errno == EPERM) { + if (fileflags == NO_FFLAGS) { @@ -1041,35 +1071,12 @@ diff --git a/util.c b/util.c diff --git a/xattrs.c b/xattrs.c --- a/xattrs.c +++ b/xattrs.c -@@ -281,6 +281,10 @@ int get_xattr(const char *fname, stat_x *sxp) - { - sxp->xattr = new(item_list); - *sxp->xattr = empty_xattr; -+ -+ if (IS_SPECIAL(sxp->st.st_mode) || IS_DEVICE(sxp->st.st_mode)) -+ return 0; -+ - if (rsync_xal_get(fname, sxp->xattr) < 0) { - free_xattr(sxp); - return -1; -@@ -856,6 +860,11 @@ int set_xattr(const char *fname, const struct file_struct *file, - return -1; - } - -+ if (IS_SPECIAL(sxp->st.st_mode) || IS_DEVICE(sxp->st.st_mode)) { -+ errno = ENOTSUP; -+ return -1; -+ } -+ - ndx = F_XATTR(file); - return rsync_xal_set(fname, lst + ndx, fnamecmp, sxp); - } -@@ -972,7 +981,7 @@ int set_stat_xattr(const char *fname, struct file_struct *file, mode_t new_mode) +@@ -1033,7 +1033,7 @@ int set_stat_xattr(const char *fname, struct file_struct *file, mode_t new_mode) mode = (fst.st_mode & _S_IFMT) | (fmode & ACCESSPERMS) | (S_ISDIR(fst.st_mode) ? 0700 : 0600); if (fst.st_mode != mode) - do_chmod(fname, mode); + do_chmod(fname, mode, ST_FLAGS(fst)); - if (!IS_DEVICE(fst.st_mode) && !IS_SPECIAL(fst.st_mode)) + if (!IS_DEVICE(fst.st_mode)) fst.st_rdev = 0; /* just in case */