X-Git-Url: https://mattmccutchen.net/rsync/rsync-patches.git/blobdiff_plain/6fa0767f0e3c9ec869f45f647d7018f37dc7410b..4c15e80040f6ac2fc79d599d1722cf209cc30536:/detect-renamed.diff diff --git a/detect-renamed.diff b/detect-renamed.diff index a6c17d1..90f3803 100644 --- a/detect-renamed.diff +++ b/detect-renamed.diff @@ -32,8 +32,9 @@ TODO: a file that can't use it, while missing out on giving it to a file that could use it. ---- old/compat.c -+++ new/compat.c +diff --git a/compat.c b/compat.c +--- a/compat.c ++++ b/compat.c @@ -41,6 +41,7 @@ extern int checksum_seed; extern int basis_dir_cnt; extern int prune_empty_dirs; @@ -42,17 +43,17 @@ TODO: extern int protect_args; extern int preserve_uid; extern int preserve_gid; -@@ -218,7 +219,7 @@ void setup_protocol(int f_out,int f_in) - } else if (protocol_version >= 30) { - if (recurse && allow_inc_recurse - && !delete_before && !delete_after && !delay_updates -- && !use_qsort && !prune_empty_dirs) -+ && !use_qsort && !prune_empty_dirs && !detect_renamed) - inc_recurse = 1; - need_messages_from_generator = 1; - } ---- old/flist.c -+++ new/flist.c +@@ -107,6 +108,7 @@ void set_allow_inc_recurse(void) + allow_inc_recurse = 0; + else if (!am_sender + && (delete_before || delete_after ++ || detect_renamed + || delay_updates || prune_empty_dirs)) + allow_inc_recurse = 0; + else if (am_server && !local_server +diff --git a/flist.c b/flist.c +--- a/flist.c ++++ b/flist.c @@ -61,6 +61,7 @@ extern int non_perishable_cnt; extern int prune_empty_dirs; extern int copy_links; @@ -60,8 +61,8 @@ TODO: +extern int detect_renamed; extern int protocol_version; extern int sanitize_paths; - extern struct stats stats; -@@ -113,6 +114,8 @@ static int64 tmp_dev, tmp_ino; + extern int munge_symlinks; +@@ -118,6 +119,8 @@ static int64 tmp_dev, tmp_ino; #endif static char tmp_sum[MAX_DIGEST_LEN]; @@ -70,7 +71,7 @@ TODO: static char empty_sum[MAX_DIGEST_LEN]; static int flist_count_offset; /* for --delete --progress */ static int dir_count = 0; -@@ -252,6 +255,45 @@ static int is_excluded(char *fname, int +@@ -261,6 +264,45 @@ static int is_excluded(char *fname, int is_dir, int filter_level) return 0; } @@ -116,9 +117,9 @@ TODO: static void send_directory(int f, struct file_list *flist, char *fbuf, int len, int flags); -@@ -2154,6 +2196,25 @@ struct file_list *recv_file_list(int f) +@@ -2167,6 +2209,25 @@ struct file_list *recv_file_list(int f) - clean_flist(flist, relative_paths); + flist_sort_and_clean(flist, relative_paths); + if (detect_renamed) { + int j = flist->used; @@ -142,8 +143,9 @@ TODO: if (protocol_version < 30) { /* Recv the io_error flag */ if (ignore_errors) ---- old/generator.c -+++ new/generator.c +diff --git a/generator.c b/generator.c +--- a/generator.c ++++ b/generator.c @@ -79,6 +79,7 @@ extern char *basis_dir[]; extern int compare_dest; extern int copy_dest; @@ -152,15 +154,15 @@ TODO: extern int whole_file; extern int list_only; extern int read_batch; -@@ -95,6 +96,7 @@ extern char *backup_suffix; +@@ -96,6 +97,7 @@ extern char *backup_suffix; extern int backup_suffix_len; extern struct file_list *cur_flist, *first_flist, *dir_flist; extern struct filter_list_struct server_filter_list; +extern struct file_list the_fattr_list; - #ifdef ICONV_OPTION - extern int ic_ndx; - #endif -@@ -105,6 +107,7 @@ int maybe_ATTRS_REPORT = 0; + + int ignore_perishable = 0; + int non_perishable_cnt = 0; +@@ -103,6 +105,7 @@ int maybe_ATTRS_REPORT = 0; static dev_t dev_zero; static int deletion_count = 0; /* used to implement --max-delete */ @@ -168,7 +170,7 @@ TODO: static int deldelay_size = 0, deldelay_cnt = 0; static char *deldelay_buf = NULL; static int deldelay_fd = -1; -@@ -114,7 +117,8 @@ static int need_retouch_dir_times; +@@ -112,7 +115,8 @@ static int need_retouch_dir_times; static int need_retouch_dir_perms; static const char *solo_file = NULL; @@ -178,7 +180,7 @@ TODO: #define DEL_RECURSE (1<<1) /* recurse */ #define DEL_DIR_IS_EMPTY (1<<2) /* internal delete_FUNCTIONS use only */ -@@ -136,11 +140,121 @@ static int is_backup_file(char *fn) +@@ -134,11 +138,121 @@ static int is_backup_file(char *fn) return k > 0 && strcmp(fn+k, backup_suffix) == 0; } @@ -300,7 +302,7 @@ TODO: */ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags) { -@@ -162,6 +276,8 @@ static enum delret delete_item(char *fbu +@@ -160,6 +274,8 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags) goto check_ret; /* OK: try to delete the directory. */ } @@ -309,7 +311,7 @@ TODO: if (!replace && max_delete >= 0 && ++deletion_count > max_delete) return DR_AT_LIMIT; -@@ -208,6 +324,8 @@ static enum delret delete_item(char *fbu +@@ -206,6 +322,8 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags) * its contents, otherwise just checks for content. Returns DR_SUCCESS or * DR_NOT_EMPTY. Note that fname must point to a MAXPATHLEN buffer! (The * buffer is used for recursion, but returned unchanged.) @@ -318,7 +320,7 @@ TODO: */ static enum delret delete_dir_contents(char *fname, int flags) { -@@ -227,7 +345,9 @@ static enum delret delete_dir_contents(c +@@ -225,7 +343,9 @@ static enum delret delete_dir_contents(char *fname, int flags) save_filters = push_local_filters(fname, dlen); non_perishable_cnt = 0; @@ -328,7 +330,7 @@ TODO: ret = non_perishable_cnt ? DR_NOT_EMPTY : DR_SUCCESS; if (!dirlist->used) -@@ -264,6 +384,8 @@ static enum delret delete_dir_contents(c +@@ -262,6 +382,8 @@ static enum delret delete_dir_contents(char *fname, int flags) if (S_ISDIR(fp->mode) && delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS) ret = DR_NOT_EMPTY; @@ -337,7 +339,7 @@ TODO: if (delete_item(fname, fp->mode, NULL, flags) != DR_SUCCESS) ret = DR_NOT_EMPTY; } -@@ -416,13 +538,18 @@ static void do_delayed_deletions(char *d +@@ -414,13 +536,18 @@ static void do_delayed_deletions(char *delbuf) * all the --delete-WHEN options. Note that the fbuf pointer must point to a * MAXPATHLEN buffer with the name of the directory in it (the functions we * call will append names onto the end, but the old dir value will be restored @@ -360,7 +362,7 @@ TODO: if (!fbuf) { change_local_filter_dir(NULL, 0, 0); -@@ -432,21 +559,28 @@ static void delete_in_dir(char *fbuf, st +@@ -430,21 +557,28 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev) if (verbose > 2) rprintf(FINFO, "delete_in_dir(%s)\n", fbuf); @@ -394,7 +396,7 @@ TODO: if (one_file_system) { if (file->flags & FLAG_TOP_DIR) filesystem_dev = *fs_dev; -@@ -456,6 +590,14 @@ static void delete_in_dir(char *fbuf, st +@@ -454,6 +588,14 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev) dirlist = get_dirlist(fbuf, dlen, 0); @@ -409,7 +411,7 @@ TODO: /* If an item in dirlist is not found in flist, delete it * from the filesystem. */ for (i = dirlist->used; i--; ) { -@@ -468,16 +610,25 @@ static void delete_in_dir(char *fbuf, st +@@ -466,16 +608,25 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev) f_name(fp, NULL)); continue; } @@ -438,7 +440,7 @@ TODO: flist_free(dirlist); } -@@ -507,9 +658,9 @@ static void do_delete_pass(void) +@@ -505,9 +656,9 @@ static void do_delete_pass(void) || !S_ISDIR(st.st_mode)) continue; @@ -450,7 +452,7 @@ TODO: if (do_progress && !am_server) rprintf(FINFO, " \r"); -@@ -1101,6 +1252,7 @@ static void list_file_entry(struct file_ +@@ -1137,6 +1288,7 @@ static void list_file_entry(struct file_struct *f) } } @@ -458,7 +460,7 @@ TODO: static int phase = 0; static int dflt_perms; -@@ -1345,8 +1497,12 @@ static void recv_generator(char *fname, +@@ -1381,8 +1533,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, } } else if (delete_during && f_out != -1 && !phase && dry_run < 2 @@ -473,7 +475,7 @@ TODO: goto cleanup; } -@@ -1624,8 +1780,14 @@ static void recv_generator(char *fname, +@@ -1660,8 +1816,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx, goto cleanup; } #endif @@ -486,10 +488,10 @@ TODO: + } goto notify_others; + } - rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s", + rsyserr(FERROR_XFER, stat_errno, "recv_generator: failed to stat %s", full_fname(fname)); goto cleanup; -@@ -1961,6 +2123,12 @@ void generate_files(int f_out, const cha +@@ -2004,6 +2166,12 @@ void generate_files(int f_out, const char *local_name) if (verbose > 2) rprintf(FINFO, "generator starting pid=%ld\n", (long)getpid()); @@ -502,7 +504,7 @@ TODO: if (delete_before && !solo_file && cur_flist->used > 0) do_delete_pass(); if (delete_during == 2) { -@@ -1971,7 +2139,7 @@ void generate_files(int f_out, const cha +@@ -2014,7 +2182,7 @@ void generate_files(int f_out, const char *local_name) } do_progress = 0; @@ -511,7 +513,7 @@ TODO: whole_file = 0; if (verbose >= 2) { rprintf(FINFO, "delta-transmission %s\n", -@@ -2009,7 +2177,7 @@ void generate_files(int f_out, const cha +@@ -2052,7 +2220,7 @@ void generate_files(int f_out, const char *local_name) dirdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)); } else dirdev = MAKEDEV(0, 0); @@ -520,7 +522,7 @@ TODO: } } } -@@ -2054,7 +2222,21 @@ void generate_files(int f_out, const cha +@@ -2095,7 +2263,21 @@ void generate_files(int f_out, const char *local_name) } while ((cur_flist = cur_flist->next) != NULL); if (delete_during) @@ -543,9 +545,10 @@ TODO: phase++; if (verbose > 2) rprintf(FINFO, "generate_files phase=%d\n", phase); ---- old/options.c -+++ new/options.c -@@ -80,6 +80,7 @@ int am_generator = 0; +diff --git a/options.c b/options.c +--- a/options.c ++++ b/options.c +@@ -81,6 +81,7 @@ int am_generator = 0; int am_starting_up = 1; int relative_paths = -1; int implied_dirs = 1; @@ -553,7 +556,7 @@ TODO: int numeric_ids = 0; int allow_8bit_chars = 0; int force_delete = 0; -@@ -383,6 +384,7 @@ void usage(enum logcode F) +@@ -386,6 +387,7 @@ void usage(enum logcode F) rprintf(F," --modify-window=NUM compare mod-times with reduced accuracy\n"); rprintf(F," -T, --temp-dir=DIR create temporary files in directory DIR\n"); rprintf(F," -y, --fuzzy find similar file for basis if no dest file\n"); @@ -561,7 +564,7 @@ TODO: rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n"); rprintf(F," --copy-dest=DIR ... and include copies of unchanged files\n"); rprintf(F," --link-dest=DIR hardlink to files in DIR when unchanged\n"); -@@ -561,6 +563,7 @@ static struct poptOption long_options[] +@@ -564,6 +566,7 @@ static struct poptOption long_options[] = { {"compare-dest", 0, POPT_ARG_STRING, 0, OPT_COMPARE_DEST, 0, 0 }, {"copy-dest", 0, POPT_ARG_STRING, 0, OPT_COPY_DEST, 0, 0 }, {"link-dest", 0, POPT_ARG_STRING, 0, OPT_LINK_DEST, 0, 0 }, @@ -569,7 +572,7 @@ TODO: {"fuzzy", 'y', POPT_ARG_NONE, &fuzzy_basis, 0, 0, 0 }, {"compress", 'z', POPT_ARG_NONE, 0, 'z', 0, 0 }, {"no-compress", 0, POPT_ARG_VAL, &do_compression, 0, 0, 0 }, -@@ -1532,7 +1535,7 @@ int parse_arguments(int *argc_p, const c +@@ -1541,7 +1544,7 @@ int parse_arguments(int *argc_p, const char ***argv_p, int frommain) inplace = 1; } @@ -578,7 +581,7 @@ TODO: partial_dir = tmp_partialdir; if (inplace) { -@@ -1541,6 +1544,7 @@ int parse_arguments(int *argc_p, const c +@@ -1550,6 +1553,7 @@ int parse_arguments(int *argc_p, const char ***argv_p, int frommain) snprintf(err_buf, sizeof err_buf, "--%s cannot be used with --%s\n", append_mode ? "append" : "inplace", @@ -586,19 +589,19 @@ TODO: delay_updates ? "delay-updates" : "partial-dir"); return 0; } -@@ -1890,6 +1894,9 @@ void server_options(char **args, int *ar - args[ac++] = arg; - } - } -+ /* Both sides need to know in case this disables incremental recursion. */ -+ if (detect_renamed) -+ args[ac++] = "--detect-renamed"; - - if (modify_window_set) { - if (asprintf(&arg, "--modify-window=%d", modify_window) < 0) ---- old/rsync.yo -+++ new/rsync.yo -@@ -384,6 +384,7 @@ to the detailed description below for a +@@ -1896,6 +1900,8 @@ void server_options(char **args, int *argc_p) + args[ac++] = "--super"; + if (size_only) + args[ac++] = "--size-only"; ++ if (detect_renamed) ++ args[ac++] = "--detect-renamed"; + } else { + if (skip_compress) { + if (asprintf(&arg, "--skip-compress=%s", skip_compress) < 0) +diff --git a/rsync.yo b/rsync.yo +--- a/rsync.yo ++++ b/rsync.yo +@@ -385,6 +385,7 @@ to the detailed description below for a complete description. verb( --modify-window=NUM compare mod-times with reduced accuracy -T, --temp-dir=DIR create temporary files in directory DIR -y, --fuzzy find similar file for basis if no dest file @@ -606,7 +609,7 @@ TODO: --compare-dest=DIR also compare received files relative to DIR --copy-dest=DIR ... and include copies of unchanged files --link-dest=DIR hardlink to files in DIR when unchanged -@@ -1424,6 +1425,21 @@ Note that the use of the bf(--delete) op +@@ -1451,6 +1452,21 @@ Note that the use of the bf(--delete) option might get rid of any potential fuzzy-match files, so either use bf(--delete-after) or specify some filename exclusions if you need to prevent this. @@ -628,9 +631,10 @@ TODO: dit(bf(--compare-dest=DIR)) This option instructs rsync to use em(DIR) on the destination machine as an additional hierarchy to compare destination files against doing transfers (if the files are missing in the destination ---- old/util.c -+++ new/util.c -@@ -1030,6 +1030,32 @@ int handle_partial_dir(const char *fname +diff --git a/util.c b/util.c +--- a/util.c ++++ b/util.c +@@ -1019,6 +1019,32 @@ int handle_partial_dir(const char *fname, int create) return 1; }