X-Git-Url: https://mattmccutchen.net/rsync/rsync-patches.git/blobdiff_plain/1071853f8d0ea561391a3d19e3606ff5ddb34991..a302c04819c87d365481d9a8b516d3c20df8bf46:/acls.diff

diff --git a/acls.diff b/acls.diff
index b237aba..c86aa66 100644
--- a/acls.diff
+++ b/acls.diff
@@ -21,9 +21,9 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +	lib/permstring.o lib/pool_alloc.o lib/sysacls.o @LIBOBJS@
  ZLIBOBJ=zlib/deflate.o zlib/inffast.o zlib/inflate.o zlib/inftrees.o \
  	zlib/trees.o zlib/zutil.o zlib/adler32.o zlib/compress.o zlib/crc32.o
- OBJS1=rsync.o generator.o receiver.o cleanup.o sender.o exclude.o util.o \
- 	main.o checksum.o match.o syscall.o log.o backup.o
- OBJS2=options.o flist.o io.o compat.o hlink.o token.o uidlist.o socket.o \
+ OBJS1=flist.o rsync.o generator.o receiver.o cleanup.o sender.o exclude.o \
+ 	util.o main.o checksum.o match.o syscall.o log.o backup.o
+ OBJS2=options.o io.o compat.o hlink.o token.o uidlist.o socket.o \
 -	fileio.o batch.o clientname.o chmod.o
 +	fileio.o batch.o clientname.o chmod.o acls.o
  OBJS3=progress.o pipe.o
@@ -31,7 +31,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  popt_OBJS=popt/findme.o  popt/popt.o  popt/poptconfig.o \
 --- old/acls.c
 +++ new/acls.c
-@@ -0,0 +1,1096 @@
+@@ -0,0 +1,1093 @@
 +/*
 + * Handle passing Access Control Lists between systems.
 + *
@@ -63,9 +63,6 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +extern int read_only;
 +extern int list_only;
 +extern int orig_umask;
-+extern int preserve_acls;
-+extern int flist_extra_ndx;
-+extern unsigned int file_struct_len;
 +
 +/* === ACL structures === */
 +
@@ -921,7 +918,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +#ifdef SMB_ACL_LOSES_SPECIAL_MODE_BITS
 +	/* Ensure that chmod() will be called to restore any lost setid bits. */
 +	if (old_mode & (S_ISUID | S_ISGID | S_ISVTX)
-+	 && (old_mode & CHMOD_BITS) == (mode & CHMOD_BITS))
++	 && BITS_EQUAL(old_mode, mode, CHMOD_BITS))
 +		old_mode &= ~(S_ISUID | S_ISGID | S_ISVTX);
 +#endif
 +
@@ -1221,9 +1218,20 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			/* If someone has hard-linked the file into the backup
  			 * dir, rename() might return success but do nothing! */
  			robust_unlink(fname); /* Just in case... */
+--- old/compat.c
++++ new/compat.c
+@@ -50,6 +50,8 @@ void setup_protocol(int f_out,int f_in)
+ 		preserve_uid = ++file_extra_cnt;
+ 	if (preserve_gid)
+ 		preserve_gid = ++file_extra_cnt;
++	if (preserve_acls && !am_sender)
++		preserve_acls = ++file_extra_cnt;
+ 
+ 	if (remote_protocol == 0) {
+ 		if (!read_batch)
 --- old/configure.in
 +++ new/configure.in
-@@ -537,6 +537,11 @@ if test x"$ac_cv_func_strcasecmp" = x"no
+@@ -542,6 +542,11 @@ if test x"$ac_cv_func_strcasecmp" = x"no
      AC_CHECK_LIB(resolv, strcasecmp)
  fi
  
@@ -1235,7 +1243,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  dnl At the moment we don't test for a broken memcmp(), because all we
  dnl need to do is test for equality, not comparison, and it seems that
  dnl every platform has a memcmp that can do at least that.
-@@ -801,6 +806,78 @@ AC_SUBST(OBJ_RESTORE)
+@@ -806,6 +811,78 @@ AC_SUBST(OBJ_RESTORE)
  AC_SUBST(CC_SHOBJ_FLAG)
  AC_SUBST(BUILD_POPT)
  
@@ -1316,7 +1324,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
 --- old/flist.c
 +++ new/flist.c
-@@ -40,6 +40,7 @@ extern int filesfrom_fd;
+@@ -41,6 +41,7 @@ extern int filesfrom_fd;
  extern int one_file_system;
  extern int copy_dirlinks;
  extern int keep_dirlinks;
@@ -1324,7 +1332,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  extern int preserve_links;
  extern int preserve_hard_links;
  extern int preserve_devices;
-@@ -144,6 +145,8 @@ static void list_file_entry(struct file_
+@@ -147,6 +148,8 @@ static void list_file_entry(struct file_
  	permstring(permbuf, f->mode);
  	len = F_LENGTH(f);
  
@@ -1333,21 +1341,21 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  #ifdef SUPPORT_LINKS
  	if (preserve_links && S_ISLNK(f->mode)) {
  		rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
-@@ -621,6 +624,12 @@ static struct file_struct *recv_file_ent
+@@ -662,6 +665,12 @@ static struct file_struct *recv_file_ent
  	}
  #endif
  
 +#ifdef SUPPORT_ACLS
 +	/* We need one or two index int32s when we're preserving ACLs. */
 +	if (preserve_acls)
-+		extra_len += (S_ISDIR(mode) ? 2 : 1) * sizeof (union flist_extras);
++		extra_len += (S_ISDIR(mode) ? 2 : 1) * EXTRA_LEN;
 +#endif
 +
  	if (always_checksum && S_ISREG(mode))
  		extra_len += SUM_EXTRA_CNT * EXTRA_LEN;
  
-@@ -733,6 +742,11 @@ static struct file_struct *recv_file_ent
- 		read_buf(f, bp, checksum_len);
+@@ -799,6 +808,11 @@ static struct file_struct *recv_file_ent
+ 			read_buf(f, bp, checksum_len);
  	}
  
 +#ifdef SUPPORT_ACLS
@@ -1358,8 +1366,8 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	return file;
  }
  
-@@ -993,6 +1007,9 @@ static struct file_struct *send_file_nam
- 					  unsigned short flags)
+@@ -1068,6 +1082,9 @@ static struct file_struct *send_file_nam
+ 					  int flags)
  {
  	struct file_struct *file;
 +#ifdef SUPPORT_ACLS
@@ -1368,7 +1376,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  	file = make_file(fname, flist, stp, flags,
  			 f == -2 ? SERVER_FILTERS : ALL_FILTERS);
-@@ -1002,11 +1019,24 @@ static struct file_struct *send_file_nam
+@@ -1077,12 +1094,26 @@ static struct file_struct *send_file_nam
  	if (chmod_modes && !S_ISLNK(file->mode))
  		file->mode = tweak_mode(file->mode, chmod_modes);
  
@@ -1385,11 +1393,14 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  	flist_expand(flist);
  	flist->files[flist->count++] = file;
- 	send_file_entry(file, f);
+-	if (f >= 0)
++	if (f >= 0) {
+ 		send_file_entry(file, f, flist->count - 1);
 +#ifdef SUPPORT_ACLS
-+	if (preserve_acls && f >= 0)
-+		send_acl(&sx, f);
++		if (preserve_acls)
++			send_acl(&sx, f);
 +#endif
++	}
  	return file;
  }
  
@@ -1411,16 +1422,15 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  extern char *backup_dir;
  extern char *backup_suffix;
  extern int backup_suffix_len;
-@@ -517,22 +519,27 @@ static void do_delete_pass(struct file_l
+@@ -518,21 +520,26 @@ static void do_delete_pass(struct file_l
  		rprintf(FINFO, "                    \r");
  }
  
 -int unchanged_attrs(struct file_struct *file, STRUCT_STAT *st)
 +int unchanged_attrs(struct file_struct *file, statx *sxp)
  {
- 	if (preserve_perms
--	 && (unsigned)(st->st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
-+	 && (unsigned)(sxp->st.st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
+-	if (preserve_perms && !BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
++	if (preserve_perms && !BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
  		return 0;
  
 -	if (am_root && preserve_uid && st->st_uid != F_UID(file))
@@ -1457,8 +1467,8 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 -		 || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
 +		 || (keep_time && cmp_time(file->modtime, sxp->st.st_mtime) != 0))
  			iflags |= ITEM_REPORT_TIME;
--		if ((unsigned)(st->st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
-+		if ((unsigned)(sxp->st.st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
+-		if (!BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
++		if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
  			iflags |= ITEM_REPORT_PERMS;
 -		if (preserve_uid && am_root && F_UID(file) != st->st_uid)
 +		if (preserve_uid && am_root && F_UID(file) != sxp->st.st_uid)
@@ -1474,16 +1484,16 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	} else
  		iflags |= ITEM_IS_NEW;
  
-@@ -807,7 +818,7 @@ void check_for_finished_hlinks(int itemi
+@@ -808,7 +819,7 @@ void check_for_finished_hlinks(int itemi
   * handling the file, -1 if no dest-linking occurred, or a non-negative
   * value if we found an alternate basis file. */
  static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
 -			 char *cmpbuf, STRUCT_STAT *stp, int itemizing,
 +			 char *cmpbuf, statx *sxp, int itemizing,
- 			 int maybe_ATTRS_REPORT, enum logcode code)
+ 			 enum logcode code)
  {
  	int best_match = -1;
-@@ -816,7 +827,7 @@ static int try_dests_reg(struct file_str
+@@ -817,7 +828,7 @@ static int try_dests_reg(struct file_str
  
  	do {
  		pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
@@ -1492,7 +1502,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			continue;
  		switch (match_level) {
  		case 0:
-@@ -824,16 +835,20 @@ static int try_dests_reg(struct file_str
+@@ -825,16 +836,20 @@ static int try_dests_reg(struct file_str
  			match_level = 1;
  			/* FALL THROUGH */
  		case 1:
@@ -1516,7 +1526,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				continue;
  			best_match = j;
  			match_level = 3;
-@@ -848,7 +863,7 @@ static int try_dests_reg(struct file_str
+@@ -849,7 +864,7 @@ static int try_dests_reg(struct file_str
  	if (j != best_match) {
  		j = best_match;
  		pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
@@ -1525,16 +1535,22 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			return -1;
  	}
  
-@@ -856,15 +871,20 @@ static int try_dests_reg(struct file_str
- #ifdef SUPPORT_HARD_LINKS
- 		if (link_dest) {
- 			int i = itemizing && (verbose > 1 || stdout_format_has_i > 1);
--			if (hard_link_one(file, ndx, fname, 0, stp,
-+			if (hard_link_one(file, ndx, fname, 0, sxp,
- 					  cmpbuf, 1, i, code) < 0)
+@@ -859,16 +874,25 @@ static int try_dests_reg(struct file_str
+ 			if (!hard_link_one(file, fname, cmpbuf, 1))
  				goto try_a_copy;
  			if (preserve_hard_links && F_IS_HLINKED(file))
- 				hard_link_cluster(file, ndx, itemizing, code, j);
+-				finish_hard_link(file, fname, stp, itemizing, code, j);
++				finish_hard_link(file, fname, &sxp->st, itemizing, code, j);
+ 			if (itemizing && (verbose > 1 || stdout_format_has_i > 1)) {
+-				itemize(file, ndx, 1, stp,
++#ifdef SUPPORT_ACLS
++				if (preserve_acls && !ACL_READY(*sxp))
++					get_acl(fname, sxp);
++#endif
++				itemize(file, ndx, 1, sxp,
+ 					ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
+ 					0, "");
+ 			}
  		} else
  #endif
 -		if (itemizing)
@@ -1546,10 +1562,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +#endif
 +			itemize(file, ndx, 0, sxp, 0, 0, NULL);
 +		}
- 		if (verbose > 1 && maybe_ATTRS_REPORT) {
+ 		if (verbose > 1 && maybe_ATTRS_REPORT)
  			rprintf(FCLIENT, "%s is uptodate\n", fname);
- 		}
-@@ -880,8 +900,13 @@ static int try_dests_reg(struct file_str
+ 		return -2;
+@@ -885,8 +909,13 @@ static int try_dests_reg(struct file_str
  			}
  			return -1;
  		}
@@ -1565,16 +1581,25 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		set_file_attrs(fname, file, NULL, 0);
  		if (maybe_ATTRS_REPORT
  		 && ((!itemizing && verbose && match_level == 2)
-@@ -904,7 +929,7 @@ static int try_dests_reg(struct file_str
+@@ -897,7 +926,7 @@ static int try_dests_reg(struct file_str
+ 		}
+ #ifdef SUPPORT_HARD_LINKS
+ 		if (preserve_hard_links && F_IS_HLINKED(file))
+-			finish_hard_link(file, fname, stp, itemizing, code, -1);
++			finish_hard_link(file, fname, &sxp->st, itemizing, code, -1);
+ #endif
+ 		return -2;
+ 	}
+@@ -909,7 +938,7 @@ static int try_dests_reg(struct file_str
   * handling the file, or -1 if no dest-linking occurred, or a non-negative
   * value if we found an alternate basis file. */
  static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 -			 char *cmpbuf, STRUCT_STAT *stp, int itemizing,
 +			 char *cmpbuf, statx *sxp, int itemizing,
- 			 int maybe_ATTRS_REPORT, enum logcode code)
+ 			 enum logcode code)
  {
  	char lnk[MAXPATHLEN];
-@@ -937,24 +962,24 @@ static int try_dests_non(struct file_str
+@@ -942,24 +971,24 @@ static int try_dests_non(struct file_str
  
  	do {
  		pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
@@ -1604,7 +1629,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				continue;
  			break;
  #endif
-@@ -969,7 +994,7 @@ static int try_dests_non(struct file_str
+@@ -974,7 +1003,7 @@ static int try_dests_non(struct file_str
  		case TYPE_SPECIAL:
  		case TYPE_DEVICE:
  			devp = F_RDEV_P(file);
@@ -1613,7 +1638,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				continue;
  			break;
  #ifdef SUPPORT_LINKS
-@@ -986,7 +1011,11 @@ static int try_dests_non(struct file_str
+@@ -991,7 +1020,11 @@ static int try_dests_non(struct file_str
  			match_level = 2;
  			best_match = j;
  		}
@@ -1626,7 +1651,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			match_level = 3;
  			best_match = j;
  			break;
-@@ -999,7 +1028,7 @@ static int try_dests_non(struct file_str
+@@ -1004,7 +1037,7 @@ static int try_dests_non(struct file_str
  	if (j != best_match) {
  		j = best_match;
  		pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
@@ -1635,7 +1660,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			return -1;
  	}
  
-@@ -1030,7 +1059,15 @@ static int try_dests_non(struct file_str
+@@ -1035,7 +1068,15 @@ static int try_dests_non(struct file_str
  			    : ITEM_LOCAL_CHANGE
  			     + (match_level == 3 ? ITEM_XNAME_FOLLOWS : 0);
  			char *lp = match_level == 3 ? "" : NULL;
@@ -1652,7 +1677,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		}
  		if (verbose > 1 && maybe_ATTRS_REPORT) {
  			rprintf(FCLIENT, "%s%s is uptodate\n",
-@@ -1043,6 +1080,7 @@ static int try_dests_non(struct file_str
+@@ -1048,6 +1089,7 @@ static int try_dests_non(struct file_str
  }
  
  static int phase = 0;
@@ -1660,7 +1685,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  /* Acts on the_file_list->file's ndx'th item, whose name is fname.  If a dir,
   * make sure it exists, and has the right permissions/timestamp info.  For
-@@ -1064,7 +1102,8 @@ static void recv_generator(char *fname, 
+@@ -1068,7 +1110,8 @@ static void recv_generator(char *fname, 
  	static int need_fuzzy_dirlist = 0;
  	struct file_struct *fuzzy_file = NULL;
  	int fd = -1, f_copy = -1;
@@ -1670,7 +1695,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	struct file_struct *back_file = NULL;
  	int statret, real_ret, stat_errno;
  	char *fnamecmp, *partialptr, *backupptr = NULL;
-@@ -1120,6 +1159,9 @@ static void recv_generator(char *fname, 
+@@ -1124,6 +1167,9 @@ static void recv_generator(char *fname, 
  		} else if (!dry_run)
  			return;
  	}
@@ -1680,7 +1705,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	if (dry_run > 1) {
  		statret = -1;
  		stat_errno = ENOENT;
-@@ -1127,7 +1169,7 @@ static void recv_generator(char *fname, 
+@@ -1131,7 +1177,7 @@ static void recv_generator(char *fname, 
  		const char *dn = file->dirname ? file->dirname : ".";
  		if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) {
  			if (relative_paths && !implied_dirs
@@ -1689,7 +1714,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			 && create_directory_path(fname) < 0) {
  				rsyserr(FERROR, errno,
  					"recv_generator: mkdir %s failed",
-@@ -1139,6 +1181,10 @@ static void recv_generator(char *fname, 
+@@ -1143,6 +1189,10 @@ static void recv_generator(char *fname, 
  			}
  			if (fuzzy_basis)
  				need_fuzzy_dirlist = 1;
@@ -1700,7 +1725,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		}
  		parent_dirname = dn;
  
-@@ -1148,7 +1194,7 @@ static void recv_generator(char *fname, 
+@@ -1152,7 +1202,7 @@ static void recv_generator(char *fname, 
  			need_fuzzy_dirlist = 0;
  		}
  
@@ -1709,7 +1734,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				    keep_dirlinks && S_ISDIR(file->mode));
  		stat_errno = errno;
  	}
-@@ -1166,8 +1212,9 @@ static void recv_generator(char *fname, 
+@@ -1170,8 +1220,9 @@ static void recv_generator(char *fname, 
  	 * mode based on the local permissions and some heuristics. */
  	if (!preserve_perms) {
  		int exists = statret == 0
@@ -1721,7 +1746,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	}
  
  	if (S_ISDIR(file->mode)) {
-@@ -1176,8 +1223,8 @@ static void recv_generator(char *fname, 
+@@ -1180,8 +1231,8 @@ static void recv_generator(char *fname, 
  		 * file of that name and it is *not* a directory, then
  		 * we need to delete it.  If it doesn't exist, then
  		 * (perhaps recursively) create it. */
@@ -1732,7 +1757,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				return;
  			statret = -1;
  		}
-@@ -1186,14 +1233,14 @@ static void recv_generator(char *fname, 
+@@ -1190,14 +1241,14 @@ static void recv_generator(char *fname, 
  			dry_run++;
  		}
  		real_ret = statret;
@@ -1746,10 +1771,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		if (statret != 0 && basis_dir[0] != NULL) {
 -			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
 +			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
- 					      itemizing, maybe_ATTRS_REPORT, code);
+ 					      itemizing, code);
  			if (j == -2) {
  				itemizing = 0;
-@@ -1202,7 +1249,11 @@ static void recv_generator(char *fname, 
+@@ -1206,7 +1257,11 @@ static void recv_generator(char *fname, 
  				statret = 1;
  		}
  		if (itemizing && f_out != -1) {
@@ -1762,7 +1787,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				statret ? ITEM_LOCAL_CHANGE : 0, 0, NULL);
  		}
  		if (real_ret != 0 && do_mkdir(fname,file->mode) < 0 && errno != EEXIST) {
-@@ -1222,22 +1273,22 @@ static void recv_generator(char *fname, 
+@@ -1226,21 +1281,21 @@ static void recv_generator(char *fname, 
  				return;
  			}
  		}
@@ -1782,16 +1807,15 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	}
  
  #ifdef SUPPORT_HARD_LINKS
- 	if (preserve_hard_links && F_IS_HLINKED(file)
--	    && hard_link_check(file, ndx, fname, statret, &st,
-+	    && hard_link_check(file, ndx, fname, statret, &sx,
- 			       itemizing, code, HL_CHECK_MASTER))
+ 	if (preserve_hard_links && F_HLINK_NOT_FIRST(file)
+-	 && hard_link_check(file, ndx, fname, statret, &st, itemizing, code))
 -		return;
++	 && hard_link_check(file, ndx, fname, statret, &sx, itemizing, code))
 +		goto cleanup;
  #endif
  
  	if (preserve_links && S_ISLNK(file->mode)) {
-@@ -1257,14 +1308,14 @@ static void recv_generator(char *fname, 
+@@ -1260,17 +1315,17 @@ static void recv_generator(char *fname, 
  			char lnk[MAXPATHLEN];
  			int len;
  
@@ -1808,8 +1832,12 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +				set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
  #ifdef SUPPORT_HARD_LINKS
  				if (preserve_hard_links && F_IS_HLINKED(file))
- 					hard_link_cluster(file, ndx, itemizing, code, -1);
-@@ -1275,10 +1326,10 @@ static void recv_generator(char *fname, 
+-					finish_hard_link(file, fname, &st, itemizing, code, -1);
++					finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
+ #endif
+ 				if (remove_source_files == 1)
+ 					goto return_with_success;
+@@ -1278,10 +1333,10 @@ static void recv_generator(char *fname, 
  			}
  			/* Not the right symlink (or not a symlink), so
  			 * delete it. */
@@ -1819,19 +1847,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		} else if (basis_dir[0] != NULL) {
 -			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
 +			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
- 					      itemizing, maybe_ATTRS_REPORT, code);
+ 					      itemizing, code);
  			if (j == -2) {
  #ifndef CAN_HARDLINK_SYMLINK
-@@ -1295,7 +1346,7 @@ static void recv_generator(char *fname, 
- 		}
- #ifdef SUPPORT_HARD_LINKS
- 		if (preserve_hard_links && F_IS_HLINKED(file)
--		    && hard_link_check(file, ndx, fname, -1, &st,
-+		    && hard_link_check(file, ndx, fname, -1, &sx,
- 				       itemizing, code, HL_SKIP))
- 			return;
- #endif
-@@ -1305,7 +1356,7 @@ static void recv_generator(char *fname, 
+@@ -1306,7 +1361,7 @@ static void recv_generator(char *fname, 
  		} else {
  			set_file_attrs(fname, file, NULL, 0);
  			if (itemizing) {
@@ -1840,7 +1859,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  					ITEM_LOCAL_CHANGE, 0, NULL);
  			}
  			if (code != FNONE && verbose)
-@@ -1331,33 +1382,38 @@ static void recv_generator(char *fname, 
+@@ -1332,33 +1387,38 @@ static void recv_generator(char *fname, 
  		if (statret == 0) {
  			char *t;
  			if (IS_DEVICE(file->mode)) {
@@ -1855,9 +1874,9 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  				t = "special file";
  			}
  			if (statret == 0
--			 && (unsigned)(st.st_mode & ~CHMOD_BITS) == (file->mode & ~CHMOD_BITS)
+-			 && BITS_EQUAL(st.st_mode, file->mode, _S_IFMT)
 -			 && st.st_rdev == rdev) {
-+			 && (unsigned)(sx.st.st_mode & ~CHMOD_BITS) == (file->mode & ~CHMOD_BITS)
++			 && BITS_EQUAL(sx.st.st_mode, file->mode, _S_IFMT)
 +			 && sx.st.st_rdev == rdev) {
  				/* The device or special file is identical. */
 -				if (itemizing)
@@ -1873,7 +1892,8 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +				set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
  #ifdef SUPPORT_HARD_LINKS
  				if (preserve_hard_links && F_IS_HLINKED(file))
- 					hard_link_cluster(file, ndx, itemizing, code, -1);
+-					finish_hard_link(file, fname, &st, itemizing, code, -1);
++					finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
  #endif
  				if (remove_source_files == 1)
  					goto return_with_success;
@@ -1886,19 +1906,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		} else if (basis_dir[0] != NULL) {
 -			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
 +			int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
- 					      itemizing, maybe_ATTRS_REPORT, code);
+ 					      itemizing, code);
  			if (j == -2) {
  #ifndef CAN_HARDLINK_SPECIAL
-@@ -1374,7 +1430,7 @@ static void recv_generator(char *fname, 
- 		}
- #ifdef SUPPORT_HARD_LINKS
- 		if (preserve_hard_links && F_IS_HLINKED(file)
--		    && hard_link_check(file, ndx, fname, -1, &st,
-+		    && hard_link_check(file, ndx, fname, -1, &sx,
- 				       itemizing, code, HL_SKIP))
- 			return;
- #endif
-@@ -1389,7 +1445,11 @@ static void recv_generator(char *fname, 
+@@ -1388,7 +1448,11 @@ static void recv_generator(char *fname, 
  		} else {
  			set_file_attrs(fname, file, NULL, 0);
  			if (itemizing) {
@@ -1911,7 +1922,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  					ITEM_LOCAL_CHANGE, 0, NULL);
  			}
  			if (code != FNONE && verbose)
-@@ -1401,7 +1461,7 @@ static void recv_generator(char *fname, 
+@@ -1400,7 +1464,7 @@ static void recv_generator(char *fname, 
  			if (remove_source_files == 1)
  				goto return_with_success;
  		}
@@ -1920,7 +1931,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	}
  
  	if (!S_ISREG(file->mode)) {
-@@ -1435,7 +1495,7 @@ static void recv_generator(char *fname, 
+@@ -1434,7 +1498,7 @@ static void recv_generator(char *fname, 
  	}
  
  	if (update_only && statret == 0
@@ -1929,7 +1940,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		if (verbose > 1)
  			rprintf(FINFO, "%s is newer\n", fname);
  		return;
-@@ -1444,20 +1504,20 @@ static void recv_generator(char *fname, 
+@@ -1443,20 +1507,20 @@ static void recv_generator(char *fname, 
  	fnamecmp = fname;
  	fnamecmp_type = FNAMECMP_FNAME;
  
@@ -1945,7 +1956,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	if (statret != 0 && basis_dir[0] != NULL) {
 -		int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &st,
 +		int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &sx,
- 				      itemizing, maybe_ATTRS_REPORT, code);
+ 				      itemizing, code);
  		if (j == -2) {
  			if (remove_source_files == 1)
  				goto return_with_success;
@@ -1954,7 +1965,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		}
  		if (j >= 0) {
  			fnamecmp = fnamecmpbuf;
-@@ -1467,7 +1527,7 @@ static void recv_generator(char *fname, 
+@@ -1466,7 +1530,7 @@ static void recv_generator(char *fname, 
  	}
  
  	real_ret = statret;
@@ -1963,7 +1974,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  	if (partial_dir && (partialptr = partial_dir_fname(fname)) != NULL
  	    && link_stat(partialptr, &partial_st, 0) == 0
-@@ -1486,7 +1546,7 @@ static void recv_generator(char *fname, 
+@@ -1485,7 +1549,7 @@ static void recv_generator(char *fname, 
  				rprintf(FINFO, "fuzzy basis selected for %s: %s\n",
  					fname, fnamecmpbuf);
  			}
@@ -1972,16 +1983,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			statret = 0;
  			fnamecmp = fnamecmpbuf;
  			fnamecmp_type = FNAMECMP_FUZZY;
-@@ -1496,7 +1556,7 @@ static void recv_generator(char *fname, 
- 	if (statret != 0) {
- #ifdef SUPPORT_HARD_LINKS
- 		if (preserve_hard_links && F_IS_HLINKED(file)
--		    && hard_link_check(file, ndx, fname, statret, &st,
-+		    && hard_link_check(file, ndx, fname, statret, &sx,
- 				       itemizing, code, HL_SKIP))
- 			return;
- #endif
-@@ -1507,38 +1567,51 @@ static void recv_generator(char *fname, 
+@@ -1504,36 +1568,41 @@ static void recv_generator(char *fname, 
  		return;
  	}
  
@@ -1999,29 +2001,21 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  			do_unlink(partialptr);
  			handle_partial_dir(partialptr, PDIR_DELETE);
  		}
- 		if (itemizing) {
--			itemize(file, ndx, real_ret, &real_st,
-+#ifdef SUPPORT_ACLS
-+			if (preserve_acls && real_ret == 0)
-+				get_acl(fnamecmp, &real_sx);
-+#endif
-+			itemize(file, ndx, real_ret, &real_sx,
- 				0, 0, NULL);
+-		if (itemizing)
+-			itemize(file, ndx, statret, &st, 0, 0, NULL);
+-		set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
++		if (itemizing) {
 +#ifdef SUPPORT_ACLS
-+			if (preserve_acls) {
-+				if (fnamecmp_type == FNAMECMP_FNAME) {
-+					sx.acc_acl = real_sx.acc_acl;
-+					sx.def_acl = real_sx.def_acl;
-+				} else
-+					free_acl(&real_sx);
-+			}
++			if (preserve_acls && statret == 0)
++				get_acl(fnamecmp, &sx);
 +#endif
- 		}
--		set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
++			itemize(file, ndx, statret, &sx, 0, 0, NULL);
++		}
 +		set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
  #ifdef SUPPORT_HARD_LINKS
  		if (preserve_hard_links && F_IS_HLINKED(file))
- 			hard_link_cluster(file, ndx, itemizing, code, -1);
+-			finish_hard_link(file, fname, &st, itemizing, code, -1);
++			finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
  #endif
  		if (remove_source_files != 1)
 -			return;
@@ -2040,13 +2034,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		fnamecmp = partialptr;
  		fnamecmp_type = FNAMECMP_PARTIAL_DIR;
  		statret = 0;
-@@ -1563,18 +1636,22 @@ static void recv_generator(char *fname, 
+@@ -1558,16 +1627,20 @@ static void recv_generator(char *fname, 
  		/* pretend the file didn't exist */
  #ifdef SUPPORT_HARD_LINKS
- 		if (preserve_hard_links && F_IS_HLINKED(file)
--		    && hard_link_check(file, ndx, fname, statret, &st,
-+		    && hard_link_check(file, ndx, fname, statret, &sx,
- 				       itemizing, code, HL_SKIP))
+ 		if (preserve_hard_links && F_HLINK_NOT_LAST(file))
 -			return;
 +			goto cleanup;
  #endif
@@ -2066,7 +2057,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		}
  		if (!(back_file = make_file(fname, NULL, NULL, 0, NO_FILTERS))) {
  			close(fd);
-@@ -1585,7 +1662,7 @@ static void recv_generator(char *fname, 
+@@ -1578,7 +1651,7 @@ static void recv_generator(char *fname, 
  				full_fname(backupptr));
  			unmake_file(back_file);
  			close(fd);
@@ -2075,7 +2066,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		}
  		if ((f_copy = do_open(backupptr,
  		    O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
-@@ -1593,14 +1670,14 @@ static void recv_generator(char *fname, 
+@@ -1586,14 +1659,14 @@ static void recv_generator(char *fname, 
  				full_fname(backupptr));
  			unmake_file(back_file);
  			close(fd);
@@ -2092,7 +2083,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	}
  
  	if (verbose > 2)
-@@ -1618,8 +1695,16 @@ static void recv_generator(char *fname, 
+@@ -1615,26 +1688,34 @@ static void recv_generator(char *fname, 
  			iflags |= ITEM_BASIS_TYPE_FOLLOWS;
  		if (fnamecmp_type == FNAMECMP_FUZZY)
  			iflags |= ITEM_XNAME_FOLLOWS;
@@ -2102,7 +2093,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +			get_acl(fnamecmp, &real_sx);
 +#endif
 +		itemize(file, -1, real_ret, &real_sx, iflags, fnamecmp_type,
- 			fuzzy_file ? F_BASENAME(fuzzy_file) : NULL);
+ 			fuzzy_file ? fuzzy_file->basename : NULL);
 +#ifdef SUPPORT_ACLS
 +		if (preserve_acls)
 +			free_acl(&real_sx);
@@ -2110,9 +2101,10 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	}
  
  	if (!do_xfers) {
-@@ -1627,17 +1712,17 @@ static void recv_generator(char *fname, 
+ #ifdef SUPPORT_HARD_LINKS
  		if (preserve_hard_links && F_IS_HLINKED(file))
- 			hard_link_cluster(file, ndx, itemizing, code, -1);
+-			finish_hard_link(file, fname, &st, itemizing, code, -1);
++			finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
  #endif
 -		return;
 +		goto cleanup;
@@ -2132,7 +2124,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  	if (f_copy >= 0) {
  		close(f_copy);
-@@ -1650,6 +1735,13 @@ static void recv_generator(char *fname, 
+@@ -1647,6 +1728,13 @@ static void recv_generator(char *fname, 
  	}
  
  	close(fd);
@@ -2146,7 +2138,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  }
  
  void generate_files(int f_out, struct file_list *flist, char *local_name)
-@@ -1716,6 +1808,8 @@ void generate_files(int f_out, struct fi
+@@ -1713,6 +1801,8 @@ void generate_files(int f_out, struct fi
  	 * notice that and let us know via the redo pipe (or its closing). */
  	ignore_timeout = 1;
  
@@ -2163,22 +2155,22 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  extern int link_dest;
 +extern int preserve_acls;
  extern int make_backups;
+ extern int protocol_version;
  extern int remove_source_files;
- extern int stdout_format_has_i;
-@@ -150,15 +151,19 @@ void init_hard_links(void)
+@@ -268,15 +269,19 @@ void match_hard_links(void)
  }
  
  static int maybe_hard_link(struct file_struct *file, int ndx,
 -			   const char *fname, int statret, STRUCT_STAT *stp,
 +			   const char *fname, int statret, statx *sxp,
- 			   const char *toname, STRUCT_STAT *to_stp,
- 			   int itemizing, enum logcode code)
+ 			   const char *oldname, STRUCT_STAT *old_stp,
+ 			   const char *realname, int itemizing, enum logcode code)
  {
  	if (statret == 0) {
--		if (stp->st_dev == to_stp->st_dev
--		 && stp->st_ino == to_stp->st_ino) {
-+		if (sxp->st.st_dev == to_stp->st_dev
-+		 && sxp->st.st_ino == to_stp->st_ino) {
+-		if (stp->st_dev == old_stp->st_dev
+-		 && stp->st_ino == old_stp->st_ino) {
++		if (sxp->st.st_dev == old_stp->st_dev
++		 && sxp->st.st_ino == old_stp->st_ino) {
  			if (itemizing) {
 -				itemize(file, ndx, statret, stp,
 +#ifdef SUPPORT_ACLS
@@ -2189,107 +2181,133 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  					ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
  					0, "");
  			}
-@@ -173,12 +178,12 @@ static int maybe_hard_link(struct file_s
- 			return -1;
- 		}
- 	}
--	return hard_link_one(file, ndx, fname, statret, stp, toname,
-+	return hard_link_one(file, ndx, fname, statret, sxp, toname,
- 			     0, itemizing, code);
- }
+@@ -297,7 +302,11 @@ static int maybe_hard_link(struct file_s
  
+ 	if (hard_link_one(file, fname, oldname, 0)) {
+ 		if (itemizing) {
+-			itemize(file, ndx, statret, stp,
++#ifdef SUPPORT_ACLS
++			if (preserve_acls && statret == 0 && !ACL_READY(*sxp))
++				get_acl(fname, sxp);
++#endif
++			itemize(file, ndx, statret, sxp,
+ 				ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS, 0,
+ 				realname);
+ 		}
+@@ -311,7 +320,7 @@ static int maybe_hard_link(struct file_s
+ /* Only called if FLAG_HLINKED is set and FLAG_HLINK_FIRST is not.  Returns:
+  * 0 = process the file, 1 = skip the file, -1 = error occurred. */
  int hard_link_check(struct file_struct *file, int ndx, const char *fname,
 -		    int statret, STRUCT_STAT *stp, int itemizing,
 +		    int statret, statx *sxp, int itemizing,
- 		    enum logcode code, int skip)
+ 		    enum logcode code)
  {
- 	int head;
-@@ -221,7 +226,7 @@ int hard_link_check(struct file_struct *
- 						 || st2.st_ino != st3.st_ino)
- 							continue;
- 						statret = 1;
--						stp = &st3;
-+						sxp->st = st3;
- 						if (verbose < 2 || !stdout_format_has_i) {
- 							itemizing = 0;
- 							code = FNONE;
-@@ -231,12 +236,16 @@ int hard_link_check(struct file_struct *
- 					if (!unchanged_file(cmpbuf, file, &st3))
- 						continue;
- 					statret = 1;
--					stp = &st3;
--					if (unchanged_attrs(file, &st3))
-+					sxp->st = st3;
+ 	STRUCT_STAT prev_st;
+@@ -362,18 +371,20 @@ int hard_link_check(struct file_struct *
+ 	if (statret < 0 && basis_dir[0] != NULL) {
+ 		/* If we match an alt-dest item, we don't output this as a change. */
+ 		char cmpbuf[MAXPATHLEN];
+-		STRUCT_STAT alt_st;
++		statx alt_sx;
+ 		int j = 0;
 +#ifdef SUPPORT_ACLS
-+					if (preserve_acls)
-+						get_acl(cmpbuf, sxp);
++		alt_sx.acc_acl = alt_sx.def_acl = NULL;
 +#endif
-+					if (unchanged_attrs(file, sxp))
- 						break;
- 				} while (basis_dir[++j] != NULL);
+ 		do {
+ 			pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
+-			if (link_stat(cmpbuf, &alt_st, 0) < 0)
++			if (link_stat(cmpbuf, &alt_sx.st, 0) < 0)
+ 				continue;
+ 			if (link_dest) {
+-				if (prev_st.st_dev != alt_st.st_dev
+-				 || prev_st.st_ino != alt_st.st_ino)
++				if (prev_st.st_dev != alt_sx.st.st_dev
++				 || prev_st.st_ino != alt_sx.st.st_ino)
+ 					continue;
+ 				statret = 1;
+-				*stp = alt_st;
+ 				if (verbose < 2 || !stdout_format_has_i) {
+ 					itemizing = 0;
+ 					code = FNONE;
+@@ -382,16 +393,36 @@ int hard_link_check(struct file_struct *
+ 				}
+ 				break;
  			}
--			maybe_hard_link(file, ndx, fname, statret, stp,
-+			maybe_hard_link(file, ndx, fname, statret, sxp,
- 					toname, &st2, itemizing, code);
- 			if (remove_source_files == 1 && do_xfers)
- 				send_msg_int(MSG_SUCCESS, ndx);
-@@ -249,7 +258,7 @@ int hard_link_check(struct file_struct *
- }
- 
- int hard_link_one(struct file_struct *file, int ndx, const char *fname,
--		  int statret, STRUCT_STAT *stp, const char *toname, int terse,
-+		  int statret, statx *sxp, const char *toname, int terse,
- 		  int itemizing, enum logcode code)
- {
- 	if (do_link(toname, fname)) {
-@@ -265,7 +274,11 @@ int hard_link_one(struct file_struct *fi
- 	}
- 
- 	if (itemizing) {
--		itemize(file, ndx, statret, stp,
+-			if (!unchanged_file(cmpbuf, file, &alt_st))
++			if (!unchanged_file(cmpbuf, file, &alt_sx.st))
+ 				continue;
+ 			statret = 1;
+-			*stp = alt_st;
+-			if (unchanged_attrs(file, &alt_st))
 +#ifdef SUPPORT_ACLS
-+		if (preserve_acls && statret == 0 && !ACL_READY(*sxp))
-+			get_acl(fname, sxp);
++			if (preserve_acls)
++				get_acl(cmpbuf, &alt_sx);
++#endif
++			if (unchanged_attrs(file, &alt_sx))
+ 				break;
+ 		} while (basis_dir[++j] != NULL);
++		if (statret == 1) {
++			sxp->st = alt_sx.st;
++#ifdef SUPPORT_ACLS
++			if (preserve_acls) {
++				if (!ACL_READY(*sxp))
++					get_acl(cmpbuf, sxp);
++				else {
++					sxp->acc_acl = alt_sx.acc_acl;
++					sxp->def_acl = alt_sx.def_acl;
++				}
++			}
++#endif
++		}
++#ifdef SUPPORT_ACLS
++		else if (preserve_acls)
++			free_acl(&alt_sx);
 +#endif
-+		itemize(file, ndx, statret, sxp,
- 			ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS, 0,
- 			terse ? "" : toname);
  	}
-@@ -279,14 +292,15 @@ void hard_link_cluster(struct file_struc
+ 
+-	if (maybe_hard_link(file, ndx, fname, statret, stp, prev_name, &prev_st,
++	if (maybe_hard_link(file, ndx, fname, statret, sxp, prev_name, &prev_st,
+ 			    realname, itemizing, code) < 0)
+ 		return -1;
+ 
+@@ -426,7 +457,8 @@ void finish_hard_link(struct file_struct
+ 		      STRUCT_STAT *stp, int itemizing, enum logcode code,
+ 		      int alt_dest)
  {
- 	char hlink1[MAXPATHLEN];
- 	char *hlink2;
--	STRUCT_STAT st1, st2;
-+	statx sx;
+-	STRUCT_STAT st, prev_st;
++	statx prev_sx;
 +	STRUCT_STAT st;
- 	int statret, ndx = master;
- 	struct hlist *hl = F_HL_LIST(file);
+ 	char alt_name[MAXPATHLEN], *prev_name;
+ 	const char *our_name;
+ 	int prev_statret, ndx, prev_ndx = F_HL_PREV(file);
+@@ -450,14 +482,24 @@ void finish_hard_link(struct file_struct
+ 	} else
+ 		our_name = fname;
  
- 	hl->hlindex = FINISHED_LINK;
- 	if (dry_run)
- 		hl->dest_used = dest_used + 1;
--	if (link_stat(f_name(file, hlink1), &st1, 0) < 0)
-+	if (link_stat(f_name(file, hlink1), &st, 0) < 0)
- 		return;
- 	if (!(file->flags & FLAG_HLINK_FIRST)) {
- 		while (!(file->flags & FLAG_HLINK_LAST)) {
-@@ -302,9 +316,13 @@ void hard_link_cluster(struct file_struc
- 		if (hl->hlindex != SKIPPED_LINK)
- 			continue;
- 		hlink2 = f_name(file, NULL);
--		statret = link_stat(hlink2, &st2, 0);
--		maybe_hard_link(file, ndx, hlink2, statret, &st2,
--				hlink1, &st1, itemizing, code);
-+		statret = link_stat(hlink2, &sx.st, 0);
-+		maybe_hard_link(file, ndx, hlink2, statret, &sx,
-+				hlink1, &st, itemizing, code);
++#ifdef SUPPORT_ACLS
++	prev_sx.acc_acl = prev_sx.def_acl = NULL;
++#endif
++
+ 	while ((ndx = prev_ndx) >= 0) {
++		int val;
+ 		file = FPTR(ndx);
+ 		file->flags = (file->flags & ~FLAG_HLINK_FIRST) | FLAG_HLINK_DONE;
+ 		prev_ndx = F_HL_PREV(file);
+ 		prev_name = f_name(file, NULL);
+-		prev_statret = link_stat(prev_name, &prev_st, 0);
+-		if (maybe_hard_link(file, ndx, prev_name, prev_statret, &prev_st,
+-				    our_name, stp, fname, itemizing, code) < 0)
++		prev_statret = link_stat(prev_name, &prev_sx.st, 0);
++		val = maybe_hard_link(file, ndx, prev_name, prev_statret, &prev_sx,
++				      our_name, stp, fname, itemizing, code);
 +#ifdef SUPPORT_ACLS
 +		if (preserve_acls)
-+			free_acl(&sx);
++			free_acl(&prev_sx);
 +#endif
++		if (val < 0)
+ 			continue;
  		if (remove_source_files == 1 && do_xfers)
  			send_msg_int(MSG_SUCCESS, ndx);
- 		hl->hlindex = FINISHED_LINK;
 --- old/lib/sysacls.c
 +++ new/lib/sysacls.c
 @@ -0,0 +1,3251 @@
@@ -5612,7 +5630,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  int preserve_perms = 0;
  int preserve_executability = 0;
  int preserve_devices = 0;
-@@ -199,6 +200,7 @@ static void print_rsync_version(enum log
+@@ -198,6 +199,7 @@ static void print_rsync_version(enum log
  	char const *got_socketpair = "no ";
  	char const *have_inplace = "no ";
  	char const *hardlinks = "no ";
@@ -5620,7 +5638,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	char const *links = "no ";
  	char const *ipv6 = "no ";
  	STRUCT_STAT *dumstat;
-@@ -215,6 +217,10 @@ static void print_rsync_version(enum log
+@@ -214,6 +216,10 @@ static void print_rsync_version(enum log
  	hardlinks = "";
  #endif
  
@@ -5631,7 +5649,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  #ifdef SUPPORT_LINKS
  	links = "";
  #endif
-@@ -233,8 +239,8 @@ static void print_rsync_version(enum log
+@@ -232,8 +238,8 @@ static void print_rsync_version(enum log
  		(int)(sizeof (int64) * 8));
  	rprintf(f, "    %ssocketpairs, %shardlinks, %ssymlinks, %sIPv6, batchfiles, %sinplace,\n",
  		got_socketpair, hardlinks, links, ipv6, have_inplace);
@@ -5642,7 +5660,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  #ifdef MAINTAINER_MODE
  	rprintf(f, "Panic Action: \"%s\"\n", get_panic_action());
-@@ -280,7 +286,7 @@ void usage(enum logcode F)
+@@ -279,7 +285,7 @@ void usage(enum logcode F)
    rprintf(F," -q, --quiet                 suppress non-error messages\n");
    rprintf(F,"     --no-motd               suppress daemon-mode MOTD (see manpage caveat)\n");
    rprintf(F," -c, --checksum              skip based on checksum, not mod-time & size\n");
@@ -5651,7 +5669,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
    rprintf(F,"     --no-OPTION             turn off an implied OPTION (e.g. --no-D)\n");
    rprintf(F," -r, --recursive             recurse into directories\n");
    rprintf(F," -R, --relative              use relative path names\n");
-@@ -302,6 +308,9 @@ void usage(enum logcode F)
+@@ -301,6 +307,9 @@ void usage(enum logcode F)
    rprintf(F," -p, --perms                 preserve permissions\n");
    rprintf(F," -E, --executability         preserve the file's executability\n");
    rprintf(F,"     --chmod=CHMOD           affect file and/or directory permissions\n");
@@ -5661,7 +5679,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
    rprintf(F," -o, --owner                 preserve owner (super-user only)\n");
    rprintf(F," -g, --group                 preserve group\n");
    rprintf(F,"     --devices               preserve device files (super-user only)\n");
-@@ -422,6 +431,9 @@ static struct poptOption long_options[] 
+@@ -421,6 +430,9 @@ static struct poptOption long_options[] 
    {"no-perms",         0,  POPT_ARG_VAL,    &preserve_perms, 0, 0, 0 },
    {"no-p",             0,  POPT_ARG_VAL,    &preserve_perms, 0, 0, 0 },
    {"executability",   'E', POPT_ARG_NONE,   &preserve_executability, 0, 0, 0 },
@@ -5671,7 +5689,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
    {"times",           't', POPT_ARG_VAL,    &preserve_times, 1, 0, 0 },
    {"no-times",         0,  POPT_ARG_VAL,    &preserve_times, 0, 0, 0 },
    {"no-t",             0,  POPT_ARG_VAL,    &preserve_times, 0, 0, 0 },
-@@ -1087,6 +1099,24 @@ int parse_arguments(int *argc, const cha
+@@ -1086,6 +1098,24 @@ int parse_arguments(int *argc, const cha
  			usage(FINFO);
  			exit_cleanup(0);
  
@@ -5696,16 +5714,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  		default:
  			/* A large opt value means that set_refuse_options()
  			 * turned this option off. */
-@@ -1223,6 +1253,8 @@ int parse_arguments(int *argc, const cha
- 		preserve_uid = ++flist_extra_cnt;
- 	if (preserve_gid)
- 		preserve_gid = ++flist_extra_cnt;
-+	if (preserve_acls)
-+		preserve_acls = ++flist_extra_cnt;
- 
- 	*argv = poptGetArgs(pc);
- 	*argc = count_args(*argv);
-@@ -1534,6 +1566,10 @@ void server_options(char **args,int *arg
+@@ -1528,6 +1558,10 @@ void server_options(char **args,int *arg
  
  	if (preserve_hard_links)
  		argstr[x++] = 'H';
@@ -5737,7 +5746,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  	int ndx, recv_ok;
  
  	if (verbose > 2)
-@@ -550,7 +555,16 @@ int recv_files(int f_in, struct file_lis
+@@ -545,7 +550,16 @@ int recv_files(int f_in, struct file_lis
  		 * mode based on the local permissions and some heuristics. */
  		if (!preserve_perms) {
  			int exists = fd1 != -1;
@@ -5920,8 +5929,8 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +#endif
 +
  #ifdef HAVE_CHMOD
--	if ((st->st_mode & CHMOD_BITS) != (new_mode & CHMOD_BITS)) {
-+	if ((sxp->st.st_mode & CHMOD_BITS) != (new_mode & CHMOD_BITS)) {
+-	if (!BITS_EQUAL(st->st_mode, new_mode, CHMOD_BITS)) {
++	if (!BITS_EQUAL(sxp->st.st_mode, new_mode, CHMOD_BITS)) {
  		int ret = do_chmod(fname, new_mode);
  		if (ret < 0) {
  			rsyserr(FERROR, errno,
@@ -5946,7 +5955,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
 --- old/rsync.h
 +++ new/rsync.h
-@@ -496,6 +496,14 @@ struct idev {
+@@ -532,6 +532,14 @@ struct idev_node {
  #define IN_LOOPBACKNET 127
  #endif
  
@@ -5960,21 +5969,29 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +
  #define GID_NONE ((gid_t)-1)
  
- #define HL_CHECK_MASTER	0
-@@ -553,10 +561,12 @@ extern int preserve_gid;
+ union file_extras {
+@@ -551,6 +559,7 @@ struct file_struct {
+ extern int file_extra_cnt;
+ extern int preserve_uid;
+ extern int preserve_gid;
++extern int preserve_acls;
+ 
+ #define FILE_STRUCT_LEN (offsetof(struct file_struct, basename))
+ #define EXTRA_LEN (sizeof (union file_extras))
+@@ -583,10 +592,12 @@ extern int preserve_gid;
  /* When the associated option is on, all entries will have these present: */
- #define F_UID(f) REQ_EXTRA(f, preserve_uid)->uid
- #define F_GID(f) REQ_EXTRA(f, preserve_gid)->gid
+ #define F_UID(f) REQ_EXTRA(f, preserve_uid)->unum
+ #define F_GID(f) REQ_EXTRA(f, preserve_gid)->unum
 +#define F_ACL(f) REQ_EXTRA(f, preserve_acls)->unum
  
  /* These items are per-entry optional and mutally exclusive: */
- #define F_HL_IDEV(f) OPT_EXTRA(f, LEN64_BUMP(f))->idev
- #define F_HL_LIST(f) OPT_EXTRA(f, LEN64_BUMP(f))->hlist
+ #define F_HL_GNUM(f) OPT_EXTRA(f, LEN64_BUMP(f))->num
+ #define F_HL_PREV(f) OPT_EXTRA(f, LEN64_BUMP(f))->num
 +#define F_DEF_ACL(f) OPT_EXTRA(f, LEN64_BUMP(f))->unum
  
  /* This optional item might follow an F_HL_*() item.
   * (Note: a device doesn't need to check LEN64_BUMP(f).) */
-@@ -694,6 +704,17 @@ struct stats {
+@@ -722,6 +733,17 @@ struct stats {
  
  struct chmod_mode_struct;
  
@@ -5992,7 +6009,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  #include "byteorder.h"
  #include "lib/mdfour.h"
  #include "lib/wildmatch.h"
-@@ -712,6 +733,16 @@ struct chmod_mode_struct;
+@@ -740,6 +762,16 @@ struct chmod_mode_struct;
  #define NORETURN __attribute__((__noreturn__))
  #endif
  
@@ -6054,7 +6071,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  
  dit(bf(-E, --executability)) This option causes rsync to preserve the
  executability (or non-executability) of regular files when bf(--perms) is
-@@ -805,6 +810,15 @@ quote(itemization(
+@@ -805,6 +810,14 @@ quote(itemization(
  
  If bf(--perms) is enabled, this option is ignored.
  
@@ -6062,15 +6079,14 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +ACLs to be the same as the source ACLs.  This nonstandard option only
 +works if the remote rsync also supports it.  bf(--acls) implies bf(--perms).
 +
-+Note also that an optimization of the ACL-sending protocol used by this
-+version makes it incompatible with sending files to an older ACL-enabled
-+rsync unless you double the bf(--acls) option (e.g. bf(-AA)).  This
-+doubling is not needed when pulling files from an older rsync.
++The ACL-sending protocol used by this version was first introduced in
++the patch that was shipped with 2.6.8.  Sending ACLs to an older version
++of the ACL patch is not supported.
 +
  dit(bf(--chmod)) This option tells rsync to apply one or more
  comma-separated "chmod" strings to the permission of the files in the
  transfer.  The resulting value is treated as though it was the permissions
-@@ -1402,8 +1416,8 @@ if the receiving rsync is at least versi
+@@ -1402,8 +1415,8 @@ if the receiving rsync is at least versi
  with older versions of rsync, but that also turns on the output of other
  verbose messages).
  
@@ -6081,7 +6097,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  type of update being done, bf(X) is replaced by the file-type, and the
  other letters represent attributes that may be output if they are being
  modified.
-@@ -1452,7 +1466,11 @@ quote(itemization(
+@@ -1452,7 +1465,11 @@ quote(itemization(
    sender's value (requires bf(--owner) and super-user privileges).
    it() A bf(g) means the group is different and is being updated to the
    sender's value (requires bf(--group) and the authority to set the group).
@@ -6690,7 +6706,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  EOT
  diff $diffopt "$chkfile" "$outfile" || test_fail "test 9 failed"
  
-@@ -186,15 +186,15 @@ $RSYNC -ivvplrtH --link-dest="$todir" "$
+@@ -185,15 +185,15 @@ $RSYNC -ivvplrtH --link-dest="$todir" "$
      | tee "$outfile"
  filter_outfile
  cat <<EOT >"$chkfile"
@@ -6715,9 +6731,9 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
  EOT
  diff $diffopt "$chkfile" "$outfile" || test_fail "test 11 failed"
  
-@@ -236,14 +236,14 @@ filter_outfile
- # TODO fix really-old problem when combining -H with --compare-dest:
- # missing output for foo/extra hard-link (and it might not be updated)!
+@@ -233,15 +233,15 @@ $RSYNC -ivvplrtH --compare-dest="$todir"
+     | tee "$outfile"
+ filter_outfile
  cat <<EOT >"$chkfile"
 -cd        ./
 -cd        bar/
@@ -6726,6 +6742,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 -cd        foo/
 -.f        foo/config1
 -.f        foo/config2
+-.f        foo/extra
 -.L        foo/sym -> ../bar/baz/rsync
 +cd          ./
 +cd          bar/
@@ -6734,6 +6751,7 @@ latest ACL-enabling patch to send files to an older ACL-enabled rsync.
 +cd          foo/
 +.f          foo/config1
 +.f          foo/config2
++.f          foo/extra
 +.L          foo/sym -> ../bar/baz/rsync
  EOT
  diff $diffopt "$chkfile" "$outfile" || test_fail "test 15 failed"