[Rsync-patches] [PATCH 3/3] Daemon: Don't reverse-lookup [...]

[Matt McCutchen]

On Wed, 2009-01-14 at 04:41 -0500, Matt McCutchen wrote:
> Oops, this is not as simple as I thought!  For the %h escape,
> log_formatted calls client_{name,addr} with fd 0 (which isn't the
> socket), counting on the calls in start_daemon to have forced the
> initialization of the client name and address.  With my patch, this is
> no longer the case when "hosts allow" and "hosts deny" are unspecified.
> [...]

Better idea: add a "reverse lookup" parameter.  That will let daemon
admins disable reverse lookups but still use a "hosts allow" based on IP
addresses, if they wish.  I'm not sure why I was resisting this at
first.

-- 
Matt