[bigint] [cppcheck][PATCH] found a few issues

Martin Ettl <ettl.martin78 at googlemail.com>
Wed Aug 4 07:04:33 PDT 2010


hello, i have scanned binit with cppcheck ( a static code analysis tool :
http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page ).
These warnings are printed when scanning with the current stable version:

[BigUnsignedInABase.hh:45]: (Style) Member variable not initialized in the
constructor 'BigUnsignedInABase::base'
[BigUnsignedInABase.hh:61]: (Style) 'operator=' should return something
[BigUnsigned.hh:43]: (Style) 'operator=' should return something
[NumberlikeArray.hh:66]: (Style) 'operator=' should return something
[BigInteger.hh:38]: (Style) 'operator=' should return something

Please refer the attached patch (cppcheck.patch) that fixes the issues. I
hope you like my changes? I have tested it with my code any the tests from
you and everything worked fine.

Best regards

Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mattmccutchen.net/mailman/archives/bigint/attachments/20100804/9ccbb41a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cppcheck.patch
Type: text/x-diff
Size: 3433 bytes
Desc: not available
URL: <http://mattmccutchen.net/mailman/archives/bigint/attachments/20100804/9ccbb41a/attachment.patch>


More information about the bigint mailing list